mirror of
https://github.com/lbonn/rofi
synced 2024-11-15 08:37:17 +00:00
b77a48c628
* tests: initialize char* in mode test Currently, test_mode_result relies on undefined behavior. The test calls mode_result, which checks whether the pointer is NULL. However, the pointer was never initialized, so it may or may not be NULL, depending on the compiler. This caused a test failure on ppc64 and Fedora 28, apparently because in this setting, gcc sets uninitialized pointers to NULL. By initializing the pointer to the empty string, the behavior is defined and the test passes on all architectures. * mode: fix input pointer check in mode_result Do not check whether *input (i.e., the char* the input points to) is NULL, as this is valid. Instead, check whether the input itself is NULL. * tests: make char* input arg in test_mode_result modifiable The function mode_result expects a modifiable char*, initialize the argument properly so it can be modified. |
||
|---|---|---|
| .. | ||
| dialogs | ||
| widgets | ||
| css-colors.c | ||
| helper.c | ||
| history.c | ||
| keyb.c | ||
| mode.c | ||
| rofi-icon-fetcher.c | ||
| rofi-types.c | ||
| rofi.c | ||
| theme.c | ||
| timings.c | ||
| view.c | ||
| xcb.c | ||
| xrmoptions.c | ||