Richard Davey
7dcfefde52
Merge pull request #3156 from Flet/patch-1
...
update headings
2018-01-12 10:30:19 +00:00
Dan Flettre
d55dc0da2d
update headings
...
I noticed `CONTRIBUTING.md` headings were not properly formatted markdown.
I believe GitHub recently changed their markdown spec recently to make headings more strict.
This update fixes all the headings in this file
2018-01-11 18:29:20 -06:00
yp
242471beb9
Renamed no longer existing Vector2/3 .sub and .len to .subtract and .length where still used
2018-01-12 02:18:36 +02:00
Dan Flettre
16b672e291
set data to KeyCombo for KeyComboMatchEvent
2018-01-11 18:14:45 -06:00
Michael Hadley
bab399a02e
Made CollideHandler consistent by returning value from logic branches
...
Each branch should return true/false based on whether a collision happened
2018-01-11 14:13:42 -06:00
Michael Hadley
00cebf8eae
CollideGroupVsTilemapLayer implementation
2018-01-11 14:03:34 -06:00
Pavle Goloskokovic
e68ff2b18a
Saving current position of the sound and stopping and releasing audio tag when calling pause method
2018-01-11 18:55:42 +01:00
Pavle Goloskokovic
f6de613fd0
Added stopAndReleaseAudioTag method to stop sound playback and mark audio tag as unused and release it for other sounds to use
2018-01-11 18:53:54 +01:00
Pavle Goloskokovic
8578319171
requiring SoundEvent class
2018-01-11 18:51:02 +01:00
Pavle Goloskokovic
40b2bf79b7
Calling pickAndPlayAudioTag from resume method
2018-01-11 18:50:25 +01:00
Pavle Goloskokovic
9e7ccb1503
Added helpful flags comment
2018-01-11 18:49:44 +01:00
Pavle Goloskokovic
a6b4066468
Moved logic for setting up and playing audio tag so it can be reused
2018-01-11 18:45:34 +01:00
Pavle Goloskokovic
f9093a2d7e
Disabling setting seek property on a delayed sound
2018-01-11 18:41:43 +01:00
Pavle Goloskokovic
81e8542af7
Resetting startTime property of a hijacked sound
2018-01-11 18:40:36 +01:00
Pavle Goloskokovic
fb29afedae
Preventing resume calls on delayed sounds
2018-01-11 18:39:45 +01:00
Pavle Goloskokovic
c1b24c4adb
Preventing pause calls on delayed sounds
2018-01-11 18:39:19 +01:00
Pavle Goloskokovic
fb6b989035
Handling delayed playback in update method
2018-01-11 18:31:36 +01:00
Pavle Goloskokovic
3388fd018f
Setting startTime based on delay config when calling play method
2018-01-11 18:30:16 +01:00
Pavle Goloskokovic
d6256c47c5
Defined startTime property
2018-01-11 18:23:28 +01:00
Pavle Goloskokovic
82819ec782
Setting sound position, applying config and starting playback if delay is set to 0 when calling play method
2018-01-11 18:20:18 +01:00
Pavle Goloskokovic
11923621ad
Finding available audio tag when calling play method and resetting and returning false if it was not successful
2018-01-11 18:17:50 +01:00
Pavle Goloskokovic
af8666f611
Added reset method that calls super stop method in order to reset sounds state
...
Calling reset method and setting audio to null after hijacking audio tag from another sound
2018-01-11 18:15:42 +01:00
Pavle Goloskokovic
106e32499f
Sorting sounds to hijack audio from by loop and seek properties values
2018-01-11 18:12:52 +01:00
Pavle Goloskokovic
f377b4fa85
Finding another sound to hijack audio tag from if there are no free audio tags and override setting is set to true
2018-01-11 18:11:10 +01:00
Pavle Goloskokovic
fc19a05f0b
Returning false if override setting of sound manager is set to false
2018-01-11 18:05:12 +01:00
Pavle Goloskokovic
935ef78102
Added method for finding unused audio tag for playing sound
2018-01-11 18:04:17 +01:00
Pavle Goloskokovic
6730b3b314
Defined seek property for HTML5AudioSound class
2018-01-11 18:00:42 +01:00
Pavle Goloskokovic
d6b11e2fdb
Defined seek property's setter for HTML5AudioSound class
2018-01-11 17:59:36 +01:00
Pavle Goloskokovic
afb8075379
Defined seek property's setter for HTML5AudioSound class
2018-01-11 17:58:26 +01:00
Pavle Goloskokovic
110c6891dd
Defined volume property for HTML5AudioSound class
2018-01-11 17:57:04 +01:00
Pavle Goloskokovic
8f9eafd315
Defined mute property for HTML5AudioSound class
2018-01-11 17:55:05 +01:00
Pavle Goloskokovic
495a79d4bf
Implemented setRate method
2018-01-11 17:51:58 +01:00
Pavle Goloskokovic
91f9629ed2
Implemented setVolume method
2018-01-11 17:50:20 +01:00
Pavle Goloskokovic
162a063f03
Implemented setMute method
2018-01-11 17:49:40 +01:00
Pavle Goloskokovic
ede81f2a03
Added destroy method
2018-01-11 17:48:23 +01:00
Pavle Goloskokovic
0223019290
Added blank update method
2018-01-11 17:47:01 +01:00
Pavle Goloskokovic
d51156fe94
Added stop method implementation that calls super method and dispatches stop event
2018-01-11 17:45:02 +01:00
Pavle Goloskokovic
196258b8ac
Added resume method implementation that calls super method and dispatches resume event
2018-01-11 17:43:56 +01:00
Pavle Goloskokovic
5e8d0dcaee
Added pause method implementation that calls super method and dispatches pause event
2018-01-11 17:42:18 +01:00
Pavle Goloskokovic
d3c034e5cc
Added play method implementation that calls super method and dispatches play event
2018-01-11 17:40:59 +01:00
Pavle Goloskokovic
b452859b78
Assigning duration and totalDuration values to audio tag duration
2018-01-11 17:38:47 +01:00
Pavle Goloskokovic
1d925105bd
Audio property docs update
2018-01-11 17:37:28 +01:00
Pavle Goloskokovic
ad858d1475
Throwing an error if no sound with given key was loaded
2018-01-11 17:36:51 +01:00
Pavle Goloskokovic
cf83880fb0
Defined tags property that holds reference to audio tags array
2018-01-11 17:35:25 +01:00
Pavle Goloskokovic
b22116e1f8
Updated override property docs
2018-01-11 17:32:49 +01:00
Pavle Goloskokovic
2372fdd812
Completed a TODO to return HTML5AudioSoundManager instance when necessary
2018-01-11 17:29:57 +01:00
Pavle Goloskokovic
7c715f1ba0
Removed detune property since it is already implemented in BaseSound class
2018-01-11 17:28:52 +01:00
Pavle Goloskokovic
be713af155
Removed rate property since it is already implemented in BaseSound class
2018-01-11 17:28:25 +01:00
Pavle Goloskokovic
98700ffff2
Updating play method to return boolean indicating if play call was done successfully
2018-01-11 17:27:19 +01:00
Pavle Goloskokovic
15562a70e3
Updated override property docs
2018-01-11 17:25:55 +01:00