Pavle Goloskokovic
919665dd96
Fixed scope issue
2018-01-12 17:11:12 +01:00
Felipe Alfonso
40262eb0cb
Merge branch 'master' into rendering-cleanup
2018-01-12 12:42:45 -03:00
Pavle Goloskokovic
95d0b5f784
Merge remote-tracking branch 'origin/master'
2018-01-12 16:12:23 +01:00
Pavle Goloskokovic
4038291373
Changed the order of defining startTime and previousTime properties
2018-01-12 16:12:15 +01:00
Pavle Goloskokovic
b2eef5b96e
Added a todo
2018-01-12 16:03:15 +01:00
Pavle Goloskokovic
2a76c6eff5
Updating previousTime property when setting seek value
2018-01-12 16:01:19 +01:00
Pavle Goloskokovic
1cdebc80c3
Updating previousTime when picking and playing audio for sound
2018-01-12 16:00:37 +01:00
Pavle Goloskokovic
1180d82c27
Updating previousTime when starting sound with delayed playback
2018-01-12 15:59:40 +01:00
Pavle Goloskokovic
398b337da9
Resetting previousTime property when stopping sound or hijacking audio from another sound
2018-01-12 15:58:43 +01:00
Pavle Goloskokovic
de9e5a0d1f
Updating currentTime to new audio currentTime value while handling looping before assigning that value to previousTime property
2018-01-12 15:57:55 +01:00
Pavle Goloskokovic
a51a0bd543
Setting previousTime property to currentTime value at the end of update method
...
Using condition when current time is less then previous time to indicate sound looping and dispatch an event
2018-01-12 15:39:58 +01:00
Pavle Goloskokovic
1ec66f644f
Added previousTime property to keep track of audio tag's playback position recorded on previous update method call
2018-01-12 15:32:30 +01:00
Pavle Goloskokovic
9ec4d9a829
Fixing sound position if sound loops and starts from the beginning between two update calls
2018-01-12 15:30:11 +01:00
Pavle Goloskokovic
735cf10a3f
Dispatching SOUND_ENDED event when sound ends, obviously :)
2018-01-12 15:28:06 +01:00
Pavle Goloskokovic
72955bfe30
Handling sound ending in update method
2018-01-12 15:27:25 +01:00
Pavle Goloskokovic
0d0df1900b
Added logic for handling looping in update method
2018-01-12 15:23:39 +01:00
Pavle Goloskokovic
81d794b4c6
Setting audio to correct state when starting it since it might be playing already when hijacked form another sound
2018-01-12 15:18:31 +01:00
Richard Davey
d554d61319
Merge pull request #3158 from Flet/KeyComboMatchEvent-fix
...
set data to KeyCombo for KeyComboMatchEvent
2018-01-12 10:31:51 +00:00
Richard Davey
911970b7d6
Merge pull request #3157 from yupaul/master
...
Fix: .sub and .len to .subtract and .length
2018-01-12 10:30:56 +00:00
Richard Davey
7dcfefde52
Merge pull request #3156 from Flet/patch-1
...
update headings
2018-01-12 10:30:19 +00:00
Dan Flettre
d55dc0da2d
update headings
...
I noticed `CONTRIBUTING.md` headings were not properly formatted markdown.
I believe GitHub recently changed their markdown spec recently to make headings more strict.
This update fixes all the headings in this file
2018-01-11 18:29:20 -06:00
yp
242471beb9
Renamed no longer existing Vector2/3 .sub and .len to .subtract and .length where still used
2018-01-12 02:18:36 +02:00
Dan Flettre
16b672e291
set data to KeyCombo for KeyComboMatchEvent
2018-01-11 18:14:45 -06:00
Michael Hadley
bab399a02e
Made CollideHandler consistent by returning value from logic branches
...
Each branch should return true/false based on whether a collision happened
2018-01-11 14:13:42 -06:00
Michael Hadley
00cebf8eae
CollideGroupVsTilemapLayer implementation
2018-01-11 14:03:34 -06:00
Pavle Goloskokovic
e68ff2b18a
Saving current position of the sound and stopping and releasing audio tag when calling pause method
2018-01-11 18:55:42 +01:00
Pavle Goloskokovic
f6de613fd0
Added stopAndReleaseAudioTag method to stop sound playback and mark audio tag as unused and release it for other sounds to use
2018-01-11 18:53:54 +01:00
Pavle Goloskokovic
8578319171
requiring SoundEvent class
2018-01-11 18:51:02 +01:00
Pavle Goloskokovic
40b2bf79b7
Calling pickAndPlayAudioTag from resume method
2018-01-11 18:50:25 +01:00
Pavle Goloskokovic
9e7ccb1503
Added helpful flags comment
2018-01-11 18:49:44 +01:00
Pavle Goloskokovic
a6b4066468
Moved logic for setting up and playing audio tag so it can be reused
2018-01-11 18:45:34 +01:00
Pavle Goloskokovic
f9093a2d7e
Disabling setting seek property on a delayed sound
2018-01-11 18:41:43 +01:00
Pavle Goloskokovic
81e8542af7
Resetting startTime property of a hijacked sound
2018-01-11 18:40:36 +01:00
Pavle Goloskokovic
fb29afedae
Preventing resume calls on delayed sounds
2018-01-11 18:39:45 +01:00
Pavle Goloskokovic
c1b24c4adb
Preventing pause calls on delayed sounds
2018-01-11 18:39:19 +01:00
Pavle Goloskokovic
fb6b989035
Handling delayed playback in update method
2018-01-11 18:31:36 +01:00
Pavle Goloskokovic
3388fd018f
Setting startTime based on delay config when calling play method
2018-01-11 18:30:16 +01:00
Pavle Goloskokovic
d6256c47c5
Defined startTime property
2018-01-11 18:23:28 +01:00
Pavle Goloskokovic
82819ec782
Setting sound position, applying config and starting playback if delay is set to 0 when calling play method
2018-01-11 18:20:18 +01:00
Pavle Goloskokovic
11923621ad
Finding available audio tag when calling play method and resetting and returning false if it was not successful
2018-01-11 18:17:50 +01:00
Pavle Goloskokovic
af8666f611
Added reset method that calls super stop method in order to reset sounds state
...
Calling reset method and setting audio to null after hijacking audio tag from another sound
2018-01-11 18:15:42 +01:00
Pavle Goloskokovic
106e32499f
Sorting sounds to hijack audio from by loop and seek properties values
2018-01-11 18:12:52 +01:00
Pavle Goloskokovic
f377b4fa85
Finding another sound to hijack audio tag from if there are no free audio tags and override setting is set to true
2018-01-11 18:11:10 +01:00
Pavle Goloskokovic
fc19a05f0b
Returning false if override setting of sound manager is set to false
2018-01-11 18:05:12 +01:00
Pavle Goloskokovic
935ef78102
Added method for finding unused audio tag for playing sound
2018-01-11 18:04:17 +01:00
Pavle Goloskokovic
6730b3b314
Defined seek property for HTML5AudioSound class
2018-01-11 18:00:42 +01:00
Pavle Goloskokovic
d6b11e2fdb
Defined seek property's setter for HTML5AudioSound class
2018-01-11 17:59:36 +01:00
Pavle Goloskokovic
afb8075379
Defined seek property's setter for HTML5AudioSound class
2018-01-11 17:58:26 +01:00
Pavle Goloskokovic
110c6891dd
Defined volume property for HTML5AudioSound class
2018-01-11 17:57:04 +01:00
Pavle Goloskokovic
8f9eafd315
Defined mute property for HTML5AudioSound class
2018-01-11 17:55:05 +01:00
