Commit graph

7 commits

Author SHA1 Message Date
Richard Davey
747f09af86 jsdoc fixes 2018-03-28 15:04:09 +01:00
orblazer
454849d67d Update JSDoc on Tweens and Utils 2018-03-19 02:07:03 +01:00
Allan Reyes
a08c75bb06 Delegate Timeline#makeActive to TweenManager
This fixes a bug when calling Timeline#resetTweens() while the tweens
are pending removal or completed. Delegating the #makeActive method
here was chosen to:
- Follow "tell, don't ask" (pragprog.com/articles/tell-dont-ask)
- Prevent an additional branch conditional in Tween.js
- Prevent a Law of Demeter violation, e.g.

        // src/tweens/tween/Tween.js
        if (this.parentIsTimeline) // "asking"
        {
            this.parent.manager.makeActive(this); // LoD violation
        }
        else
        {
            this.parent.makeActive(this);
        }
2018-03-12 09:31:00 -07:00
Richard Davey
d1f5f8a82b Added jsdocs 2018-02-12 16:01:21 +00:00
Richard Davey
5f39206f35 Added jsdocs 2018-02-10 17:40:40 +00:00
Richard Davey
2ece55c28e Renamed folder to match namespace 2018-02-10 14:56:08 +00:00
Richard Davey
8e07320596 Migrating to plugins 2018-01-16 19:49:13 +00:00
Renamed from src/tweens/timeline/Timeline.js (Browse further)