Commit graph

80 commits

Author SHA1 Message Date
Richard Davey
f57ab02fe6 Recoded how RTree generations its functions. Solves perf issue introduced in 3.4 Fix #3594 2018-04-18 22:32:52 +01:00
Richard Davey
6b2307594a Scene plugin flow overhaul
Every Plugin has been updated to correctly follow the same flow through the Scene lifecycle. Instead of listening for the Scene 'boot' event, which is only dispatched once (when the Scene is first created), they will now listen for the Scene 'start' event, which occurs every time the Scene is started. All plugins now consistently follow the same Shutdown and Destroy patterns too, meaning they tidy-up after themselves on a shutdown, not just a destroy. Overall, this change means that there should be less issues when returning to previously closed Scenes, as the plugins will restart themselves properly.
2018-04-13 17:12:17 +01:00
jdotrjs
6c6d5f4aa1 somebody forgot their ;s 2018-04-10 23:49:46 -07:00
jdotrjs
d089e16345 [fixes #3535] Fix constructed bounding box functions for RTree
The previous patch didn't take into account that the accessors passed
in as the format array were dot-prefixed due to the previous eval-based
construction.

The only two uses of RTree that I found were in World.js:

```javascript
        this.tree = new RTree(this.maxEntries, [ '.left', '.top', '.right', '.bottom' ]);
        this.staticTree = new RTree(this.maxEntries, [ '.left', '.top', '.right', '.bottom' ]);
```

It's likely that this could be updated to just not pass dotted attribute
names but I wasn't super comfortable that they weren't needed in this form
elsewhere despite a quick search. I'd honestly say that it might be a better
change if we remove the dots before merge but I'll leave that up to the
discretion of the reviewers/merger.

I'm not super familiar with Phaser's style but I passed lint sooo :D

Buyer beware: the only testing I did was on the repo case I left in the
bug and I did not verify that this is still within the twitch CSP (though
it should be).
2018-04-10 23:11:14 -07:00
Richard Davey
330eac1ebc List is now internally using all of the new Utils.Array functions. 2018-04-10 04:00:39 +01:00
Richard Davey
ae8706a424 Added missing callback 2018-04-05 15:28:22 +01:00
Richard Davey
a44fcb6ad6 Added addCallback, removeCallback and skipCallback arguments 2018-04-05 13:51:57 +01:00
orblazer
e3b0c3e4d2
Remove generic on type 2018-04-03 16:24:48 +02:00
Antriel
630732f9fc jsdoc generics fix 2018-03-30 14:43:58 +02:00
orblazer
e10a10b3b1 Fix usage of @genericUse 2018-03-29 12:58:18 +02:00
Richard Davey
06998276ec Removed stict mode warning 2018-03-28 16:00:19 +01:00
orblazer
d0e1320cbe Add generic types and fix types on Input and Structs 2018-03-27 15:59:49 +02:00
Richard Davey
1f44366bc7 Merge branch 'master' of https://github.com/photonstorm/phaser 2018-03-27 01:09:34 +01:00
Richard Davey
3aa95b4f20 Formatting fix. 2018-03-27 01:09:23 +01:00
Richard Davey
25cbb320a5
Merge pull request #3453 from orblazer/genericTypes
Change structs for generic types
2018-03-27 00:37:34 +01:00
orblazer
f42f1bf132 Change structs for generic types 2018-03-23 16:54:12 +01:00
Jamie Mansfield
88647a4879
Remove string-generated Functions for CSP policies - Resolves #3441 2018-03-22 22:32:46 +00:00
orblazer
7fba122321 Fix "any" types 2018-03-20 17:15:49 +01:00
orblazer
fa13b597e3 Add more callbacks 2018-03-19 23:08:05 +01:00
orblazer
6b5dc62ad1 Update JSDoc on Structs 2018-03-19 02:00:21 +01:00
yp
9f07ee0af4 Bugfixes in Structs.Set 2018-02-18 12:59:32 +02:00
Richard Davey
d23688c3e4 Added eslint fixes and overrides 2018-02-16 18:44:07 +00:00
Richard Davey
e1554c34d6 eslint fixes 2018-02-16 18:07:49 +00:00
Richard Davey
b6b8f70550 DisplayList now just extends List and removed the Plugin, as it acts as its own plugin now. 2018-02-12 16:59:57 +00:00
Richard Davey
d1f5f8a82b Added jsdocs 2018-02-12 16:01:21 +00:00
Richard Davey
ff1a26c7a3 Added jsdocs 2018-02-09 04:35:23 +00:00
Pavle Goloskokovic
499c2206c6 Merge remote-tracking branch 'origin/master' 2018-01-31 16:42:59 +01:00
Pavle Goloskokovic
53fc478a1c Fixed scope bug 2018-01-31 16:42:47 +01:00
Richard Davey
2a86400a28 Added in jsdocs 2018-01-31 13:54:44 +00:00
Richard Davey
d8f1ba03e9 Moved repository location 2018-01-09 21:43:56 +00:00