Mirrors/phaser
2
0
Fork 0
mirror of https://github.com/photonstorm/phaser synced 2024-11-24 13:43:26 +00:00
Code Issues Projects Releases Packages Wiki Activity

Completed a TODO by setting BaseSound update method to NOOP

Browse source
This commit is contained in:
Pavle Goloskokovic 2017-11-23 13:19:22 +01:00
parent a2ceff63f1
commit 5f55931d22
1 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
v3/src/sound/BaseSound.js
View file

@ -1,6 +1,7 @@
var Class = require('../utils/Class'); var Class = require('../utils/Class');
var Extend = require('../utils/object/Extend'); var Extend = require('../utils/object/Extend');
var EventDispatcher = require('../events/EventDispatcher'); var EventDispatcher = require('../events/EventDispatcher');
var NOOP = require('../utils/NOOP');
// Phaser.Sound.BaseSound // Phaser.Sound.BaseSound
var BaseSound = new Class({ var BaseSound = new Class({
initialize: function BaseSound(manager, key, config) { initialize: function BaseSound(manager, key, config) {
@ -136,7 +137,6 @@ var BaseSound = new Class({
*/ */
this.events = new EventDispatcher(); this.events = new EventDispatcher();
}, },
// TODO set default methods to NOOP if not used
addMarker: function (marker) { addMarker: function (marker) {
if (!marker) { if (!marker) {
console.error('addMarker - Marker object has to be provided!'); console.error('addMarker - Marker object has to be provided!');
@ -254,8 +254,7 @@ var BaseSound = new Class({
fadeTo: function (volume, duration) { fadeTo: function (volume, duration) {
return null; return null;
}, },
update: function () { update: NOOP,
},
destroy: function () { destroy: function () {
} }
}); });