From 5f55931d22c52efc68faf0ccb8f768ce71be46a3 Mon Sep 17 00:00:00 2001 From: Pavle Goloskokovic Date: Thu, 23 Nov 2017 13:19:22 +0100 Subject: [PATCH] Completed a TODO by setting BaseSound update method to NOOP --- v3/src/sound/BaseSound.js | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/v3/src/sound/BaseSound.js b/v3/src/sound/BaseSound.js index 4266aa355..d86e7840e 100644 --- a/v3/src/sound/BaseSound.js +++ b/v3/src/sound/BaseSound.js @@ -1,6 +1,7 @@ var Class = require('../utils/Class'); var Extend = require('../utils/object/Extend'); var EventDispatcher = require('../events/EventDispatcher'); +var NOOP = require('../utils/NOOP'); // Phaser.Sound.BaseSound var BaseSound = new Class({ initialize: function BaseSound(manager, key, config) { @@ -136,7 +137,6 @@ var BaseSound = new Class({ */ this.events = new EventDispatcher(); }, - // TODO set default methods to NOOP if not used addMarker: function (marker) { if (!marker) { console.error('addMarker - Marker object has to be provided!'); @@ -254,8 +254,7 @@ var BaseSound = new Class({ fadeTo: function (volume, duration) { return null; }, - update: function () { - }, + update: NOOP, destroy: function () { } });