Only use SDL_HINT_VIDEO_MAC_FULLSCREEN_SPACES=0 for native notched resolution

Full-screen and borderless windowed are now fully indistinguishable on macOS to avoid user confusion.

Fixes #861
This commit is contained in:
Cameron Gutman 2024-05-11 19:58:36 -05:00
parent 0dfa8a7b53
commit e25d9b0da2

View file

@ -570,7 +570,7 @@ bool Session::initialize()
// (notched or notchless), override the fullscreen mode to ensure it works as expected.
// - SDL_HINT_VIDEO_MAC_FULLSCREEN_SPACES=0 will place the video underneath the notch
// - SDL_HINT_VIDEO_MAC_FULLSCREEN_SPACES=1 will place the video below the notch
bool shouldUseFullScreenSpaces = m_Preferences->windowMode != StreamingPreferences::WM_FULLSCREEN;
bool shouldUseFullScreenSpaces = true;
SDL_DisplayMode desktopMode;
SDL_Rect safeArea;
for (int displayIndex = 0; StreamUtils::getNativeDesktopMode(displayIndex, &desktopMode, &safeArea); displayIndex++) {
@ -583,12 +583,6 @@ bool Session::initialize()
shouldUseFullScreenSpaces = false;
break;
}
else if (m_Preferences->width == safeArea.w && m_Preferences->height == safeArea.h) {
SDL_LogInfo(SDL_LOG_CATEGORY_APPLICATION,
"Overriding default fullscreen mode for native safe area resolution");
shouldUseFullScreenSpaces = true;
break;
}
}
}