From e25d9b0da200154276fd0b8f44a0f7419420275f Mon Sep 17 00:00:00 2001 From: Cameron Gutman Date: Sat, 11 May 2024 19:58:36 -0500 Subject: [PATCH] Only use SDL_HINT_VIDEO_MAC_FULLSCREEN_SPACES=0 for native notched resolution Full-screen and borderless windowed are now fully indistinguishable on macOS to avoid user confusion. Fixes #861 --- app/streaming/session.cpp | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/app/streaming/session.cpp b/app/streaming/session.cpp index d22d7da9..887f2386 100644 --- a/app/streaming/session.cpp +++ b/app/streaming/session.cpp @@ -570,7 +570,7 @@ bool Session::initialize() // (notched or notchless), override the fullscreen mode to ensure it works as expected. // - SDL_HINT_VIDEO_MAC_FULLSCREEN_SPACES=0 will place the video underneath the notch // - SDL_HINT_VIDEO_MAC_FULLSCREEN_SPACES=1 will place the video below the notch - bool shouldUseFullScreenSpaces = m_Preferences->windowMode != StreamingPreferences::WM_FULLSCREEN; + bool shouldUseFullScreenSpaces = true; SDL_DisplayMode desktopMode; SDL_Rect safeArea; for (int displayIndex = 0; StreamUtils::getNativeDesktopMode(displayIndex, &desktopMode, &safeArea); displayIndex++) { @@ -583,12 +583,6 @@ bool Session::initialize() shouldUseFullScreenSpaces = false; break; } - else if (m_Preferences->width == safeArea.w && m_Preferences->height == safeArea.h) { - SDL_LogInfo(SDL_LOG_CATEGORY_APPLICATION, - "Overriding default fullscreen mode for native safe area resolution"); - shouldUseFullScreenSpaces = true; - break; - } } }