1349 commits

This branch

This branch

All branches

Author	SHA1	Message	Date
Ross Goldberg	c36a797ac2	SwiftLint ... opt_in_rules: - all Resolve #592 Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>	2024-10-23 06:18:34 -04:00
Ross Goldberg	4d4dd02cd3	Improve lint configurations. ... Partial #592 Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>	2024-10-23 06:18:34 -04:00
Ross Goldberg	2edd21803b	Improve unwrapping. ... Cleanup code. Partial #592 Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>	2024-10-23 06:18:34 -04:00
Ross Goldberg	87aaba555d	Remove unnecessary variable type. ... Partial #592 Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>	2024-10-23 06:18:34 -04:00
Ross Goldberg	ee28af69df	Eliminate magic numbers. ... Partial #592 Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>	2024-10-23 06:18:34 -04:00
Ross Goldberg	fcf8ba29f6	Improve error output. ... Partial #592 Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>	2024-10-23 06:18:34 -04:00
Ross Goldberg	65218eff74	Comment that catch ignores error. ... Partial #592 Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>	2024-10-23 06:18:34 -04:00
Ross Goldberg	3a6d6724c9	Reorder elements. ... Partial #592 Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>	2024-10-23 06:18:33 -04:00
Ross Goldberg	2af2a42a88	Improve parameter names. ... Partial #592 Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>	2024-10-23 06:18:33 -04:00
Ross Goldberg	586de07389	Improve access control. ... Partial #592 Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>	2024-10-23 06:18:33 -04:00
Ross Goldberg	490ee2d338	Fix class names. ... Partial #592 Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>	2024-10-23 06:18:33 -04:00
Ross Goldberg	e927466dce	Use Self. ... Partial #592 Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>	2024-10-23 06:18:33 -04:00
Ross Goldberg	06a347c450	Use isEmpty / beEmpty(). ... Partial #592 Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>	2024-10-23 06:18:33 -04:00
Ross Goldberg	d7074db06f	Remove unnecessary else blocks. ... Partial #592 Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>	2024-10-23 06:18:33 -04:00
Ross Goldberg	71fbe2e444	Improve spacing. ... Partial #592 Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>	2024-10-23 06:18:28 -04:00
Ross Goldberg	3eaffa5c3e	Improve DocC. ... Partial #592 Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>	2024-10-23 06:17:43 -04:00
Ross Goldberg	a100f3acd0	Remove unnecessary generics. ... Partial #592 Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>	2024-10-23 06:17:38 -04:00
Ross Goldberg	3d9ea972f9	Cleanup code. ... Partial #592 Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>	2024-10-23 06:01:42 -04:00
Ross Goldberg	57da9e0f51	Improve style.md. ... Partial #592 Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>	2024-10-23 06:01:41 -04:00
Ross Goldberg	c2892626d7	Fix search & uninstall tests. ... Partial #592 Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>	2024-10-23 06:01:40 -04:00
Ross Goldberg	e62169eeaa	Merge pull request #584 from rgoldberg/583-testing-downgrade ... Downgrade Nimble & Quick to fix testing on newer Xcode versions.	2024-10-18 10:41:27 -04:00
Ross Goldberg	7cd8c1436b	Downgrade Nimble & Quick to fix testing on newer Xcode versions. ... Resolve #583 Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>	2024-10-18 10:28:44 -04:00
Ross Goldberg	916718b415	Merge pull request #581 from rgoldberg/580-bootstrap ... Improve `bootstrap`.	2024-10-17 21:44:06 -04:00
Ross Goldberg	967e8db9ba	Only install periphery from brew if macOS version is >= 13. ... Resolve #580 Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>	2024-10-17 21:40:08 -04:00
Ross Goldberg	f08f0a37d7	Improve bootstrap. ... Partial #580 Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>	2024-10-17 21:39:56 -04:00
Ross Goldberg	ac3d81ed83	Merge pull request #577 from rgoldberg/576-trash ... Improve usage of `trash` in scripts.	2024-10-15 08:20:05 -04:00
Ross Goldberg	f06fc7bb75	Use trash -F instead of trash to facilitate better undelete. ... Resolve #576 Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>	2024-10-15 08:13:54 -04:00
Ross Goldberg	bc961cf0d9	Add trash to Brewfile. ... Partial #576 Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>	2024-10-15 08:13:54 -04:00
Ross Goldberg	de13ad12f5	Merge pull request #575 from rgoldberg/574-app-id-value ... `appIDValue` to encapsulate `uint64Value`.	2024-10-15 08:11:19 -04:00
Ross Goldberg	b0d0f4aacd	appIDValue to encapsulate uint64Value. ... Resolve #574 Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>	2024-10-15 08:06:14 -04:00
Ross Goldberg	8c5890f46d	Merge pull request #573 from rgoldberg/559-readme ... Update `README.md`.	2024-10-15 07:59:47 -04:00
Ross Goldberg	20c08eb855	Update README.md. ... Resolve #559 Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>	2024-10-15 07:49:15 -04:00
Ross Goldberg	bf627ccd79	Merge pull request #572 from rgoldberg/561-itunes-search ... Fix iTunes Search API issues	2024-10-14 16:55:07 -04:00
Ross Goldberg	a44655ac31	Refactor StoreSearch.lookup(…) & StoreSearch.search(…) to share implementation, which allows lookup to accept an Entity argument instead of being hardcoded to desktopSoftware. ... Resolve #561 Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>	2024-10-14 16:46:13 -04:00
Ross Goldberg	280b38dfe8	Add media=software query item to lookup URL to improve results. ... Reorder query items for both lookup URLs & search URLs. Partial #561 Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>	2024-10-14 16:29:47 -04:00
Ross Goldberg	6c5a277ad9	Add & use Entity.desktopSoftware instead of macSoftware. ... `desktopSoftware` returns info (including version & description) that aligns with what is displayed earlier in the App Store, while `macSoftware` is at least sometimes out of alignment. Partial #561 Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>	2024-10-14 16:24:39 -04:00
Ross Goldberg	6489daa0e3	Update iTunes Search API documentation URL. ... Partial #561 Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>	2024-10-14 16:12:39 -04:00
Ross Goldberg	ac3599d050	Merge pull request #571 from rgoldberg/555-testing ... Improve tests	2024-10-14 05:14:51 -04:00
Ross Goldberg	265326dede	Add captureStream(…) to observe stdout & stderr in tests. ... Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>	2024-10-14 05:05:45 -04:00
Ross Goldberg	dccac33abb	Improve tests. ... Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>	2024-10-14 04:40:01 -04:00
Ross Goldberg	f8d7a36a4c	Upgrade test dependencies. ... Quick upgrade necessary if we ever switch from PromiseKit to Swift concurrency. Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>	2024-10-14 04:39:51 -04:00
Ross Goldberg	751e47bd26	Merge pull request #570 from rgoldberg/478-app-id ... Fix app IDs	2024-10-14 04:16:33 -04:00
Ross Goldberg	006273bb81	Standardize names of variables & parameters relating to AppIDs. ... Resolve #478 Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>	2024-10-14 04:10:39 -04:00
Ross Goldberg	39f77c01a9	Create typealias AppID = UInt64. ... Use `AppID` everywhere appropriate. Associated appID cleanup. Partial #478 Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>	2024-10-14 04:10:38 -04:00
Ross Goldberg	43505db37f	Merge pull request #554 from rgoldberg/542-swift-argument-parser ... Use Swift Argument Parser instead of Commandant.	2024-10-14 04:06:33 -04:00
Ross Goldberg	0efd73a5ee	Simplify Outdated.run(…). ... Resolve #542 Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>	2024-10-14 03:44:12 -04:00
Ross Goldberg	cd42176859	Rename apps property of Upgrade as appIds. ... Resolve #542 Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>	2024-10-14 03:44:12 -04:00
Ross Goldberg	388d963cd1	Do not return Result (or anything else) from command run(…) functions. ... Throw when failure. Normal Void return when success. Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>	2024-10-14 03:44:12 -04:00
Ross Goldberg	3b86deb63e	Rename 2 test files that weren't renamed in previous commit to preserve history. ... Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>	2024-10-14 03:44:11 -04:00
Ross Goldberg	2535e3da42	Use Swift Argument Parser instead of Commandant. ... Command structs are nested types of Mas. Renamed structs. Limit code visibility as much as possible. Standardize variable names. Standardize spacing. Fix a few tests. Disable a useless test. Remove unnecessary test stdout output. Get swift-format from Brewfile instead of from Package.swift since swift-format depends on an old version of swift-argument-parser. Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>	2024-10-14 03:44:11 -04:00