Ross Goldberg
602131df1d
Only set bash variables once.
...
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-11-16 14:48:13 -05:00
Ross Goldberg
8338d0b5de
Rename OLD_FILENAME as generated_bottle_filename.
...
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-11-16 14:48:13 -05:00
Ross Goldberg
ea26b72d91
Suppress output for class-dump executable check.
...
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-11-16 14:48:12 -05:00
Ross Goldberg
b96a0a71ba
Simplify script/update_headers.
...
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-11-16 14:48:12 -05:00
Ross Goldberg
53958a40c5
Write to stderr where appropriate.
...
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-11-16 14:48:12 -05:00
Ross Goldberg
92660f665b
Inline bash variables.
...
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-11-16 14:48:12 -05:00
Ross Goldberg
0ea3035324
Move bash variable to left of test.
...
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-11-16 14:48:12 -05:00
Ross Goldberg
a4b7a64e0d
Use bash '…', $'…', or unquoted word instead of "…" whenever possible.
...
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-11-16 14:48:06 -05:00
Ross Goldberg
7cf316a718
Delete unnecessary bash comment.
...
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-11-16 14:47:22 -05:00
Ross Goldberg
73a2b4a364
Ensure single newline at end of every file.
...
Ensure no newlines at beginning of any file.
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-11-16 14:47:22 -05:00
Ross Goldberg
6b1903cde9
cd into root of mas project at beginning of every bash script.
...
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-11-16 14:47:22 -05:00
Ross Goldberg
33559bff9a
Replace bash test with [[ ]].
...
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-11-16 14:47:21 -05:00
Ross Goldberg
7a260db279
Simplify defaults for unsupplied script arguments.
...
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-11-16 14:47:21 -05:00
Ross Goldberg
f1a9cde9fd
Use double quotes around bash substitutions.
...
Use braces around bash variable uses.
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-11-16 14:47:15 -05:00
Ross Goldberg
5b96b77e22
Use short/abbreviated options for consistency.
...
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-11-16 14:46:33 -05:00
Ross Goldberg
7523bc91d0
Update script usage output.
...
Fix acceptable argument count.
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-11-16 14:46:33 -05:00
Ross Goldberg
86a13bb5e6
Update Homebrew formula URL.
...
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-11-16 14:46:33 -05:00
Ross Goldberg
b704d40ee1
If a bottle & its checksum are the same for multiple versions of the same OS, then a checksum is required only for the oldest OS version that shares that bottle/checksum; all later versions of the OS will use that checksum.
...
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-11-16 14:46:32 -05:00
Ross Goldberg
0fe1837277
Fix typo.
...
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-11-16 14:46:32 -05:00
Ross Goldberg
bff9ab52be
Install tools via Homebrew instead of via mise.
...
Remove mise.
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-11-16 14:46:32 -05:00
Ross Goldberg
b4e42b5dd6
Simplify script/bootstrap.
...
We shouldn't need to delete `Brewfile.lock.json` because it doesn't actually lock anything; it just records versions that were installed.
If we don't delete it, new `brew bundle install` run just adds info about what was installed during its run to the existing info about previous bundle installs.
By not deleting, the code can be simplified as per this commit.
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-11-16 14:46:32 -05:00
Ross Goldberg
67ca8f5404
Improve script/lint output.
...
Change YAML emoji to fix spacing issue.
Move YAML lint before Git lint to keep the names getting progressively shorter.
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-11-16 14:46:32 -05:00
Ross Goldberg
c91de70167
release.yml: Check pre_release once for all of homebrew-core job instead of once per each step of that job.
...
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-11-16 04:06:53 -05:00
Ross Goldberg
30962b322e
release.yml: remove unnecessary output.
...
Remove commented code.
Improve step name.
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-11-16 04:06:52 -05:00
Ross Goldberg
a76a2288d2
Obtain path to tap via brew --repo mas-cli/tap instead of hardcoding it.
...
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-11-16 04:06:52 -05:00
Ross Goldberg
097d04c460
Upgrade Xcode dependency to 14.2.
...
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-11-16 04:06:50 -05:00
Ross Goldberg
173b0a9d86
script/bottle: reword "better" as "newer".
...
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-11-15 15:05:55 -05:00
Ross Goldberg
9f9923ea57
Makefile: Mirror bash by using ${…} & $(…) for all variables & command substitutions, respectively.
...
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-11-15 13:19:06 -05:00
Ross Goldberg
1d1335a6f3
Output error to stderr instead of stdout.
...
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-11-15 13:08:47 -05:00
Ross Goldberg
39c5ad0420
Remove seemingly unnecessary pushd & popd.
...
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-11-15 13:08:46 -05:00
Ross Goldberg
88f2bffdf5
Remove unused $echo variable.
...
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-11-15 13:08:46 -05:00
Ross Goldberg
e62482cf42
clean seems unnecessary in bootstrap.
...
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-11-15 13:08:46 -05:00
Ross Goldberg
19e4f6b6d6
mise is installed via brew bundle.
...
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-11-15 13:08:44 -05:00
Ross Goldberg
ddf0028fa6
event.json has placeholder values, and incorrect & inconsistent version values.
...
It only seems to be used for testing with `act`. `event.json` should either be generated or be manually created; in either case, it should reside somewhere that is ignored by git, as the only source of version info in git should be version tags.
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-11-15 12:53:48 -05:00
Ross Goldberg
b050e5363d
Use /bin/bash instead of bash from the $PATH to keep things consistent with the shebangs that are used throughout.
...
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-11-15 12:53:47 -05:00
Ross Goldberg
a3c99702db
Upgrade danger from 3.18.0 to 3.20.2.
...
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-11-15 12:53:32 -05:00
Ross Goldberg
ca921c07d8
Merge pull request #506 from mas-cli/releases/release-1.8.7
...
🔖 Release 1.8.7
2024-11-15 11:08:36 -05:00
Ross Goldberg
8617c75ace
Fix typo in argument check in script/build.
...
Partial #506
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-11-07 09:30:55 -05:00
Ben Chatelain
c314af5167
🩹 Remove duplicate v in tap's root_url
2024-11-03 13:43:21 -07:00
Ben Chatelain
4405807010
🩹 Add pre_release output to start step
2024-11-03 13:10:41 -07:00
Ben Chatelain
a976581515
👔 Open tap PR as ready to review instead of draft
2024-11-03 13:04:02 -07:00
Ben Chatelain
d1be1d9d12
👔 Only run homebrew-core job for real releases
2024-11-03 12:25:25 -07:00
Ben Chatelain
2ccdb03486
🔧 Add PRE_RELEASE var to release workflow
2024-11-03 12:17:31 -07:00
Ben Chatelain
58f9fbcc8c
🚨 Remove unused vars
2024-11-03 12:11:41 -07:00
Ben Chatelain
7bde8fa7e6
🔐 Move HOMEBREW_GITHUB_API_TOKEN to mas formula step
2024-11-03 11:51:53 -07:00
Ben Chatelain
8eeb204ad7
🚨 Fix YAML list indentation
2024-11-03 11:40:46 -07:00
Ben Chatelain
b325020c5c
🚨 Wrap long line
2024-11-03 11:38:06 -07:00
Ben Chatelain
8dd72139a1
👷🏻 Set name of build-test job
2024-11-03 11:32:16 -07:00
Ben Chatelain
b735bcbb6f
🚚 Restore build-test.yml workflow filename
2024-11-03 11:20:32 -07:00
Ben Chatelain
513b99d26f
👷🏻 Restore Build, Test, and Lint name of pr-checks workflow
2024-11-03 11:18:17 -07:00
