Ross Goldberg
47c07d1376
Delete script/brew_core_update
& move its homebrew-core/mas
bump into release.yml
.
...
Run `git rev-parse …` instead of `git rev-list -n 1 …` for mas-cli/tap/mas.
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-20 13:27:12 -05:00
Ross Goldberg
9968bcd148
Replace echo
with printf
in bash scripts.
...
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-20 13:27:12 -05:00
Ross Goldberg
902ab83db6
release.yml
: Combine all separate jobs into one single job to simplify & speedup workflow.
...
Move all environment variables to the top level.
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-20 13:27:12 -05:00
Ross Goldberg
514b93ebc6
release.yml
: Change homebrew-tap.needs
from start
to pkg-installer
to ensure that custom tap isn't bumped if the package installer wasn't uploaded to the GitHub release.
...
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-20 13:27:11 -05:00
Ross Goldberg
e24f52472a
release.yml
: Remove unnecessary
👢 Bootstrap
step from homebrew-core
job.
...
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-20 13:27:11 -05:00
Ross Goldberg
823d4f0c5a
release.yml
: Use !contains(env.RELEASE_TAG, '-')
instead of a pre_release
output from start
job.
...
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-20 13:27:11 -05:00
Ross Goldberg
a7f89f6b7c
release.yml
: Use DRY_RUN
top-level environment variable instead of an output from start
job.
...
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-20 13:27:11 -05:00
Ross Goldberg
ec9a95e00f
release.yml
: Use environment variables top prevent code injection attacks / accidents.
...
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-20 13:27:11 -05:00
Ross Goldberg
d80b898b90
release.yml
: Change start
job
🔈 Log real release event
step if condition.
...
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-20 13:27:11 -05:00
Ross Goldberg
686489a3b6
release.yml
: Improve step names.
...
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-20 13:27:10 -05:00
Ross Goldberg
659bf2e240
release.yml
: Move RELEASE_TAG
environment variable to top level.
...
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-20 13:27:10 -05:00
Ross Goldberg
c15c6a2a8a
release.yml
: Sanitize version tag input by using environment variable.
...
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-20 13:27:10 -05:00
Ross Goldberg
26b892b9f2
Improve URLs.
...
Cleanup comments / documentation / spacing.
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-20 13:27:10 -05:00
Ross Goldberg
3f3b84eaf4
Incorporate fixes from 638/release-fixes by @phatblat.
...
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-20 13:27:10 -05:00
Ross Goldberg
77175d29bc
Improve dry run.
...
`brew_core_update`: disable tracing & cleanup script.
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-20 13:27:10 -05:00
Ross Goldberg
2960ef61fa
Do not indent cases in bash scripts.
...
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-20 13:27:10 -05:00
Ross Goldberg
4b6482e1e1
release.yml
: replace needs.start.outputs.mas_version
with github.event.release.tag_name
.
...
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-20 13:27:10 -05:00
Ross Goldberg
5122765a31
Bash scripts: Change all non-environment variable names to lowercase.
...
Inline variables that are only used once.
Improve comments.
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-20 13:27:10 -05:00
Ross Goldberg
0e8e8488e0
script/install
: fix universal executable path.
...
Cleanup `script/install`.
`Makefile`: use `${PREFIX}` for `install-universal`.
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-20 13:27:09 -05:00
Ross Goldberg
41b100f022
Replace external grep dependency with bash conditional.
...
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-20 13:27:09 -05:00
Ross Goldberg
41f5cb04e9
Remove unnecessary comments from GitHub workflows.
...
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-20 13:27:09 -05:00
Ross Goldberg
1ec76e9d65
Remove extraneous spaces surrounding variables in GitHub workflows.
...
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-20 13:27:09 -05:00
Ross Goldberg
8c397ae24d
release.yml
: improve comments, remove unnecessary environment variables, and reorder some settings.
...
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-20 13:27:09 -05:00
Ross Goldberg
ce81834035
Make brew bump-formula-pr
usages consistent.
...
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-20 13:27:09 -05:00
Ross Goldberg
4f4a37ec74
Cleanup homebrew-core
release job.
...
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-20 13:27:09 -05:00
Ross Goldberg
31e946a69b
Just bump custom tap formula.
...
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-20 13:27:09 -05:00
Ross Goldberg
3b10909c2a
Delete script/bottle
.
...
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-20 13:27:09 -05:00
Ross Goldberg
e1bea1f412
Remove obsolete Makefile
target.
...
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-20 13:27:08 -05:00
Ross Goldberg
4831ea4ac4
Fix Makefile
comment.
...
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-20 13:27:08 -05:00
Ross Goldberg
460718fe3e
Unfinished: Only bump formulae; don't generate them or store them in git.
...
Obtain version & revision from most recent version tag in the current branch, not from environment variable or argument.
Do not branch or commit on release.
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-20 13:27:08 -05:00
Ross Goldberg
009ac1b9bd
Rename script/version_bump
as script/generate_version_info_for_swift
.
...
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-20 13:27:08 -05:00
Ross Goldberg
c2f1bf8e8d
Simplify & standardize script output headers & mas version handling.
...
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-20 13:27:08 -05:00
Ross Goldberg
3414328426
Cleanup .editorconfig
.
...
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-20 13:27:08 -05:00
Ross Goldberg
28266c4734
Simplify script/bottle
.
...
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-20 13:27:08 -05:00
Ross Goldberg
68bdbfe0b9
Only set bash variables once.
...
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-20 13:27:08 -05:00
Ross Goldberg
019c9b9580
Rename OLD_FILENAME
as generated_bottle_filename
.
...
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-20 13:27:07 -05:00
Ross Goldberg
12d0fe9c5c
Suppress output for class-dump
executable check.
...
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-20 13:27:07 -05:00
Ross Goldberg
b7a6948169
Simplify script/update_headers
.
...
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-20 13:27:07 -05:00
Ross Goldberg
ce4205ee66
Write to stderr where appropriate.
...
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-20 13:27:07 -05:00
Ross Goldberg
b3dca79a93
Inline bash variables.
...
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-20 13:27:07 -05:00
Ross Goldberg
8fa8ae9493
Move bash variable to left of test.
...
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-20 13:27:07 -05:00
Ross Goldberg
4d05199fd2
Use bash '…'
, $'…'
, or unquoted word instead of "…"
whenever possible.
...
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-20 13:27:07 -05:00
Ross Goldberg
3789cbdc09
Delete unnecessary bash comment.
...
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-20 13:27:06 -05:00
Ross Goldberg
2ebda42f2b
Ensure single newline at end of every file.
...
Ensure no newlines at beginning of any file.
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-20 13:27:06 -05:00
Ross Goldberg
542356936d
cd
into root of mas project at beginning of every bash script.
...
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-20 13:27:06 -05:00
Ross Goldberg
fc753f69b2
Replace bash test
with [[ ]]
.
...
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-20 13:27:06 -05:00
Ross Goldberg
06e0f401b6
Simplify defaults for unsupplied script arguments.
...
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-20 13:27:06 -05:00
Ross Goldberg
3205a6d2f4
Fix bash subcommand completion.
...
Use double quotes around bash & fish substitutions.
Use braces around bash variable uses.
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-20 13:27:06 -05:00
Ross Goldberg
615be3b8e1
Use short/abbreviated options for consistency.
...
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-13 11:09:41 -05:00
Ross Goldberg
b971d4dbd4
Update script usage output.
...
Fix acceptable argument count.
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-13 11:09:41 -05:00