Ross Goldberg
ecb1070f2a
Remove useless tests.
...
Partial #596
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2025-01-01 20:41:33 -05:00
Ross Goldberg
ad68b6ea5e
Migrate all vestigial XCTest tests to Quick.
...
Partial #596
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-31 19:21:13 -05:00
Ross Goldberg
33efcd4c6b
Rename XCTest files & classes in preparation for migrating them to Quick.
...
Partial #596
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-31 18:06:16 -05:00
Ross Goldberg
f077898d8b
Pass through arguments for script/test to its swift test call.
...
Partial #596
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-31 17:34:17 -05:00
Ross Goldberg
40b6515c20
Merge pull request #646 from rgoldberg/645-codeql
...
Scan for security vulnerabilities with GitHub CodeQL
2024-12-31 11:37:34 -05:00
Ross Goldberg
1f7e391316
Improve .github/workflows/codeql.yml.
...
Allow manual runs.
Run on all pushes & pull requests.
Use `runs-on: macos-15`.
Analyze GitHub workflows.
Don't analyze `ruby` or `c-cpp`.
Perform `security-and-quality` queries.
Remove parentheses from job name.
Remove unnecessary settings.
Remove unnecessary comments.
Remove unnecessary quotes.
Fix lint spacing violations.
Use double quotes instead of single quotes.
Partial #645
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-31 10:52:14 -05:00
Ross Goldberg
ccdadbca8d
Scan for security vulnerabilities with GitHub CodeQL
...
Scan for security vulnerabilities with GitHub CodeQL by adding `codeql.yml` workflow.
Partial #645
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-31 10:37:33 -05:00
Ross Goldberg
af55727ff4
Merge pull request #692 from rgoldberg/679-cleanup
...
Minor Swift cleanup
2024-12-31 10:33:35 -05:00
Ross Goldberg
00a180b846
Improve MASError.jsonParsing.
...
Partial #679
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-31 09:20:51 -05:00
Ross Goldberg
77e1d073d7
Rename ITunesSearchAppStoreSearcher.appVersionExpression as appVersionRegex.
...
Rewrite `appVersionRegex` as `#""versionDisplay":"([^"]+)""#`.
Partial #679
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-31 09:20:51 -05:00
Ross Goldberg
b7f21c583e
Change default value for SearchResult.displayPrice from Unknown to ?.
...
Partial #679
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-31 09:20:51 -05:00
Ross Goldberg
6edda5067d
Rename SoftwareProduct.isOutdatedWhenComparedTo(_) as isOutdated(comparedTo:).
...
Partial #679
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-31 09:20:51 -05:00
Ross Goldberg
49003bc988
Merge pull request #691 from rgoldberg/590-github
...
Configure GitHub workflows
2024-12-31 09:10:34 -05:00
Ross Goldberg
d33b996c9b
Add Swift to dependabot.yml.
...
Partial #590
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-31 09:02:39 -05:00
Ross Goldberg
ff82e2c0e5
Standardize release.yml formatting.
...
Partial #590
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-31 09:01:50 -05:00
Ross Goldberg
3829a0baf3
Minimize permissions granted to github.token.
...
Partial #590
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-31 09:01:50 -05:00
Ross Goldberg
44191ccb8e
Use correct label in dependabot.yml.
...
Standardize `dependabot.yml` format.
Partial #590
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-31 09:01:45 -05:00
Ross Goldberg
8eb8f33d6d
Cleanup build-test.yml Checkout step logs.
...
Partial #590
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-31 05:28:27 -05:00
Ross Goldberg
9db50fd688
No longer use Danger because our implementation was broken & it didn't do anything useful.
...
Partial #590
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-31 05:27:21 -05:00
Ross Goldberg
74797d0fec
Merge pull request #690 from rgoldberg/480-display-name
...
Replace `appNameOrBundleIdentifier` & all output `appName` with `displayName`
2024-12-30 04:06:57 -05:00
Ross Goldberg
d7c4526a32
Replace appNameOrBundleIdentifier & all output appName with displayName, which provides better fallback values for the app name.
...
Minor code cleanup.
Resolve #480
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-30 03:45:57 -05:00
Ross Goldberg
f34efa9c3a
Merge pull request #689 from rgoldberg/684-region
...
Use MAS region instead of macOS region & add `mas region`
2024-12-30 00:03:30 -05:00
Ross Goldberg
f1c21b8e59
Add region command.
...
Use region from `SKStorefront` obtained from `SKPaymentQueue` for macOS 10.15+.
Pass `region` as argument to `lookup` & `search` functions instead of saving as a class member to isolate region to specific calls.
Rename `country` as `region` as much as possible.
Minor cleanup.
Resolve #684
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-29 23:57:23 -05:00
Ross Goldberg
af73aed5ee
Misc DocC cleanup.
...
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-29 21:36:01 -05:00
Ross Goldberg
11a3555f69
Merge pull request #688 from rgoldberg/685-version-uncommitted
...
Append a `+` to version name if there are any uncommitted changes or unignored untracked files
2024-12-29 21:34:05 -05:00
Ross Goldberg
7bfe4e1950
Append a + to the version name if there are any uncommitted changes or unignored untracked files.
...
Resolve #685
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-29 21:29:10 -05:00
Ross Goldberg
48ab1caefd
Merge pull request #687 from rgoldberg/686-immutable
...
Use immutable instead of mutable Swift data
2024-12-29 21:11:28 -05:00
Ross Goldberg
75d651131c
Move captureStream(…) from mas to masTests.
...
Resolve #686
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-29 20:59:27 -05:00
Ross Goldberg
e6f28eb49e
Simplify SearchResult.swift.
...
Partial #686
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-29 20:59:27 -05:00
Ross Goldberg
5d92266600
Remove bundleIdentifier related functions.
...
Partial #686
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-29 20:59:27 -05:00
Ross Goldberg
ed676787f0
Use Swift immutable instead of mutable data.
...
Use `struct` instead of `class`.
Requires switching `SoftwareMapAppLibrary.installedApps` property from lazy to eagerly initialized.
Use `let` instead of `var`.
Inline unnecessary variables.
Improve `Bundle` resource reading.
Restrict symbol visibility.
Simplify code.
Partial #686
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-29 20:59:27 -05:00
Ross Goldberg
26964a8620
Merge pull request #683 from rgoldberg/682-release
...
Finish release overhaul
2024-12-27 00:48:03 -05:00
Ross Goldberg
2bcc0f34f9
Add release scripts.
...
Resolve #682
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-27 00:36:05 -05:00
Ross Goldberg
f777088ba4
Use Xcode 16.2 to build.
...
Partial #682
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-27 00:36:03 -05:00
Ross Goldberg
d6345fb6be
Use GitHub app installation access token instead of a personal access token.
...
Partial #682
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-27 00:36:02 -05:00
Ross Goldberg
080f7944c2
Fix prerelease argument for gh release create in tag-pushed.yml.
...
Partial #682
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-27 00:36:02 -05:00
Ross Goldberg
6010ea8f5d
Remove permissions from tag-pushed.yml.
...
Partial #682
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-27 00:36:01 -05:00
Ross Goldberg
dc72de494f
Improve bump.url handling in release-published.yml.
...
Partial #682
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-27 00:36:00 -05:00
Ross Goldberg
fbbd8bcdb4
Run danger.yml on ubuntu-24.04.
...
Partial #682
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-27 00:35:59 -05:00
Ross Goldberg
c8dc938bd5
Merge pull request #640 from rgoldberg/638-release-improvements
...
Release improvements
2024-12-22 22:05:20 -05:00
Ross Goldberg
82e28104c6
Removed unnecessary quoting.
...
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-22 16:49:06 -05:00
Ross Goldberg
a3a00fc9be
Fix workflows.
...
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-22 16:12:06 -05:00
Ross Goldberg
2b92c5db3d
Improve git fetching in tag-pushed.yml.
...
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-21 12:16:55 -05:00
Ross Goldberg
fa018e7b3d
Include zsh options in GitHub workflows.
...
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-21 11:35:42 -05:00
Ross Goldberg
b069658bc3
Cleanup actions/checkout@v4 step in danger.yml.
...
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-21 11:03:11 -05:00
Ross Goldberg
ac5856e7d5
Spacing in tag-pushed.yml.
...
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-20 15:48:09 -05:00
Ross Goldberg
bbdf8f17dc
Use tag name & tag message in release title.
...
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-20 15:48:05 -05:00
Ross Goldberg
567a330735
Fix tag verification steps in tag-pushed.yml.
...
Avoid warning from checkout step.
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-20 13:27:21 -05:00
Ross Goldberg
61e473e93c
Add HOMEBREW_GITHUB_API_TOKEN environment variable to 🚰 Bump mas-cli/tap/mas formula step in tag-pushed job in tag-pushed.yml.
...
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-20 13:27:21 -05:00
Ross Goldberg
f9ec6bb84f
Add GH_TOKEN environment variable to tag-pushed job in tag-pushed.yml.
...
Partial #638
Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
2024-12-20 13:27:21 -05:00
