Mirrors/inspec
2
0
Fork 0
mirror of https://github.com/inspec/inspec synced 2024-12-26 13:03:13 +00:00
Code Issues Projects Releases Packages Wiki Activity
8059 commits 460 branches 1909 tags 77 MiB
Commit graph

3994 commits

Author SHA1 Message Date
Clinton Wolfe
3cd6eee016 Add valid_plugin_name? predicate and push exclusion list check into its own method 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-27 21:29:42 -04:00
Clinton Wolfe
16fecbefb5 Return version number when listing plugins; correct UX coloration 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-27 21:29:42 -04:00
Clinton Wolfe
e1031cc818 Correct newlines and duplicate output ins various UX messaging 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-27 21:29:42 -04:00
Clinton Wolfe
cc758c7624 Linting 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-27 21:29:42 -04:00
Clinton Wolfe
f0aa934ddc List tests pass again, adding filtering options 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-27 21:29:42 -04:00
Clinton Wolfe
8cab0e862b Adopt the new UI style table, breaking most of the UI tests, which were already broken anyway 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-27 21:29:42 -04:00
Clinton Wolfe
68329aa8e5 Linting 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-27 21:28:52 -04:00
Clinton Wolfe
e581245391 Plausible implementation of detect_system_plugins 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-27 21:28:52 -04:00
Clinton Wolfe
00b2d9480a Rename constant for user gem installs for clarity 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-27 21:28:52 -04:00
Clinton Wolfe
149663ba55 Updated messaging for user gem plugins 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-27 21:28:52 -04:00
Clinton Wolfe
4211d3eb7c Failing functional tests for listing plugin gems 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-27 21:26:49 -04:00
Clinton Wolfe
e90482e955 Refactor train plugin decoration 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-27 21:26:49 -04:00
Chef Expeditor
ba64d06ef7
Bump version to 4.14.2 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-08-28 00:03:34 +00:00
Clinton Wolfe
f90a4c633d
Merge pull request #4419 from inspec/cw/check-enforce-version 
inspec check: warn if inspec_version is not supported by current inspec
 2019-08-27 20:03:19 -04:00
Chef Expeditor
d2dd311561
Bump version to 4.14.1 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-08-27 23:54:27 +00:00
Chef Expeditor
9b84b7b5c1
Bump version to 4.14.0 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-08-27 20:35:09 +00:00
Clinton Wolfe
12c7c51fea Warn not error 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-26 23:29:19 -04:00
Clinton Wolfe
714dc26006 Add unit test and include runtime version check in metadata.valid 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-26 23:05:49 -04:00
Clinton Wolfe
ada6aad169 Move input name stringification into the method 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-22 21:40:01 -04:00
Ryan Davis
bd3ec9aec7 Code cleanup. 
While I was in here... nothing big.

It does seem like we have too many hard-coded symbols in our code in
general as well as too many symbol styles (underscore vs dash).

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-08-20 13:25:21 -07:00
Ryan Davis
7273a7380f Fixed file resource raising UndefinedMethod on source_path 
This is a first pass at fixing the failure found by @scottvidmar where
file resource was raising undefined_method on nil. The problem was
that the initialize method for file was not being called at all
because Resource#initialize was returning early without reporting
anything.

This fix causes a failure in test/functional/inspec_exec_test.rb where
it is testing a similar scenario but for some reason the unsupported
resources get reported. We need to figure that part out, but in the
meantime this will at least report an error at the root cause rather
than down the road.

Fixes #4208

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-08-20 13:25:21 -07:00
Clinton Wolfe
2ef151dd56 Hrm, linting for upstream? 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-19 13:52:28 -04:00
Clinton Wolfe
cc4aa16212 Add test framework to run Runner API input tests 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-19 13:51:51 -04:00
Clinton Wolfe
93521dea0c Accept either input or attribute in the runner API 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-19 13:39:31 -04:00
Chef Expeditor
59301c54ad
Bump version to 4.13.2 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-08-19 16:56:07 +00:00
Clinton Wolfe
3f54f7ac46
Ensure that resources are always initialized in all cases (#4366) 
Ensure that resources are always initialized in all cases
 2019-08-19 12:55:52 -04:00
Chef Expeditor
88d23697f7
Bump version to 4.13.1 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-08-19 16:52:35 +00:00
Clinton Wolfe
e7ccdc03c9
Refactor lib/source_readers/inspec.rb (#4376) 
Refactor lib/source_readers/inspec.rb
 2019-08-19 12:52:20 -04:00
Chef Expeditor
7581ab37c7
Bump version to 4.13.0 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-08-19 16:38:32 +00:00
Clinton Wolfe
8dc350bc6c
Add a Postfix-specific configuration testing resource (#4378) 
Add a Postfix-specific configuration testing resource
 2019-08-19 12:38:17 -04:00
Ryan Davis
43e07e8f2d Finished refactoring! 
Now that the code is easier to read and actually focuses on what it
does in a readable way, it is easier to reason about. In this case, we
have blocks being passed around in order to evaluate a bunch of
paths (read: strings) to determine if they're correct. Why do multiple
`start_with?` and `end_with?` calls? It doesn't cleanly describe what
it is trying to do. Instead, we can use regexps and it'll work just
fine, so lets do that. This simplifies things even further.

46.5: flog total

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-08-18 20:36:19 -07:00
Ryan Davis
3f0e9e9ffa Fix chefstyle. 
This is an area where I really disagree with chefstyle. 🤷

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-08-18 20:36:19 -07:00
Ryan Davis
f8b8f968aa lib/source_readers/inspec.rb refactor 8/8: reformat 
58.9: flog total

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-08-18 20:36:19 -07:00
Ryan Davis
ac6164e56d lib/source_readers/inspec.rb refactor 7/8: combine load_all and find_all. 
58.9: flog total

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-08-18 20:36:19 -07:00
Ryan Davis
213a4489ed lib/source_readers/inspec.rb refactor 6/8: use if/compact instead of delete_if. 
59.0: flog total

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-08-18 20:36:19 -07:00
Ryan Davis
6399116e5f lib/source_readers/inspec.rb refactor 5/8: extract to local var 
60.1: flog total

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-08-18 20:36:19 -07:00
Ryan Davis
5d19283199 lib/source_readers/inspec.rb refactor 4/8: use to_h 
59.8: flog total

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-08-18 20:36:19 -07:00
Ryan Davis
70d8ecf1e8 lib/source_readers/inspec.rb refactor 3/8: pull up file reading. 
59.8: flog total

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-08-18 20:36:19 -07:00
Ryan Davis
4f0a5d6ba1 lib/source_readers/inspec.rb refactor 2/8: normalize variable names. 
76.1: flog total

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-08-18 20:36:19 -07:00
Ryan Davis
6735d03a09 lib/source_readers/inspec.rb refactor 1/8: pull up file selection. 
71.3: original flog total
73.0: flog total (this version)

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-08-18 20:36:19 -07:00
Ryan Davis
f4bae13c68 Fixes for 2 failed tests. 
Rescue NotImplementedError and call failed_resource only if we haven't
already failed the support_check call.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-08-18 19:30:30 -07:00
Ryan Davis
cd5f58f8eb Do not call return inside of an initialize method. 
It does NOT do what you think it does. It does NOT prevent an object
from coming back. All it does is have an uninitialized (or partially
initialized) object come back, which isn't helpful.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-08-18 17:28:56 -07:00
Chef Expeditor
8eded7e258
Bump version to 4.12.0 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-08-15 18:47:02 +00:00
dalee-bis
7f2dbd918f
Fixed MssqlSession.query not escaping double quote correctly 
When `MssqlSession.query` is escaping the `"` character, it is doing so by prefixing it with a backslash (e.g. `\"`). This does not escape the quote character. It should be escaped by adding an additional double quote character (e.g. `""`).
 2019-08-15 11:28:50 +01:00
Chef Expeditor
8e62048b97
Bump version to 4.11.5 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-08-13 16:59:16 +00:00
Chef Expeditor
134ff8048a
Bump version to 4.11.4 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-08-12 18:01:20 +00:00
Chef Expeditor
bce0fbe177
Bump version to 4.11.3 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-08-08 22:06:17 +00:00
David Gasper
52ae5e434b Add docs and unit tests, remove .travis.yml 
Signed-off-by: David Gasper <dmgasper@osuosl.org>
 2019-08-08 13:54:35 -07:00
David Gasper
6ba210d82d Add automatic path resolution 
Signed-off-by: David Gasper <dmgasper@osuosl.org>
 2019-08-08 13:54:22 -07:00
David Gasper
098610f128 Add Postfix_conf resource 
Signed-off-by: David Gasper <dmgasper@osuosl.org>
 2019-08-08 13:50:12 -07:00
Chef Expeditor
3981110da5
Bump version to 4.11.2 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-08-08 17:13:42 +00:00
Chef Expeditor
ffba747523
Bump version to 4.11.1 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-08-08 15:56:10 +00:00
Clinton Wolfe
95e6bcb317
Modified DarwinGroup to collect all users properly. (#4343) 
group resource: Modified DarwinGroup to collect all users properly on macos
 2019-08-08 11:55:48 -04:00
Chef Expeditor
8fad74d4a2
Bump version to 4.11.0 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-08-08 15:32:53 +00:00
Clinton Wolfe
c28dd8f9ec
Add startuser windows service (#4363) 
Add startuser windows service
 2019-08-08 11:32:39 -04:00
Chef Expeditor
7ab39ba273
Bump version to 4.10.7 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-08-08 15:16:21 +00:00
Ryan Davis
374e365c02 Modified DarwinGroup to collect all users properly. 
I noticed that my profile targeting group "staff" on OSX wasn't
returning *me*. I'm awesome! So that seemed wrong. And it turns out it
is wrong. We were not collecting any users whose primary group was
that group. (almost all regular users are in group staff and they're
all missing).

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-08-07 20:27:13 -07:00
Chef Expeditor
90fb536bf7
Bump version to 4.10.6 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-08-08 03:17:56 +00:00
Chef Expeditor
a6dd013ec2
Bump version to 4.10.5 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-08-07 20:29:26 +00:00
Mendy Baitelman
042dd26033 Fix ternary operator 
Signed-off-by: Mendy Baitelman <mendy@baitelman.com>
 2019-08-06 21:12:51 -07:00
Mendy Baitelman
db58322d41 Add startname to systemd server 
Signed-off-by: Mendy Baitelman <mendy@baitelman.com>
 2019-08-06 21:04:52 -07:00
Mendy Baitelman
e3b641f676 Fix whitespace 
Signed-off-by: Mendy Baitelman <mendy@baitelman.com>
 2019-08-06 15:11:15 -07:00
Mendy Baitelman
4505471ec7 Fix differences 
Signed-off-by: Mendy Baitelman <mendy@baitelman.com>
 2019-08-06 13:26:37 -07:00
Mendy Baitelman
126b1efc74 Add startuser to windows service 
Signed-off-by: Mendy Baitelman <mendy@baitelman.com>
 2019-08-06 13:20:57 -07:00
Kris Shannon
4a30a8aa32 Move some resources into Inspec::Resources module 
The `DhParams`, `EtcHosts`, `GrubConfig`, `IisAppPool`, and `SSL`
resources were not properly located inside the `Inspec::Resources`
module.

Fixes: #4327

Signed-off-by: Kris Shannon <k.shannon@amaze.com.au>
 2019-08-05 18:17:01 +10:00
Chef Expeditor
723d53e6b1
Bump version to 4.10.4 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-08-01 00:16:47 +00:00
Chef Expeditor
4aa1ef81f3
Bump version to 4.10.3 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-30 23:45:06 +00:00
Chef Expeditor
1045f67a76
Bump version to 4.10.2 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-30 22:08:14 +00:00
Chef Expeditor
66f709875d
Bump version to 4.10.1 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-30 21:46:48 +00:00
Chef Expeditor
ae898b9eb3
Bump version to 4.10.0 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-30 18:38:10 +00:00
Clinton Wolfe
100e96db1c
Relative Path Support for the Git Fetcher (#4217) 
Relative Path Support for the Git Fetcher
 2019-07-30 14:37:54 -04:00
Chef Expeditor
fbf06ccc7d
Bump version to 4.9.1 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-30 18:37:23 +00:00
Clinton Wolfe
80d5788883
Apply new UI code to CLI and plugin-manager-cli (#4000) 
Apply new UI code to CLI and plugin-manager-cli
 2019-07-30 14:37:09 -04:00
Chef Expeditor
718629e42a
Bump version to 4.9.0 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-30 17:58:52 +00:00
Clinton Wolfe
b8c9043a3a
Permit plugin to be in path with git ref (#4251) 
Permit plugin to be in path with git ref
 2019-07-30 13:58:37 -04:00
Clinton Wolfe
f00e741999 PR feedback 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-07-30 13:38:02 -04:00
Clinton Wolfe
c03862fe7b Code climate updates 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-07-30 13:38:02 -04:00
Clinton Wolfe
abc5e84b87 Fix two tiresome cache issues with simple fixes 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-07-30 13:38:02 -04:00
Clinton Wolfe
1a47026419 Rename some vars, eliminate @profile_directory 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-07-30 13:38:02 -04:00
Clinton Wolfe
4f6d296a22 The error case in which the path does not exist 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-07-30 13:38:02 -04:00
Clinton Wolfe
80241ec971 Passing basic test harness 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-07-30 13:38:02 -04:00
Clinton Wolfe
c257763de6 Linting 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-07-30 13:38:02 -04:00
Clinton Wolfe
0e32d2429f Rename path_within_repo option to relative_path 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-07-30 13:36:20 -04:00
Clinton Wolfe
9c1fa967fd Rename profile_path to path_within_repo 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-07-30 13:36:20 -04:00
Jerry Aldrich
3e1d08cafe Add support for relative paths to the Git fetcher 
This adds support for specifying a path to a profile in a Git repo.

For example, you could have a Git repo containing multiple profiles and
you want to specify a single one like below:

```yaml
depends:
  - name: profile-1
    git: https://github.com/myorg/all-my-profiles.git
    profile_path: profiles/my-specific-profile-1
  - name: profile-2
    git: https://github.com/myorg/all-my-profiles.git
    profile_path: profiles/my-specific-profile-2
```
Signed-off-by: Jerry Aldrich <jerryaldrichiii@gmail.com>
 2019-07-30 13:36:20 -04:00
Clinton Wolfe
88962af285 Update UX message testing 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-07-30 13:19:43 -04:00
Clinton Wolfe
918acb01c1 Linting 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-07-30 13:19:43 -04:00
Miah Johnson
72f02e6cac Fix rubocop 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-07-30 13:19:43 -04:00
Miah Johnson
b148bc85a2 Only some of the output is red 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-07-30 13:19:43 -04:00
Miah Johnson
44592338c6 String interoplation > concatenation 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-07-30 13:19:43 -04:00
Miah Johnson
9fb755a213 Use EXIT value constants 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-07-30 13:19:43 -04:00
Miah Johnson
a524dc030f Convert to new Inspec::UI in inspec-plugin-manager-cli 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-07-30 13:19:43 -04:00
Miah Johnson
da9bd13fd4 Use Inspec::UI throughout InspecCLI 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-07-30 13:19:43 -04:00
Chef Expeditor
ef14623c0a
Bump version to 4.8.6 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-30 00:50:58 +00:00
Chef Expeditor
d9840d9a3c
Bump version to 4.8.5 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-29 20:15:52 +00:00
Chef Expeditor
3182227fb2
Bump version to 4.8.4 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-29 19:47:51 +00:00
Ryan Davis
2d5fdabf86
Merge pull request #4337 from inspec/zenspider/remove-version-checking 
Removed lib/inspec/utils/latest_version.rb and associated code.
 2019-07-29 12:47:37 -07:00
Chef Expeditor
d12a3c8b59
Bump version to 4.8.3 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-29 19:46:52 +00:00
Ryan Davis
3d6a4143a1 Removed lib/inspec/utils/latest_version.rb and associated code. 
There is no reason why our tests should be failing because we deploy a
new version. That test shouldn't even be hitting the network for real.

Besides, the functionality has no place in our codebase. It's
functionality provided via `gem outdated` so why did we re-implement
it? And we expect most people to be running via omnibus, so they're
pinned to a specific version in the first place. Even if they updated,
they still couldn't run it and that would be more confusing.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-07-29 11:57:08 -07:00
Chef Expeditor
6e307797da
Bump version to 4.8.2 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-29 17:02:06 +00:00
Chef Expeditor
aee7511820
Bump version to 4.8.1 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-29 17:00:32 +00:00
Clinton Wolfe
be91550343
windows_task: Fix handling of multiple triggers (#4242) 
windows_task: Fix handling of multiple triggers
 2019-07-29 13:00:16 -04:00
Chef Expeditor
9fd9a57f02
Bump version to 4.8.0 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-29 16:51:04 +00:00
Clinton Wolfe
962ec0591e
Transition the Habitat plugin to use scaffolding (#4320) 
Transition the Habitat plugin to use scaffolding
 2019-07-29 12:50:49 -04:00
Chef Expeditor
2e9b838af1
Bump version to 4.7.26 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-26 18:49:01 +00:00
Chef Expeditor
bf845da203
Bump version to 4.7.25 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-25 23:13:48 +00:00
Ryan Davis
04a0139057
Merge pull request #4324 from inspec/zenspider/windows-testing 
Initial pass to clean up functional testing wrt exit codes and output.
 2019-07-25 16:13:33 -07:00
Chef Expeditor
868cb4a39f
Bump version to 4.7.24 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-25 22:21:21 +00:00
Ryan Davis
917a531a92 Skipped all failing tests on windows AT the failures site. 
This activates a BUNCH of tests but keeps us green.

Whether these tests are valid or not is not being addressed here.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-07-24 18:09:08 -07:00
Ryan Davis
1d5d3dfc43 I don't know how I missed these. Removing the rest of the skip_windows calls. 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-07-24 18:06:25 -07:00
Ryan Davis
18ce4850f0 Initial pass to clean up functional testing wrt exit codes and output. 
This should get windows tests running again? Hopefully? They're
running SO slowly on my vagrant box that I'm just pushing for now.
They're clean on the mac side.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-07-24 18:06:25 -07:00
Chef Expeditor
b27465b027
Bump version to 4.7.23 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-23 18:47:27 +00:00
Ryan Davis
bd79e9c895
Merge pull request #4316 from inspec/zenspider/fix-file-aws 
Fix exceptions when resources are used with incompatible transports
 2019-07-23 11:47:13 -07:00
Chef Expeditor
399b1cbdc1
Bump version to 4.7.22 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-23 02:38:02 +00:00
Chef Expeditor
22d8a6e7d2
Bump version to 4.7.21 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-22 21:39:44 +00:00
Ryan Davis
7a1e1bb775
Merge pull request #4230 from yeoldegrove/sys_info 
add resource sys_info.manufacturer and sys_info.model
 2019-07-22 14:39:28 -07:00
Ryan Davis
9f91b53193 Refactored and cleaned a minor bit in runner.rb 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-07-22 14:19:15 -07:00
Ryan Davis
d3df69213b Fix handling using resources with incompatible resources (eg file + aws). 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-07-22 14:19:15 -07:00
Chef Expeditor
f90255ab09
Bump version to 4.7.20 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-22 20:44:43 +00:00
Clinton Wolfe
7c251b6fd6
Suppress gem docs when installing plugins (#4286) 
Suppress gem docs when installing plugins
 2019-07-22 16:44:28 -04:00
Chef Expeditor
8247bf694f
Bump version to 4.7.19 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-22 19:29:50 +00:00
Clinton Wolfe
1c7c2a1e32 Pass option to skip installing documentation when installing plugins 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-07-22 15:17:30 -04:00
Clinton Wolfe
a31e0bcf5e Un-deprecate the be_running matcher on service resource 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-07-22 14:52:45 -04:00
John Snow
ea7956177a Fix tests to use only plan file 
Signed-off-by: John Snow <thelunaticscripter@outlook.com>
 2019-07-22 07:35:33 -04:00
John Snow
bbb809f703 Transition the Habitat plugin to use scaffolding 
Signed-off-by: John Snow <thelunaticscripter@outlook.com>
 2019-07-19 15:25:06 -04:00
Chef Expeditor
a804fd477d
Bump version to 4.7.18 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-18 01:46:12 +00:00
Chef Expeditor
2d4798b948
Bump version to 4.7.17 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-17 22:15:45 +00:00
Chef Expeditor
c37e69e0fc
Bump version to 4.7.16 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-17 21:25:52 +00:00
Eike Waldt
73f729e4b1
changed from system_profiler to sysctl on OSX 
(kudos to Petrik)

Signed-off-by: Eike Waldt <waldt@b1-systems.de>
 2019-07-16 21:53:15 +02:00
Eike Waldt
b47cf6e80e
change from dmidecode to /sys/class/dmi/id/* 
(kudos to Seife)

Signed-off-by: Eike Waldt <waldt@b1-systems.de>
 2019-07-16 21:53:03 +02:00
Eike Waldt
9fa97e8baa
use double quotes 
Signed-off-by: Eike Waldt <waldt@b1-systems.de>
 2019-07-16 21:02:53 +02:00
Eike Waldt
cf4c0f1ed3
fix copypasta 
Signed-off-by: Eike Waldt <waldt@b1-systems.de>
 2019-07-16 21:02:52 +02:00
Eike Waldt
2700018c58
hardcode "Apple Inc." vendor if on OSX 
Signed-off-by: Eike Waldt <waldt@b1-systems.de>
 2019-07-16 21:02:52 +02:00
Eike Waldt
64777457c9
use "system_profiler" instead of "dmidecode" on OSX 
Signed-off-by: Eike Waldt <waldt@b1-systems.de>
 2019-07-16 21:02:52 +02:00
Eike Waldt
c5fb5c0f9f
add resource sys_info.manufacturer and sys_info.model 
Signed-off-by: Eike Waldt <waldt@b1-systems.de>
 2019-07-16 20:39:38 +02:00
Chef Expeditor
354cf97e54
Bump version to 4.7.15 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-16 18:14:57 +00:00
Chef Expeditor
1cac2b3383
Bump version to 4.7.14 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-16 18:14:09 +00:00
Chef Expeditor
7d25e6ae05
Bump version to 4.7.13 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-16 18:10:43 +00:00
Chef Expeditor
7d627f8663
Bump version to 4.7.12 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-16 17:11:00 +00:00
Chef Expeditor
95ed2696e9
Bump version to 4.7.11 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-16 04:22:15 +00:00
Ryan Davis
ee3a989897
Merge pull request #4302 from TheLonelyGhost/fix-typo-in-exception-class-name 
Typo in class name (obvious fix)
 2019-07-15 22:21:58 -06:00
Chef Expeditor
92e88efcae
Bump version to 4.7.10 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-16 04:16:26 +00:00
David Alexander
56c81ee34e
Typo in class name (obvious fix) 
Signed-off-by: David Alexander <opensource@thelonelyghost.com>
 2019-07-15 17:00:37 -04:00
Chef Expeditor
f73b6b55f5
Bump version to 4.7.9 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-15 17:20:09 +00:00
Chef Expeditor
ca02539ccf
Bump version to 4.7.8 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-12 17:16:37 +00:00
Chef Expeditor
44a7d5412e
Bump version to 4.7.7 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-12 17:05:01 +00:00
Clinton Wolfe
389fd96920
chefstyle -a (#4276) 
chefstyle -a
 2019-07-12 13:04:46 -04:00
Chef Expeditor
bf74ea3995
Bump version to 4.7.6 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-10 19:58:14 +00:00
Chef Expeditor
cec4121152
Bump version to 4.7.5 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-10 04:50:17 +00:00
Chef Expeditor
80b1a209af
Bump version to 4.7.4 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-10 02:06:27 +00:00
Chef Expeditor
239ae17185
Bump version to 4.7.3 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-09 20:36:34 +00:00
Chef Expeditor
badb7e6b89
Bump version to 4.7.2 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-09 00:25:35 +00:00
Miah Johnson
a4f4fe5231 chefstyle -a; https://github.com/chef/chefstyle/pull/74 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-07-08 17:22:50 -07:00
Chef Expeditor
a0475c5069
Bump version to 4.7.1 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-08 19:03:37 +00:00
Chef Expeditor
ac30832933
Bump version to 4.7.0 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-08 18:45:48 +00:00
Miah Johnson
8272d0184b
Merge pull request #4236 from ramereth/ip6tables 
Add ip6tables resource
 2019-07-08 11:45:33 -07:00
Miah Johnson
fdf5f6f133
Merge pull request #4256 from inspec/cw/update-style-to-rubocop-0.72 
Automated chefstyle application for rubocop 0.72 compatibility
 2019-07-08 11:39:14 -07:00
Chef Expeditor
26825ca3d6
Bump version to 4.6.13 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-05 20:05:04 +00:00
Chef Expeditor
48262f68bd
Bump version to 4.6.12 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-03 23:40:51 +00:00
Chef Expeditor
90b109dff6
Bump version to 4.6.11 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-03 22:38:48 +00:00
Clinton Wolfe
e4e7c255de Automated chefstyle application for rubocop 0.72 compatibility 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-07-03 17:24:41 -04:00
James Stocks
3ef4092d39 Permit plugin to be in path with git ref 
Fixes #3904

Signed-off-by: James Stocks <jstocks@chef.io>
 2019-07-02 16:49:38 +01:00
Chef Expeditor
490824e6ce
Bump version to 4.6.10 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-02 06:39:18 +00:00
Miah Johnson
825751bdb9
Merge pull request #4233 from jaredledvina/patch-1 
Debian service detection for Buster
 2019-07-01 23:39:01 -07:00
Chef Expeditor
be237ad6ef
Bump version to 4.6.9 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-01 19:16:31 +00:00
Jerry Aldrich
668b8d82bf windows_task: Fix handling of multiple triggers 
When using `schtasks` a list is returned if the task has multiple
triggers. This merges that list with the last item taking precedence.
This is how `Get-ScheduledTask` behaves.

Initially, I was going to rewrite this resource to use
`Get-ScheduledTask` but the original author purposely did not do this
so that PowerShell v3 would be supported. We only support PowerShell
v5, but I don't want to break any current users and this change didn't
seem to controversial to me.

If it gives us trouble, I recommend rewriting it to use
`Get-ScheduledTask`.

Signed-off-by: Jerry Aldrich <jerryaldrichiii@gmail.com>
 2019-06-28 00:27:53 -07:00
Lance Albertson
3263d76627 Add ip6tables resource 
This should resolve #1011 which provides an ip6tables resource to test IPv6
iptables rules. This is essentially a copy of the iptables resource with a few
renames.

In addition, I've pulled in the integration tests for iptables into ip6tables
and enabled it on docker so that it properly gets tested regularly. The test
cookbook recipe has been updated to support all of the current platforms that
are being tested.

Signed-off-by: Lance Albertson <lance@osuosl.org>
 2019-06-24 17:01:34 -07:00
Jared Ledvina
0e1f31747b
Debian service detection for Buster 
Currently, /etc/debian_version for the Debian Buster/Sid release contains "buster/sid". This causes version to be set to 0 resulting in SysV being configured as the service provider incorrectly. This commit updates the debian detection logic to work for "buster/sid" as version 10 and makes sense that we have a non-0 version before setting the init system.

Signed-off-by: Jared Ledvina <jared@techsmix.net>
 2019-06-22 12:50:14 -04:00
Chef Expeditor
8bcbaf6967
Bump version to 4.6.8 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-06-22 00:14:38 +00:00
Chef Expeditor
47f887b8f9
Bump version to 4.6.7 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-06-21 20:01:58 +00:00
Chef Expeditor
9e426ab1e7
Bump version to 4.6.6 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-06-20 18:35:11 +00:00
Miah Johnson
9d7b651938
Merge pull request #4219 from inspec/mj/ucs 
`chefstyle -a` after merging #4156
 2019-06-19 13:51:47 -07:00
Miah Johnson
8e020f1b51 chefstyle -a after merging #4156 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-06-19 13:34:17 -07:00
Chef Expeditor
3cd2ff51a9
Bump version to 4.6.5 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-06-19 20:33:41 +00:00
Miah Johnson
aa52697725
Merge branch 'master' into license-check 2019-06-19 11:46:23 -07:00
Chef Expeditor
07e53e72d0
Bump version to 4.6.4 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-06-19 00:55:37 +00:00
Jerry Aldrich
2d72cd5905 Modify line to be more idiomatic. 
Thanks @clintoncwolfe!

Signed-off-by: Jerry Aldrich <jerryaldrichiii@gmail.com>
 2019-06-18 08:05:57 -08:00
Jerry Aldrich
80c595ba3d nginx_conf: Fix commented/empty file parsing 
This fixes `nginx_conf.params` when:
  - Given an empty file
  - Given a file with only comments
  - Given a file that has an include for a file that:
    - Is empty
    - Has all lines commented out

This also fixes a test where a missing file is actually empty

Signed-off-by: Jerry Aldrich <jerryaldrichiii@gmail.com>
 2019-06-17 21:57:26 -08:00
Chef Expeditor
24b7c3a15b
Bump version to 4.6.3 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-06-17 17:00:38 +00:00
Chef Expeditor
8358ec5861
Bump version to 4.6.2 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-06-17 16:29:26 +00:00
Clinton Wolfe
a2dcb9fbea Manually sync lib version files for sanity's sake 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-06-17 11:26:53 -04:00
Clinton Wolfe
4ce2192678 Impactful KPI upswing 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-06-12 19:09:11 -04:00
Clinton Wolfe
5a4cbe2c17 Add missing param 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-06-12 19:05:48 -04:00
Clinton Wolfe
4aa805c7ad Linting 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-06-12 19:05:48 -04:00
Clinton Wolfe
43f7fe52f1 Implementation and some light refactoring of bind_inputs_from_metadata 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-06-12 19:02:34 -04:00
Ryan Davis
f16238607d Turn off aws and azure testing via NO_AWS env. 
This massively speeds up our testing, shaving our functionals by a
third (639s -> 423s). We can realize this speedup either by setting
the env or by jettisoning aws and azure into their own separately
tested gems.

This is currently turned off for travis just for demonstration
purposes.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-06-11 21:32:23 -07:00
Ryan Davis
387b713d79 Removing extra requires from inspec/profile. 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-06-11 21:32:22 -07:00
Ryan Davis
fae4230a41 Removing inspec/profile_vendor from inspec/base_cli. 
This was the next most expensive require in the analysis.

Also rearranged the way that ui handled tables to be lazy.

```
% SLOW=1 time rake test:functional

before: Finished in  681.514579s, 0.5136 runs/s, 2.9919 assertions/s.
after : Finished in  642.655918s, 0.5446 runs/s, 3.1728 assertions/s.
```

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-06-11 19:16:58 -07:00
Ryan Davis
bfbb89a05c First pass making bin/inspec faster. 
This removes requiring 'inspec' in bin/inspec and goes straight to
'inspec/cli'. It removes almost all the top-level requires in
inspec/cli.rb. This requires some autoloads and rearrangements of
requires to the command methods themselves.

```
% SLOW=1 time rake test:functional

before: Finished in 1072.442633s, 0.3264 runs/s, 1.9013 assertions/s.
after:  Finished in  681.514579s, 0.5136 runs/s, 2.9919 assertions/s.
```

I'm positive there is more we can do.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-06-11 18:59:55 -07:00
Ryan Davis
692d6a9ab8 hand applied one that is now marked as unsafe in rubocop 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-06-11 18:52:38 -07:00
Miah Johnson
c8836e6856 enforce_type_restriction! will exit before new_value 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-06-11 18:52:38 -07:00
Miah Johnson
68e540a15a Ignore Rubocop checks 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-06-11 18:52:38 -07:00
Miah Johnson
20531342d2 unused assignment 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-06-11 18:52:38 -07:00
Miah Johnson
729177f3c6 chefstyle -a 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-06-11 18:52:38 -07:00
Miah Johnson
e46018a517 chefstyle -a cleanup 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-06-11 18:52:38 -07:00
Miah Johnson
c458897ad1 != 0 vs !foo.zero? 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-06-11 18:52:38 -07:00
Ryan Davis
a5309ea392 blindly applied chefstyle -a 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-06-11 18:52:03 -07:00
Chef Expeditor
77d2bebda2
Bump version to 4.5.1 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-06-11 20:04:03 +00:00
Chef Expeditor
e275f3343c
Bump version to 4.5.0 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-06-10 19:14:13 +00:00
Clinton Wolfe
ec1baf6237
New plugin type: Input (#4019) 
New plugin type: Input
 2019-06-10 15:13:57 -04:00
Chef Expeditor
1ad929648b
Bump version to 4.4.75 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-06-06 22:30:50 +00:00
Clinton Wolfe
27d9643353 Fix nil profile name 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-06-06 15:26:09 -04:00
Chef Expeditor
b4444c0cef
Bump version to 4.4.74 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-06-06 18:33:45 +00:00
Chef Expeditor
a0def41ce2
Bump version to 4.4.73 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-06-06 18:33:12 +00:00
Clinton Wolfe
9366804335 PR Feedback 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-06-06 12:51:22 -04:00
Clinton Wolfe
3a3a2cefff linting 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-06-06 12:51:22 -04:00
Clinton Wolfe
90da768ef0 Move event creation to input_registry to simplify plugin authorship 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-06-06 12:51:22 -04:00
Clinton Wolfe
a62fdabf70 bugfix - plugin_name is called from both plugin definition and implementation classes 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-06-06 12:51:22 -04:00
Clinton Wolfe
53beaff372 Input plugin types work 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-06-06 12:51:22 -04:00
Clinton Wolfe
7fc50708d1 bugfix - allow setting input priority in DSL 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-06-06 12:51:22 -04:00
Clinton Wolfe
9e2e569d85 Add input plugin type API 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-06-06 12:51:21 -04:00
Clinton Wolfe
82f910e320 Plugin type declaration and unit test 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-06-06 12:51:21 -04:00
Chef Expeditor
d4ae9e1e01
Bump version to 4.4.72 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-06-04 21:17:25 +00:00
Ryan Davis
443f4a16d7 Fix CLI version command test to be resilient on a bad network. 
Also switched out LatestInSpecVersion.latest to be much cleaner using open-uri.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-06-04 13:47:48 -07:00
Chef Expeditor
f28265358b
Bump version to 4.4.71 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-06-04 17:48:58 +00:00
Chef Expeditor
82718c779b
Bump version to 4.4.70 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-06-04 06:40:43 +00:00
Ryan Davis
58fa148773 Stabilize windows functional testing. 
Skip most everything.

After some digging, in those tests that didn't have 100% failures, of
the ~10+% passing, those tests weren't checking enough. So I skip them
too in the hopes that we improve testing across the board.

At this point, we need appveyor to be green more than we need these
tests to be fixed. If that means we skip them, so be it.

These tests will time-bomb at the end of July.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-06-03 23:27:26 -07:00
Chef Expeditor
702533f351
Bump version to 4.4.69 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-06-04 06:04:19 +00:00
Chef Expeditor
0474910f57
Bump version to 4.4.68 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-06-04 06:03:36 +00:00
Chef Expeditor
b63f70df1c
Bump version to 4.4.67 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-06-04 00:20:48 +00:00
Chef Expeditor
5a7d548c14
Bump version to 4.4.66 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-06-03 20:39:48 +00:00
Artem Sidorenko
eaec745edf Using dist constants for license check 
Signed-off-by: Artem Sidorenko <artem.sidorenko@t-systems.com>
 2019-06-03 15:29:53 +02:00
Artem Sidorenko
9d03fd7882 Allow to switch off the license check 
similar to the approach in chef/chef: https://github.com/chef/chef/pull/8354/files#diff-847fc1c7c0af04a65c570c6f4c3381e9R25

Signed-off-by: Artem Sidorenko <artem.sidorenko@t-systems.com>
 2019-06-03 15:29:53 +02:00
Chef Expeditor
c0643c33ee
Bump version to 4.4.65 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-05-31 20:46:22 +00:00
Miah Johnson
2a1b1d8e88 Remove all leading newlines. 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-05-31 11:43:44 -07:00
Chef Expeditor
97df4c33fd
Bump version to 4.4.64 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-05-31 18:29:50 +00:00
Chef Expeditor
e4567052e3
Bump version to 4.4.63 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-05-31 18:29:14 +00:00
Chef Expeditor
ecbb8c0d17
Bump version to 4.4.62 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-05-30 19:07:17 +00:00
Chef Expeditor
ed7861fcf6
Bump version to 4.4.61 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-05-30 01:33:24 +00:00
Ryan Davis
4790e288a0
Merge pull request #4142 from inspec/zenspider/clean_unnecessary_requires 
Clean unnecessary requires
 2019-05-29 18:33:06 -07:00
Chef Expeditor
66e95a4847
Bump version to 4.4.60 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-05-30 01:08:31 +00:00
Ryan Davis
be125598c8 Additional whitespace cleanup. 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-05-29 17:58:02 -07:00
Ryan Davis
a8bcba780f Got the rest of the functionals to pass. 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-05-29 17:58:02 -07:00
Ryan Davis
82c9aa6ed6 Got the rest of the tests to pass. 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-05-29 17:58:02 -07:00
Ryan Davis
de8258c9f7 Get yaml_test.rb working 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-05-29 17:58:02 -07:00
Ryan Davis
761f48e63c Get user_test.rb working 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-05-29 17:58:02 -07:00
Ryan Davis
61585de0f0 Moved out all of the requires for inspec/resources/* from inspec/resource.rb 
All requires moved to inspec/resources.rb

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-05-29 17:58:02 -07:00
Ryan Davis
adaf2bc364 Removed aws resource requiring from test/helper and inspec/resource. 
This speeds up parallel unit test runs from a very consistent 2:49 to
a very consistent 1:53, or a 33% reduction.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-05-29 17:58:02 -07:00
Chef Expeditor
15c770183f
Bump version to 4.4.59 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-05-29 23:52:19 +00:00
Ryan Davis
fcb65b2ffb Fixed Inspec::Dist on habitat CLI. 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-05-29 16:22:28 -07:00
Chef Expeditor
1fc518c588
Bump version to 4.4.58 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-05-29 02:24:01 +00:00
Chef Expeditor
9007dbb540
Bump version to 4.4.57 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-05-28 21:17:53 +00:00
Miah Johnson
365810a622
Merge pull request #4136 from artem-forks/debranding-plugin-manager-cli 
Dist branding for some of plugins
 2019-05-28 14:17:36 -07:00
Chef Expeditor
2d528f5899
Bump version to 4.4.56 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-05-28 20:06:10 +00:00
Miah Johnson
6c19e81a06 Remove authors tags from source files. 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-05-28 12:47:39 -07:00
Artem Sidorenko
eee2199960 Dist branding for plugins/inspec-compliance 
Signed-off-by: Artem Sidorenko <artem.sidorenko@t-systems.com>
 2019-05-28 21:00:56 +02:00
Artem Sidorenko
e468c592ca Dist branding for plugins/inspec-habitat 
Signed-off-by: Artem Sidorenko <artem.sidorenko@t-systems.com>
 2019-05-28 21:00:56 +02:00
Artem Sidorenko
4c0260aedd Dist branding for plugins/inspec-artifact 
Signed-off-by: Artem Sidorenko <artem.sidorenko@t-systems.com>
 2019-05-28 21:00:49 +02:00
Artem Sidorenko
5a2bf961f8 Dist branding for plugins/inspec-plugin-manager-cli 
Signed-off-by: Artem Sidorenko <artem.sidorenko@t-systems.com>
 2019-05-28 21:00:36 +02:00
Chef Expeditor
85f2dcccb8
Bump version to 4.4.55 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-05-28 18:44:58 +00:00
Clinton Wolfe
c8f0de05af
inspec check: Send log to STDERR when running with --format json (#4001) 
inspec check: Send log to STDERR when running with --format json
 2019-05-28 14:44:44 -04:00
Chef Expeditor
54a75f7d62
Bump version to 4.4.54 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-05-28 18:35:11 +00:00
Miah Johnson
2215bb0570 Update all requires pointing to util/ 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-05-28 11:30:16 -07:00
Miah Johnson
86e638ee20 Move lib/utils -> lib/inspec/utils 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-05-28 11:29:16 -07:00
Chef Expeditor
ea959d32ba
Bump version to 4.4.53 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-05-28 18:12:59 +00:00
Chef Expeditor
1065d3ff1d
Bump version to 4.4.52 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-05-28 18:08:38 +00:00
Chef Expeditor
333b2a4f7a
Bump version to 4.4.51 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-05-28 18:01:36 +00:00
Chef Expeditor
96e36c423b
Bump version to 4.4.50 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-05-28 17:58:43 +00:00
Ryan Davis
f36a7c8061 No tabs. 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-05-25 03:40:36 -07:00
Chef Expeditor
06e517ba07
Bump version to 4.4.49 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-05-22 19:35:42 +00:00
Chef Expeditor
c72d8bc2aa
Bump version to 4.4.48 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-05-21 23:50:36 +00:00
Chef Expeditor
b1191f1b65
Bump version to 4.4.47 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-05-21 19:45:35 +00:00
Miah Johnson
fb0993e0f2
Merge pull request #4089 from mirskiy/github_url_regex_bug 
Fix github url regex. Add period for repo
 2019-05-21 12:45:18 -07:00
Chef Expeditor
869103dccf
Bump version to 4.4.46 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-05-21 02:52:43 +00:00
Miah Johnson
83bc512f3e
Merge pull request #4104 from inspec/mj/aws 
Ensure AwsResourceMixin returns a resource name in deprecation message
 2019-05-20 19:52:27 -07:00
Chef Expeditor
f20cc5508a
Bump version to 4.4.45 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-05-20 20:10:45 +00:00
Miah Johnson
27ee7a1a63
Merge pull request #4107 from inspec/zenspider/telemetry_requires 
Minor require cleanup for telemetry.
 2019-05-20 13:10:30 -07:00
Ryan Davis
9c6965b2ed Minor require cleanup for telemetry. 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-05-20 13:09:38 -07:00
Chef Expeditor
2ce931f6d5
Bump version to 4.4.44 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-05-20 20:09:32 +00:00
Chef Expeditor
f71e7febf9
Bump version to 4.4.43 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-05-20 20:08:51 +00:00
Miah Johnson
2df6dc2ea8
Merge pull request #4100 from inspec/zenspider/fix-missing-requires 
Fixed missing requires.
 2019-05-20 13:08:46 -07:00
Chef Expeditor
106bc6cdda
Bump version to 4.4.42 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-05-20 20:08:10 +00:00
Miah Johnson
d1358df59f
Merge pull request #4115 from inspec/zenspider/clean_method_call_pattern 
Stop using method(...).call(...)
 2019-05-20 13:07:43 -07:00
Chef Expeditor
c1e022bd3c
Bump version to 4.4.41 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-05-20 20:07:21 +00:00
Miah Johnson
36029da0a3
Merge pull request #4116 from inspec/zenspider/clean_more_requires 
Clean more requires
 2019-05-20 13:07:04 -07:00
Chef Expeditor
4cd62d3d30
Bump version to 4.4.40 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-05-20 20:04:49 +00:00
Miah Johnson
1fe48f2e7b
Merge pull request #4113 from inspec/zenspider/use_math_for_perms 
Just use math.
 2019-05-20 13:04:24 -07:00
Chef Expeditor
499e99f2ba
Bump version to 4.4.39 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-05-20 20:03:36 +00:00
Ryan Davis
e1061f41f2 Clean more requires 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-05-20 13:01:18 -07:00
Chef Expeditor
461991a1a3
Bump version to 4.4.38 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-05-20 19:58:42 +00:00
Chef Expeditor
01dee92ca2
Bump version to 4.4.37 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-05-20 19:57:23 +00:00
Miah Johnson
69151ced56
Merge pull request #4119 from inspec/mj/missing_requires 
Fix missing requires in toml, postgres_conf resources
 2019-05-20 12:56:59 -07:00
Chef Expeditor
da57262892
Bump version to 4.4.36 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-05-20 19:56:40 +00:00
Miah Johnson
b6c86bfad8
Merge pull request #4118 from inspec/mj/rtjson 
json was required twice.
 2019-05-20 12:56:27 -07:00
Miah Johnson
94f14bae20 Fix missing requires in toml, postgres_conf resources 
toml was missing json
postgres_conf was missing object_traversal

Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-05-19 11:31:59 -07:00
Miah Johnson
e514fbff90 json was required twice. 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-05-19 11:02:02 -07:00
Ryan Davis
7e5c27410e This is one place where rubocop and I strongly disagree. 
Using self.something makes it more clear. Sometimes that is necessary.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-05-18 21:04:27 -07:00
Ryan Davis
22a3ee5855 Fixed missing requires. 
Telemetry tests were hitting inspec/config via a different route and
inspec/config uses forwardable w/o requiring.

lib/plugins/inspec-compliance/test/unit/api_test.rb had a test that
had never run before and required webmock.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-05-18 21:02:13 -07:00
Chef Expeditor
7fb177a691
Bump version to 4.4.35 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-05-19 01:08:41 +00:00
Ryan Davis
03a1fba565 Stop using method(...).call(...) 
Use send. It's **vastly** faster:

```
Comparison:
                send:  6364383.9 i/s
         method+call:  2530347.8 i/s - 2.52x  slower
```

Also removed a bunch of unnecessary to_sym's. Ruby doesn't care.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-05-18 16:53:33 -07:00
Ryan Davis
fe82931b39 Just use math. 
I don't know what the reasoning is behind the rjust & the format
call... String converting between octal to binary in order to get an
integer? Instead, this converts from an octal string and uses
straight-forward binary manipulation and logic.

Please avoid `cond ? false : true` like constructs. Use `!cond` instead.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-05-18 15:50:01 -07:00
Chef Expeditor
d665efc8c8
Bump version to 4.4.34 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-05-18 22:44:42 +00:00
Ryan Davis
62890e4809 This needed to be a flat_map because :profiles was an array. 
Entirely on me. Pushing this through to rectify my mistake in review.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-05-18 15:16:09 -07:00
Chef Expeditor
f1654c02d2
Bump version to 4.4.33 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-05-18 22:01:01 +00:00
Ryan Davis
8ea1889001
Merge pull request #4079 from inspec/mj/cli_warn 
Fix @unique_controls uninitialized warning
 2019-05-18 15:00:47 -07:00
Chef Expeditor
87db267ef1
Bump version to 4.4.32 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-05-18 21:29:49 +00:00
Ryan Davis
9b7c292d4c Use IO globals instead of IO constants. 
Helps testing and lots of other things if we only use $stdout/$stderr.

STDOUT/STDERR should only be used to restore the globals.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-05-18 12:48:18 -07:00
Dan Mirsky
1e20e2998e Fix github tree url regex. Add period for repo 
Signed-off-by: Dan Mirsky <mirskiy@gmail.com>
 2019-05-18 10:50:39 -07:00
Miah Johnson
a3c55ea49f We didn't need a Set! 
Update this based on feedback from @zenspider

Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-05-18 00:00:59 -07:00
Miah Johnson
2181b9a76b Ensure AwsResourceMixin returns a resource name 
`@__resource_name` may be nil, so return our resource name via
`self.class.to_s`. This isn't perfect, is there something better to use
here?

.[2019-05-17T20:14:37-07:00] WARN: DEPRECATION: AWS resources shipped with core InSpec are being to moved to a resource pack for faster iteration. Please update your profiles to depend on git@github.com:inspec/inspec-aws.git . Resource 'AwsElbs'

AwsElbs? This is the `aws_elbs` resource, this is not user-friendly. :(

Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-05-17 20:15:21 -07:00
Chef Expeditor
a0f9487f9d
Bump version to 4.4.31 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-05-18 00:55:15 +00:00
Miah Johnson
3db8d93fe5 Use #key? rather than #has_key? in profile_name ternary 
lib/inspec/profile_context.rb:28:29: C: [Corrected] Style/PreferredHashMethods: Use Hash#key? instead of Hash#has_key?.
      @profile_name = @conf.has_key?('profile') ? @conf['profile'].profile_name : @profile_id
                            ^^^^^^^^

355 files inspected, 1 offense detected, 1 offense corrected

Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-05-17 16:39:14 -07:00
Chef Expeditor
40ef08183b
Bump version to 4.4.30 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-05-17 22:21:51 +00:00
Miah Johnson
ee899d694f
Merge pull request #4081 from inspec/mj/profile_context 
Fix @profile_name not initialized
 2019-05-17 15:21:38 -07:00
Chef Expeditor
b51608e629
Bump version to 4.4.29 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-05-17 22:20:59 +00:00
Miah Johnson
0e896221e5
Merge pull request #4083 from inspec/mj/circular-telemetry 
Fix circular require in telemetry
 2019-05-17 15:20:43 -07:00
Chef Expeditor
a4f039adff
Bump version to 4.4.28 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-05-17 21:38:26 +00:00
Ryan Davis
9b0d8edfb4 Fixed another bad test interaction. 
This time between:

+ PluginManagerCliDefinitionTests#(?:test_plugin_registered
+ PluginLoaderTests#test_load_mock_plugin_by_gem

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-05-17 02:26:07 -07:00
Ryan Davis
3ba7aecffb Skips the one test that hits rspec directly and causes mocha to blow out afterwards 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-05-17 02:26:07 -07:00
Ryan Davis
ec9121dafe Cleanup long lines for readability / debugging. 
Also asked a couple q's in TODO lines.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-05-17 02:26:07 -07:00
Ryan Davis
8ec76e666e Fixed assignment to RUBY_VERSION. 
Lost in a sea of deprecation warnings.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-05-17 02:26:07 -07:00
Ryan Davis
a53d118b3f Punting on 2 tests in inspec-plugin-manager-cli. 
These two tests make assumptions that are not valid when bundler is
not being used.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-05-17 02:26:07 -07:00
Ryan Davis
e16657883a Fixed referenced urls so we can find the cited code again. 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-05-17 02:26:06 -07:00
Ryan Davis
7935d5553d Fix how we're running inspec to include local lib dir. 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-05-17 02:26:06 -07:00
Ryan Davis
e7348f4d72 Add minitest/hell and parallelize_me! to the plugin tests. 
We already do this in test/helper.rb so we might as well do it here.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-05-17 02:26:06 -07:00
Ryan Davis
0c9644c1c2 Use RbConfig::CONFIG instead of Gem.ruby_version for plugin_gem_path 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-05-17 02:26:06 -07:00
Ryan Davis
6235c3f658 Fixed missing requires 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-05-17 02:26:06 -07:00
Ryan Davis
cdf95cd160 Fixed 3 failures in cmp matcher. 
+ float? comparison can raise a TypeError
+ octal? comparison was allowing non-octal values (which cast to 0)
+ symbol comparison was casting to a string, but then doing an == check instead of casecmp.

The latter seems optional, but consistent with the intent of cmp.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-05-17 02:26:06 -07:00
Ryan Davis
bc249a78cb Changed cmp matcher to use send. 
obj.method(name).call(*args) == obj.send(name, *args)

```
Calculating -------------------------------------
         method+call      2.561M (± 2.2%) i/s -     12.816M in   5.006835s
                send      6.299M (± 2.4%) i/s -     31.501M in   5.004045s

Comparison:
                send:  6299002.5 i/s
         method+call:  2560909.2 i/s - 2.46x  slower
```

There aren't any direct tests for this? But I forcefully failed 2
functionals and then verified they passed after my change.

Not sure how (or if) to write tests against rspec matchers in a
meaningful way, even tho all I really want to test is a plain ole
method in it. I'll poke to see if it is possible / practical.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-05-17 02:26:06 -07:00
Ryan Davis
427d59f13f Fixes loading of Telemetry::DataSeries (and neighbors) in isolation. 
Fixes telemetry tests when run individually.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-05-17 02:26:06 -07:00
Chef Expeditor
e251ebf22b
Bump version to 4.4.27 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-05-16 23:57:46 +00:00
Lynn Frank
4511ac6aaf Updates the init plugin desc to show proper usage 
Obvious fix.
 2019-05-16 16:43:05 -05:00
Chef Expeditor
506cb5a6a2
Bump version to 4.4.26 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-05-16 18:45:27 +00:00
Miah Johnson
6a60f6137f Don't require telemetry/global_methods to prevent circular require 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-05-16 00:45:58 -07:00
Miah Johnson
75f071ae48 require telemetry/global_methods 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-05-16 00:45:24 -07:00
Miah Johnson
d70172f96e Fix @profile_name not initialized 
I believe that if `@conf['profile']` doesn't exist @profile_name may not
be initialized.

```
inspec-master/lib/inspec/profile_context.rb:35: warning: instance variable @profile_name not initialized
```

Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-05-16 00:22:27 -07:00
Miah Johnson
083c6c0bae Fix @unique_controls uninitialized warning 
memoize @unique_controls to a Set if nil and
check that its empty? to continue and add controls

/home/miah/projects/github/inspec-master/lib/inspec/reporters/cli.rb:169: warning: instance variable @unique_controls not initialized

Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-05-15 17:29:37 -07:00
Chef Expeditor
67929db658
Bump version to 4.4.25 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-05-15 23:50:31 +00:00
Chef Expeditor
39dd4128d0
Bump version to 4.4.24 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-05-15 22:55:39 +00:00
Chef Expeditor
77f0efd1e8
Bump version to 4.4.23 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-05-15 22:40:48 +00:00
Chef Expeditor
043790dcb3
Bump version to 4.4.22 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-05-15 22:40:03 +00:00
Chef Expeditor
e470937ee3
Bump version to 4.4.21 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-05-15 21:43:57 +00:00
Chef Expeditor
060e00e6e2
Bump version to 4.4.20 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-05-15 20:44:39 +00:00
Chef Expeditor
07082f2473
Bump version to 4.4.19 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-05-15 20:36:53 +00:00
Chef Expeditor
2b54b0bede
Bump version to 4.4.18 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-05-15 19:31:33 +00:00
Miah Johnson
947e7ddad9
Merge pull request #4052 from aaronlippold/al/mssql-session-fix 
Removed unneeded 'supports: windows'
 2019-05-15 12:31:18 -07:00
Chef Expeditor
11f5c311d2
Bump version to 4.4.17 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-05-15 17:55:57 +00:00
Miah Johnson
bb92546bf2
Merge pull request #4037 from inspec/ap/improve-postgres-resource 
Make the postgres resource more defensive
 2019-05-15 10:55:41 -07:00
Chef Expeditor
73d6b6953f
Bump version to 4.4.16 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-05-15 17:05:18 +00:00
Chef Expeditor
7381a6902f
Bump version to 4.4.15 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-05-15 08:39:16 +00:00
Ryan Davis
f5d35494d9 Pulling requires out of often called methods. 
While debugging this hairy situation, I had hooked require to try to
figure out sequencing. These requires were called thousands upon
thousands of times, creating a lot of noise and having no benefit
other than a possible savings of a few millisecond on an already slow
startup.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-05-14 23:25:28 -07:00
Ryan Davis
6adf1d2560 Remove all byebug requires in code. 
Please don't leave debugging remnants in the code.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-05-14 23:24:14 -07:00
Chef Expeditor
e2426bf6b6
Bump version to 4.4.14 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-05-10 22:17:53 +00:00
Aaron Lippold
8a20c63c05 Removed unneeded 'supports: windows' 
Microsoft now support `sqlcmd` on all platforms so we can support
all platforms as runners. Without this I cannot run mssql profiles from
osx or linux runners.

https://docs.microsoft.com/en-us/sql/connect/odbc/linux-mac/installing-the-microsoft-odbc-driver-for-sql-server?view=sql-server-2017#os-x-1011-el-capitan-and-macos-1012-sierra

Signed-off-by: Aaron Lippold <lippold@gmail.com>
 2019-05-09 17:02:16 -04:00
Miah Johnson
f7575cca00 Remove more magic comments 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-05-09 13:24:25 -07:00
Chef Expeditor
9cbd7c395f
Bump version to 4.4.13 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-05-09 17:56:53 +00:00
Alex Pop
1f32d92f78 updates based on PR feedback 
Signed-off-by: Alex Pop <alexpop@users.noreply.github.com>
 2019-05-09 09:14:03 +01:00
Alex Pop
902920f0fa Make the postgres resource more defensive 
Signed-off-by: Alex Pop <alexpop@users.noreply.github.com>
 2019-05-09 08:43:31 +01:00
Chef Expeditor
5d6bb7753f
Bump version to 4.4.12 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-05-09 06:49:40 +00:00
Miah Johnson
bf28482350
Merge pull request #4043 from inspec/ap/no-resource-capitalize 
Wrap resources in backticks and remove resource name capitalizing
 2019-05-08 23:49:25 -07:00
Chef Expeditor
6d56b3e4d9
Bump version to 4.4.11 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-05-08 23:25:17 +00:00
Miah Johnson
5dd4356abf
Merge pull request #4042 from inspec/mj/resources 
Relocate core resources from lib/resources to lib/inspec/resources
 2019-05-08 16:24:59 -07:00
Chef Expeditor
845ecea1e7
Bump version to 4.4.10 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-05-08 20:25:05 +00:00
Miah Johnson
25382bc281 Update require path in main resource loader 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-05-08 13:09:54 -07:00
Miah Johnson
0abac967f5 Update resource requires after relocation 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-05-08 13:09:54 -07:00
Miah Johnson
4172ae48fa Relocate resources to inspec/resources 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-05-08 13:09:54 -07:00
Chef Expeditor
b2a18a7aa4
Bump version to 4.4.9 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-05-08 20:01:20 +00:00
Chef Expeditor
fbb4b78e51
Bump version to 4.4.8 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-05-08 20:00:26 +00:00
Miah Johnson
11b8da3283
Merge branch 'master' into mj/encoding 2019-05-08 12:59:55 -07:00
Chef Expeditor
654a6617d3
Bump version to 4.4.7 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-05-08 19:58:16 +00:00
Chef Expeditor
08a92b510d
Bump version to 4.4.6 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-05-08 19:56:42 +00:00
Miah Johnson
1edfeae5f4
Merge pull request #4025 from inspec/mj/3849 
Enable user telemetry opt-in / opt-out on cli
 2019-05-08 12:56:29 -07:00
Chef Expeditor
5a98792a9e
Bump version to 4.4.5 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-05-08 19:49:36 +00:00
Chef Expeditor
2bdae3b296
Bump version to 4.4.4 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-05-08 19:37:27 +00:00
Miah Johnson
9eeb8274cb
Merge pull request #3954 from cc-build/distro-identity 
First step to get inspec names changeable
 2019-05-08 12:37:12 -07:00
Chef Expeditor
59b5ee5260
Bump version to 4.4.3 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-05-08 19:32:48 +00:00
Chef Expeditor
ff82a7e2dc
Bump version to 4.4.2 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-05-08 19:24:07 +00:00
Miah Johnson
37ea6f2f77
Merge pull request #4023 from inspec/zenspider/minitest 
Modernize use of Minitest.
 2019-05-08 12:23:49 -07:00
Alex Pop
d7f06f98f1 Wrap resources in backticks and remove resource name capitalizing 
Signed-off-by: Alex Pop <alexpop@users.noreply.github.com>
 2019-05-08 20:17:51 +01:00
Chef Expeditor
4628036b57
Bump version to 4.4.1 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-05-08 19:08:17 +00:00
Miah Johnson
d000f20f34 Update Collector#reset to clear telemetry_toggled_off 
Updated the name of #reset -> #reset! as we are modifying state of a
singeton.

Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-05-08 00:36:45 -07:00
Miah Johnson
871b0e9a38 Ensure telemetry can be disabled 
The #disable_telemetry method now toggles @telemetry_toggle_off.
The @telemetry_toggle_off is defaulted to false

The #telemetry_enabled? method now checks @telemetry_toggle_off
and we generally check the configuration. We do not flip
@telemetry_toggle_off based on the content of the configuration.

Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-05-08 00:30:24 -07:00
Miah Johnson
046d4567ae rubocop 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-05-07 19:10:42 -07:00
Miah Johnson
ea0643cc14 Handle load_config better 
private method to minimize external interface
default enabled to false if unable to find setting in configuration
add reader for config

Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-05-07 19:04:51 -07:00
Miah Johnson
6881c210ad Gather all telemetry options and return them 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-05-07 19:03:30 -07:00
Miah Johnson
3695094218 cli -> --enable-telemetry and default to false 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-05-07 18:55:11 -07:00
Miah Johnson
659b4b373a Remove # encoding: utf8 magic comments 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-05-07 16:06:23 -07:00
Chef Expeditor
1d3bd603aa
Bump version to 4.4.0 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-05-06 19:58:27 +00:00
Clinton Wolfe
ec91ac9ee0
Rename 'attribute' DSL method to 'input' (#4008) 
Rename 'attribute' DSL method to 'input'
 2019-05-06 15:58:09 -04:00
Clinton Wolfe
ad3a9f7807 Allow setting location when format is JSON, but default to STDERR 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-05-06 14:58:10 -04:00
Clinton Wolfe
329eee3782 Make inspec check respect logging destination 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-05-06 14:58:10 -04:00
Artem Sidorenko
96353a708a First step to get inspec names changeable 
for community distributions

Signed-off-by: Artem Sidorenko <artem.sidorenko@t-systems.com>
 2019-05-06 18:40:35 +02:00
Miah Johnson
c9ae6a9d20 Add a missing doc 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-05-03 16:28:01 -07:00
Miah Johnson
f1b1b3eccf Ensure the collector is aware of the config class 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-05-03 16:06:25 -07:00
Ryan Davis
476c6878b3 Modernize use of Minitest. 
+ Turn off verbosity in Rakefile by default. Use `rake V=1` to turn back on.
+ MiniTest -> Minitest everywhere.
+ MiniTest::Unit::TestCase -> Minitest::Test everywhere.
+ Updated minitest doco urls to official and up-to-date site.
+ Normalize requires. Only needs "minitest/autorun" and "minitest/pride".

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-05-03 15:01:57 -07:00
Chef Expeditor
04ad6351d8
Bump version to 4.3.5 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-05-03 17:52:04 +00:00
Miah Johnson
122246bcc4 load our configuration and set telemetry status 
Allow overriding config object

Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-05-02 20:14:15 -07:00
Miah Johnson
78f7f000f5 Allow enabling or disabling telemetry from the cli 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-05-02 20:13:37 -07:00
Miah Johnson
b0ee14a204 Expose configuration for telemetry as method 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-05-02 20:12:53 -07:00
Chef Expeditor
1bba904dad
Bump version to 4.3.4 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-05-01 19:00:55 +00:00
Miah Johnson
063a7d82e7
Merge pull request #4004 from inspec/mj/4003 
Update resource registry_key documentation example
 2019-05-01 12:00:36 -07:00
Chef Expeditor
9a15388431
Bump version to 4.3.3 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-05-01 18:24:53 +00:00
Clinton Wolfe
3bfc0cec68 Add input() DSL method, could use some DRY up 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-04-30 23:56:17 -04:00
Clinton Wolfe
f54abf9719 How was value: ever working? 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-04-30 23:28:23 -04:00
Miah Johnson
5c00a44d71 Update resource registry_key documentation example 
ref: https://github.com/inspec/inspec/issues/4003

Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-04-30 17:04:12 -07:00
Chef Expeditor
a6feb2f32c
Bump version to 4.3.2 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-04-30 00:43:30 +00:00
Chef Expeditor
d87c24514f
Bump version to 4.3.1 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-04-30 00:03:18 +00:00
tyler-ball
d1a3c55863 Correcting missing version for InSpec 
Signed-off-by: tyler-ball <tball@chef.io>
 2019-04-29 17:55:13 -06:00
Clinton Wolfe
a282204b41 Update exe location in functional test helpers 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-04-29 13:27:10 -06:00
Chef Expeditor
9b13bcb953
Bump version to 4.2.0 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-04-26 18:00:08 +00:00
Clinton Wolfe
154824128c Make sure --input-file change made it in 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-04-26 13:14:32 -04:00
Clinton Wolfe
7d2028287c Get unit and functional tests passing 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-04-26 13:14:32 -04:00
Clinton Wolfe
9156a782fe Add stack introspection 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-04-26 13:14:32 -04:00
Clinton Wolfe
9faf4b1034 Add tests for marshalling 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-04-26 13:14:31 -04:00
Clinton Wolfe
407dcd9028 Add unit tests for enforcing type validation 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-04-26 13:14:31 -04:00
Clinton Wolfe
2536d76324 Events work at the unit level, except for stack hueristics 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-04-26 13:14:31 -04:00
Clinton Wolfe
b8cde5530b Add event, some tests still commented out 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-04-26 13:14:31 -04:00
Clinton Wolfe
aae54d2cb6 Checkpoint commit after Input rename; precedence is broken 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-04-26 13:14:31 -04:00
Clinton Wolfe
8ef5eb46b1 Start getting unit tests passing again 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-04-26 13:14:31 -04:00
Clinton Wolfe
883572fcbb First bits on consolidating attribute creation into the registry 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-04-26 13:14:31 -04:00
Chef Expeditor
9e07bf8fbd
Bump version to 4.1.16 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-04-26 17:11:57 +00:00
Chef Expeditor
f5cbccc626
Bump version to 4.1.15 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-04-25 23:49:53 +00:00
Chef Expeditor
049c6cb3bf
Bump version to 4.1.14 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-04-25 22:57:00 +00:00
Chef Expeditor
78d94965b9
Bump version to 4.1.13 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-04-25 22:33:34 +00:00
Clinton Wolfe
db129be2b2
Provide logger to license-acceptance for help debugging in the future (#3958) 
Provide logger to license-acceptance for help debugging in the future
 2019-04-25 18:33:16 -04:00
Chef Expeditor
a8333172d8
Bump version to 4.1.12 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-04-25 22:28:40 +00:00
Chef Expeditor
4265c5ff17
Bump version to 4.1.11 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-04-25 22:27:47 +00:00
Chef Expeditor
3ae47763bb
Bump version to 4.1.10 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-04-25 18:43:58 +00:00
Clinton Wolfe
9e6adcc7b1
update 'low' impact value to align with CVSS 3.0 (#3961) 
update 'low' impact value to align with CVSS 3.0
 2019-04-25 14:43:43 -04:00
Chef Expeditor
406cc82b1f
Bump version to 4.1.9 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-04-25 15:11:14 +00:00
Chef Expeditor
2628857241
Bump version to 4.1.8 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-04-25 15:10:33 +00:00
Chef Expeditor
3c4e3d1279
Bump version to 4.1.7 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-04-25 15:09:55 +00:00
Clinton Wolfe
00bcf91dac
When mssql response is parsed, header might be nil. (#3971) 
When mssql response is parsed, header might be nil.
 2019-04-25 11:09:52 -04:00
Clinton Wolfe
843ba7afa2
Improve ss parsing code for IPv6 addresses (#3962) 
Improve ss parsing code for IPv6 addresses
 2019-04-25 11:09:31 -04:00
Chef Expeditor
5504820d39
Bump version to 4.1.6 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-04-24 00:57:35 +00:00
Miah Johnson
7506ae4121 When mssql response is parsed, header might be nil. 
Only set and downcase header if its not nil.

Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-04-23 14:45:34 -07:00
Aaron Lippold
6d452540d0 updated low to align with CVSS 3.0 
Signed-off-by: Aaron Lippold <lippold@gmail.com>
 2019-04-23 15:02:52 -04:00
Chef Expeditor
3defc93670
Bump version to 4.1.5 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-04-23 01:17:19 +00:00
Chef Expeditor
f1cc0b0477
Bump version to 4.1.4 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-04-22 16:50:02 +00:00
Miah Johnson
27935e9e51 Improve ss parsing code for IPv6 addresses 
Some versions of `ss` wrap IPv6 addresses in brackets, eg:

```
[fe80::dc11:b9b6:514b:134]%eth0:123
[::]
```

This change removes all brackets during parsing.

Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-04-18 23:55:50 -07:00
tyler-ball
8425a50872 Provide logger to license-acceptance for help debugging in the future 
Signed-off-by: tyler-ball <tball@chef.io>
 2019-04-18 12:29:57 -06:00
Chef Expeditor
50a8fd7370
Bump version to 4.1.3 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-04-17 21:12:41 +00:00
Clinton Wolfe
3d0b8dff2e
Merge pull request #3956 from inspec/cw/use-deprecation-everywhere-4-port 
Use deprecation facility everywhere - v4 port
 2019-04-17 17:12:24 -04:00
Clinton Wolfe
6a580ade70 Add missing group argument in deprecator 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-04-17 15:58:18 -04:00
Chef Expeditor
e3999a0814
Bump version to 4.1.2 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-04-17 17:41:26 +00:00
Chef Expeditor
bf15cffcc4
Bump version to 4.1.1 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-04-17 15:57:48 +00:00
Clinton Wolfe
7aeb1763a9
Merge pull request #3897 from mattlqx/interface-addresses 
Support address matchers on interface resource
 2019-04-17 11:57:29 -04:00
Clinton Wolfe
1552dc0210 Merge branch 'cw/use-deprecation-everywhere-3-port' of github.com:inspec/inspec into cw/use-deprecation-everywhere-4-port 2019-04-16 17:42:45 -04:00
Clinton Wolfe
ba6d59dc66 Deprecation handler in unit test helper 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-04-16 16:27:56 -04:00
Chef Expeditor
92a132ef18
Bump version to 4.1.0 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-04-16 18:42:03 +00:00
Clinton Wolfe
0c884b1415
Merge pull request #3895 from mitre/al-mitre/more-permissive-than 
Signed-off-by: Aaron Lippold <lippold@gmail.com>
 2019-04-16 14:41:43 -04:00
Matt Kulka
633cea6673 support address matchers on interface resource 
Adds missing functionality to `interface`. Fixes #1830

```
describe interface("eth0") do
  its(ipv4_addresses) { should include 1.2.3.4 }
end
```

And so on... see diff/docs for additional matchers.

Signed-off-by: Matt Kulka <mkulka@parchment.com>
 2019-04-12 08:24:13 -07:00
Clinton Wolfe
fc1bc75358 Adjust deprecations somewhat 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-04-12 10:55:36 -04:00
Chef Expeditor
5de39cb325
Bump version to 4.0.8 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-04-12 14:09:02 +00:00
Chef Expeditor
e456a1786d
Bump version to 4.0.7 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-04-12 14:08:18 +00:00
Jerry Aldrich
40031a9b83 Use deprecation facility throughout code 
This converts all current deprecation warnings/TODOs to use the
`Inspec.deprecate()` deprecation facility.

This also modifies `Inspec.deprecate()` to only require 1 argument.

Signed-off-by: Jerry Aldrich <jerryaldrichiii@gmail.com>
 2019-04-11 19:15:01 -04:00
Chef Expeditor
414268eccc
Bump version to 4.0.6 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-04-11 22:56:25 +00:00
Clinton Wolfe
4348e8fa07
Merge pull request #3935 from inspec/cw/add-license-gating 
Add license acceptance to InSpec v4
 2019-04-11 18:56:11 -04:00
Chef Expeditor
afe936ead1
Bump version to 4.0.5 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-04-11 20:23:32 +00:00
Clinton Wolfe
03385b98ba
Merge pull request #3928 from inspec/mj/tmr 
Telemetry Object Model
 2019-04-11 16:23:17 -04:00
Clinton Wolfe
0ce122ff21 Linting 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-04-11 10:37:43 -04:00
Clinton Wolfe
1c13bcc35e Change exit code to 172 when license is not accepted 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-04-11 10:30:46 -04:00
Clinton Wolfe
f7c4f56670 Ensure that an empty invocation does not trigger the license check 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-04-11 10:30:46 -04:00
Clinton Wolfe
e0fe3f1876 Add version to list of exempt commands 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-04-11 10:30:46 -04:00
Clinton Wolfe
07a1679086 Customize behavior when the license challenge fails 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-04-11 10:29:27 -04:00
tyler-ball
96edf5394f Fully leveraging latest set of license acceptance library features 
Signed-off-by: tyler-ball <tball@chef.io>
 2019-04-11 10:29:27 -04:00
Clinton Wolfe
47da04f4e0 Alter require to use snakecase library name 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-04-11 10:27:48 -04:00
Clinton Wolfe
e3c9c019e3 Add basic integration for the acceptance lib 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-04-11 10:27:48 -04:00
Miah Johnson
acead4dd40 Remove doc line. 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-04-11 00:42:26 -07:00
Miah Johnson
61e639e2fe Move @data creation to initialize. 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-04-11 00:41:51 -07:00
Miah Johnson
ac78feb090 Remove list_data_series_by_name. 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-04-11 00:41:09 -07:00
Miah Johnson
56a5c80bf5 Rebuild the core telemetry interface. 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-04-09 16:58:40 -07:00
Clinton Wolfe
a83401c932 Freeze version to appease rubocop 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-04-09 14:00:46 -04:00
Clinton Wolfe
2b30646642 Merge branch 'cw/attrs-rename-cli-option' into 3-stable 2019-04-09 12:10:53 -04:00
Chef Expeditor
4648018f1d
Bump version to 4.0.4 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-04-09 15:46:50 +00:00
Clinton Wolfe
b701317616
Merge pull request #3879 from inspec/cw/attrs-rename-cli-option 
Attribute->Input Rename: Rename cli option
 2019-04-09 11:46:29 -04:00
Chef Expeditor
04242abe61
Bump version to 4.0.3 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-04-08 22:23:05 +00:00
Chef Expeditor
4a11430e4e Bump version to 4.0.2.pre by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-04-08 15:14:48 -04:00
Stuart Paterson
3f1ed29af8 Address PR feedback, add a comment to inspec.yml. 
Signed-off-by: Stuart Paterson <spaterson@chef.io>
 2019-04-08 14:30:21 -04:00
Stuart Paterson
549a04bdae Update README with the re-added security group control. 
Signed-off-by: Stuart Paterson <spaterson@chef.io>
 2019-04-08 14:30:21 -04:00
Stuart Paterson
50a7bc7862 Replace port 22 ingress control. 
Signed-off-by: Stuart Paterson <spaterson@chef.io>
 2019-04-08 14:30:21 -04:00
Stuart Paterson
41a680270e Update AWS profile generation for InSpec 4 to depend on the new resource pack. 
Signed-off-by: Stuart Paterson <spaterson@chef.io>
 2019-04-08 14:30:21 -04:00
Chef Expeditor
36eb4459c1 Bump version to 4.0.1.pre by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-04-08 14:30:21 -04:00
Clinton Wolfe
0d38b65d50 Linting 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-04-08 14:28:57 -04:00
Clinton Wolfe
af4d9edd2a Ignore resource overwrite warnings if they are aws resources 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-04-08 14:28:31 -04:00
Clinton Wolfe
82b8638472 Use inspec v3 internally 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-04-08 14:28:31 -04:00
Clinton Wolfe
4b44df8d6e Set version to 4.0.0.pre 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-04-08 14:26:03 -04:00
Chef Expeditor
9ce07e7ab9
Bump version to 3.9.2 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-04-08 15:22:51 +00:00
Chef Expeditor
29bec90b1b
Bump version to 3.9.1 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-04-04 17:26:28 +00:00
Miah Johnson
8435990722
Merge pull request #3899 from inspec/sp/crontab-path-update 
crontab: Add validation for path param
 2019-04-04 17:26:13 +00:00
Chef Expeditor
1833a98730
Bump version to 3.9.0 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-04-01 20:08:08 +00:00
Chef Expeditor
dab819088c
Bump version to 3.8.1 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-04-01 19:59:26 +00:00
Chef Expeditor
90c325a196
Bump version to 3.8.0 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-04-01 19:07:28 +00:00
Clinton Wolfe
e931d277b1
Merge pull request #3906 from inspec/cw/projects-passthru 
automate reporter: Add top-level 'passthrough' field
 2019-04-01 15:07:12 -04:00
Chef Expeditor
f72241b6e6
Bump version to 3.7.12 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-04-01 18:11:12 +00:00
Aaron Lippold
1e9f8fd018 Merge branch 'master' of https://github.com/inspec/inspec into al-mitre/more-permissive-than 
Signed-off-by: Aaron Lippold <lippold@gmail.com>
 2019-03-28 15:50:16 -04:00
Clinton Wolfe
2f5c063e08 Add 'passthrough' field 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-03-28 01:10:25 -04:00
Clinton Wolfe
5aeeefb3ed Remove 'recipies' field 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-03-28 01:08:57 -04:00
Clinton Wolfe
973054dd81 Move existing passthru fields into json-automate 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-03-28 01:08:20 -04:00
Aaron Lippold
e312b44563 Addressing review items. 
Signed-off-by: Aaron Lippold <lippold@gmail.com>
 2019-03-27 09:55:48 -04:00
Chef Expeditor
70ffa66a8e
Bump version to 3.7.11 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-03-22 05:20:54 +00:00
Chef Expeditor
51e8ac2f4f
Bump version to 3.7.10 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-03-21 17:37:27 +00:00
Miah Johnson
6ce349dcde
Merge pull request #3873 from inspec/cw/config-add-caching 
Add caching to Inspec::Config
 2019-03-21 10:37:06 -07:00
Stuart Paterson
0c0e0aa016
Remove debugging lines. 
Signed-off-by: Stuart Paterson <spaterson@chef.io>
 2019-03-21 16:20:06 +00:00
Stuart Paterson
5accfa5391
Add protection for crontab resource path and document it. 
Signed-off-by: Stuart Paterson <spaterson@chef.io>
 2019-03-21 15:49:00 +00:00
Chef Expeditor
69a3f7130c
Bump version to 3.7.9 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-03-20 15:10:50 +00:00
Lynn Frank
6018a6959d Fixes indentation of kernal_module example 
Signed-off-by: Franklin Webber <franklin.webber@gmail.com>
 2019-03-19 12:05:15 -05:00
Lynn Frank
23eff3df24 Fixes rubocop violation on indention 
Signed-off-by: Franklin Webber <franklin.webber@gmail.com>
 2019-03-19 11:32:07 -05:00
Lynn Frank
2857d07151 Fixes resource examples 
The opening and closing mechanic varied between all the various
resources. This changes them all to use a HEREDOC with a tilde
to remove leading whitespace. This removes the need for the
special method to trim the `#print_example` method from shell.

Signed-off-by: Franklin Webber <franklin.webber@gmail.com>
 2019-03-19 11:25:41 -05:00
Aaron Lippold
a2a86860d6 This adds the more_permissive_than?(mode) matcher to the file resource. 
Fixes #3893

Signed-off-by: Aaron Lippold <lippold@gmail.com>
 2019-03-18 18:10:13 -04:00
Chef Expeditor
7887d25251
Bump version to 3.7.8 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-03-18 14:43:45 +00:00
Keith Walters
c2bd0616fe Allow http resource to follow redirects 
By specifying a `max_redirects` attribute, the `http` resource worker
will follow any HTTP Redirect response (301, 302, etc...) up to the
limit defined by this attribute. For a local worker, exceeding that
limit will raise a `FaradayMiddleware::RedirectLimitReached` exception.
For a remote worker, the curl command will exit without populating the
`status` and `body` properties.

Signed-off-by: Keith Walters <keith.walters@cattywamp.us>
 2019-03-16 20:54:52 -04:00
Chef Expeditor
9c67fe89a5
Bump version to 3.7.7 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-03-13 23:14:38 +00:00
Chef Expeditor
8e3aabc2e4
Bump version to 3.7.6 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-03-11 17:56:40 +00:00
Clinton Wolfe
c580b695c7
Merge pull request #3842 from inspec/ja/fix-iis-app-pool-resource 
iis_app_pool: Fix PowerShell JSON parsing error
 2019-03-11 13:52:07 -04:00
Chef Expeditor
488a1ebe52
Bump version to 3.7.5 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-03-11 17:51:51 +00:00
Clinton Wolfe
e7ee82a12a
Merge pull request #3843 from inspec/ja/http-to-s 
http resource: Add fallback to `#to_s`
 2019-03-11 13:51:34 -04:00
Clinton Wolfe
709a5dbdd9 Implement renaming --attrs -> --input-file 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-03-08 11:38:03 -05:00
Chef Expeditor
95196838ef
Bump version to 3.7.4 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-03-08 15:12:54 +00:00
Chef Expeditor
fd59635cc3
Bump version to 3.7.3 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-03-08 14:52:03 +00:00
Clinton Wolfe
74e2f72ed5
Merge pull request #3818 from inspec/ja/rewrite-habitat-plugin 
Rewrite inspec-habitat plugin
 2019-03-08 09:51:46 -05:00
Chef Expeditor
929b46b554
Bump version to 3.7.2 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-03-07 19:14:17 +00:00
Clinton Wolfe
f7202c229b Add caching to Inspec::Config 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-03-06 14:59:06 -05:00
Stuart Paterson
54e7428e75
Set minimal inspec version in line with inspec-zure resource pack guidelines. 
Signed-off-by: Stuart Paterson <spaterson@chef.io>
 2019-03-04 15:47:39 +00:00
Stuart Paterson
a337ca1d23
Add InSpec init profile folder for Azure. 
Signed-off-by: Stuart Paterson <spaterson@chef.io>
 2019-03-04 15:33:37 +00:00
Stuart Paterson
dcb141da79
Add InSpec init profile for Azure. 
Signed-off-by: Stuart Paterson <spaterson@chef.io>
 2019-03-04 15:32:31 +00:00
Chef Expeditor
94f69c4cfc
Bump version to 3.7.1 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-03-02 00:12:07 +00:00
Chef Expeditor
988eee728f
Bump version to 3.7.0 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-03-01 03:35:59 +00:00
Jerry Aldrich
22c20b7989 Add comment explaining -Compress 
Signed-off-by: Jerry Aldrich <jerryaldrichiii@gmail.com>
 2019-02-28 12:04:59 -08:00
Jerry Aldrich
66a343555b iis_app_pool: Fix PowerShell JSON parsing error 
This works around a current bug in PowerShell where the output cannot be
parsed as JSON.

The `-Compress` flag does not affect the validity of the data but only
the appearance of the string.

Signed-off-by: Jerry Aldrich <jerryaldrichiii@gmail.com>
 2019-02-28 12:04:59 -08:00
Jerry Aldrich
7168c41c09 Prevent stack trace from being set to the user 
This also verifies Habitat setup during create as well

Signed-off-by: Jerry Aldrich <jerryaldrichiii@gmail.com>
 2019-02-28 11:55:59 -08:00
Jerry Aldrich
1ac435bceb Modify output to be a bit better for the user 
Signed-off-by: Jerry Aldrich <jerryaldrichiii@gmail.com>
 2019-02-28 10:42:42 -08:00
Jerry Aldrich
af5d6e9285 http resource: Add fallback to #to_s 
This prevents a stack trace from being shown to the user if the `http`
resource is used on an unsupported platform.

Signed-off-by: Jerry Aldrich <jerryaldrichiii@gmail.com>
 2019-02-28 09:08:49 -05:00
Clinton Wolfe
55ab0ead32 Fix linting on master 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-02-28 09:07:20 -05:00
Clinton Wolfe
a4018029fb Linting 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-02-27 15:14:27 -05:00
Clinton Wolfe
52f6351f84 Adjust regexes for credset name and add tests 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-02-27 15:14:27 -05:00
Clinton Wolfe
7328e82ae6 Implement credential set loading 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-02-27 15:14:27 -05:00
Chef Expeditor
354e7bb5e3
Bump version to 3.6.19 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-02-27 19:43:39 +00:00
Chef Expeditor
36b4025b39
Bump version to 3.6.18 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-02-27 19:21:40 +00:00
Clinton Wolfe
c23d828ba0
Merge pull request #3833 from chris-rock/chris-rock/postgres 
detect postgres 10 on centos properly
 2019-02-27 14:20:50 -05:00
Chef Expeditor
46a46dcf9a
Bump version to 3.6.17 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-02-27 19:17:21 +00:00
Clinton Wolfe
ef18081dfe Merge branch 'cw/attrs-rename-classes-methods' 
Accidentally merged cw/attrs-rename-default-attribute into cw/attrs-rename-classes-methods, intended to go to master.
 2019-02-26 15:38:20 -05:00
Chef Expeditor
d8b1e72e33
Bump version to 3.6.16 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-02-26 19:36:13 +00:00
Clinton Wolfe
3024c60c64
Merge pull request #3834 from skylerto/master 
inspec compliance: Fix mocked configuration
 2019-02-26 14:35:53 -05:00
Christoph Hartmann
afadc896f2 make rubocop happy 
Signed-off-by: Christoph Hartmann <chris@lollyrock.com>
 2019-02-26 16:57:48 +01:00
Chef Expeditor
8282c36737
Bump version to 3.6.15 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-02-25 23:02:30 +00:00
Clinton Wolfe
ac41a6ae20
Merge pull request #3811 from inspec/cw/attrs-rename-classes-methods 
Attribute->Input Rename:  Rename Classes and Methods
 2019-02-25 18:02:11 -05:00
Chef Expeditor
e8b3b30792
Bump version to 3.6.14 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-02-25 19:14:35 +00:00
Chef Expeditor
78bbb3f894
Bump version to 3.6.13 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-02-25 16:57:19 +00:00
skylerto
51cda478d2 Fix issues with inspec compliance upload 
Issues with underlying API changes caused a break in the current `inspec compliance upload`

This diff shows the change in API:

3cc2ee63e0...85c815011a (diff-9d107f8e84fe350fa821fed1838dbda8L162)

Implementing the same change in the `inspec-compliance` plugin fixes the
following issue:

```
Traceback (most recent call last):
        11: from /hab/pkgs/chef/inspec/3.6.12/20190221172437/lib/gems/inspec-3.6.12/bin/inspec:12:in `<main>'
        10: from /hab/pkgs/chef/inspec/3.6.12/20190221172437/lib/gems/thor-0.20.3/lib/thor/base.rb:466:in `start'
         9: from /hab/pkgs/chef/inspec/3.6.12/20190221172437/lib/gems/thor-0.20.3/lib/thor.rb:387:in `dispatch'
         8: from /hab/pkgs/chef/inspec/3.6.12/20190221172437/lib/gems/thor-0.20.3/lib/thor/invocation.rb:126:in `invoke_command'
         7: from /hab/pkgs/chef/inspec/3.6.12/20190221172437/lib/gems/thor-0.20.3/lib/thor/command.rb:27:in `run'
         6: from /hab/pkgs/chef/inspec/3.6.12/20190221172437/lib/gems/thor-0.20.3/lib/thor.rb:238:in `block in subcommand'
         5: from /hab/pkgs/chef/inspec/3.6.12/20190221172437/lib/gems/thor-0.20.3/lib/thor/invocation.rb:115:in `invoke'
         4: from /hab/pkgs/chef/inspec/3.6.12/20190221172437/lib/gems/thor-0.20.3/lib/thor.rb:387:in `dispatch'
         3: from /hab/pkgs/chef/inspec/3.6.12/20190221172437/lib/gems/thor-0.20.3/lib/thor/invocation.rb:126:in `invoke_command'
         2: from /hab/pkgs/chef/inspec/3.6.12/20190221172437/lib/gems/thor-0.20.3/lib/thor/command.rb:27:in `run'
         1: from /hab/pkgs/chef/inspec/3.6.12/20190221172437/lib/gems/inspec-3.6.12/lib/plugins/inspec-compliance/lib/inspec-compliance/cli.rb:144:in `upload'
/hab/pkgs/chef/inspec/3.6.12/20190221172437/lib/gems/inspec-3.6.12/lib/inspec/backend.rb:45:in `create': undefined method `unpack_train_credentials' for {:target=>"mock://"}:Hash (NoMethodError)
```

Signed-off-by: skylerto <skylerclayne@gmail.com>
 2019-02-25 10:24:27 -05:00
Christoph Hartmann
15c03cf8fc detect postgres 10 on centos properly 
Signed-off-by: Christoph Hartmann <chris@lollyrock.com>
 2019-02-25 13:39:17 +01:00
Jerry Aldrich
b533958ae6 Remove stacktrace being sent to exit_with_error 
It is already available at the debug log level.

Thanks @clintoncwolfe for the suggestion.

Signed-off-by: Jerry Aldrich <jerryaldrichiii@gmail.com>
 2019-02-22 10:56:28 -08:00
Clinton Wolfe
c9e8716310 Change two more mentions of DEFAULT_ATTRIBUTE 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-02-22 10:10:50 -05:00
Clinton Wolfe
24e8c0a6dd Replace DEFAULT_ATTRUBUTE, unit test for it passes 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-02-22 10:05:31 -05:00
Jerry Aldrich
535ecdc4ac Remove Rakefile (testing should be done in InSpec) 
Signed-off-by: Jerry Aldrich <jerryaldrichiii@gmail.com>
 2019-02-21 15:02:54 -08:00
Jerry Aldrich
3a67e1c958 Fix typos/grammer/etc in README.md 
Signed-off-by: Jerry Aldrich <jerryaldrichiii@gmail.com>
 2019-02-21 15:02:37 -08:00
Jerry Aldrich
5676bd114f Align = in initialize 
Signed-off-by: Jerry Aldrich <jerryaldrichiii@gmail.com>
 2019-02-21 13:16:20 -08:00
Jerry Aldrich
d2569e8da9 Make @log and attr_reader and rename to logger 
Signed-off-by: Jerry Aldrich <jerryaldrichiii@gmail.com>
 2019-02-21 13:16:16 -08:00
Jerry Aldrich
27eab8686f Change log message type to debug 
Signed-off-by: Jerry Aldrich <jerryaldrichiii@gmail.com>
 2019-02-21 13:06:08 -08:00
Chef Expeditor
8c37a61494
Bump version to 3.6.12 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-02-21 17:24:19 +00:00