Mirrors/inspec
2
0
Fork 0
mirror of https://github.com/inspec/inspec synced 2024-09-21 06:51:56 +00:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #4079 from inspec/mj/cli_warn

Browse source 
Fix @unique_controls uninitialized warning
This commit is contained in:
Ryan Davis 2019-05-18 15:00:47 -07:00 committed by GitHub
commit 8ea1889001
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
lib/inspec/reporters/cli.rb
View file

@ -166,14 +166,11 @@ module Inspec::Reporters
end
def all_unique_controls
return @unique_controls unless @unique_controls.nil?
@unique_controls = Set.new
run_data[:profiles].each do |profile|
profile[:controls].map { |control| @unique_controls.add(control) }
end
@unique_controls
@unique_controls ||= begin
run_data[:profiles].map { |profile|
profile[:controls]
}.uniq
end
end
def profile_summary

7
test/unit/reporters/cli_test.rb
View file

@ -288,13 +288,6 @@ describe Inspec::Reporters::CLI do
it 'return unique controls' do
report.send(:all_unique_controls).count.must_equal 4
end
it 'return unique controls cached' do
instance_variable_get(:@unique_controls).must_be_nil
report.send(:all_unique_controls).count.must_equal 4
assert = report.instance_variable_get(:@unique_controls)
assert.count.must_equal 4
end
end
describe '#profile_summary' do