Mirrors/inspec
2
0
Fork 0
mirror of https://github.com/inspec/inspec synced 2024-12-04 02:19:50 +00:00
Code Issues Projects Releases Packages Wiki Activity
6341 commits 452 branches 1901 tags 75 MiB
Commit graph

3217 commits

Author SHA1 Message Date
Miah Johnson
d1358df59f
Merge pull request #4115 from inspec/zenspider/clean_method_call_pattern 
Stop using method(...).call(...)
 2019-05-20 13:07:43 -07:00
Chef Expeditor
c1e022bd3c
Bump version to 4.4.41 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-05-20 20:07:21 +00:00
Miah Johnson
36029da0a3
Merge pull request #4116 from inspec/zenspider/clean_more_requires 
Clean more requires
 2019-05-20 13:07:04 -07:00
Chef Expeditor
4cd62d3d30
Bump version to 4.4.40 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-05-20 20:04:49 +00:00
Miah Johnson
1fe48f2e7b
Merge pull request #4113 from inspec/zenspider/use_math_for_perms 
Just use math.
 2019-05-20 13:04:24 -07:00
Chef Expeditor
499e99f2ba
Bump version to 4.4.39 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-05-20 20:03:36 +00:00
Ryan Davis
e1061f41f2 Clean more requires 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-05-20 13:01:18 -07:00
Chef Expeditor
461991a1a3
Bump version to 4.4.38 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-05-20 19:58:42 +00:00
Chef Expeditor
01dee92ca2
Bump version to 4.4.37 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-05-20 19:57:23 +00:00
Miah Johnson
69151ced56
Merge pull request #4119 from inspec/mj/missing_requires 
Fix missing requires in toml, postgres_conf resources
 2019-05-20 12:56:59 -07:00
Chef Expeditor
da57262892
Bump version to 4.4.36 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-05-20 19:56:40 +00:00
Miah Johnson
b6c86bfad8
Merge pull request #4118 from inspec/mj/rtjson 
json was required twice.
 2019-05-20 12:56:27 -07:00
Miah Johnson
94f14bae20 Fix missing requires in toml, postgres_conf resources 
toml was missing json
postgres_conf was missing object_traversal

Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-05-19 11:31:59 -07:00
Miah Johnson
e514fbff90 json was required twice. 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-05-19 11:02:02 -07:00
Ryan Davis
7e5c27410e This is one place where rubocop and I strongly disagree. 
Using self.something makes it more clear. Sometimes that is necessary.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-05-18 21:04:27 -07:00
Chef Expeditor
7fb177a691
Bump version to 4.4.35 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-05-19 01:08:41 +00:00
Ryan Davis
03a1fba565 Stop using method(...).call(...) 
Use send. It's **vastly** faster:

```
Comparison:
                send:  6364383.9 i/s
         method+call:  2530347.8 i/s - 2.52x  slower
```

Also removed a bunch of unnecessary to_sym's. Ruby doesn't care.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-05-18 16:53:33 -07:00
Ryan Davis
fe82931b39 Just use math. 
I don't know what the reasoning is behind the rjust & the format
call... String converting between octal to binary in order to get an
integer? Instead, this converts from an octal string and uses
straight-forward binary manipulation and logic.

Please avoid `cond ? false : true` like constructs. Use `!cond` instead.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-05-18 15:50:01 -07:00
Chef Expeditor
d665efc8c8
Bump version to 4.4.34 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-05-18 22:44:42 +00:00
Ryan Davis
62890e4809 This needed to be a flat_map because :profiles was an array. 
Entirely on me. Pushing this through to rectify my mistake in review.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-05-18 15:16:09 -07:00
Chef Expeditor
f1654c02d2
Bump version to 4.4.33 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-05-18 22:01:01 +00:00
Ryan Davis
8ea1889001
Merge pull request #4079 from inspec/mj/cli_warn 
Fix @unique_controls uninitialized warning
 2019-05-18 15:00:47 -07:00
Chef Expeditor
87db267ef1
Bump version to 4.4.32 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-05-18 21:29:49 +00:00
Ryan Davis
9b7c292d4c Use IO globals instead of IO constants. 
Helps testing and lots of other things if we only use $stdout/$stderr.

STDOUT/STDERR should only be used to restore the globals.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-05-18 12:48:18 -07:00
Miah Johnson
a3c55ea49f We didn't need a Set! 
Update this based on feedback from @zenspider

Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-05-18 00:00:59 -07:00
Chef Expeditor
a0f9487f9d
Bump version to 4.4.31 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-05-18 00:55:15 +00:00
Miah Johnson
3db8d93fe5 Use #key? rather than #has_key? in profile_name ternary 
lib/inspec/profile_context.rb:28:29: C: [Corrected] Style/PreferredHashMethods: Use Hash#key? instead of Hash#has_key?.
      @profile_name = @conf.has_key?('profile') ? @conf['profile'].profile_name : @profile_id
                            ^^^^^^^^

355 files inspected, 1 offense detected, 1 offense corrected

Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-05-17 16:39:14 -07:00
Chef Expeditor
40ef08183b
Bump version to 4.4.30 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-05-17 22:21:51 +00:00
Miah Johnson
ee899d694f
Merge pull request #4081 from inspec/mj/profile_context 
Fix @profile_name not initialized
 2019-05-17 15:21:38 -07:00
Chef Expeditor
b51608e629
Bump version to 4.4.29 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-05-17 22:20:59 +00:00
Miah Johnson
0e896221e5
Merge pull request #4083 from inspec/mj/circular-telemetry 
Fix circular require in telemetry
 2019-05-17 15:20:43 -07:00
Chef Expeditor
a4f039adff
Bump version to 4.4.28 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-05-17 21:38:26 +00:00
Ryan Davis
9b0d8edfb4 Fixed another bad test interaction. 
This time between:

+ PluginManagerCliDefinitionTests#(?:test_plugin_registered
+ PluginLoaderTests#test_load_mock_plugin_by_gem

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-05-17 02:26:07 -07:00
Ryan Davis
3ba7aecffb Skips the one test that hits rspec directly and causes mocha to blow out afterwards 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-05-17 02:26:07 -07:00
Ryan Davis
ec9121dafe Cleanup long lines for readability / debugging. 
Also asked a couple q's in TODO lines.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-05-17 02:26:07 -07:00
Ryan Davis
8ec76e666e Fixed assignment to RUBY_VERSION. 
Lost in a sea of deprecation warnings.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-05-17 02:26:07 -07:00
Ryan Davis
a53d118b3f Punting on 2 tests in inspec-plugin-manager-cli. 
These two tests make assumptions that are not valid when bundler is
not being used.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-05-17 02:26:07 -07:00
Ryan Davis
e16657883a Fixed referenced urls so we can find the cited code again. 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-05-17 02:26:06 -07:00
Ryan Davis
7935d5553d Fix how we're running inspec to include local lib dir. 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-05-17 02:26:06 -07:00
Ryan Davis
e7348f4d72 Add minitest/hell and parallelize_me! to the plugin tests. 
We already do this in test/helper.rb so we might as well do it here.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-05-17 02:26:06 -07:00
Ryan Davis
0c9644c1c2 Use RbConfig::CONFIG instead of Gem.ruby_version for plugin_gem_path 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-05-17 02:26:06 -07:00
Ryan Davis
6235c3f658 Fixed missing requires 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-05-17 02:26:06 -07:00
Ryan Davis
cdf95cd160 Fixed 3 failures in cmp matcher. 
+ float? comparison can raise a TypeError
+ octal? comparison was allowing non-octal values (which cast to 0)
+ symbol comparison was casting to a string, but then doing an == check instead of casecmp.

The latter seems optional, but consistent with the intent of cmp.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-05-17 02:26:06 -07:00
Ryan Davis
bc249a78cb Changed cmp matcher to use send. 
obj.method(name).call(*args) == obj.send(name, *args)

```
Calculating -------------------------------------
         method+call      2.561M (± 2.2%) i/s -     12.816M in   5.006835s
                send      6.299M (± 2.4%) i/s -     31.501M in   5.004045s

Comparison:
                send:  6299002.5 i/s
         method+call:  2560909.2 i/s - 2.46x  slower
```

There aren't any direct tests for this? But I forcefully failed 2
functionals and then verified they passed after my change.

Not sure how (or if) to write tests against rspec matchers in a
meaningful way, even tho all I really want to test is a plain ole
method in it. I'll poke to see if it is possible / practical.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-05-17 02:26:06 -07:00
Ryan Davis
427d59f13f Fixes loading of Telemetry::DataSeries (and neighbors) in isolation. 
Fixes telemetry tests when run individually.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-05-17 02:26:06 -07:00
Chef Expeditor
e251ebf22b
Bump version to 4.4.27 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-05-16 23:57:46 +00:00
Lynn Frank
4511ac6aaf Updates the init plugin desc to show proper usage 
Obvious fix.
 2019-05-16 16:43:05 -05:00
Chef Expeditor
506cb5a6a2
Bump version to 4.4.26 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-05-16 18:45:27 +00:00
Miah Johnson
6a60f6137f Don't require telemetry/global_methods to prevent circular require 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-05-16 00:45:58 -07:00
Miah Johnson
75f071ae48 require telemetry/global_methods 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-05-16 00:45:24 -07:00