Commit graph

4171 commits

Author SHA1 Message Date
Chef Expeditor
9bdf02ac28 Bump version to 4.21.2 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2020-06-26 09:25:05 +00:00
James Stocks
d94d56c4b9 Ignore intermittent test teardown error
Occasionally when the `isolated` tests run in CI, this error is seen:

```
inspec-reporter-html2::when run on a basic profile#test_0002_should produce valid HTML:
Errno::ENOENT: No such file or directory @ apply2files - /tmp/temp20200625-1802-2izu7e.html
    /usr/local/lib/ruby/2.6.0/fileutils.rb:1437:in `unlink'
    /usr/local/lib/ruby/2.6.0/fileutils.rb:1437:in `block in remove_file'
    /usr/local/lib/ruby/2.6.0/fileutils.rb:1442:in `platform_support'
    /usr/local/lib/ruby/2.6.0/fileutils.rb:1436:in `remove_file'
    /usr/local/lib/ruby/2.6.0/fileutils.rb:775:in `remove_file'
    /usr/local/lib/ruby/2.6.0/fileutils.rb:562:in `block in rm'
    /usr/local/lib/ruby/2.6.0/fileutils.rb:561:in `each'
    /usr/local/lib/ruby/2.6.0/fileutils.rb:561:in `rm'
    lib/plugins/inspec-reporter-html2/test/functional/inspec_reporter_html2_test.rb:9:in `teardown'
```

It should be OK to ignore the failure to delete the test file - the issue doesn't reproduce on laptops, and CI uses clean VMs each time.

Signed-off-by: James Stocks <jstocks@chef.io>
2020-06-26 09:23:21 +01:00
Chef Expeditor
88cdff8422 Bump version to 4.21.1 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2020-06-25 10:28:16 +00:00
James Stocks
af5fd7bd03
Merge pull request #5036 from inspec/cw/interface-improvements
Additions to the interface resource
2020-06-25 11:27:53 +01:00
Chef Expeditor
1ac816f027 Bump version to 4.21.0 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2020-06-25 10:26:19 +00:00
Clinton Wolfe
ad673fa570 Do not include CIDR range on ipv4_address and ipv6_address
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-06-18 15:37:19 -04:00
Clinton Wolfe
502509aa5a Rework IP range filtering for clarity, add 172.16/12
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-06-18 15:37:19 -04:00
Clinton Wolfe
d9007588a6 Add an heuristic-based IP lookup property
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-06-18 15:37:19 -04:00
Clinton Wolfe
52468e470e Barebones plural interfaces resource
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-06-18 15:37:19 -04:00
Clinton Wolfe
c386828e7a Add properties for ipv4 and ipv6 ipaddresses for compat
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-06-18 15:37:19 -04:00
Clinton Wolfe
a4000d6912 Adds support for interface on BSD and MacOS
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-06-18 15:37:19 -04:00
Mary Jinglewski
ac615db4fb Copyediting
Signed-off-by: Mary Jinglewski <mjinglewski@chef.io>
2020-06-18 14:23:54 -04:00
Clinton Wolfe
bd292c9dbb Fix JS execution on Internet Explorer by adding MOTW
Mark of the Web is a special comment in HTML that IE looks for
to set the JS security zone when running a local HTML file.
See
http://msdn.microsoft.com/en-us/library/ms537628(v=vs.85).aspx

Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-06-18 14:23:54 -04:00
Clinton Wolfe
e4aa9f1793 Skip HTML validation testing on windows
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-06-18 14:23:54 -04:00
Clinton Wolfe
aa824d1b49 Fix a bad interaction involving clearing the plugin registry in unit testing
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-06-18 14:23:54 -04:00
Clinton Wolfe
83c7f84290 Add ability to show/hide child profiles, start off hidden
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-06-18 14:22:31 -04:00
Clinton Wolfe
adc59ea4ad Correct html validation assertion syntax
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-06-18 14:22:31 -04:00
Clinton Wolfe
b8b7e4e848 Add ability to inline alternate JS and CSS
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-06-18 14:22:31 -04:00
Clinton Wolfe
e7a5c59b90 Use PRODUCT_NAME from Dist to allow community to rebrand
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-06-18 14:21:51 -04:00
Clinton Wolfe
a131067a09 Add functional test, including html validation
This uses html-proofer, which adds in nokogiri as a testing dep.
I expect we'll be using nokogiri soon anyway for the JUnit reporter.

Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-06-18 14:21:51 -04:00
Clinton Wolfe
81e2f36fde Basic unit tests for plugin definition
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-06-18 14:21:51 -04:00
Clinton Wolfe
bb2dfaa02d First pass at docs
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-06-18 14:21:13 -04:00
Clinton Wolfe
c4487f1892 Initial commit of inspec-reporter-html2
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-06-18 14:21:13 -04:00
Chef Expeditor
5aa0d92794 Bump version to 4.20.10 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2020-06-18 16:29:22 +00:00
Chef Expeditor
b5b0d0351a Bump version to 4.20.9 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2020-06-18 13:33:27 +00:00
Nick Schwaderer
7068694885 Revert "Make CLI reporter into a plugin"
Signed-off-by: Nick Schwaderer <nschwaderer@chef.io>
2020-06-18 12:30:15 +01:00
Chef Expeditor
c523a4f50c Bump version to 4.20.8 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2020-06-18 11:29:19 +00:00
Chef Expeditor
af7964984b Bump version to 4.20.7 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2020-06-17 17:17:29 +00:00
Nick Schwaderer
dca57b61c0
Merge pull request #4907 from inspec/cw/telemetry-run-context
Telemetry - determine run context from stack introspection
2020-06-17 18:17:09 +01:00
Chef Expeditor
c271f439fa Bump version to 4.20.6 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2020-06-17 16:02:27 +00:00
Nick Schwaderer
82c6472444
Merge pull request #5069 from inspec/cw/reporter-plugin-cli
Make CLI reporter into a plugin
2020-06-17 17:02:07 +01:00
Chef Expeditor
dfff9d36a8 Bump version to 4.20.5 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2020-06-17 08:51:51 +00:00
Chef Expeditor
7f10acc1ef Bump version to 4.20.4 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2020-06-15 11:25:44 +00:00
Clinton Wolfe
3651f85a7c Use methods to access RunData
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-06-11 16:46:04 -04:00
Clinton Wolfe
98ae89e6cc Convert JUnit reporter to plugin, RunData is still Hash-based
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-06-11 16:46:04 -04:00
Chef Expeditor
acda76723f Bump version to 4.20.3 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2020-06-11 11:30:34 +00:00
James Stocks
070823122d
Merge pull request #5062 from inspec/cw/reporter-plugin-jsonmin
Make the JSON-min Reporter into Plugin
2020-06-11 12:30:18 +01:00
Chef Expeditor
705d0ffbb6 Bump version to 4.20.2 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2020-06-09 14:02:32 +00:00
Chef Expeditor
62c5cba7ec Bump version to 4.20.1 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2020-06-05 23:14:18 +00:00
Chef Expeditor
52392600d1 Bump version to 4.20.0 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2020-06-05 13:11:07 +00:00
James Stocks
d5f825e716
Merge pull request #5026 from inspec/cw/silence-deprecations
CLI Option to silence deprecations
2020-06-05 14:10:50 +01:00
Chef Expeditor
c44eb725fe Bump version to 4.19.4 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2020-06-05 11:28:43 +00:00
Chef Expeditor
b114792fe5 Bump version to 4.19.3 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2020-06-05 11:24:06 +00:00
Nick Schwaderer
fb1aeb0655
Merge pull request #5011 from inspec/cw/complex-cli-inputs
Boolean, Numeric, and Structured CLI inputs
2020-06-05 04:23:48 -07:00
Clinton Wolfe
afdcc9d2a1 Add cli to list of valid types explicitly to fix unit tests
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-06-04 15:03:16 -04:00
Chef Expeditor
144abfb5de Bump version to 4.19.2 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2020-06-04 10:00:27 +00:00
Clinton Wolfe
458a5c4410 Replace Hash RunData access with method calls
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-06-03 21:51:21 -04:00
Clinton Wolfe
76033c03ff Convert CLI reporter to plugin, RunData is still Hash-based
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-06-03 21:13:27 -04:00
Clinton Wolfe
935bb81e6f Use RunData object instead of Hash
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-06-02 15:29:52 -04:00
Clinton Wolfe
402366c219 Convert json-min to be a plugin reporter, rundata is still a Hash
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-06-02 15:29:52 -04:00
Clinton Wolfe
49f3e94133 Modify Hashlike behavior when values are nil
Exclude nil-valued keys when RunData acts like a Hash
Add non_nil? for clarity when people are calling key? and meaning not-nil

Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-06-02 15:29:01 -04:00
Chef Expeditor
10e28c6895 Bump version to 4.19.1 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2020-06-02 16:56:17 +00:00
Chef Expeditor
d6453b82a5 Bump version to 4.19.0 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2020-05-27 12:06:41 +00:00
Clinton Wolfe
d5be4c2927 Test kitchen setup to test detection of audit-cookbook
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-05-25 21:00:24 -04:00
Clinton Wolfe
439c93b115 Add a functional test to check Thor run context detection
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-05-25 21:00:24 -04:00
Clinton Wolfe
45e3421595 Remove too-brittle frame ranges on stack locations
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-05-25 21:00:24 -04:00
Clinton Wolfe
4122157542 rename to match class name
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-05-25 21:00:24 -04:00
Clinton Wolfe
cd9ca19901 stack probe for audit cookbook
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-05-25 21:00:24 -04:00
Clinton Wolfe
5be4ee913f stack probe for test-kitchen
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-05-25 21:00:24 -04:00
Clinton Wolfe
e96ddbf2cb Add stack probe for detecting when run as CLI by Thor
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-05-25 21:00:24 -04:00
Clinton Wolfe
dcc70bc541 Trim log message, make boolean check case insensitive
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-05-23 00:25:08 -04:00
Chef Expeditor
e90c6e35c4 Bump version to 4.18.118 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2020-05-22 15:54:55 +00:00
James Stocks
32fa14f1b0
Merge pull request #5039 from james-stocks/js/issue_5037
Allow for waiver time as well as date
2020-05-22 16:52:23 +01:00
Chef Expeditor
94c30647ed Bump version to 4.18.117 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2020-05-22 15:10:46 +00:00
James Stocks
23ed9bcf06
Merge pull request #5007 from inspec/cw/reporters-as-plugins
Reporters as Plugins
2020-05-22 16:10:29 +01:00
Chef Expeditor
0794051417 Bump version to 4.18.116 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2020-05-22 10:29:55 +00:00
James Stocks
7085adf5e5
Merge pull request #5017 from inspec/ns/inspec_json_in_archive
Stores output of `inspec json` to archive and artifact
2020-05-22 11:29:35 +01:00
Clinton Wolfe
3184d5ca9e Add an object model for run_data
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-05-20 13:27:20 -04:00
James Stocks
350c0bfe8f Handle waiver expiration dates being YAML strings
This is technically incorrect YAML, but if you transcode YAML between several tools you may end up with a date/time value being an explicit string.
It would be helpful if InSpec supported any string value that easily translates to a Time.

Signed-off-by: James Stocks <jstocks@chef.io>
2020-05-20 15:00:43 +01:00
James Stocks
35e36ad40a Allow for waiver time as well as date
Fixes #5037

The YAML parser may parse a waiver timestamp as a Time rather than a Date. Even when the user doesn't care about time, they may be using a tool that outputs YAML with trailing zeroes for hour, minutes, seconds etc.

Signed-off-by: James Stocks <jstocks@chef.io>
2020-05-20 14:59:07 +01:00
Nick Schwaderer
989d86c2ce Stores output of inspec json to archive and artifact
Signed-off-by: Nick Schwaderer <nschwaderer@chef.io>
2020-05-20 12:34:17 +01:00
Chef Expeditor
e924364565 Bump version to 4.18.115 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2020-05-20 11:33:26 +00:00
Nick Schwaderer
e882bc727e Update for incoming ruby openSSL deprecations
Fixes #5031

See above issue for full context, this updates to the latest rubocop requirements for incoming ruby OpenSSL deprecations

Signed-off-by: Nick Schwaderer <nschwaderer@chef.io>
2020-05-19 15:37:24 +01:00
Clinton Wolfe
c5e347bae5 Implement silencing deprecations
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-05-14 12:17:55 -04:00
Clinton Wolfe
8ec249e0cc Copy in reporter message size limiter code from core reporter base
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-05-12 17:04:19 -04:00
Clinton Wolfe
36069943c4 Add ability to generate reporter plugins using inspec init
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-05-12 17:00:44 -04:00
Chef Expeditor
6b45777e81 Bump version to 4.18.114 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2020-05-11 23:09:52 +00:00
Clinton Wolfe
ee095a244a Soften the exception to a warning when the input is not parseable
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-05-07 10:47:57 -04:00
Chef Expeditor
caa6a300bc Bump version to 4.18.113 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2020-05-07 11:54:51 +00:00
James Stocks
2103b52dbe
Merge pull request #4994 from james-stocks/js/json
Reporter options to truncate message and suppress stacktrace
2020-05-07 12:54:34 +01:00
James Stocks
1d67349214 Do not inject config to base reporter
The base reporter class should access the InSpec config cache, instead of the runner needing to inject config into the base reporter

Signed-off-by: James Stocks <jstocks@chef.io>
2020-05-06 15:24:15 +01:00
Chef Expeditor
12b41fc183 Bump version to 4.18.112 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2020-05-06 10:50:57 +00:00
Clinton Wolfe
849bd90930 Parse CLI inputs as booleans
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-05-05 18:17:40 -04:00
Clinton Wolfe
acfda5a735 Clarify names of examples and a method
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-05-05 17:59:20 -04:00
Clinton Wolfe
e8d80dd3cd Update docs
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>

Linting

Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-05-05 17:37:23 -04:00
Clinton Wolfe
5e69e3bab6 Allow complex inputs on CLI
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-05-05 17:37:23 -04:00
Clinton Wolfe
d9f2cdb171 Fix for #4977 by adding a cleanup function for CLI inputs
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-05-05 17:37:23 -04:00
Clinton Wolfe
47baa59ed8 Add comment tracking when reporters will migrate
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-05-05 16:51:31 +01:00
Clinton Wolfe
5a7a48bb62 Basics of a working reporter plugin system
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-05-05 16:51:31 +01:00
Chef Expeditor
d9e5b65e3d Bump version to 4.18.111 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2020-05-05 10:28:20 +00:00
Nick Schwaderer
87d7978340
Merge pull request #5001 from inspec/ns/investigate_waivers_and_namespace_clashing
Allows input and control to have the same name
2020-05-05 11:28:03 +01:00
Nick Schwaderer
a1129f9efc Allows input and control to have the same name
In https://github.com/inspec/inspec/issues/4936 the issue was reported that naming an input the same as a control caused an unexpected failure.

In that particular case, the naming was a result of a pre-waivers workaround which is no longer necessary, but ultimately a breakage of that name clash is an unexpected occurrance.

Due to how inputs are named and registered, `__apply_waivers` thinks that an object is a waiver that is not a waiver and tries to process it. On the micro level, it breaks when trying to pass a variable to a string as if it were a Hash.

It is imperative that we preserve 100% of the current featureset, pass our tests, and fix this edge case along with new test coverage for the failure.

This PR updates the code to do a slightly more elegant and small ‘waiver check’ to stop the namespace clash from breaking our code.

Signed-off-by: Nick Schwaderer <nschwaderer@chef.io>
2020-05-05 10:00:19 +01:00
Chef Expeditor
3616ac21dc Bump version to 4.18.110 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2020-05-04 16:01:32 +00:00
James Stocks
69fb6e0782 Move reporter option handling to base
They don't need to be json specific, they should apply to any reporter if the user has chosen these settings.

Signed-off-by: James Stocks <jstocks@chef.io>
2020-05-04 15:24:50 +01:00
James Stocks
ae66aee2b2 (WIP) Reporter options to truncate message and suppress stacktrace
TODO: Option names are not JSON specific but only json reporter has been implemented.

Signed-off-by: James Stocks <jstocks@chef.io>
2020-05-04 15:24:50 +01:00
Chef Expeditor
2e887a94af Bump version to 4.18.109 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2020-05-01 14:22:05 +00:00
Clinton Wolfe
5a7ad0c352 Don't be obnoxious
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-04-30 15:36:25 -04:00
Clinton Wolfe
131d6678de Fix for prematurely warning when checking for input value
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-04-24 16:38:57 -04:00
Clinton Wolfe
e88dab4365 Update message when input has no value
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-04-24 14:13:07 -04:00
Chef Expeditor
b46b68ccd1 Bump version to 4.18.108 by Chef Expeditor
Obvious fix; these changes are the result of automation not creative thinking.
2020-04-23 15:18:13 +00:00