Mirrors/inspec
2
0
Fork 0
mirror of https://github.com/inspec/inspec synced 2024-12-23 19:43:14 +00:00
Code Issues Projects Releases Packages Wiki Activity
9281 commits 460 branches 1907 tags 77 MiB
Commit graph

4560 commits

Author SHA1 Message Date
Chef Expeditor
9f2b621f9b Bump version to 4.18.83 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-02-04 00:42:29 +00:00
Ryan Davis
cac6b88c03 Fixed error on ruby 2.4 because define_method was private. 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2020-02-03 14:41:37 -08:00
Ryan Davis
89a0b44c64 Refactored and moved Resource.create_dsl to ProfileContext. 
ProfileContext#to_resources_dsl is the only usage of it.
The responsibility for this code should be on ProfileContext.

Refactored a majority of #create_dsl to be a 2-line long Module.new
instead of 36 lines. Much less magic. Still has an anonymous module
but it is now much easier to address and debug.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2020-02-03 14:41:37 -08:00
Ryan Davis
fa3122cbff Removed metaprogramming in Inspec::Backend. 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2020-02-03 14:41:37 -08:00
Ryan Davis
cea752a01d Tweak for aws resources to determine if they're still under test. 
Everyone now has an `inspec` method, but the AWS ones still return
nil as their backend hasn't been set up.

This seems wrong...

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2020-02-03 14:41:37 -08:00
Ryan Davis
950c79319e Moved __register down to bookkeeping section. 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2020-02-03 14:41:37 -08:00
Ryan Davis
b38a3b05f9 Reworked Resource.__register's metaprogramming to be as small as possible. 
Mostly involved pushing up all the regular initialize code to a
regular method, calling that, THEN doing super up to the resource
initialize.

This brings __register's Class.new to 5 lines.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2020-02-03 14:41:37 -08:00
Ryan Davis
43f520b4a8 Merged Inspec::Plugins::Resource to Inspec::Resource. 
This also removes Inspec::ResourceBehaviors and Inspec::ResourceDSL.

All class methods look like class methods.
All instance methods look like instance methods.

There is still too much clever going on with __register creating
another anonymous subclass, but I think I can work that out/down too.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2020-02-03 14:41:37 -08:00
Ryan Davis
44a006a05a Rename Inspec::Resource.supports to support_registry. 
To fix an already existing name collision between Inspec::Resource and
Inspec::Plugins::Resource.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2020-02-03 13:19:32 -08:00
Ryan Davis
f0a5ddd4df Simple refactoring + assign __resource_registry to the current if needed. 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2020-02-03 13:19:32 -08:00
Ryan Davis
81dfe21a98 First pass reworking LibraryEvalContext. 
This takes 3 anonymous Class.new w/ no superclasses, no documentation,
and no obvious clue as to what anything is and drops it down to 2
Class.new w/ superclasses, documents what it can, and makes it much
more clear what is going on. (yet, still not clear)

It also actually uses LibraryEvalContext. Having names is important.
Probably more important than any of the rest of this diff.

One extra thing this adds is Module.find_class_instance_variable and
hooks it up to Resource.__resource_registry. This allows it to find a
class-level registry regardless of whether it was hidden in an
anonymous superclass or not.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2020-02-03 13:19:32 -08:00
Ryan Davis
07631a53e7 Added extra doco on our require method. 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2020-02-03 13:19:32 -08:00
Ryan Davis
d7bae9de30 Mostly minor cleanup, clarification, and comments. 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2020-02-03 13:19:32 -08:00
Ryan Davis
fdc281d19c Clean up the end of our custom require. 
There are only 2 options. Shortcutting one of them with a `require` just
makes it messy. Use `if`. It's really basic. Basic is good. Maybe we
should try to push towards basic and good. It would be work but make
us happier in the long run.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2020-02-03 13:18:56 -08:00
Ryan Davis
51b65f6c2e Overhaul Platform#supported? 
+ State normal path first.
+ Use Enumerable to state your logic up front, don't build it into
  loops with breaks/returns.
+ Remove nonsensical duplication of key formats. (should push up or remove)
+ Had to add an extra test case that wasn't covered here but was in
  metadata_test.rb (why?!?)

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2020-02-03 13:18:56 -08:00
Ryan Davis
10cb92da48 Clean up Platform#params. 
State your normal case first, then deal with edge cases, not the other
way around.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2020-02-03 13:18:56 -08:00
Ryan Davis
aef285a1f6 Don't meta-program if you don't need to. 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2020-02-03 13:18:56 -08:00
Ryan Davis
06ceba3f3d Add test for LEC to expose second-level libraries require. 
Not the best test in the world, but it is better than nothing.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2020-02-03 13:18:56 -08:00
Chef Expeditor
3cfd35f98f Bump version to 4.18.82 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-02-01 02:04:23 +00:00
Ryan Davis
2c7101df26 Fix minor style issues. 
I swear... rubocop hates me.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2020-01-31 18:01:01 -08:00
Chef Expeditor
4ab4b04bed Bump version to 4.18.81 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-02-01 01:51:56 +00:00
Chef Expeditor
d09656cdff Bump version to 4.18.80 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-02-01 01:38:34 +00:00
Ryan Davis
c79245cde3
Merge pull request #4869 from inspec/zenspider/crontab 
Refactored crontab resource
 2020-01-31 17:38:12 -08:00
Chef Expeditor
c3a37ee126 Bump version to 4.18.79 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-02-01 00:42:32 +00:00
Ryan Davis
c70f73dc96
Merge pull request #4864 from inspec/zenspider/resource/inspect 
Added --inspect option to inspect shell command.
 2020-01-31 16:42:00 -08:00
Chef Expeditor
01b9bacaa1 Bump version to 4.18.78 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-02-01 00:41:46 +00:00
Ryan Davis
cc1393bb9a
Merge pull request #4822 from PiQuer/master 
make command.exist? POSIX conform
 2020-01-31 16:41:27 -08:00
Chef Expeditor
09e0bc63da Bump version to 4.18.77 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-01-31 22:29:39 +00:00
Chef Expeditor
d83ead45f9 Bump version to 4.18.76 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-01-31 01:21:42 +00:00
Chef Expeditor
7e258f8944 Bump version to 4.18.75 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-01-30 16:04:33 +00:00
Chef Expeditor
f69d76e4a0 Bump version to 4.18.74 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-01-30 00:36:49 +00:00
Ryan Davis
a79eb417a0 the correct, un-panicked fix. 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2020-01-29 16:35:11 -08:00
Chef Expeditor
fb81c806b5 Bump version to 4.18.73 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-01-30 00:25:39 +00:00
Ryan Davis
622ae78d9a bad master merge... rushing this through 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2020-01-29 16:24:35 -08:00
Chef Expeditor
5c6be7b936 Bump version to 4.18.72 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-01-30 00:19:44 +00:00
Ryan Davis
f2155a64ed
Merge pull request #4843 from michaellihs/master 
Add support for yocto linux in service resource
 2020-01-29 16:19:27 -08:00
Ryan Davis
19ce5df589
Merge pull request #4827 from inspec/mj/namespaces 
Move parsers under Utils
 2020-01-29 16:18:43 -08:00
Chef Expeditor
bb70c50961 Bump version to 4.18.71 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-01-30 00:08:10 +00:00
Ryan Davis
10406545ca
Merge pull request #4862 from inspec/zenspider/resources 
Fix up the platform on etc_hosts, virtualization, ini, and xml resources to fix OS disparity.
 2020-01-29 16:07:47 -08:00
Chef Expeditor
eaf2d7ca5b Bump version to 4.18.70 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-01-30 00:06:50 +00:00
Chef Expeditor
485aa93d90 Bump version to 4.18.69 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-01-29 23:50:00 +00:00
Ryan Davis
124b56b6ee
Merge pull request #4825 from inspec/zenspider/tarball 
Properly report errors with bad tarball files.
 2020-01-29 15:49:40 -08:00
Ryan Davis
2ae2bcf6fb
Merge pull request #4818 from JackChance/master 
replaced instances of `have_protocols` with `have_protocol` in docume…
 2020-01-29 15:46:25 -08:00
Ryan Davis
ceab1cbdac Refactored crontab resource 
Specifically the parsing was pretty unreadable. This refactoring
emphasizes using a default hash and merging in the differences for
what was parsed. Everything is funneled through one `merge_crontab`
method that does the actual parsing and the system vs user differences
are merged in after in their respective parse methods.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2020-01-29 13:56:11 -08:00
Clinton Wolfe
37455bdd11 Parallelize unit tests 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-01-29 16:15:58 -05:00
Clinton Wolfe
3419c84233 Make predicates private to reduce namespace pollution; added dockerenv check for docker mode 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-01-29 11:28:52 -05:00
Chef Expeditor
193905a827 Bump version to 4.18.68 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-01-29 16:03:44 +00:00
Ryan Davis
15f77941af Some cleanup on the apache_conf resource. 
The biggie to know is that all the extra read_content calls were
needlessly redundant with it also being called in initialize.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2020-01-28 14:53:37 -08:00
Ryan Davis
9c051da22b Fix platform on apache_conf to include all unix. 
Now discovers the first available conf file from a list of known
paths. Might have to expand based on various distros.

Had to tweak the tests because the mock loader mocks EVERYTHING every
time. :/

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2020-01-28 14:53:37 -08:00
Ryan Davis
8bd2528ef8 Added --inspect option to inspect shell command. 
* Removed Resource#inspect (calling to_s) to make debugging a happy experience.
* Added ResourceBehavior.toggle_inspect to add/remove a basic inspect.
* Added `--inspect` flag to `shell` command. Call toggle_inspect unless --inspect used.
* Cleaned up matchers.rb and removed most explicit calls to inspect.
* Added ResourceInspector to rspec's INSPECTOR_CLASSES.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2020-01-28 14:52:04 -08:00
Clinton Wolfe
357cf051b1 PR feedback part 1 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-01-28 11:06:12 -05:00
Chef Expeditor
41f3927e84 Bump version to 4.18.67 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-01-28 15:03:18 +00:00
Clinton Wolfe
46ade02401
Use an archive if possible when fetching fails and --airgap is… (#4806) 
Use an archive if possible when fetching fails and --airgap is provided
 2020-01-28 10:02:57 -05:00
Ryan Davis
df31f744f4 Fix up platform on filesystem resource. 
From linux to unix. This should work fine even on AIX, according to
the man pages.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2020-01-27 15:34:33 -08:00
Ryan Davis
65c44d22e2 Audited virtualization a bit. 
Cleaned up some code.
Reordered virtualization detection by order of probability.
Added TODOs for obvious problems.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2020-01-27 15:31:41 -08:00
Ryan Davis
f830ddeca6 Slimmed up and removed "clever" from file resource description. 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2020-01-27 15:30:48 -08:00
Ryan Davis
b9d49e0fed Fix up the platform on etc_hosts, virtualization, ini, and xml resources to fix OS disparity. 
+ File format oriented resources should always be `os`.
+ virtualization should (in theory) be any unix (tho, it currently seems wrong).
+ etc_hosts should be any (reasonable) unix.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2020-01-27 15:29:52 -08:00
Clinton Wolfe
76a9c3e590 Install-path based install context detection 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-01-27 13:29:37 -05:00
Clinton Wolfe
eac3b31095 PR feedback re: cache warming 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-01-27 11:01:15 -05:00
Chef Expeditor
2089bf80c7 Bump version to 4.18.66 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-01-27 15:51:46 +00:00
Clinton Wolfe
31d2383285
Missing end quote in oracledb_session (#4852) 
Missing end quote in oracledb_session
 2020-01-27 10:51:25 -05:00
Chef Expeditor
cafb4f3e3e Bump version to 4.18.65 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-01-27 15:31:19 +00:00
Miah Johnson
89549bd884 Missing end quote. 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2020-01-24 12:00:00 -08:00
Chef Expeditor
6434009051 Bump version to 4.18.64 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-01-24 17:40:12 +00:00
Ryan Davis
faf7833559 Clarified service logic logic for redhat flavors. 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2020-01-23 16:36:44 -08:00
Ryan Davis
ad6ffcccd6 Switch Service#select_service_mgmt from huge if statement to case. 
Having a ton of conditions with `%w{one-string}.include?(platform)` is
incredibly wasteful and slow. Apparently about 17x slower:

```
Calculating -------------------------------------
          include_eh    529.315k (± 3.2%) i/s -      2.675M in   5.058296s
       include_or_eq    909.795k (± 1.5%) i/s -      4.568M in   5.022491s
           case_when      9.043M (± 2.8%) i/s -     45.443M in   5.029499s

Comparison:
           case_when:  9042590.3 i/s
       include_or_eq:   909795.2 i/s - 9.94x  slower
          include_eh:   529315.0 i/s - 17.08x  slower
```

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2020-01-23 16:36:36 -08:00
Ryan Davis
8f4bac23eb Refactor some of resources/service.rb 
Starting with: normalizing a huge if in select_service_mgmt to only
use strings.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2020-01-23 16:33:15 -08:00
Chef Expeditor
d013ac1e47 Bump version to 4.18.63 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-01-23 18:09:12 +00:00
Noel Georgi
7ac25401bb
Add: content option for x509_certificate 
Signed-off-by: Noel Georgi <git@frezbo.com>
 2020-01-22 13:49:35 +05:30
Chef Expeditor
7da7c2774b Bump version to 4.18.62 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-01-21 21:18:34 +00:00
Raimar Sandner
fa2f2c2caa make command.exist? POSIX conform 
With the current implementation, on a Linux system without bash
command.exist? always returns false. 'sh -c' is guaranteed to exist on a
POSIX-conform system [1] whereas 'bash -c' only works if bash is
actually installed.

[1] https://pubs.opengroup.org/onlinepubs/9699919799/utilities/sh.html

Obvious fix.
 2020-01-19 00:05:33 +01:00
Michael Lihs
edd93eea81 Add support for yocto linux in service resource 
Signed-off-by: Michael Lihs <michael.lihs@thoughtworks.com>
 2020-01-18 01:26:16 +01:00
Chef Expeditor
356de23c5c Bump version to 4.18.61 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-01-15 21:02:41 +00:00
Ryan Davis
9bd07954a6
Merge pull request #4833 from inspec/zenspider/mac/groups 
Fixed duplicate groups on osx by merging members by gid.
 2020-01-15 13:02:24 -08:00
Chef Expeditor
8cede82c20 Bump version to 4.18.60 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-01-15 20:37:45 +00:00
Clinton Wolfe
4c270efe78
upstream is basic_auth_only not basic_auth (#4834) 
upstream is basic_auth_only not basic_auth
 2020-01-15 15:37:26 -05:00
Chef Expeditor
d4481b82fb Bump version to 4.18.59 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-01-14 21:07:12 +00:00
Shawn Foley
83bc974923 winrm_basic_auth_only 
Signed-off-by: Shawn Foley <shawn.foley@marketleader.com>
 2020-01-14 08:46:06 -08:00
Ryan Davis
ea611634d1 Fixed duplicate groups on osx by merging members by gid. 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2020-01-13 13:25:05 -08:00
Clinton Wolfe
71e34abae4 Clarify usage message for --airgap option 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-01-07 21:02:16 -08:00
Miah Johnson
0d57612103 Update references to use new namespace 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2020-01-07 15:12:42 -08:00
Miah Johnson
0f4538ca4d Move all these modules to live until Inspec::Utils 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2020-01-07 15:12:42 -08:00
Clinton Wolfe
a11c41283c Clarify comment on fallback_to_archive_fetch_failure 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-01-06 19:48:03 -05:00
Clinton Wolfe
479256fad3 Compress some code 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-01-06 19:32:13 -05:00
Clinton Wolfe
3a97e5d75b Accept a refactornig suggestion 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-01-06 19:21:12 -05:00
Clinton Wolfe
835bd2be8c A clumsy but effective way of usually dodging windows filesystem length restrictions. 
Still definitely possible to run afoul of that issue, but that is not specific to
this feature, and frankly one might consider increasing thier FS path length
as a solution, as well.

Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-01-06 18:54:23 -05:00
Ryan Davis
0e77af3a77 Fixed resolver_test.rb by making Inspec::Config.cached a lazy accessor. 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2020-01-03 17:13:18 -08:00
Ryan Davis
885e4f6c71 Fix test failure for call to vendor! w/o options. 
Had to make options available for the mocking as well.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2020-01-03 17:12:51 -08:00
Clinton Wolfe
9bf8f2f4cd Adjust usage message for --airgap option 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-01-03 14:15:05 -05:00
Clinton Wolfe
9ada8362b8 Push up update_from_opts implementation 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-01-03 14:15:05 -05:00
Clinton Wolfe
5369b7ac79 make a one-liner per miah 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-01-03 14:15:05 -05:00
Clinton Wolfe
b92537aff5 bangify vendor_dependencies 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-01-03 14:15:05 -05:00
Clinton Wolfe
6a0f7eeea9 A terrible implementation of fetcher fallback for compliance fetcher 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-01-03 14:15:05 -05:00
Clinton Wolfe
f4a3cf9144 Implementation for local fetcher 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-01-03 14:15:05 -05:00
Clinton Wolfe
4e0ad4a56b Implementation of archive fallback for the URL fetcher 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-01-03 14:15:05 -05:00
Clinton Wolfe
1eb33049e4 Alter resolver to fallback to an archive if in airgap mode 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-01-03 14:15:05 -05:00
Clinton Wolfe
1806900794 Add an optional API method to update the internal state of a fetcher 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-01-03 14:15:04 -05:00
Clinton Wolfe
e1941b2d11 When archiving with --airgap, warm the vendor cache from any available local archives 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-01-03 14:15:04 -05:00
Clinton Wolfe
f9d419f219 Remove constructors from raise statements 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-01-03 14:15:04 -05:00
Clinton Wolfe
48a97ea60f Add .invalid TLD to test hostanmes 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2020-01-03 14:15:04 -05:00
Chef Expeditor
395d6d5421 Bump version to 4.18.58 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-01-03 16:47:38 +00:00
Clinton Wolfe
328302dd48
Fix empty attributes array in json reporter (#4815) 
shallow copy of params missed inputs
 2020-01-03 11:47:16 -05:00
Ryan Davis
b51da7d037 Properly report errors with bad tarball files. 
+ Raise a well-worded error with details and avoid an uncaught exception.
+ Fix error caused when the tar file is already invalid and we try to close it.

Fixes #3765.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2020-01-02 16:13:55 -08:00
Chef Expeditor
230ce1532e Bump version to 4.18.57 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-01-03 00:07:52 +00:00
Ryan Davis
f09595c33d
Merge pull request #4821 from inspec/zenspider/mocha2 
Found and fixed more mocha/setup deprecations.
 2020-01-02 16:07:35 -08:00
Chef Expeditor
8b5789004a Bump version to 4.18.56 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2020-01-01 00:59:32 +00:00
Ryan Davis
c57a0e1f13 Found and fixed more mocha/setup deprecations. 
This level of duplication is not good.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-12-31 15:46:47 -08:00
Ryan Davis
a0ffa67b71 Switched from profile_id to __profile_id per feedback. 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-12-31 15:27:12 -08:00
Ryan Davis
6426feeeb4 Removed the last of the metaprogramming from ControlEvalContext. 
* Merged CEC.create args into CEC#initialize
* Converted the only call site of CEC.create to just call new.
* Added profile_context and resources_dsl accessors to CEC.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-12-31 15:27:12 -08:00
Ryan Davis
f6407fb01b Future code cleanup TODO 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-12-31 15:27:12 -08:00
Ryan Davis
15941279ae Removed 90+% of all metaprogramming from ControlEvalContext 
+ Removed ControlEvalContext.rule_context entirely pushing into Rule
+ Gutted ControlEvalContext.create pushing into ControlEvalContext.
+ Added class ivar accessors for ControlEvalContext to bypass need for closures.
+ Converted all define_methods into defs.
+ Added resource_dsl to Rule#initialize

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-12-31 15:27:12 -08:00
Chef Expeditor
f4815204d9 Bump version to 4.18.55 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-12-31 22:20:03 +00:00
Nazli Beitollahpour
1486d8d890 issue 4807: shallow copy of params missed inputs 
Signed-off-by: Nazli Beitollahpour <nazli.beitollahpour@umontreal.ca>
 2019-12-31 13:02:27 -05:00
Cameron Straka
8b037fa9c2 replaced instances of have_protocols with have_protocol in documentation and examples 
Signed-off-by: Cameron Straka <strakacameron@hotmail.com>
 2019-12-31 10:51:55 -05:00
Ryan Davis
7d95ece60d Remove circular require between fetcher and compliance plugin w/ autoloads. 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-12-24 04:10:48 -08:00
Chef Expeditor
5b957ef776 Bump version to 4.18.54 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-12-17 22:05:59 +00:00
Ryan Davis
83f7504d7c
Merge pull request #4789 from Perceptyx/add-freebsd-package 
Add suport for freebsd package resource
 2019-12-17 14:05:40 -08:00
Chef Expeditor
ee20fc5789 Bump version to 4.18.53 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-12-17 22:04:39 +00:00
Ryan Davis
409cd17551
Merge pull request #4794 from Perceptyx/add-freebsd-postfix_conf 
postfix_conf: Changed supported platform to unix
 2019-12-17 14:04:22 -08:00
Chef Expeditor
80d63db71e Bump version to 4.18.52 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-12-17 22:02:36 +00:00
Felipe Zipitria
824c3f4e89
Changed supported platform to unix 
Signed-off-by: Felipe Zipitria <fzipitria@perceptyx.com>
 2019-12-17 12:16:35 -03:00
Felipe Zipitria
bff3fa960d
Add suport for freebsd package resource 
Signed-off-by: Felipe Zipitria <fzipitria@perceptyx.com>
 2019-12-17 08:39:43 -03:00
Trevor Vaughan
21edc712bd
Fix auditd resource processing of action and list 
Per auditctl(8), the -a option can have either list,action or
action,list. This PR matches against valid actions for the action field
and passed the remainder off to the list field.

Closes #4664

Signed-off-by: Trevor Vaughan <tvaughan@onyxpoint.com>
 2019-12-12 17:38:47 -05:00
Chef Expeditor
2ed57d5d82 Bump version to 4.18.51 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-12-11 22:07:06 +00:00
Miah Johnson
cf0159b7e2
Merge pull request #4754 from inspec/jb/hab_template 
remove inspec from pkg_deps/pkg_build_deps in template
 2019-12-11 14:06:48 -08:00
Chef Expeditor
263e798cb7 Bump version to 4.18.50 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-12-10 19:56:56 +00:00
Ryan Davis
4811606b00
Merge pull request #4766 from inspec/zenspider/fix-warnings/method-redefined 
Fix warnings coming from ruby -w
 2019-12-10 11:56:37 -08:00
Chef Expeditor
2825e8df64 Bump version to 4.18.49 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-12-09 20:10:36 +00:00
Chef Expeditor
14e81b88f7 Bump version to 4.18.48 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-12-09 20:09:53 +00:00
Ryan Davis
5d8a0af8ce
Merge pull request #4768 from inspec/zenspider/bug628 
Wire up backend to rspec metadata, allowing for example groups to use resources
 2019-12-09 12:09:41 -08:00
Ryan Davis
77ce1b6559 Wire up backend to rspec metadata, allowing for example groups to use resources 
Fixes #628.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-12-06 17:07:22 -08:00
Chef Expeditor
b9f8d1ea59 Bump version to 4.18.47 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-12-05 19:23:34 +00:00
Clinton Wolfe
7d2733df23
Make fetchers fail consistently (#4736) 
Make fetchers fail consistently
 2019-12-05 14:23:14 -05:00
Ryan Davis
11a22c63c7 Removed duplicate method warning in shadow resource. 
Removed from filtertable because the deprecations are in the regular
methods.

Fixes #4213.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-12-04 17:13:39 -08:00
Ryan Davis
4942a572bb Fix warnings coming from ruby -w 
This first pass fixes all our circular requires and duplicate method
warnings that come from:

```
ruby -w -Ilib:test test/functional/helper.rb
```

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-12-04 17:07:37 -08:00
Chef Expeditor
55664f753a Bump version to 4.18.46 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-12-04 20:23:35 +00:00
Ryan Davis
eca23385ea
Merge pull request #4760 from inspec/zenspider/detect+logger 
Hook up logger to inspec detect.
 2019-12-04 12:23:17 -08:00
Clinton Wolfe
84d4325516 Linting 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-12-04 13:35:13 -05:00
Clinton Wolfe
b6cb418af6 Flatten a conditional 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-12-04 13:32:58 -05:00
Clinton Wolfe
bba6d70b3b Raise FetcherFailure for url headers missing 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-12-04 13:32:58 -05:00
Clinton Wolfe
8c53e8a6b9 Remove constructors from raise statements 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-12-04 13:32:58 -05:00
Clinton Wolfe
b34d489f5c Add .invalid TLD to test hostanmes 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-12-04 13:32:58 -05:00
Clinton Wolfe
4bda0ddeeb fixture and implementation for git fetcher failure handling 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-12-04 13:32:19 -05:00
Clinton Wolfe
8a3213861a Fixture and implementation for URL fetcher 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-12-04 13:32:19 -05:00
Clinton Wolfe
72f1011979 Fixture and implementation for local fetcher error handling 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-12-04 13:30:08 -05:00
Chef Expeditor
31e4fea3ff Bump version to 4.18.45 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-12-04 02:43:54 +00:00
Ryan Davis
af494c193f Hook up logger to inspec detect. 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-12-03 18:43:52 -08:00
Josh Brand
3af3df34d7 remove inspec/jq from pkg_deps/pkg_build_deps 
It's included as a dep in the scaffolding itself, and the multiple
dependencies cause failures when building (ty @smacfarlane <3)

`jq` is also no longer needed, it was an artifact of legacy testing

Signed-off-by: Josh Brand <jbrand@chef.io>
 2019-12-03 18:04:51 -05:00
Chef Expeditor
41897d3beb Bump version to 4.18.44 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-12-02 21:28:06 +00:00
Miah Johnson
b174273034
Merge pull request #4724 from mbaitelman/add_last_login_user 
Add last login date to WindowsUser
 2019-12-02 13:27:45 -08:00
Chef Expeditor
b133a48487 Bump version to 4.18.43 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-12-02 21:27:22 +00:00
Chef Expeditor
bc3d6e634b Bump version to 4.18.42 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-12-02 18:41:25 +00:00
Chef Expeditor
5d09cfce2f Bump version to 4.18.41 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-11-29 21:08:37 +00:00
Ryan Davis
f2e4fb549c Address and fix all our ruby 2.7 warnings & errors. 
This does NOT include fixes for our dependencies that are also having
2.7 warnings (which cause our functional tests to fail because for
some reason we expect stderr to be empty, which is brittle).

I've got upstream PRs to fix all of those. My tests pass locally. I
could push a commit that modifies the Gemfile to use my forks, but I'd
like to see how this fares for now.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-11-27 15:42:52 -08:00
Chef Expeditor
f0533846fb Bump version to 4.18.40 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-11-25 19:56:25 +00:00
Clinton Wolfe
6adf7b13be
Merge pull request #4734 from inspec/cw/move-fetchers 
Move lib/fetchers to lib/inspec/fetchers and re-namspace
 2019-11-25 14:56:06 -05:00
Clinton Wolfe
9792bae00d Move the registry cache object 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-11-22 10:09:51 -05:00
Clinton Wolfe
d9f55bf85c Singularize the fetchers directory name 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-11-22 09:57:28 -05:00
Clinton Wolfe
7807c3fa01 Re-namespace core Fetchers 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-11-18 13:20:35 -05:00
Clinton Wolfe
80ef0eeeba Take back the Inspec::Fetcher namespace 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-11-15 16:23:00 -05:00
Chef Expeditor
61f6207fdf Bump version to 4.18.39 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-11-14 23:30:37 +00:00
Clinton Wolfe
b39d47bda7 Move fetcher files 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-11-14 15:25:43 -05:00
Mendy Baitelman
4ba95a0236 Fix syntax, start tests 
Signed-off-by: Mendy Baitelman <mendy@baitelman.com>
 2019-11-13 23:08:23 -08:00
Mendy Baitelman
311d7ee9c9 Syntax fix 
Signed-off-by: Mendy Baitelman <mendy@baitelman.com>
 2019-11-13 21:28:43 -08:00
Mendy Baitelman
8205a78fd2 Add last login to WindowsUser 
Signed-off-by: Mendy Baitelman <mendy@baitelman.com>
 2019-11-13 21:20:58 -08:00
Chef Expeditor
b9a55682dc Bump version to 4.18.38 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-11-13 23:51:04 +00:00
Chef Expeditor
741fcc3564 Bump version to 4.18.37 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-11-13 23:48:32 +00:00
Ryan Davis
540521031b
Merge pull request #4707 from inspec/zenspider/apt-fix 
Fixes parsing of apt config files with arch specifier.
 2019-11-13 15:48:15 -08:00
Chef Expeditor
95a8b55dcb Bump version to 4.18.36 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-11-13 20:35:08 +00:00
Chef Expeditor
4d705f31c0 Bump version to 4.18.35 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-11-13 20:34:03 +00:00
Ryan Davis
4e818faeb4 Fixes parsing of apt config files with arch specifier. 
Fixes #4683.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-11-12 15:08:06 -08:00
Ryan Davis
d829fa2d61 Changed FileProvider to try to encode UTF-8 and convert newlines. 
For Windows compatibility.
 2019-11-12 14:51:56 -08:00
Ryan Davis
2a680058f4 Missing require? 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-11-12 14:51:56 -08:00
Ryan Davis
a27eef1d0b Fixed env vars on functional plugin tests for windows. 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-11-12 14:51:56 -08:00
Ryan Davis
ead386df14 Fixed inspec_init_plugin_test.rb 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-11-12 14:51:56 -08:00
Ryan Davis
a598356e12 Strip down plugin helper and change windows prefix execution. 
Powershell doesn't use "&&" and we have it all over the tests.
Changing to ";".

Also starting to unify the plugin helper w/ the functional helper
since it has a LOT of duplication.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-11-12 14:51:56 -08:00
Ryan Davis
e60dc84188 Cleaned up inspec artifact testing. 
Removed redundant test/functional/inspec_artifact_test.rb
Cleaned up lib/plugins/inspec-artifact/test/functional/inspec_artifact_test.rb
Made an error on windows (install-profile fails) raise instead of just print.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-11-12 14:50:39 -08:00
Ryan Davis
2cb5f26998 Rearrange a require in metadata.rb to break circularity is load. 
For some reason this works fine in linux & osx but fails on windows
but only when some things are loaded in isolation. *shrug*
 2019-11-12 14:50:39 -08:00
Chef Expeditor
fb163ad294 Bump version to 4.18.34 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-11-12 21:01:36 +00:00
Clinton Wolfe
1db2941a9e
Fix for invocation when calling npm under sudo (#4548) 
Fix for invocation when calling npm under sudo
 2019-11-12 16:01:07 -05:00
Chef Expeditor
d9339eab02 Bump version to 4.18.33 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-11-12 20:31:02 +00:00
Bryan McLellan
e4a096ba83
Merge pull request #4680 from inspec/btm/warn-objects 
Deprecate inspec/object/* classes
 2019-11-12 15:30:45 -05:00
Chef Expeditor
91511c0ca4 Bump version to 4.18.32 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-11-12 20:21:53 +00:00
Ryan Davis
b1c2af209b Corresponding fixes for the move from test/unit/mock to test/fixtures. 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-11-08 19:20:12 -08:00
Chef Expeditor
ad0e9abd33 Bump version to 4.18.31 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-11-09 00:08:00 +00:00
Ryan Davis
244c7bbed4
Merge pull request #4677 from inspec/zenspider/bump-chefstyle 
Bump chefstyle and fix up flagged code.
 2019-11-08 16:07:42 -08:00
Ryan Davis
bb49d58cd9 Switched chefstyle back to Layout/AlignArguments=with_first_argument. 
Fixed the flags mostly with `chefstyle -a` but also refactored/cleaned
some stuff by hand.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-11-08 12:57:43 -08:00
Ryan Davis
8f1e607d55 Bump chefstyle and fix up flagged code. 
Very minor.

I want to change a default config but I'll do that in a separate
commit since it is a bigger diff.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-11-08 12:57:43 -08:00
Bryan McLellan
3670500701 Deprecate inspec/object/* classes 
The classes in inspec/object have been moved to the inspec-objects
library. They aren't used directly by Inspec and will be removed in the
next major release.

Signed-off-by: Bryan McLellan <btm@loftninjas.org>
 2019-11-08 15:09:09 -05:00
Clinton Wolfe
5acc8fed1a Correctly detect NPM modules with a custom path on Windows 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-11-07 17:30:50 -05:00
Clinton Wolfe
34cd236036 Revert "Remove erroneous windows support declaration" 
We do in fact support windows. We want to support windows with a custom path, too.

This reverts commit 2092984fdd.
 2019-11-07 15:39:58 -05:00
Clinton Wolfe
2092984fdd Remove erroneous windows support declaration 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-11-07 15:39:08 -05:00
Clinton Wolfe
c0b5b9cd41 Fix for invocation when calling npm under sudo 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-11-07 15:39:08 -05:00
Chef Expeditor
b3f44ad91f Bump version to 4.18.30 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-11-07 16:58:31 +00:00
Clinton Wolfe
d9f34dda58
Make input() work in describe.one (#4666) 
Make input() work in describe.one
 2019-11-07 11:58:11 -05:00
Clinton Wolfe
bf5ce746c9 Make __profile_id private and add comment 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-11-07 10:49:49 -05:00
Chef Expeditor
3c1fadd1cb Bump version to 4.18.29 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-11-07 03:04:10 +00:00
Clinton Wolfe
11438d5d3c Refactor to DRY up repeated implementation of input() 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-11-06 11:13:18 -05:00
Chef Expeditor
b810f82328 Bump version to 4.18.28 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-11-06 00:33:09 +00:00
Ryan Davis
4ed9305535
Merge pull request #4670 from inspec/zenspider/gem-resource 
Pre-load the gem resource to override the global gem method.
 2019-11-05 16:32:48 -08:00
Chef Expeditor
76a8ac7190 Bump version to 4.18.27 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-11-05 07:20:46 +00:00
Mendy Baitelman
1a9a47ee96 Merge remote-tracking branch 'upstream/master' into add-startuser-systemd-service 
Signed-off-by: Mendy Baitelman <mendy@baitelman.com>
 2019-11-04 21:07:56 -08:00
Ryan Davis
04986547ac Added some todos to the gem resource. 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-11-04 13:25:35 -08:00
Ryan Davis
5b6fdf9a98 Pre-load the gem resource to override the global gem method. 
This seems problematic to me in general. We should probably not
override global methods. Renaming this to rubygem and providing a
deprecated alias seems like the right thing to do.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-11-04 13:25:35 -08:00
Chef Expeditor
b1fc46e883 Bump version to 4.18.26 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-11-01 21:56:36 +00:00
Clinton Wolfe
b776b84603 Rough implementation of input() in describe.one, could use dome DRYing 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-11-01 16:52:21 -04:00
Chef Expeditor
7841361428 Bump version to 4.18.25 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-11-01 18:45:27 +00:00
Chef Expeditor
15a70539b8 Bump version to 4.18.24 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-10-31 22:24:00 +00:00
Chef Expeditor
548c82ac36 Bump version to 4.18.23 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-10-31 21:41:31 +00:00
Miah Johnson
22dbfbd705 Ooops. I didn't need to remove this just yet. html parser is using it. 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-10-31 14:39:10 -07:00
Chef Expeditor
fe3fc3ffbf Bump version to 4.18.22 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-10-31 21:20:26 +00:00
Miah Johnson
1b93755410
Merge pull request #4653 from landychan/lchan/bug-fix-3611 
Nginx Resource: Add parsing support for wildcard, dot prefix, and regex
 2019-10-31 14:20:08 -07:00
Chef Expeditor
6f4a7ffe48 Bump version to 4.18.21 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-10-31 21:19:05 +00:00
Miah Johnson
7442955ed6
Merge pull request #4650 from inspec/cw/fix-compliance-exec 
Fix config reference in `compliance exec`
 2019-10-31 14:18:47 -07:00
Chef Expeditor
a7bd16a1f9 Bump version to 4.18.20 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-10-31 21:14:13 +00:00
Miah Johnson
7a68d58904
Merge pull request #4654 from inspec/mj/oracle 
oracledb_session fixes
 2019-10-31 14:13:56 -07:00
Chef Expeditor
26f4d66006 Bump version to 4.18.19 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-10-31 21:13:25 +00:00
Miah Johnson
de4139aff8
Merge pull request #4568 from ramereth/yum-el8-support 
Improve testing for yum.repo in CentOS 8
 2019-10-31 14:13:05 -07:00
Chef Expeditor
a599ba428b Bump version to 4.18.18 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-10-31 21:10:23 +00:00
Ryan Davis
7189f2e21a Fixed problem with accessing backend in TestDslLazyLoader#method_missing. 
Fixes #4587.
Fixes #4524.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-10-31 14:09:16 -07:00
Ryan Davis
defe63dada Test for bug #4524 and bug #4587 to verify that resources are available w/in rspec constructs. 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-10-31 14:09:16 -07:00
Miah Johnson
b63e886523 Fixes based on PR feedback. 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-10-31 11:44:08 -07:00
Miah Johnson
c582895434 cmd and command were too similar 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-10-30 19:41:57 -07:00
Miah Johnson
636f34f7fc remove old comments 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-10-30 19:41:28 -07:00
Miah Johnson
6bab53cbd3 after dropping the return we dont have to worry about executing during init 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-10-30 19:10:57 -07:00
Miah Johnson
0ff8383369 give bin a default value 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-10-30 19:10:03 -07:00
Miah Johnson
85df7f52ef Don't need to return on these. 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-10-30 17:28:14 -07:00
Landy Chan
9e38bec396 Added wildcard and dot-prefixed identifier support. Combined regex identifier into standard identifier 
Signed-off-by: Landy Chan <landychan92@gmail.com>
 2019-10-30 16:39:38 -07:00
Miah Johnson
6e346a3616 make readers match their instance variables 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-10-30 15:28:34 -07:00
Miah Johnson
c82a94f2a3 wire everythign up 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-10-30 15:28:19 -07:00
Miah Johnson
08462e4319 give our argument a better name 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-10-30 15:27:18 -07:00
Miah Johnson
36dc965d70 dead code 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-10-30 15:26:19 -07:00
Miah Johnson
45348965b6 figure out command outside of query. 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-10-30 15:25:03 -07:00
Miah Johnson
96d832effa fix verify_query 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-10-30 15:16:05 -07:00
Miah Johnson
3a8c474e56 Move our resource checks out of initialize. 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-10-30 15:14:41 -07:00
Landy Chan
e60179b91f Added regex identifier 2019-10-30 13:51:20 -07:00
Clinton Wolfe
954174c921 Fix config reference in compliance exec 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-10-30 15:56:07 -04:00
Miah Johnson
a46f78031b set sqlcl_bin if specified by users, else don't. 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-10-30 12:28:15 -07:00
Chef Expeditor
4c0675dc79 Bump version to 4.18.17 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-10-30 09:38:42 +00:00
Mendy Baitelman
1a289571ed Simplify logic 
Signed-off-by: Mendy Baitelman <mendy@baitelman.com>
 2019-10-29 22:03:34 -07:00
Chef Expeditor
d241dcab23 Bump version to 4.18.16 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-10-29 21:47:57 +00:00
Ryan Davis
f56ccb16cb
Merge pull request #4628 from inspec/zenspider/minitest-output 
Fixed the rest of the minitest deprecations by removing FuncTestRunResult.
 2019-10-29 14:47:36 -07:00
Chef Expeditor
58d9a975c1 Bump version to 4.18.15 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-10-24 20:25:59 +00:00
Chef Expeditor
4897f75371 Bump version to 4.18.14 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-10-24 20:25:17 +00:00
Miah Johnson
9c953a0e68
Merge pull request #4638 from inspec/mj/eha 
Add #to_s to etc_hosts_allow, and add tests
 2019-10-24 13:24:46 -07:00
Chef Expeditor
c0001ff873 Bump version to 4.18.13 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-10-24 20:24:35 +00:00
Miah Johnson
44579ab4b3
Merge pull request #4637 from inspec/mj/3921 
Fix filesystem resource when device has long name
 2019-10-24 13:24:23 -07:00
Miah Johnson
86acdda337
Merge pull request #4636 from inspec/mj/4630 
iis_app_pool better handling of non-existent pools.
 2019-10-24 13:24:03 -07:00
Chef Expeditor
71d0683ff0 Bump version to 4.18.12 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-10-24 20:23:51 +00:00
Miah Johnson
c9c8bc5f9d
Merge pull request #4635 from inspec/zenspider/users-bad-date 
Fix a crash from users resource if the password has never been updated
 2019-10-24 13:23:30 -07:00
Miah Johnson
ac399b7af9 Add #to_s to etc_hosts_allow, and add tests 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-10-24 12:07:26 -07:00
Lance Albertson
dab91a321a Improve testing for yum.repo in CentOS 8 
The output for ``yum -v repolist all`` changes slightly in CentOS 8. There are
two specific changes:

1. EL8 is no longer trailing the repo name with release version and arch (i.e.
   base instead of base/7/x86)
2. EL8 no longer adds a trailing newline on the last repo and instead has a line
   with ``Total packages:``. This means the repo listed last will never show up.

A fix was introduced in #4566 however the tests still use CentOS 7 yum output
instead of dnf repolist output. One issue was still discovered where it was
including the ``Total packages`` line in the last repository. This includes a
regex for to work around that and fixes for the tests.

Signed-off-by: Lance Albertson <lance@osuosl.org>
 2019-10-24 08:22:42 -07:00
Miah Johnson
0affbc0487 Use the posix output format 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-10-23 19:55:53 -07:00
Miah Johnson
90d3d9fd32 supports should cover this, salmon! 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-10-23 17:59:25 -07:00
Miah Johnson
e6b6762e51 Nicer memoize 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-10-23 17:58:58 -07:00
Miah Johnson
044110e6fc Return true/false if iis_app_pool[:pool_name] has a value (or not) 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-10-23 17:57:42 -07:00
Ryan Davis
8d51d878f6 Fixed users resource when "Last password change" is "never". 
Extended quick_resource to have platform methods and a new string
command mock. The named resource to mock may now be a symbol.

Added a new test that shows how to use quick_resource with multiple commands.

Fixes #4629.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-10-23 16:49:49 -07:00
Ryan Davis
c9a3c927f9 Fixed inspec from crashing on startup when it can't create the cache directory. 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-10-23 16:35:11 -07:00
Chef Expeditor
8200e625b4 Bump version to 4.18.11 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-10-23 21:54:39 +00:00
Ryan Davis
d201d1fbc2 Fixed the rest of the minitest deprecations by removing FuncTestRunResult. 
Folded the json & other payloads into plain ivars on the test.
Found and removed some unused code while I was there.

Fixes #4533.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-10-22 12:15:28 -07:00
Chef Expeditor
aebcd3c119 Bump version to 4.18.10 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-10-21 21:26:54 +00:00
Ryan Davis
8d4e8c1d96
Merge pull request #4627 from inspec/zenspider/json-and-resource-cleanup 
JSON processing and resource cleanup
 2019-10-21 14:26:37 -07:00
Chef Expeditor
aaecbfa602 Bump version to 4.18.9 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-10-21 20:48:25 +00:00
Ryan Davis
4dfec45b8c Extra todos! Yay! 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-10-21 13:30:14 -07:00
Ryan Davis
33dacc4044 ResourceDSL#name should actually return the name if it is going to be named like a getter. 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-10-21 13:30:14 -07:00
Ryan Davis
ebf90ca140 Added Resource.backfill_supports! to provide platform inheritance. 
This make it so resources like yaml (which subclasses json) have their
platform information filled in properly.

This still isn't being called. Not sure where the right entry point
is... but the method is now available and allowed me to do analysis on
the rest of the resources.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-10-21 13:30:14 -07:00
Ryan Davis
7e013e0a48 Mark json as an 'os' platform. 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-10-21 13:30:14 -07:00
Ryan Davis
915fdd0396 Mark mssql_session as a windows platform. 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-10-21 13:30:14 -07:00
Ryan Davis
e469af9d70 Remove (test?) cruft modifying $LOAD_PATH in plugin loader. 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-10-21 13:30:14 -07:00
Ryan Davis
d7a2e047f4 Rename describe.rb to describe_base.rb 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-10-21 13:30:14 -07:00
Chef Expeditor
13e9774da2 Bump version to 4.18.8 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-10-21 19:41:12 +00:00
Ryan Davis
031d4c592b
Merge pull request #4597 from inspec/zenspider/systemstackerror 
Rescue SystemStackError to make errors during inspec check/archive more graceful.
 2019-10-21 12:40:52 -07:00
Chef Expeditor
fa43309993 Bump version to 4.18.7 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-10-21 19:31:52 +00:00
Ryan Davis
dd3043a992
Merge pull request #4619 from inspec/zenspider/empty-tarball 
Fix TarProvider when the tarball has empty files in it.
 2019-10-21 12:31:29 -07:00
Ryan Davis
e4f4f5d1cc Fix TarProvider when the tarball has empty files in it. 
Added a unit test that runs in ~0.1s. Let's avoid heavy integration
tests where possible.

Fixes #4616

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-10-18 14:30:00 -07:00
Chef Expeditor
cf4f5509dc Bump version to 4.18.6 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-10-18 20:37:00 +00:00
Ryan Davis
3d604348a4
Merge pull request #4566 from inspec/zenspider/mock 
Refactored and added an alternative test mock resource system.
 2019-10-18 13:36:42 -07:00
Ryan Davis
a61d8b9d34 Rescue SystemStackError to make errors during inspec check/archive more graceful. 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-10-17 15:34:40 -07:00
Chef Expeditor
c7909b7dd7 Bump version to 4.18.5 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-10-17 22:19:39 +00:00
Chef Expeditor
344d99f510 Bump version to 4.18.4 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-10-17 19:49:55 +00:00
Chef Expeditor
0542ac5b30 Bump version to 4.18.3 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-10-17 19:39:13 +00:00
Ryan Davis
fc8ea79ad0 Fixed parsing yum output on centos8. 
* Renamed and added extra test data to distinguish between centos 7 & centos 8.
* Renamed and added extra tests to cover centos 8.
* Fixed missing repo data by checking at the end if we were still in parse mode.

Fixes #4517

Signed-off-by: Ryan Davis <zenspider@chef.io>
Cc: Miah Johnson <miah@chia-pet.org>
 2019-10-16 16:54:07 -07:00
Miah Johnson
df7efefc9d mostly a search and replace for gordon -> example 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-10-16 10:13:24 -07:00
Chef Expeditor
5e699d2fb3 Bump version to 4.18.2 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-10-15 18:22:14 +00:00
Chef Expeditor
8d71d3b4dc Bump version to 4.18.1 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-10-11 17:50:46 +00:00
Clinton Wolfe
bde308f72d
Replace input to_hash method, and add unit test for it (#4545) 
Replace input to_hash method, and add unit test for it
 2019-10-11 10:50:27 -07:00
Chef Expeditor
8bc9cbb9e8 Bump version to 4.18.0 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-10-10 20:39:36 +00:00
Clinton Wolfe
a04142d034
Waivers Feedback - Per control reporting and other minor issues (#4567) 
Waivers Feedback - Per control reporting and other minor issues
 2019-10-10 13:39:18 -07:00
Clinton Wolfe
1495583cdc linting 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-10-09 20:16:10 -07:00
Ryan Davis
b03bc67bbb Fixed 2 failing tests w/ missing empty hash waiver data. 
Doesn't prove that data is being passed through when we have it.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-10-09 17:49:04 -07:00
Chef Expeditor
3302960a46 Bump version to 4.17.27 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-10-09 20:08:55 +00:00
Clinton Wolfe
ba61cd3f45 Update JSON schema to reflect new waiver keys 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-10-08 21:01:19 -07:00
Clinton Wolfe
0f5fde9729 Modify waiver input file to use 'run' subfield instead of 'skip' 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-10-08 01:03:40 -07:00
Clinton Wolfe
7516f959d1 If there is no data, alwaya return an empty hash. 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-10-08 00:31:23 -07:00
Clinton Wolfe
56c2416c57 Move waiver JSON data from per-result to per-control 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-10-08 00:25:06 -07:00
Clinton Wolfe
88ed1794cb Revert to a small amount of duplicating to_hash in inspec/input.rb 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-10-06 19:30:37 -04:00
Chef Expeditor
40b6fcfe6f Bump version to 4.17.26 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-10-04 22:30:55 +00:00
Miah Johnson
e48d08343b
Merge pull request #4452 from mhackethal/user-windows-fix 
User windows fix
 2019-10-04 15:30:37 -07:00
Chef Expeditor
656d3882bc Bump version to 4.17.25 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-10-04 22:27:17 +00:00
Ryan Davis
632dd5f18b
Merge pull request #4556 from inspec/zenspider/array/at 
Don't use #at when you can use #[] for array (or hash) access.
 2019-10-04 15:26:57 -07:00
Ryan Davis
f47990a030 Don't use #at when you can use #[] for array (or hash) access. 
This is just more idiomatic ruby.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-10-04 15:24:42 -07:00
Chef Expeditor
a0fc2705c7 Bump version to 4.17.24 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-10-04 21:18:49 +00:00
Miah Johnson
1a76d59cca
Merge pull request #4553 from inspec/mj/polyfill 
Remove unused polyfill.rb file adding to_h to Struct
 2019-10-04 14:18:32 -07:00
Chef Expeditor
71a7506644 Bump version to 4.17.23 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-10-04 20:02:39 +00:00
Ryan Davis
471524711a
Merge pull request #4565 from inspec/zenspider/rspec_method_missing 
Fix problem in method_missing in rspec extensions when backend unavailable.
 2019-10-04 13:02:21 -07:00
Clinton Wolfe
36db8b9a7b Rely on copy of to_hash in objects/input.rb to avoid duplication 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-10-04 14:05:19 -04:00
Clinton Wolfe
51812a9e4e Replace to_hsh method, and add unit test for it 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-10-04 14:05:19 -04:00
Ryan Davis
9c0c62f89b Fix problem in method_missing in rspec extensions when backend unavailable. 
Fixes #4564

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-10-04 00:36:16 -07:00
Chef Expeditor
f4c979cabd Bump version to 4.17.22 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-10-03 23:25:46 +00:00
Chef Expeditor
029a95541b Bump version to 4.17.21 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-10-03 23:25:02 +00:00
Miah Johnson
302abaaa85
Merge pull request #4558 from inspec/mj/4517 
Add name property to interface resource
 2019-10-03 16:24:58 -07:00
Miah Johnson
44a4f8f221 This file isn't used by anything inside of InSpec 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-10-03 14:59:26 -07:00
Miah Johnson
1e6daffd80 Missing require for EnvPrinter means inspec env stacktraced. 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-10-03 14:58:42 -07:00
Miah Johnson
416c33e056 Add name property to interface resource 
Also some general cleanup.

Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-10-03 14:53:43 -07:00
Chef Expeditor
4411550ca9 Bump version to 4.17.20 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-10-03 21:51:31 +00:00
Chef Expeditor
a5e834d66b Bump version to 4.17.19 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-10-03 21:50:50 +00:00
Ryan Davis
6fd2db256d
Merge pull request #4560 from inspec/zenspider/apt 
Fixed apt resource incorrectly parsing deb files w/ quoted URIs.
 2019-10-03 14:50:48 -07:00
Ryan Davis
fd7a569d6b Minor cleanups for readability. 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-10-03 13:45:19 -07:00
Ryan Davis
07dc5e3192 First pass at cleaning deprecations for old minitest/spec-style tests. 
3 files left to go, and they're behaving oddly so I'm leaving them out
in this pass. Looks like 21 deprecations left.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-10-03 13:45:19 -07:00
Ryan Davis
09392943f5 Fixed apt resource incorrectly parsing deb files w/ quoted URIs. 
Fixes #4559.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-10-03 12:55:15 -07:00
Chef Expeditor
c28284a797 Bump version to 4.17.18 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-10-03 19:51:29 +00:00
Chef Expeditor
90961d3cf7 Bump version to 4.17.17 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-10-02 04:11:17 +00:00
Clinton Wolfe
d7e39c38f9
Merge pull request #4550 from inspec/zenspider/only_if/os 
Add no-op resource and switch Rule to use it for skipped resources.
 2019-10-02 00:11:02 -04:00
Chef Expeditor
54f51b75df Bump version to 4.17.16 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-10-02 04:07:16 +00:00
Clinton Wolfe
a4090f9c1c
Merge pull request #4549 from inspec/zenspider/describe.one 
Added method_missing to Inspec::DescribeBase (used by describe.one) to fix resource loading
 2019-10-02 00:06:56 -04:00
Ryan Davis
ae6cec831d Add no-op resource and switch Rule to use it for skipped resources. 
Avoids the situation of using `os` for non-os transports and blowing up.

Fixes #4541.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-10-01 17:26:32 -07:00
Ryan Davis
8b7a7386c8 Added method_missing to Inspec::DescribeBase (used by describe.one) to fix resource loading. 
Fixes #4547.

Completely lacking in tests. Our current tests around describe.one are
not very useful in this context.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-10-01 16:37:53 -07:00
Ryan Davis
11b8e54223 Refactored Rule#with_dsl to be a bit more readable and flat. 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-10-01 16:37:28 -07:00
Chef Expeditor
28dac6b5fb Bump version to 4.17.15 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-09-30 22:44:01 +00:00
Miah Johnson
7b039fea84
Merge pull request #4483 from frezbo/bug/inspec_config_clear 
Fix config clearing
 2019-09-30 15:43:41 -07:00
Chef Expeditor
592f091d95 Bump version to 4.17.14 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-09-30 19:26:49 +00:00
Chef Expeditor
09acafc612 Bump version to 4.17.13 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-09-30 19:15:47 +00:00
Chef Expeditor
bc6fdc25e3 Bump version to 4.17.12 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-09-30 19:15:20 +00:00
Ryan Davis
c9da57efa7
Merge pull request #4537 from syseleven/fix/group_loading 
Add missing resource stubs for 'group' resource
 2019-09-30 12:15:14 -07:00
Clinton Wolfe
9f79fffb39 Add resource stub for sshd_config 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-09-30 13:43:53 -04:00
Matthias Baur
59ae6629ec
Add missing resource stubs for 'group' resource 
Fixes #4536.

Signed-off-by: Matthias Baur <m.baur@syseleven.de>
 2019-09-30 11:04:26 +02:00
Chef Expeditor
98606ef721 Bump version to 4.17.11 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-09-27 23:51:46 +00:00
Chef Expeditor
f4c0c60d2e Bump version to 4.17.10 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-09-27 23:33:04 +00:00
Chef Expeditor
bc60fc5a80 Bump version to 4.17.9 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-09-27 23:32:18 +00:00
Ryan Davis
737badc619
Merge pull request #4534 from inspec/zenspider/rspec/resources 
Fixed inspec lazy resource loader for rspec test dsl (eg before/after)
 2019-09-27 16:32:08 -07:00
Ryan Davis
9369bad99a Fixed inspec lazy resource loader for rspec test dsl (eg before/after) 
This does NOT fix lazy loading of resources at the describe block
level. I need to figure out where our backend/inspec/whatever is in
that context and it looks like we don't have one available.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-09-27 15:55:38 -07:00
Clinton Wolfe
9a2d360b71 Last four resources 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-09-27 14:47:40 -07:00
Clinton Wolfe
19a0803a71 Four more resources 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-09-27 14:47:40 -07:00
Clinton Wolfe
72ff1cee7f Add resource loader stubs so the dynamic resource loader will find the code file for services 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-09-27 14:47:40 -07:00
Chef Expeditor
8fffa5e2cb Bump version to 4.17.8 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-09-27 21:45:41 +00:00
Chef Expeditor
1933fdefa0 Bump version to 4.17.7 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-09-27 00:01:28 +00:00
Chef Expeditor
df93b99277 Bump version to 4.17.6 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-09-26 19:29:48 +00:00
Ryan Davis
fd1ab6fff0
Merge pull request #4513 from inspec/zenspider/plugin_loader 
Fixed Inspec::Plugin::V2::Registry#detect_system_plugins
 2019-09-26 12:29:29 -07:00
Ryan Davis
ca4844210d Fixed Inspec::Plugin::V2::Registry#detect_system_plugins 
+ Falls back to checking for inspec-core if inspec not found.
+ Fails gracefully if neither are found.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-09-25 16:10:00 -07:00
mhackethal
9369426d8b
fix whitespace. Signed-off-by: mhackethal <mh@it31.de> 2019-09-25 11:40:57 +02:00
mhackethal
07ba40ecee
Ruby calculation for passwordage. 
Change calculation for passwordage from inspec.cmd to ruby date calculation.
Added require "date"
Parse provided date and calculate against Date.today.
Signed-off-by: mhackethal <mh@it31.de>
 2019-09-25 11:27:11 +02:00
Mendy Baitelman
d44f9edc55 Merge remote-tracking branch 'upstream/master' into add-startuser-systemd-service 
Signed-off-by: Mendy Baitelman <mendy@baitelman.com>
 2019-09-24 22:30:51 -07:00
Chef Expeditor
52b0765347 Bump version to 4.17.5 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-09-25 00:46:14 +00:00
Ryan Davis
90c4904a55
Merge pull request #4490 from inspec/zenspider/split-long-functional 
Split and parallelize some tests to make them faster
 2019-09-24 17:45:57 -07:00
Chef Expeditor
9e641e9e94 Bump version to 4.17.4 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-09-23 16:43:27 +00:00
Clinton Wolfe
14e611b25a
Merge pull request #4393 from dalee-bis/query-double-quote-escape-fix 
Fixed MssqlSession.query not escaping double quote correctly
 2019-09-23 12:43:09 -04:00
Chef Expeditor
76901e0247 Bump version to 4.17.3 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-09-18 01:14:06 +00:00
Ryan Davis
577521296c
Merge pull request #4476 from inspec/zenspider/gem_pathing 
Use File.realpath in Loader#plugin_gem_path to resolve all symlinks.
 2019-09-17 18:13:35 -07:00
Chef Expeditor
d35b123f67 Bump version to 4.17.2 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-09-18 01:13:19 +00:00
Irving Popovetsky
ffbcc29c59 Fix the Tag object to_ruby, as used by inspec-scap 
Signed-off-by: Irving Popovetsky <irving@chef.io>
 2019-09-17 15:58:12 -07:00
Ryan Davis
fc1ad67ffc More parallelization for functionals. 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-09-17 11:50:31 -07:00
Chef Expeditor
9afbce04ca Bump version to 4.17.1 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-09-17 00:50:32 +00:00
Ryan Davis
a473a94303
Merge pull request #4493 from inspec/mj/waiver3 
Waivers Phase 3
 2019-09-16 17:50:02 -07:00
Chef Expeditor
a3006d7f4d Bump version to 4.17.0 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-09-17 00:46:42 +00:00
Clinton Wolfe
f1f5840fa7
Merge pull request #4388 from Vancelot11/vancelot/sys_info.hostname 
Expand sys_info resource functionality
 2019-09-16 20:46:25 -04:00
Ryan Davis
769d492108 Split up inspec-plugin_test.rb into a file per subcommand + helper. 
This takes the run time from ~3 minutes to ~1 minute (in parallel).

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-09-16 17:19:32 -07:00
Chef Expeditor
3f3c0fba32 Bump version to 4.16.15 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-09-17 00:04:05 +00:00
Ryan Davis
a0a7917faa
Merge pull request #4485 from inspec/zenspider/objects-inputs 
Split out Inspec::Input functional code from the code generation code.
 2019-09-16 17:03:49 -07:00
Ryan Davis
1526838ea6 Refactored JSON reporter to be much cleaner / consistent. 
Everything can just be a simple clean map + reject if nil value.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-09-16 16:55:38 -07:00
Miah Johnson
5d94b0d709 Add waiver_data to json output, update assertion to show where waiver_data lives. 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-09-16 14:49:05 -07:00
Ryan Davis
e375ea30c8 Split out Inspec::Input functional code from the code generation code. 
Includes moving errors into Inspec::Input and Inspec::InputRegistry.

Fixes #4456.
Fixes #4473.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-09-13 17:12:20 -07:00
Noel Georgi
48c22a118b
Support config clearing 
Signed-off-by: Noel Georgi <git@frezbo.com>
 2019-09-13 10:41:32 +05:30
Chef Expeditor
b9eff6e3b9 Bump version to 4.16.14 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-09-13 00:25:52 +00:00
Ryan Davis
5bf13e05d3 Use File.realpath in Loader#plugin_gem_path to resolve all symlinks. 
Fixes #4472.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-09-12 16:21:01 -07:00
Chef Expeditor
f419546e76 Bump version to 4.16.13 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-09-12 23:08:47 +00:00
Clinton Wolfe
d366af15e8
Merge pull request #4478 from inspec/cw/fix-symbol-error 
Add to_s definitions to several resources
 2019-09-12 19:08:31 -04:00
mhackethal
d3291ae61c fix whitespace. Signed-off-by: mhackethal <mh@it31.de> 2019-09-12 21:56:50 +02:00
mhackethal
c08db992a9
remove awk on lastb 2019-09-12 16:06:03 +02:00
mhackethal
e48f672968
Update users.rb 
Signed-off-by: mhackethal <mh@it31.de>
 2019-09-12 16:04:44 +02:00
Clinton Wolfe
23ca9ba64d Add to_s to remaining resources 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-09-11 20:20:37 -04:00
Clinton Wolfe
80db6b52c7 Add a to_s method for sys_info to avoid conversion error 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-09-11 19:56:05 -04:00
Chef Expeditor
d0505a98e5
Bump version to 4.16.12 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-09-11 22:33:40 +00:00
Clinton Wolfe
fe351dba61
Merge pull request #4469 from inspec/cw/waivers2-fixes 
Fix broken unit test by adding require
 2019-09-11 17:36:46 -04:00
Chef Expeditor
192c241ee0
Bump version to 4.16.11 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-09-11 15:12:40 +00:00
Clinton Wolfe
8132aaf85c
Merge pull request #3844 from inspec/ja/add-error-output-to-json-command 
json resource: Add handling for `command:` error
 2019-09-11 11:12:26 -04:00
Clinton Wolfe
e07cca0f8d Add require for input registry 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-09-11 10:31:23 -04:00
Ryan Davis
fcfcc354fe Reworked test cases and impl to only respond to output, not exit code. 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-09-10 14:19:42 -07:00
Kerry Vance
933d7f14ac fix indentation 
Signed-off-by: Kerry Vance <vancelot@osuosl.org>
 2019-09-10 11:32:15 -07:00
Chef Expeditor
e0e61155d6
Bump version to 4.16.10 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-09-10 18:18:31 +00:00
Ryan Davis
576370cf62
Merge pull request #4437 from inspec/zenspider/waivers/input 
Rough draft on waiver input
 2019-09-10 11:18:17 -07:00
Ryan Davis
7a718103c5 Minor cleanup in config.rb. 
The logic involved was unnecessary and had a hard-coded string in it
that is now wrong.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-09-09 18:44:55 -07:00
Ryan Davis
ce80cf3cf9 First draft at waiver file processing. 
1) Don't know how much filtering or rewriting we want at this level.
2) Don't know where to put the tests.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-09-09 18:44:55 -07:00
Chef Expeditor
29feee9b00
Bump version to 4.16.9 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-09-10 01:41:52 +00:00
Ryan Davis
dfce5e722f
Merge pull request #4427 from inspec/cw/waivers-overlay 
waivers: functional test fixture and eval-time skipping
 2019-09-09 18:41:37 -07:00
Chef Expeditor
69b583bd3d
Bump version to 4.16.8 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-09-10 01:02:22 +00:00
Ryan Davis
f5bbfe5fac
Merge pull request #4365 from inspec/zenspider/the-need-for-speed 
Make inspec much faster for most commands.
 2019-09-09 18:02:10 -07:00
Jerry Aldrich
0e1b3fa65a json resource: Add handling for command: error 
This provides the user with messages if `json(command: 'command_that_errors')`
exits non-zero and/or has STDERR.

Without this the resource will report "No output from command" when really the
output is contained in STDERR.

Signed-off-by: Jerry Aldrich <jerryaldrichiii@gmail.com>
 2019-09-09 15:16:34 -07:00
Chef Expeditor
d1ecefc970
Bump version to 4.16.7 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-09-09 18:14:06 +00:00
Ryan Davis
79b9c3cbad
Merge pull request #4451 from inspec/zenspider/fix-tarball-decoding 
Try to decode archive contents to UTF-8 to avoid encoding corruption.
 2019-09-09 11:13:48 -07:00
Clinton Wolfe
5d94440823 Fix logic error for future expiring waivers 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-09-09 11:29:26 -04:00
Clinton Wolfe
9fd0fb242c Store waiver information in control metadata and pass into report run_data 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-09-09 11:29:26 -04:00
Clinton Wolfe
43bc7e0343 Modify @__skip_rule to distinguish only_if and waiver, and force waiver to win 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-09-09 11:29:26 -04:00
Clinton Wolfe
aab45b507f Clarify input-waiver interaction 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-09-09 11:29:26 -04:00
Clinton Wolfe
0db0a2bfdc Don't assume waiver_ prefix in waiver files 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-09-09 11:29:26 -04:00
Clinton Wolfe
718e205cf2 Alter expiration_date behavior to match spec 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-09-09 11:29:26 -04:00
Clinton Wolfe
6ec50efd22 Initial implementation of skipping a control by waivering it via input flagging 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-09-09 11:29:26 -04:00
Clinton Wolfe
6b618b6b83 Comments for clarity on skipping 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-09-09 11:29:26 -04:00
Chef Expeditor
b82158ba53
Bump version to 4.16.6 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-09-06 18:58:25 +00:00
Chef Expeditor
32d93b367d
Bump version to 4.16.5 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-09-06 18:57:54 +00:00
Miah Johnson
f11d6bcfba
Merge pull request #4443 from ramereth/fix-postfix_conf-other-file 
Fix for postfix_conf when using a non-standard config location
 2019-09-06 11:57:51 -07:00
Miah Johnson
d96b0a3281
Merge pull request #4446 from inspec/zenspider/activated_eh 
Rework activator plugin to be more idiomatic.
 2019-09-06 11:57:31 -07:00
Kerry Vance
41978b4bc7 reduce cognitive complexity, breakup function 
Signed-off-by: Kerry Vance <vancelot@osuosl.org>
 2019-09-06 10:34:31 -07:00
Ryan Davis
f93d0a2aee Make TarProvider much more efficient. 
Read each file once at the start.
Extract should use that cache as well.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-09-06 00:42:36 -07:00
Ryan Davis
9849906198 Cleaned up TarProvider#initialize. 
TarProvider still decompresses & reads N+1 times... that's next

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-09-05 17:33:08 -07:00
Ryan Davis
13301f30d1 Use ||= when possible, esp with lazy hashes. 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-09-05 17:23:48 -07:00
Ryan Davis
e0a835a34d Added comments to the end of these classes to ease navigation. 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-09-05 17:23:01 -07:00
Ryan Davis
fe4e687721 Try to decode archive contents to UTF-8 to avoid encoding corruption. 
Fixes #4135.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-09-05 17:22:02 -07:00
Kerry Vance
729d9965ed fails loudly with unsupported options 
Signed-off-by: Kerry Vance <vancelot@osuosl.org>
 2019-09-05 12:14:36 -07:00
Kerry Vance
540515f796 rename ip-address to ip_address 
Signed-off-by: Kerry Vance <vancelot@osuosl.org>

Signed-off-by: Kerry Vance <vancelot@osuosl.org>
 2019-09-05 12:13:52 -07:00
Kerry Vance
9dafab2215 removed deprecated alias option 
Signed-off-by: Kerry Vance <vancelot@osuosl.org>
 2019-09-05 11:56:13 -07:00
Kerry Vance
75b17561ee expand sys_info resource functionality 
Signed-off-by: Kerry Vance <vancelot@osuosl.org>
 2019-09-05 11:56:12 -07:00
Chef Expeditor
4c1523ff88
Bump version to 4.16.4 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-09-05 13:30:39 +00:00
Clinton Wolfe
dffefc3f0b
Merge pull request #4435 from inspec/zenspider/apt/fix 
Guard against nil in apt repo parser.
 2019-09-05 09:30:22 -04:00
Chef Expeditor
eb9096f14c
Bump version to 4.16.3 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-09-05 13:28:15 +00:00
Ryan Davis
8b0f6efb41 Fixed the formatting of inspec exec -h by not using long_desc. 
long_desc does some really bad word wrapping stuff that totally breaks
our formatting of the output (like code blocks). So, don't use it. If
we like this, I will apply it to all of them.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-09-04 16:54:37 -07:00
Ryan Davis
75ca4613c2 Extended to pick up our internal aws resources as well. 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-09-04 15:44:26 -07:00
Ryan Davis
4590fee51d Documented lib/inspec/resources.rb current usage. 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-09-04 15:44:26 -07:00
Ryan Davis
3b69967cc8 Fixed a bug in checking supports (strings vs symbols) 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-09-04 15:44:26 -07:00
Ryan Davis
3f0f675364 Moved rspec/matchers require to somewhere more appropriate. 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-09-04 15:44:26 -07:00
Ryan Davis
2fc9ec3ec7 Refactor into Inspec::DSL.method_missing_resource 
This way I can add aws lazy loading to only one place.

I don't actually care that this is in Inspec::DSL. There is probably a
better place for it. Suggestions welcome.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-09-04 15:44:26 -07:00
Ryan Davis
ae88c3ddec Sped up inspec shell by avoiding pre-registering all reesources. 
Now it tries to load a resource when `help xxx` is invoked or loads
all resources when `help resources` is invoked. Otherwise, it stays
lazy.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-09-04 15:44:26 -07:00
Ryan Davis
e413cee6a4 I don't like this, but make chef shell require all resources. 
I think there is probably a better way to do this, but my first
instinct was that I'd have to dig into hacking pry, and I don't want
to do that right now.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-09-04 15:44:26 -07:00
Ryan Davis
b6bfeffd9e Make inspec much faster for most commands. 
Removes pre-loading and registration of resources by adding
method_missing to a couple key areas.

This still drops the ball in some areas, but it is a start.
 2019-09-04 15:44:26 -07:00
Ryan Davis
5a26b3c538 Rewrote apt.rb's read_debs' main loop. 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-09-04 15:38:08 -07:00
Ryan Davis
1aebd53314 Rework apt.rb's read_debs. 
This goes a step further and relaxes the parsing quite a bit while
making it more readable and flexible.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-09-04 15:38:08 -07:00
Ryan Davis
4e822f3c37 Refactored V2::Activator into more idiomatic ruby. 
Predicate methods are usually added to make code more expressive, but
they still act off of normal attributes. Predicate methods are not
setters. This moves from X? to X and then aliases the predicate
method.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-09-04 15:33:48 -07:00
Ryan Davis
de22ba3ac1 Fixed warning from overlapping regexp range. 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-09-04 15:33:48 -07:00
Ryan Davis
bb41b4fa8c Guard against nil in apt repo parser. 
Fixes #4093.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-09-04 15:32:47 -07:00
Lance Albertson
1e94e3503e Fix for postfix_conf when using a non-standard config location 
Pass the first argument of the opts array instead of the whole array which
confuses the SimpleConfig parser. Also added a test which verifies this fixes
the issue.

In addition, change the base_name to something that matches other resource base
names.

Signed-off-by: Lance Albertson <lance@osuosl.org>
 2019-09-03 15:28:44 -07:00
Chef Expeditor
d1ffce7278
Bump version to 4.16.2 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-09-03 20:24:54 +00:00
Chef Expeditor
8562397d78
Bump version to 4.16.1 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-08-30 20:20:21 +00:00
kekaichinose
d33870b635
Merge pull request #4214 from inspec/zenspider/fix_nil_file 
Fixed file resource raising UndefinedMethod on source_path
 2019-08-30 13:19:54 -07:00
mhackethal
204c41bfd1 Update users.rb to include new attributes 2019-08-30 22:07:36 +02:00
mhackethal
9d7f9e6f39 add cache credentials/meta_info to windows user resource 2019-08-29 23:12:42 +02:00
Chef Expeditor
435747a2d2
Bump version to 4.16.0 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-08-28 19:41:38 +00:00
Clinton Wolfe
a6bd7ec4b5
Merge pull request #4401 from inspec/cw/input-from-cli 
inputs: Accept bare input from the command line
 2019-08-28 15:41:21 -04:00
Chef Expeditor
683170bd26
Bump version to 4.15.0 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-08-28 19:34:05 +00:00
Clinton Wolfe
edf335bbc9 Use plugin filter predicates to check plugin names 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-28 13:36:12 -04:00
Clinton Wolfe
82acec957e Add API for fetching plugin vconfig values. 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-28 13:25:49 -04:00
Clinton Wolfe
38f3469ee3 Validation for the plugins area of the config file 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-28 13:25:49 -04:00
Clinton Wolfe
c6d355e4f7 Accept version 1.2 for config file format 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-28 13:25:49 -04:00
Chef Expeditor
4a515e5010
Bump version to 4.14.3 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-08-28 17:14:05 +00:00
Clinton Wolfe
e346b16114 Tighten help listing assertion and adjust chomp 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-28 13:03:42 -04:00
Clinton Wolfe
296158c447 Implementation and functional tests for the --input CLI option 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-28 13:03:42 -04:00
Clinton Wolfe
512189a06b Add CLI option and check in help 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-28 12:53:27 -04:00
Clinton Wolfe
7c2e1dfce2 Add explanatory comment 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-27 21:43:35 -04:00
Clinton Wolfe
ac78ecd5ae Swap actual and expected in a test file 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-27 21:29:42 -04:00
Clinton Wolfe
54f1011f7a Linting 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-27 21:29:42 -04:00
Clinton Wolfe
d7750054c8 Move sindows skip lines to be below test execution per rdavis 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-27 21:29:42 -04:00
Clinton Wolfe
9e4ace6799 Go ahead and refactor the fillter predicates 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-27 21:29:42 -04:00
Clinton Wolfe
d1a42b8059 filter was introduced in ruby 2.6 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-27 21:29:42 -04:00
Clinton Wolfe
f44c7bcdcd Convert the plugin name to a string only once when guessing at versions 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-27 21:29:42 -04:00
Clinton Wolfe
1b7a8f3888 Make const in test file 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-27 21:29:42 -04:00
Clinton Wolfe
28f747ebbb Interpolation 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-27 21:29:42 -04:00
Clinton Wolfe
8d80c89e56 Make install types and labels constant 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-27 21:29:42 -04:00
Clinton Wolfe
f962ef2662 Simplify sort for list output 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-27 21:29:42 -04:00
Clinton Wolfe
3cd6eee016 Add valid_plugin_name? predicate and push exclusion list check into its own method 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-27 21:29:42 -04:00
Clinton Wolfe
16fecbefb5 Return version number when listing plugins; correct UX coloration 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-27 21:29:42 -04:00
Clinton Wolfe
e1031cc818 Correct newlines and duplicate output ins various UX messaging 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-27 21:29:42 -04:00
Clinton Wolfe
cc758c7624 Linting 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-27 21:29:42 -04:00
Clinton Wolfe
f0aa934ddc List tests pass again, adding filtering options 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-27 21:29:42 -04:00
Clinton Wolfe
8cab0e862b Adopt the new UI style table, breaking most of the UI tests, which were already broken anyway 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-27 21:29:42 -04:00
Clinton Wolfe
68329aa8e5 Linting 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-27 21:28:52 -04:00
Clinton Wolfe
e581245391 Plausible implementation of detect_system_plugins 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-27 21:28:52 -04:00
Clinton Wolfe
00b2d9480a Rename constant for user gem installs for clarity 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-27 21:28:52 -04:00
Clinton Wolfe
149663ba55 Updated messaging for user gem plugins 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-27 21:28:52 -04:00
Clinton Wolfe
4211d3eb7c Failing functional tests for listing plugin gems 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-27 21:26:49 -04:00
Clinton Wolfe
e90482e955 Refactor train plugin decoration 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-27 21:26:49 -04:00
Chef Expeditor
ba64d06ef7
Bump version to 4.14.2 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-08-28 00:03:34 +00:00
Clinton Wolfe
f90a4c633d
Merge pull request #4419 from inspec/cw/check-enforce-version 
inspec check: warn if inspec_version is not supported by current inspec
 2019-08-27 20:03:19 -04:00
Chef Expeditor
d2dd311561
Bump version to 4.14.1 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-08-27 23:54:27 +00:00
Chef Expeditor
9b84b7b5c1
Bump version to 4.14.0 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-08-27 20:35:09 +00:00
Clinton Wolfe
12c7c51fea Warn not error 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-26 23:29:19 -04:00
Clinton Wolfe
714dc26006 Add unit test and include runtime version check in metadata.valid 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-26 23:05:49 -04:00
Clinton Wolfe
ada6aad169 Move input name stringification into the method 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-22 21:40:01 -04:00
Ryan Davis
bd3ec9aec7 Code cleanup. 
While I was in here... nothing big.

It does seem like we have too many hard-coded symbols in our code in
general as well as too many symbol styles (underscore vs dash).

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-08-20 13:25:21 -07:00
Ryan Davis
7273a7380f Fixed file resource raising UndefinedMethod on source_path 
This is a first pass at fixing the failure found by @scottvidmar where
file resource was raising undefined_method on nil. The problem was
that the initialize method for file was not being called at all
because Resource#initialize was returning early without reporting
anything.

This fix causes a failure in test/functional/inspec_exec_test.rb where
it is testing a similar scenario but for some reason the unsupported
resources get reported. We need to figure that part out, but in the
meantime this will at least report an error at the root cause rather
than down the road.

Fixes #4208

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-08-20 13:25:21 -07:00
Clinton Wolfe
2ef151dd56 Hrm, linting for upstream? 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-19 13:52:28 -04:00
Clinton Wolfe
cc4aa16212 Add test framework to run Runner API input tests 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-19 13:51:51 -04:00
Clinton Wolfe
93521dea0c Accept either input or attribute in the runner API 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-08-19 13:39:31 -04:00
Chef Expeditor
59301c54ad
Bump version to 4.13.2 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-08-19 16:56:07 +00:00
Clinton Wolfe
3f54f7ac46
Ensure that resources are always initialized in all cases (#4366) 
Ensure that resources are always initialized in all cases
 2019-08-19 12:55:52 -04:00
Chef Expeditor
88d23697f7
Bump version to 4.13.1 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-08-19 16:52:35 +00:00
Clinton Wolfe
e7ccdc03c9
Refactor lib/source_readers/inspec.rb (#4376) 
Refactor lib/source_readers/inspec.rb
 2019-08-19 12:52:20 -04:00
Chef Expeditor
7581ab37c7
Bump version to 4.13.0 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-08-19 16:38:32 +00:00
Clinton Wolfe
8dc350bc6c
Add a Postfix-specific configuration testing resource (#4378) 
Add a Postfix-specific configuration testing resource
 2019-08-19 12:38:17 -04:00
Ryan Davis
43e07e8f2d Finished refactoring! 
Now that the code is easier to read and actually focuses on what it
does in a readable way, it is easier to reason about. In this case, we
have blocks being passed around in order to evaluate a bunch of
paths (read: strings) to determine if they're correct. Why do multiple
`start_with?` and `end_with?` calls? It doesn't cleanly describe what
it is trying to do. Instead, we can use regexps and it'll work just
fine, so lets do that. This simplifies things even further.

46.5: flog total

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-08-18 20:36:19 -07:00
Ryan Davis
3f0e9e9ffa Fix chefstyle. 
This is an area where I really disagree with chefstyle. 🤷

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-08-18 20:36:19 -07:00
Ryan Davis
f8b8f968aa lib/source_readers/inspec.rb refactor 8/8: reformat 
58.9: flog total

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-08-18 20:36:19 -07:00
Ryan Davis
ac6164e56d lib/source_readers/inspec.rb refactor 7/8: combine load_all and find_all. 
58.9: flog total

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-08-18 20:36:19 -07:00
Ryan Davis
213a4489ed lib/source_readers/inspec.rb refactor 6/8: use if/compact instead of delete_if. 
59.0: flog total

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-08-18 20:36:19 -07:00
Ryan Davis
6399116e5f lib/source_readers/inspec.rb refactor 5/8: extract to local var 
60.1: flog total

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-08-18 20:36:19 -07:00
Ryan Davis
5d19283199 lib/source_readers/inspec.rb refactor 4/8: use to_h 
59.8: flog total

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-08-18 20:36:19 -07:00
Ryan Davis
70d8ecf1e8 lib/source_readers/inspec.rb refactor 3/8: pull up file reading. 
59.8: flog total

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-08-18 20:36:19 -07:00
Ryan Davis
4f0a5d6ba1 lib/source_readers/inspec.rb refactor 2/8: normalize variable names. 
76.1: flog total

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-08-18 20:36:19 -07:00
Ryan Davis
6735d03a09 lib/source_readers/inspec.rb refactor 1/8: pull up file selection. 
71.3: original flog total
73.0: flog total (this version)

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-08-18 20:36:19 -07:00
Ryan Davis
f4bae13c68 Fixes for 2 failed tests. 
Rescue NotImplementedError and call failed_resource only if we haven't
already failed the support_check call.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-08-18 19:30:30 -07:00
Ryan Davis
cd5f58f8eb Do not call return inside of an initialize method. 
It does NOT do what you think it does. It does NOT prevent an object
from coming back. All it does is have an uninitialized (or partially
initialized) object come back, which isn't helpful.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-08-18 17:28:56 -07:00
Chef Expeditor
8eded7e258
Bump version to 4.12.0 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-08-15 18:47:02 +00:00
dalee-bis
7f2dbd918f
Fixed MssqlSession.query not escaping double quote correctly 
When `MssqlSession.query` is escaping the `"` character, it is doing so by prefixing it with a backslash (e.g. `\"`). This does not escape the quote character. It should be escaped by adding an additional double quote character (e.g. `""`).
 2019-08-15 11:28:50 +01:00
Chef Expeditor
8e62048b97
Bump version to 4.11.5 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-08-13 16:59:16 +00:00
Chef Expeditor
134ff8048a
Bump version to 4.11.4 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-08-12 18:01:20 +00:00
Chef Expeditor
bce0fbe177
Bump version to 4.11.3 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-08-08 22:06:17 +00:00
David Gasper
52ae5e434b Add docs and unit tests, remove .travis.yml 
Signed-off-by: David Gasper <dmgasper@osuosl.org>
 2019-08-08 13:54:35 -07:00
David Gasper
6ba210d82d Add automatic path resolution 
Signed-off-by: David Gasper <dmgasper@osuosl.org>
 2019-08-08 13:54:22 -07:00
David Gasper
098610f128 Add Postfix_conf resource 
Signed-off-by: David Gasper <dmgasper@osuosl.org>
 2019-08-08 13:50:12 -07:00
Chef Expeditor
3981110da5
Bump version to 4.11.2 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-08-08 17:13:42 +00:00
Chef Expeditor
ffba747523
Bump version to 4.11.1 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-08-08 15:56:10 +00:00
Clinton Wolfe
95e6bcb317
Modified DarwinGroup to collect all users properly. (#4343) 
group resource: Modified DarwinGroup to collect all users properly on macos
 2019-08-08 11:55:48 -04:00
Chef Expeditor
8fad74d4a2
Bump version to 4.11.0 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-08-08 15:32:53 +00:00
Clinton Wolfe
c28dd8f9ec
Add startuser windows service (#4363) 
Add startuser windows service
 2019-08-08 11:32:39 -04:00
Chef Expeditor
7ab39ba273
Bump version to 4.10.7 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-08-08 15:16:21 +00:00
Ryan Davis
374e365c02 Modified DarwinGroup to collect all users properly. 
I noticed that my profile targeting group "staff" on OSX wasn't
returning *me*. I'm awesome! So that seemed wrong. And it turns out it
is wrong. We were not collecting any users whose primary group was
that group. (almost all regular users are in group staff and they're
all missing).

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-08-07 20:27:13 -07:00
Chef Expeditor
90fb536bf7
Bump version to 4.10.6 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-08-08 03:17:56 +00:00
Chef Expeditor
a6dd013ec2
Bump version to 4.10.5 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-08-07 20:29:26 +00:00
Mendy Baitelman
042dd26033 Fix ternary operator 
Signed-off-by: Mendy Baitelman <mendy@baitelman.com>
 2019-08-06 21:12:51 -07:00
Mendy Baitelman
db58322d41 Add startname to systemd server 
Signed-off-by: Mendy Baitelman <mendy@baitelman.com>
 2019-08-06 21:04:52 -07:00
Mendy Baitelman
e3b641f676 Fix whitespace 
Signed-off-by: Mendy Baitelman <mendy@baitelman.com>
 2019-08-06 15:11:15 -07:00
Mendy Baitelman
4505471ec7 Fix differences 
Signed-off-by: Mendy Baitelman <mendy@baitelman.com>
 2019-08-06 13:26:37 -07:00
Mendy Baitelman
126b1efc74 Add startuser to windows service 
Signed-off-by: Mendy Baitelman <mendy@baitelman.com>
 2019-08-06 13:20:57 -07:00
Kris Shannon
4a30a8aa32 Move some resources into Inspec::Resources module 
The `DhParams`, `EtcHosts`, `GrubConfig`, `IisAppPool`, and `SSL`
resources were not properly located inside the `Inspec::Resources`
module.

Fixes: #4327

Signed-off-by: Kris Shannon <k.shannon@amaze.com.au>
 2019-08-05 18:17:01 +10:00
Chef Expeditor
723d53e6b1
Bump version to 4.10.4 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-08-01 00:16:47 +00:00
Chef Expeditor
4aa1ef81f3
Bump version to 4.10.3 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-30 23:45:06 +00:00
Chef Expeditor
1045f67a76
Bump version to 4.10.2 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-30 22:08:14 +00:00
Chef Expeditor
66f709875d
Bump version to 4.10.1 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-30 21:46:48 +00:00
Chef Expeditor
ae898b9eb3
Bump version to 4.10.0 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-30 18:38:10 +00:00
Clinton Wolfe
100e96db1c
Relative Path Support for the Git Fetcher (#4217) 
Relative Path Support for the Git Fetcher
 2019-07-30 14:37:54 -04:00
Chef Expeditor
fbf06ccc7d
Bump version to 4.9.1 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-30 18:37:23 +00:00
Clinton Wolfe
80d5788883
Apply new UI code to CLI and plugin-manager-cli (#4000) 
Apply new UI code to CLI and plugin-manager-cli
 2019-07-30 14:37:09 -04:00
Chef Expeditor
718629e42a
Bump version to 4.9.0 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-30 17:58:52 +00:00
Clinton Wolfe
b8c9043a3a
Permit plugin to be in path with git ref (#4251) 
Permit plugin to be in path with git ref
 2019-07-30 13:58:37 -04:00
Clinton Wolfe
f00e741999 PR feedback 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-07-30 13:38:02 -04:00
Clinton Wolfe
c03862fe7b Code climate updates 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-07-30 13:38:02 -04:00
Clinton Wolfe
abc5e84b87 Fix two tiresome cache issues with simple fixes 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-07-30 13:38:02 -04:00
Clinton Wolfe
1a47026419 Rename some vars, eliminate @profile_directory 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-07-30 13:38:02 -04:00
Clinton Wolfe
4f6d296a22 The error case in which the path does not exist 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-07-30 13:38:02 -04:00
Clinton Wolfe
80241ec971 Passing basic test harness 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-07-30 13:38:02 -04:00
Clinton Wolfe
c257763de6 Linting 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-07-30 13:38:02 -04:00
Clinton Wolfe
0e32d2429f Rename path_within_repo option to relative_path 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-07-30 13:36:20 -04:00
Clinton Wolfe
9c1fa967fd Rename profile_path to path_within_repo 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-07-30 13:36:20 -04:00
Jerry Aldrich
3e1d08cafe Add support for relative paths to the Git fetcher 
This adds support for specifying a path to a profile in a Git repo.

For example, you could have a Git repo containing multiple profiles and
you want to specify a single one like below:

```yaml
depends:
  - name: profile-1
    git: https://github.com/myorg/all-my-profiles.git
    profile_path: profiles/my-specific-profile-1
  - name: profile-2
    git: https://github.com/myorg/all-my-profiles.git
    profile_path: profiles/my-specific-profile-2
```
Signed-off-by: Jerry Aldrich <jerryaldrichiii@gmail.com>
 2019-07-30 13:36:20 -04:00
Clinton Wolfe
88962af285 Update UX message testing 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-07-30 13:19:43 -04:00
Clinton Wolfe
918acb01c1 Linting 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-07-30 13:19:43 -04:00
Miah Johnson
72f02e6cac Fix rubocop 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-07-30 13:19:43 -04:00
Miah Johnson
b148bc85a2 Only some of the output is red 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-07-30 13:19:43 -04:00
Miah Johnson
44592338c6 String interoplation > concatenation 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-07-30 13:19:43 -04:00
Miah Johnson
9fb755a213 Use EXIT value constants 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-07-30 13:19:43 -04:00
Miah Johnson
a524dc030f Convert to new Inspec::UI in inspec-plugin-manager-cli 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-07-30 13:19:43 -04:00
Miah Johnson
da9bd13fd4 Use Inspec::UI throughout InspecCLI 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-07-30 13:19:43 -04:00
Chef Expeditor
ef14623c0a
Bump version to 4.8.6 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-30 00:50:58 +00:00
Chef Expeditor
d9840d9a3c
Bump version to 4.8.5 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-29 20:15:52 +00:00
Chef Expeditor
3182227fb2
Bump version to 4.8.4 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-29 19:47:51 +00:00
Ryan Davis
2d5fdabf86
Merge pull request #4337 from inspec/zenspider/remove-version-checking 
Removed lib/inspec/utils/latest_version.rb and associated code.
 2019-07-29 12:47:37 -07:00
Chef Expeditor
d12a3c8b59
Bump version to 4.8.3 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-29 19:46:52 +00:00
Ryan Davis
3d6a4143a1 Removed lib/inspec/utils/latest_version.rb and associated code. 
There is no reason why our tests should be failing because we deploy a
new version. That test shouldn't even be hitting the network for real.

Besides, the functionality has no place in our codebase. It's
functionality provided via `gem outdated` so why did we re-implement
it? And we expect most people to be running via omnibus, so they're
pinned to a specific version in the first place. Even if they updated,
they still couldn't run it and that would be more confusing.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-07-29 11:57:08 -07:00
Chef Expeditor
6e307797da
Bump version to 4.8.2 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-29 17:02:06 +00:00
Chef Expeditor
aee7511820
Bump version to 4.8.1 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-29 17:00:32 +00:00
Clinton Wolfe
be91550343
windows_task: Fix handling of multiple triggers (#4242) 
windows_task: Fix handling of multiple triggers
 2019-07-29 13:00:16 -04:00
Chef Expeditor
9fd9a57f02
Bump version to 4.8.0 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-29 16:51:04 +00:00
Clinton Wolfe
962ec0591e
Transition the Habitat plugin to use scaffolding (#4320) 
Transition the Habitat plugin to use scaffolding
 2019-07-29 12:50:49 -04:00
Chef Expeditor
2e9b838af1
Bump version to 4.7.26 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-26 18:49:01 +00:00
Chef Expeditor
bf845da203
Bump version to 4.7.25 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-25 23:13:48 +00:00
Ryan Davis
04a0139057
Merge pull request #4324 from inspec/zenspider/windows-testing 
Initial pass to clean up functional testing wrt exit codes and output.
 2019-07-25 16:13:33 -07:00
Chef Expeditor
868cb4a39f
Bump version to 4.7.24 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-25 22:21:21 +00:00
Ryan Davis
917a531a92 Skipped all failing tests on windows AT the failures site. 
This activates a BUNCH of tests but keeps us green.

Whether these tests are valid or not is not being addressed here.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-07-24 18:09:08 -07:00
Ryan Davis
1d5d3dfc43 I don't know how I missed these. Removing the rest of the skip_windows calls. 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-07-24 18:06:25 -07:00
Ryan Davis
18ce4850f0 Initial pass to clean up functional testing wrt exit codes and output. 
This should get windows tests running again? Hopefully? They're
running SO slowly on my vagrant box that I'm just pushing for now.
They're clean on the mac side.

Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-07-24 18:06:25 -07:00
Chef Expeditor
b27465b027
Bump version to 4.7.23 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-23 18:47:27 +00:00
Ryan Davis
bd79e9c895
Merge pull request #4316 from inspec/zenspider/fix-file-aws 
Fix exceptions when resources are used with incompatible transports
 2019-07-23 11:47:13 -07:00
Chef Expeditor
399b1cbdc1
Bump version to 4.7.22 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-23 02:38:02 +00:00
Chef Expeditor
22d8a6e7d2
Bump version to 4.7.21 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-22 21:39:44 +00:00
Ryan Davis
7a1e1bb775
Merge pull request #4230 from yeoldegrove/sys_info 
add resource sys_info.manufacturer and sys_info.model
 2019-07-22 14:39:28 -07:00
Ryan Davis
9f91b53193 Refactored and cleaned a minor bit in runner.rb 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-07-22 14:19:15 -07:00
Ryan Davis
d3df69213b Fix handling using resources with incompatible resources (eg file + aws). 
Signed-off-by: Ryan Davis <zenspider@chef.io>
 2019-07-22 14:19:15 -07:00
Chef Expeditor
f90255ab09
Bump version to 4.7.20 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-22 20:44:43 +00:00
Clinton Wolfe
7c251b6fd6
Suppress gem docs when installing plugins (#4286) 
Suppress gem docs when installing plugins
 2019-07-22 16:44:28 -04:00
Chef Expeditor
8247bf694f
Bump version to 4.7.19 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-22 19:29:50 +00:00
Clinton Wolfe
1c7c2a1e32 Pass option to skip installing documentation when installing plugins 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-07-22 15:17:30 -04:00
Clinton Wolfe
a31e0bcf5e Un-deprecate the be_running matcher on service resource 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-07-22 14:52:45 -04:00
John Snow
ea7956177a Fix tests to use only plan file 
Signed-off-by: John Snow <thelunaticscripter@outlook.com>
 2019-07-22 07:35:33 -04:00
John Snow
bbb809f703 Transition the Habitat plugin to use scaffolding 
Signed-off-by: John Snow <thelunaticscripter@outlook.com>
 2019-07-19 15:25:06 -04:00
Chef Expeditor
a804fd477d
Bump version to 4.7.18 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-18 01:46:12 +00:00
Chef Expeditor
2d4798b948
Bump version to 4.7.17 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-17 22:15:45 +00:00
Chef Expeditor
c37e69e0fc
Bump version to 4.7.16 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-17 21:25:52 +00:00
Eike Waldt
73f729e4b1
changed from system_profiler to sysctl on OSX 
(kudos to Petrik)

Signed-off-by: Eike Waldt <waldt@b1-systems.de>
 2019-07-16 21:53:15 +02:00
Eike Waldt
b47cf6e80e
change from dmidecode to /sys/class/dmi/id/* 
(kudos to Seife)

Signed-off-by: Eike Waldt <waldt@b1-systems.de>
 2019-07-16 21:53:03 +02:00
Eike Waldt
9fa97e8baa
use double quotes 
Signed-off-by: Eike Waldt <waldt@b1-systems.de>
 2019-07-16 21:02:53 +02:00
Eike Waldt
cf4c0f1ed3
fix copypasta 
Signed-off-by: Eike Waldt <waldt@b1-systems.de>
 2019-07-16 21:02:52 +02:00
Eike Waldt
2700018c58
hardcode "Apple Inc." vendor if on OSX 
Signed-off-by: Eike Waldt <waldt@b1-systems.de>
 2019-07-16 21:02:52 +02:00
Eike Waldt
64777457c9
use "system_profiler" instead of "dmidecode" on OSX 
Signed-off-by: Eike Waldt <waldt@b1-systems.de>
 2019-07-16 21:02:52 +02:00
Eike Waldt
c5fb5c0f9f
add resource sys_info.manufacturer and sys_info.model 
Signed-off-by: Eike Waldt <waldt@b1-systems.de>
 2019-07-16 20:39:38 +02:00
Chef Expeditor
354cf97e54
Bump version to 4.7.15 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-16 18:14:57 +00:00
Chef Expeditor
1cac2b3383
Bump version to 4.7.14 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-16 18:14:09 +00:00
Chef Expeditor
7d25e6ae05
Bump version to 4.7.13 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-16 18:10:43 +00:00
Chef Expeditor
7d627f8663
Bump version to 4.7.12 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-16 17:11:00 +00:00
Chef Expeditor
95ed2696e9
Bump version to 4.7.11 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-16 04:22:15 +00:00
Ryan Davis
ee3a989897
Merge pull request #4302 from TheLonelyGhost/fix-typo-in-exception-class-name 
Typo in class name (obvious fix)
 2019-07-15 22:21:58 -06:00
Chef Expeditor
92e88efcae
Bump version to 4.7.10 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-16 04:16:26 +00:00
David Alexander
56c81ee34e
Typo in class name (obvious fix) 
Signed-off-by: David Alexander <opensource@thelonelyghost.com>
 2019-07-15 17:00:37 -04:00
Chef Expeditor
f73b6b55f5
Bump version to 4.7.9 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-15 17:20:09 +00:00
Chef Expeditor
ca02539ccf
Bump version to 4.7.8 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-12 17:16:37 +00:00
Chef Expeditor
44a7d5412e
Bump version to 4.7.7 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-12 17:05:01 +00:00
Clinton Wolfe
389fd96920
chefstyle -a (#4276) 
chefstyle -a
 2019-07-12 13:04:46 -04:00
Chef Expeditor
bf74ea3995
Bump version to 4.7.6 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-10 19:58:14 +00:00
Chef Expeditor
cec4121152
Bump version to 4.7.5 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-10 04:50:17 +00:00
Chef Expeditor
80b1a209af
Bump version to 4.7.4 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-10 02:06:27 +00:00
Chef Expeditor
239ae17185
Bump version to 4.7.3 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-09 20:36:34 +00:00
Chef Expeditor
badb7e6b89
Bump version to 4.7.2 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-09 00:25:35 +00:00
Miah Johnson
a4f4fe5231 chefstyle -a; https://github.com/chef/chefstyle/pull/74 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-07-08 17:22:50 -07:00
Chef Expeditor
a0475c5069
Bump version to 4.7.1 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-08 19:03:37 +00:00
Chef Expeditor
ac30832933
Bump version to 4.7.0 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-08 18:45:48 +00:00
Miah Johnson
8272d0184b
Merge pull request #4236 from ramereth/ip6tables 
Add ip6tables resource
 2019-07-08 11:45:33 -07:00
Miah Johnson
fdf5f6f133
Merge pull request #4256 from inspec/cw/update-style-to-rubocop-0.72 
Automated chefstyle application for rubocop 0.72 compatibility
 2019-07-08 11:39:14 -07:00
Chef Expeditor
26825ca3d6
Bump version to 4.6.13 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-05 20:05:04 +00:00
Chef Expeditor
48262f68bd
Bump version to 4.6.12 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-03 23:40:51 +00:00
Chef Expeditor
90b109dff6
Bump version to 4.6.11 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-03 22:38:48 +00:00
Clinton Wolfe
e4e7c255de Automated chefstyle application for rubocop 0.72 compatibility 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-07-03 17:24:41 -04:00
James Stocks
3ef4092d39 Permit plugin to be in path with git ref 
Fixes #3904

Signed-off-by: James Stocks <jstocks@chef.io>
 2019-07-02 16:49:38 +01:00
Chef Expeditor
490824e6ce
Bump version to 4.6.10 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-02 06:39:18 +00:00
Miah Johnson
825751bdb9
Merge pull request #4233 from jaredledvina/patch-1 
Debian service detection for Buster
 2019-07-01 23:39:01 -07:00
Chef Expeditor
be237ad6ef
Bump version to 4.6.9 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-07-01 19:16:31 +00:00
Jerry Aldrich
668b8d82bf windows_task: Fix handling of multiple triggers 
When using `schtasks` a list is returned if the task has multiple
triggers. This merges that list with the last item taking precedence.
This is how `Get-ScheduledTask` behaves.

Initially, I was going to rewrite this resource to use
`Get-ScheduledTask` but the original author purposely did not do this
so that PowerShell v3 would be supported. We only support PowerShell
v5, but I don't want to break any current users and this change didn't
seem to controversial to me.

If it gives us trouble, I recommend rewriting it to use
`Get-ScheduledTask`.

Signed-off-by: Jerry Aldrich <jerryaldrichiii@gmail.com>
 2019-06-28 00:27:53 -07:00
Lance Albertson
3263d76627 Add ip6tables resource 
This should resolve #1011 which provides an ip6tables resource to test IPv6
iptables rules. This is essentially a copy of the iptables resource with a few
renames.

In addition, I've pulled in the integration tests for iptables into ip6tables
and enabled it on docker so that it properly gets tested regularly. The test
cookbook recipe has been updated to support all of the current platforms that
are being tested.

Signed-off-by: Lance Albertson <lance@osuosl.org>
 2019-06-24 17:01:34 -07:00
Jared Ledvina
0e1f31747b
Debian service detection for Buster 
Currently, /etc/debian_version for the Debian Buster/Sid release contains "buster/sid". This causes version to be set to 0 resulting in SysV being configured as the service provider incorrectly. This commit updates the debian detection logic to work for "buster/sid" as version 10 and makes sense that we have a non-0 version before setting the init system.

Signed-off-by: Jared Ledvina <jared@techsmix.net>
 2019-06-22 12:50:14 -04:00
Chef Expeditor
8bcbaf6967
Bump version to 4.6.8 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-06-22 00:14:38 +00:00
Chef Expeditor
47f887b8f9
Bump version to 4.6.7 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-06-21 20:01:58 +00:00
Chef Expeditor
9e426ab1e7
Bump version to 4.6.6 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-06-20 18:35:11 +00:00
Miah Johnson
9d7b651938
Merge pull request #4219 from inspec/mj/ucs 
`chefstyle -a` after merging #4156
 2019-06-19 13:51:47 -07:00
Miah Johnson
8e020f1b51 chefstyle -a after merging #4156 
Signed-off-by: Miah Johnson <miah@chia-pet.org>
 2019-06-19 13:34:17 -07:00
Chef Expeditor
3cd2ff51a9
Bump version to 4.6.5 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-06-19 20:33:41 +00:00
Miah Johnson
aa52697725
Merge branch 'master' into license-check 2019-06-19 11:46:23 -07:00
Chef Expeditor
07e53e72d0
Bump version to 4.6.4 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-06-19 00:55:37 +00:00
Jerry Aldrich
2d72cd5905 Modify line to be more idiomatic. 
Thanks @clintoncwolfe!

Signed-off-by: Jerry Aldrich <jerryaldrichiii@gmail.com>
 2019-06-18 08:05:57 -08:00
Jerry Aldrich
80c595ba3d nginx_conf: Fix commented/empty file parsing 
This fixes `nginx_conf.params` when:
  - Given an empty file
  - Given a file with only comments
  - Given a file that has an include for a file that:
    - Is empty
    - Has all lines commented out

This also fixes a test where a missing file is actually empty

Signed-off-by: Jerry Aldrich <jerryaldrichiii@gmail.com>
 2019-06-17 21:57:26 -08:00
Chef Expeditor
24b7c3a15b
Bump version to 4.6.3 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-06-17 17:00:38 +00:00
Chef Expeditor
8358ec5861
Bump version to 4.6.2 by Chef Expeditor 
Obvious fix; these changes are the result of automation not creative thinking.
 2019-06-17 16:29:26 +00:00
Clinton Wolfe
a2dcb9fbea Manually sync lib version files for sanity's sake 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-06-17 11:26:53 -04:00
Clinton Wolfe
4ce2192678 Impactful KPI upswing 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-06-12 19:09:11 -04:00
Clinton Wolfe
5a4cbe2c17 Add missing param 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-06-12 19:05:48 -04:00
Clinton Wolfe
4aa805c7ad Linting 
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
 2019-06-12 19:05:48 -04:00