Nick Schwaderer
87d7978340
Merge pull request #5001 from inspec/ns/investigate_waivers_and_namespace_clashing
...
Allows input and control to have the same name
2020-05-05 11:28:03 +01:00
Nick Schwaderer
a1129f9efc
Allows input and control to have the same name
...
In https://github.com/inspec/inspec/issues/4936 the issue was reported that naming an input the same as a control caused an unexpected failure.
In that particular case, the naming was a result of a pre-waivers workaround which is no longer necessary, but ultimately a breakage of that name clash is an unexpected occurrance.
Due to how inputs are named and registered, `__apply_waivers` thinks that an object is a waiver that is not a waiver and tries to process it. On the micro level, it breaks when trying to pass a variable to a string as if it were a Hash.
It is imperative that we preserve 100% of the current featureset, pass our tests, and fix this edge case along with new test coverage for the failure.
This PR updates the code to do a slightly more elegant and small ‘waiver check’ to stop the namespace clash from breaking our code.
Signed-off-by: Nick Schwaderer <nschwaderer@chef.io>
2020-05-05 10:00:19 +01:00
Chef Expeditor
3616ac21dc
Bump version to 4.18.110 by Chef Expeditor
...
Obvious fix; these changes are the result of automation not creative thinking.
2020-05-04 16:01:32 +00:00
James Stocks
b22e97de5c
Merge pull request #5010 from devopsdina/automate-reporter-json
...
Updating automate reporter example config to valid json
2020-05-04 17:01:16 +01:00
Clinton Wolfe
4c3a0aa4d7
Add comment tracking when reporters will migrate
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-05-04 11:52:17 -04:00
James Stocks
69fb6e0782
Move reporter option handling to base
...
They don't need to be json specific, they should apply to any reporter if the user has chosen these settings.
Signed-off-by: James Stocks <jstocks@chef.io>
2020-05-04 15:24:50 +01:00
James Stocks
ae66aee2b2
(WIP) Reporter options to truncate message and suppress stacktrace
...
TODO: Option names are not JSON specific but only json reporter has been implemented.
Signed-off-by: James Stocks <jstocks@chef.io>
2020-05-04 15:24:50 +01:00
James Stocks
5b0fdfec89
Merge pull request #5009 from james-stocks/js/windows_skip
...
Push Windows test skipping for 2 more months
2020-05-04 15:24:23 +01:00
James Stocks
e4fd110ff4
Push Windows test skipping for 2 more months
...
There are open issues for the failng cases and they are in our priority list.
https://github.com/inspec/inspec/issues?q=is%3Aopen+label%3A%22Aspect%3A+Testing%22+label%3A%22Platform%3A+Windows%22
Signed-off-by: James Stocks <jstocks@chef.io>
2020-05-04 14:55:51 +01:00
Clinton Wolfe
4cb613400f
Advance windows test skip timebomb to beginning of 3rd quarter 2020
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-05-02 14:08:26 -04:00
Clinton Wolfe
510c7d847d
Linting, and a thinko
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-05-02 14:04:55 -04:00
Clinton Wolfe
8f7ecbb503
Add docs for reporter plugins
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-05-02 00:23:41 -04:00
Clinton Wolfe
63d95b6b6b
Basics of a working reporter plugin system
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-05-01 23:48:05 -04:00
Dina Muscanell
1da222a092
updating automate reporter example config to valid json; Signed-off-by: Dina Muscanell <dmuscanell@chef.io>
2020-05-01 14:03:16 -04:00
Chef Expeditor
2e887a94af
Bump version to 4.18.109 by Chef Expeditor
...
Obvious fix; these changes are the result of automation not creative thinking.
2020-05-01 14:22:05 +00:00
Nick Schwaderer
d5d9352897
Merge pull request #4995 from inspec/cw/late-warn-on-no-value
...
Fix for warning when input is provided
2020-05-01 15:21:47 +01:00
Clinton Wolfe
5a7ad0c352
Don't be obnoxious
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-04-30 15:36:25 -04:00
Chef Expeditor
7f77c101d2
Executed '.expeditor/update_dockerfile.sh'
...
Obvious fix; these changes are the result of automation not creative thinking.
2020-04-27 08:58:05 +00:00
Clinton Wolfe
131d6678de
Fix for prematurely warning when checking for input value
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-04-24 16:38:57 -04:00
Clinton Wolfe
58e8bc5167
Divide tests into undeclared and required groups
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-04-24 16:38:11 -04:00
Clinton Wolfe
e88dab4365
Update message when input has no value
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-04-24 14:13:07 -04:00
Clinton Wolfe
a12dfcfdc0
Add a failing test case for 4769
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-04-24 13:57:28 -04:00
Chef Expeditor
b46b68ccd1
Bump version to 4.18.108 by Chef Expeditor
...
Obvious fix; these changes are the result of automation not creative thinking.
2020-04-23 15:18:13 +00:00
James Stocks
14a85eba93
Merge pull request #4992 from inspec/ns/bump_method_source_version
...
Bumps method_source dependency version
2020-04-23 16:17:52 +01:00
Clinton Wolfe
b2deb9a4c1
Pin pry to ~> 0.13 to get Pry::Prompt new API to avoid deprecation warning
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-04-22 14:57:22 -04:00
Chef Expeditor
9200fec420
Bump version to 4.18.107 by Chef Expeditor
...
Obvious fix; these changes are the result of automation not creative thinking.
2020-04-22 15:24:06 +00:00
James Stocks
c35657bf43
Merge pull request #4983 from jvogt/docs-config-json-fix
...
Docs fix - config.json example missing indentation and closing brace
2020-04-22 16:23:46 +01:00
James Stocks
836ef745be
Merge pull request #4969 from inspec/csnapp/add_ubuntu2004
...
Add Ubuntu 20.04 x86_64 support
2020-04-22 09:20:10 +01:00
Chef Expeditor
842d276bd3
Bump version to 4.18.106 by Chef Expeditor
...
Obvious fix; these changes are the result of automation not creative thinking.
2020-04-22 08:10:56 +00:00
James Stocks
e7d9a79d5b
Merge pull request #4990 from TheLunaticScripter/tls/add_debug_a2_login
...
Add additional debug logging for automate login
2020-04-22 09:10:33 +01:00
Clinton Wolfe
dc5f8f1f64
Loosen gemspec constraint on method_source per tas50
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-04-21 16:43:06 -04:00
Clinton Wolfe
ad7569103e
Alter inspec shell prompt to silence deprecation warning
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-04-21 16:38:21 -04:00
Clinton Wolfe
913dcac4b3
Alter call into Pry::Output to match new API and get shell tests passing
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-04-21 15:36:08 -04:00
Clinton Wolfe
a3ea5acb3f
Merge pull request #4980 from paul1994/pb/doc_fix
...
Fixed inputs example to display correct output when the same code is …
2020-04-21 11:56:42 -04:00
Nick Schwaderer
4021bb3c62
Bumps method_source dependency version
...
The `method_source` dependency for inspec-core has not been bumped in
five years, and it is indirectly holding `pry` back elsewhere in the
ecosystem which is causing issues for ruby 2.7+ support.
Signed-off-by: Nick Schwaderer <nschwaderer@chef.io>
2020-04-21 15:39:28 +01:00
John Snow
8d676f6ed2
Fix typo's after review
...
Signed-off-by: John Snow <thelunaticscripter@outlook.com>
2020-04-20 09:50:58 -04:00
John Snow
03c012e3c9
Add additional debug logging for automate login
...
Signed-off-by: John Snow <thelunaticscripter@outlook.com>
2020-04-17 15:50:40 -04:00
Chef Expeditor
6292462f14
Update CHANGELOG.md with details from pull request #4974
...
Obvious fix; these changes are the result of automation not creative thinking.
2020-04-15 08:39:56 +00:00
James Stocks
1a995a6e74
Merge pull request #4974 from inspec/cw/release-docs-2
...
Release process documentation
2020-04-15 09:39:42 +01:00
Jeff Vogt
156ac119e5
fix example config.json syntax
...
Obvious fix.
2020-04-13 08:33:00 -07:00
Seth Chisamore
3aed2eb54d
Merge pull request #4975 from inspec/schisamo/use-discourse-helper-function
...
Use Expeditor's built in Bash helper to post release announcement
2020-04-10 13:22:26 -04:00
Christopher A. Snapp
7f851059c8
Add Ubuntu 20.04 x86_64 support
...
Signed-off-by: Christopher A. Snapp <csnapp@chef.io>
2020-04-09 12:24:36 -06:00
Paul Bradford
c7f2c18305
Fixed inputs example to display correct output when the same code is ran.
...
updated output example
Signed-off-by: Paul Bradford <pbradford@chef.io>
2020-04-09 09:37:50 -07:00
Chef Expeditor
7fa8d1ca68
Bump version to 4.18.105 by Chef Expeditor
...
Obvious fix; these changes are the result of automation not creative thinking.
2020-04-09 16:18:16 +00:00
Clinton Wolfe
4f61e37395
Fixes for tests under ruby 2.7 ( #4970 )
...
Fixes for tests under ruby 2.7
2020-04-09 12:17:53 -04:00
Seth Chisamore
f1aa8917fe
Use Expeditor's built in Bash helper to post release announcement
...
Signed-off-by: Seth Chisamore <schisamo@chef.io>
2020-04-08 13:43:46 -04:00
Clinton Wolfe
1d8693670e
Release process documentation
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-04-08 12:56:01 -04:00
Clinton Wolfe
a8b04769ca
Ignore deprecation warning in fileutils and rubygems gems under ruby 2.7
...
Signed-off-by: Clinton Wolfe <clintoncwolfe@gmail.com>
2020-04-08 10:56:55 -04:00
Chef Expeditor
ab131eff65
Executed '.expeditor/update_dockerfile.sh'
...
Obvious fix; these changes are the result of automation not creative thinking.
2020-04-08 09:47:26 +00:00
Chef Expeditor
c6f09eb6fb
Bump version to 4.18.104 by Chef Expeditor
...
Obvious fix; these changes are the result of automation not creative thinking.
2020-04-07 12:04:57 +00:00