Mirrors/fish-shell
2
0
Fork 0
mirror of https://github.com/fish-shell/fish-shell synced 2024-12-29 06:13:20 +00:00
Code Issues Projects Releases Packages Wiki Activity

Disable history race test on Github Actions

Browse source 
Same as ever: Flaky test, makes reviews more annoying. It should be
fixed, but until that happens it's better not to have it fail in
unrelated PRs.
This commit is contained in:
Fabian Homborg 2022-03-05 18:36:26 +01:00
parent 456359f78d
commit c1900ed41c
1 changed files with 8 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/fish_tests.cpp
View file

@ -4387,6 +4387,14 @@ void history_tests_t::test_history_races() {
return;
}
// This fails too often on Github Actions,
// leading to a bunch of spurious test failures on unrelated PRs.
// For now it's better to disable it.
// TODO: Figure out *why* it does that and fix it.
if (getenv("CI")) {
return;
}
say(L"Testing history race conditions");
// It appears TSAN and ASAN's allocators do not release their locks properly in atfork, so