From c1900ed41cc1afe4b710f6194e95604a81363b3c Mon Sep 17 00:00:00 2001 From: Fabian Homborg Date: Sat, 5 Mar 2022 18:36:26 +0100 Subject: [PATCH] Disable history race test on Github Actions Same as ever: Flaky test, makes reviews more annoying. It should be fixed, but until that happens it's better not to have it fail in unrelated PRs. --- src/fish_tests.cpp | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/src/fish_tests.cpp b/src/fish_tests.cpp index 646cfcdac..94221bf12 100644 --- a/src/fish_tests.cpp +++ b/src/fish_tests.cpp @@ -4387,6 +4387,14 @@ void history_tests_t::test_history_races() { return; } + // This fails too often on Github Actions, + // leading to a bunch of spurious test failures on unrelated PRs. + // For now it's better to disable it. + // TODO: Figure out *why* it does that and fix it. + if (getenv("CI")) { + return; + } + say(L"Testing history race conditions"); // It appears TSAN and ASAN's allocators do not release their locks properly in atfork, so