Mirrors/fish-shell
2
0
Fork 0
mirror of https://github.com/fish-shell/fish-shell synced 2025-01-14 05:53:59 +00:00
Code Issues Projects Releases Packages Wiki Activity

Revert "Explicitly close input fd to fish_title"

Browse source 
This reverts commit b247c8d9ad.

It breaks the title entirely.

[ci skip]
This commit is contained in:
Fabian Homborg 2019-02-18 15:01:07 +01:00
parent 7958e1d5c4
commit 11009de431
1 changed files with 0 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/reader.cpp
View file

@ -829,12 +829,6 @@ void reader_write_title(const wcstring &cmd, bool reset_cursor_position) {
fish_title_command.append( fish_title_command.append(
escape_string(cmd, ESCAPE_ALL | ESCAPE_NO_QUOTED | ESCAPE_NO_TILDE)); escape_string(cmd, ESCAPE_ALL | ESCAPE_NO_QUOTED | ESCAPE_NO_TILDE));
} }
// `fish_title` is executed in a non-interactive context and attempts at reading
// from within that function will cause problems ranging segfaults, SIGTTIN
// deadlocks, or infinite loops - we explicitly close the input fd to safeguard
// against such a scenario.
fish_title_command.append(L"<&-");
} }
wcstring_list_t lst; wcstring_list_t lst;