From 11009de431fcad5b8e8fc55b3903811290062200 Mon Sep 17 00:00:00 2001 From: Fabian Homborg Date: Mon, 18 Feb 2019 15:01:07 +0100 Subject: [PATCH] Revert "Explicitly close input fd to `fish_title`" This reverts commit b247c8d9ada92c4d039453a551b83cc0ff40724e. It breaks the title entirely. [ci skip] --- src/reader.cpp | 6 ------ 1 file changed, 6 deletions(-) diff --git a/src/reader.cpp b/src/reader.cpp index 413f6f660..34b0df044 100644 --- a/src/reader.cpp +++ b/src/reader.cpp @@ -829,12 +829,6 @@ void reader_write_title(const wcstring &cmd, bool reset_cursor_position) { fish_title_command.append( escape_string(cmd, ESCAPE_ALL | ESCAPE_NO_QUOTED | ESCAPE_NO_TILDE)); } - - // `fish_title` is executed in a non-interactive context and attempts at reading - // from within that function will cause problems ranging segfaults, SIGTTIN - // deadlocks, or infinite loops - we explicitly close the input fd to safeguard - // against such a scenario. - fish_title_command.append(L"<&-"); } wcstring_list_t lst;