Mirrors/fish-shell
2
0
Fork 0
mirror of https://github.com/fish-shell/fish-shell synced 2024-12-29 14:23:09 +00:00
Code Issues Projects Releases Packages Wiki Activity
fish-shell/tests/checks/pipeline-pgroup.fish

71 lines
2.3 KiB
Fish
Raw Normal View History

Extended & human-friendly keys See the changelog additions for user-visible changes. Since we enable/disable terminal protocols whenever we pass terminal ownership, tests can no longer run in parallel on the same terminal. For the same reason, readline shortcuts in the gdb REPL will not work anymore. As a remedy, use gdbserver, or lobby for CSI u support in libreadline. Add sleep to some tests, otherwise they fall (both in CI and locally). There are two weird failures on FreeBSD remaining, disable them for now https://github.com/fish-shell/fish-shell/pull/10359/checks?check_run_id=23330096362 Design and implementation borrows heavily from Kakoune. In future, we should try to implement more of the kitty progressive enhancements. Closes #10359
2024-03-30 15:10:12 +00:00
# RUN: env fth=%fish_test_helper fish=%fish %fish %s | %filter-ctrlseqs
Add a test to verify that processes get the right pgrps in pipelines
2019-12-08 21:28:30 +00:00
Revert "Revert "Enable job-control in pipeline-pgroup test"" This reverts commit c9f450a93eb19c2e2d641dc93d26975990909143. Puts back job-control in this test.
2020-03-02 22:01:59 +00:00
status job-control full
Add a test to verify that processes get the right pgrps in pipelines
2019-12-08 21:28:30 +00:00
# Ensure that lots of nested jobs all end up in the same pgroup.
function save_pgroup -a var_name
$fth print_pgrp | read -g $var_name
end
# Here everything should live in the pgroup of the first fish_test_helper.
Run fish_indent on all our fish scripts It's now good enough to do so. We don't allow grid-alignment: ```fish complete -c foo -s b -l barnanana -a '(something)' complete -c foo -s z -a '(something)' ``` becomes ```fish complete -c foo -s b -l barnanana -a '(something)' complete -c foo -s z -a '(something)' ``` It's just more trouble than it is worth. The one part I'd change: We align and/or'd parts of an if-condition with the in-block code: ```fish if true and false dosomething end ``` becomes ```fish if true and false dosomething end ``` but it's not used terribly much and if we ever fix it we can just reindent.
2020-01-13 19:34:22 +00:00
$fth print_pgrp | read -g global_group | save_pgroup g1 | begin
save_pgroup g2
Thread pgroups into command substitutions Give string expansion an (optional) parent pgroup. This is threaded all the way into eval(). This ensures that in a mixed pipeline like: cmd | begin ; something (cmd2) ; end that cmd2 and cmd have the same pgroup. Add a test to ensure that command substitutions inherit pgroups properly. Fixes #6624
2020-03-11 18:06:52 +00:00
end | begin
echo (save_pgroup g3) >/dev/null
Run fish_indent on all our fish scripts It's now good enough to do so. We don't allow grid-alignment: ```fish complete -c foo -s b -l barnanana -a '(something)' complete -c foo -s z -a '(something)' ``` becomes ```fish complete -c foo -s b -l barnanana -a '(something)' complete -c foo -s z -a '(something)' ``` It's just more trouble than it is worth. The one part I'd change: We align and/or'd parts of an if-condition with the in-block code: ```fish if true and false dosomething end ``` becomes ```fish if true and false dosomething end ``` but it's not used terribly much and if we ever fix it we can just reindent.
2020-01-13 19:34:22 +00:00
end
Add a test to verify that processes get the right pgrps in pipelines
2019-12-08 21:28:30 +00:00
Thread pgroups into command substitutions Give string expansion an (optional) parent pgroup. This is threaded all the way into eval(). This ensures that in a mixed pipeline like: cmd | begin ; something (cmd2) ; end that cmd2 and cmd have the same pgroup. Add a test to ensure that command substitutions inherit pgroups properly. Fixes #6624
2020-03-11 18:06:52 +00:00
[ "$global_group" -eq "$g1" ] && [ "$g1" -eq "$g2" ] && [ "$g2" -eq "$g3" ]
Add a test to verify that processes get the right pgrps in pipelines
2019-12-08 21:28:30 +00:00
and echo "All pgroups agreed"
Thread pgroups into command substitutions Give string expansion an (optional) parent pgroup. This is threaded all the way into eval(). This ensures that in a mixed pipeline like: cmd | begin ; something (cmd2) ; end that cmd2 and cmd have the same pgroup. Add a test to ensure that command substitutions inherit pgroups properly. Fixes #6624
2020-03-11 18:06:52 +00:00
or echo "Pgroups disagreed. Should be in $global_group but found $g1, $g2, $g3"
Add a test to verify that processes get the right pgrps in pipelines
2019-12-08 21:28:30 +00:00
# CHECK: All pgroups agreed
# Here everything should live in fish's pgroup.
# Unfortunately we don't know what fish's pgroup is (it may not be fish's pid).
# So run it twice and verify that everything agrees; this implies that it could
# not have used any of the pids of the child procs.
Run fish_indent on all our fish scripts It's now good enough to do so. We don't allow grid-alignment: ```fish complete -c foo -s b -l barnanana -a '(something)' complete -c foo -s z -a '(something)' ``` becomes ```fish complete -c foo -s b -l barnanana -a '(something)' complete -c foo -s z -a '(something)' ``` It's just more trouble than it is worth. The one part I'd change: We align and/or'd parts of an if-condition with the in-block code: ```fish if true and false dosomething end ``` becomes ```fish if true and false dosomething end ``` but it's not used terribly much and if we ever fix it we can just reindent.
2020-01-13 19:34:22 +00:00
function nothing
end
nothing | $fth print_pgrp | read -g a0 | save_pgroup a1 | begin
save_pgroup a2
end
nothing | $fth print_pgrp | read -g b0 | save_pgroup b1 | begin
save_pgroup b2
end
Add a test to verify that processes get the right pgrps in pipelines
2019-12-08 21:28:30 +00:00
[ "$a0" -eq "$a1" ] && [ "$a1" -eq "$a2" ] \
Run fish_indent on all our fish scripts It's now good enough to do so. We don't allow grid-alignment: ```fish complete -c foo -s b -l barnanana -a '(something)' complete -c foo -s z -a '(something)' ``` becomes ```fish complete -c foo -s b -l barnanana -a '(something)' complete -c foo -s z -a '(something)' ``` It's just more trouble than it is worth. The one part I'd change: We align and/or'd parts of an if-condition with the in-block code: ```fish if true and false dosomething end ``` becomes ```fish if true and false dosomething end ``` but it's not used terribly much and if we ever fix it we can just reindent.
2020-01-13 19:34:22 +00:00
&& [ "$b0" -eq "$b1" ] && [ "$b1" -eq "$b2" ] \
&& [ "$a0" -eq "$b0" ]
Add a test to verify that processes get the right pgrps in pipelines
2019-12-08 21:28:30 +00:00
and echo "All pgroups agreed"
or echo "Pgroups disagreed. Found $a0 $a1 $a2, and $b0 $b1 $b2"
# CHECK: All pgroups agreed
Rationalize background-in-background procs If a background process runs a fish function which launches another background process, ensure that these background procs get different pgroups. Add a test for it.
2020-02-20 19:18:36 +00:00
Thread pgroups into builtin_eval Ensure that if eval is invoked as part of a pipeline, any jobs spawned by eval will have the same pgroup as the parent job. Partially fixes #6806
2020-04-26 00:11:36 +00:00
# Ensure that eval retains pgroups - #6806.
Reenable pgroup eval test in more robust form This re-enables the test that eval retains pgroups, from #6806. The old version was racey and failed a lot. In the new version, we use temp files to resolve the race.
2020-09-13 20:18:01 +00:00
set -l tmpfile1 (mktemp)
set -l tmpfile2 (mktemp)
$fth print_pgrp > $tmpfile1 | eval '$fth print_pgrp > $tmpfile2'
read -l pgrp1 < $tmpfile1
read -l pgrp2 < $tmpfile2
[ "$pgrp1" -eq "$pgrp2" ]
and echo "eval pgroups agreed"
or echo "eval pgroups disagreed, meaning eval does not retain pgroups: $pgrp1 $pgrp2"
# CHECK: eval pgroups agreed
Use temporary files for the background job pgroup test This also reduces the likelihood of a race.
2020-09-13 20:23:56 +00:00
echo -n > $tmpfile1
echo -n > $tmpfile2
Thread pgroups into builtin_eval Ensure that if eval is invoked as part of a pipeline, any jobs spawned by eval will have the same pgroup as the parent job. Partially fixes #6806
2020-04-26 00:11:36 +00:00
Rationalize background-in-background procs If a background process runs a fish function which launches another background process, ensure that these background procs get different pgroups. Add a test for it.
2020-02-20 19:18:36 +00:00
# Ensure that if a background job launches another background job, that they have different pgroups.
# Our regex will capture the first pgroup and use a negative lookahead on the second.
status job-control full
Use temporary files for the background job pgroup test This also reduces the likelihood of a race.
2020-09-13 20:23:56 +00:00
$fth print_pgrp > $tmpfile1 | begin
$fth print_pgrp > $tmpfile2 &
wait
Rationalize background-in-background procs If a background process runs a fish function which launches another background process, ensure that these background procs get different pgroups. Add a test for it.
2020-02-20 19:18:36 +00:00
end &
wait
Use temporary files for the background job pgroup test This also reduces the likelihood of a race.
2020-09-13 20:23:56 +00:00
read -l pgrp1 < $tmpfile1
read -l pgrp2 < $tmpfile2
[ "$pgrp1" -ne "$pgrp2" ]
and echo "background job correctly got new pgroup"
or echo "background job did not get new pgroup: $pgrp1 $pgrp2"
# CHECK: background job correctly got new pgroup
rm $tmpfile1 $tmpfile2
Reference in a new issue Copy permalink