Evan Almloff
e4c7218fe8
make dioxus an optional dependancy
2023-02-04 20:45:29 -06:00
Evan Almloff
5087429cff
Merge branch 'upstream' into simplify-native-core
2023-02-04 17:57:46 -06:00
Evan Almloff
6fe00c4f78
make dioxus dependancy optional
2023-02-04 17:56:30 -06:00
Evan Almloff
8dde4e492f
finish migrating tests
2023-02-02 14:48:02 -06:00
Evan Almloff
c8eb5c7dd7
update native core tests
2023-02-02 14:26:59 -06:00
Evan Almloff
6cf0274a5b
expose listener methods
2023-02-02 14:26:47 -06:00
Marc Espín
d521da1991
Remove unnecessary 'static lifetime ( #812 )
2023-02-02 14:25:20 -06:00
Evan Almloff
2f6b8393f8
make parallelism optional
2023-02-02 08:57:23 -06:00
Evan Almloff
687cdf2cac
use thread pool
2023-02-02 07:08:29 -06:00
Evan Almloff
d67b21c0e9
improve performance
2023-02-01 20:45:11 -06:00
Evan Almloff
71a0bdf71d
TUI rendering mostly working
2023-02-01 14:36:56 -06:00
Evan Almloff
39a3db68bd
fix deadlock
2023-02-01 14:15:17 -06:00
Evan Almloff
5eb4ca677d
don't panic when trying to get information about a node that does not exist
2023-02-01 13:59:08 -06:00
Evan Almloff
ea46db0966
enable hydration feature in dev-dependancies
2023-01-31 14:19:19 -06:00
Evan Almloff
9baef6bcd9
always load the templates in hydration
2023-01-31 14:18:34 -06:00
Evan Almloff
696109db10
implement hydration
2023-01-31 14:10:48 -06:00
Jon Kelley
e9dd5a94c7
Merge pull request #807 from Demonthos/add-use-memo
2023-01-29 21:01:54 -08:00
Evan Almloff
0058c7ed32
create a way to create states
2023-01-29 20:28:29 -06:00
Evan Almloff
c7e957d6f9
add use_memo
2023-01-29 15:57:40 -06:00
Jon Kelley
98c2e6ec5f
Merge pull request #805 from amindWalker/liveview-shuttle
...
`chore:` change `tokio` to support `shuttle-service`
2023-01-29 12:12:56 -08:00
Evan Almloff
65be035506
only add non-static components to the borrowed_props list
2023-01-29 11:53:52 -06:00
Evan Almloff
2c205f8ca5
fix some type bounds
2023-01-29 09:17:06 -06:00
Evan Almloff
d53bfb6c56
Merge branch 'upstream' into simplify-native-core
2023-01-28 18:49:19 -06:00
Breno Rocha
8d470ceb78
chore: change tokio
to support shuttle-service
2023-01-28 20:20:22 -03:00
Evan Almloff
a74a3b1925
add remaining passes
2023-01-28 15:54:02 -06:00
Evan Almloff
ec31014966
fix clippy in TUI
2023-01-28 15:06:03 -06:00
Evan Almloff
9efff74c0c
update TUI renderer to new approach
2023-01-28 14:51:05 -06:00
Jonathan Kelley
4f83c1b86d
Merge branch 'master' of github.com:DioxusLabs/dioxus
2023-01-27 23:27:36 -08:00
Jonathan Kelley
6fde323112
bump core version
2023-01-27 23:27:28 -08:00
Evan Almloff
b6c7d44a27
fix clippy
2023-01-27 20:35:46 -06:00
Anatolii Kurotych
624f32115b
Fix release build ( #802 )
2023-01-27 20:07:00 -06:00
Evan Almloff
51ca23b3f7
fix drag serialization on desktop
2023-01-25 20:44:42 -06:00
Evan Almloff
ce59ccfd44
enable multithreading
2023-01-23 21:03:28 -06:00
Jon Kelley
1b597f43d1
Merge pull request #754 from Demonthos/desktop-hot-reload
...
Implement hot reloading for Desktop, TUI, and Liveview
2023-01-23 09:48:54 -10:00
Jonathan Kelley
b5c7d5cfd9
chore: use 0.2 of bumpslab
2023-01-23 11:45:18 -08:00
Evan Almloff
a0441f686c
use main bumpslab branch
2023-01-23 12:48:00 -06:00
Evan Almloff
82e2175500
make entry key return scopeid
2023-01-23 10:08:11 -06:00
Evan Almloff
bdb63d18f3
try a different branch
2023-01-23 08:25:08 -06:00
Evan Almloff
00a9ad29a8
fix memory leak
2023-01-22 21:24:30 -06:00
Evan Almloff
c5f003e41e
use git version of bump slab
2023-01-22 21:07:54 -06:00
Evan Almloff
3279068569
clean up view code
2023-01-22 21:06:59 -06:00
Evan Almloff
ae028d82f8
use bump slab
2023-01-22 17:16:34 -06:00
Evan Almloff
4738352955
remove native-core-macro
2023-01-22 16:41:15 -06:00
Evan Almloff
ba79d4babd
don't-box-scopestates
2023-01-22 15:05:32 -06:00
Evan Almloff
fb0c6c1b62
Merge branch 'upstream' into simplify-native-core
2023-01-21 18:33:52 -06:00
Evan Almloff
0a5499508a
simplify api and pass clippy
2023-01-21 18:30:42 -06:00
Evan Almloff
7294edcd89
Merge branch 'upstream' into add-fuzzing-to-native-core
2023-01-21 07:45:39 -06:00
Evan Almloff
adff97036d
clean up some unused code + clippy
2023-01-21 07:44:38 -06:00
Jon Kelley
e686e42cfe
Merge pull request #790 from Demonthos/make-cursor-agnostic-over-storage
...
Make text editing utilities in native core agnostic over the text storage
2023-01-21 00:40:16 -08:00
Jon Kelley
877268737d
Merge pull request #791 from Demonthos/default-to-medium-border-width-when-style-is-set
...
Apply medium width when the border style is not none to match browsers
2023-01-21 00:37:26 -08:00
Evan Almloff
e81f05fe9d
make native core compile
2023-01-20 20:24:44 -06:00
Evan Almloff
20751327f3
apply medium width when the border style is not none to comply with browser behavior
2023-01-20 17:36:41 -06:00
Evan Almloff
d019ada3da
make delete selection public
2023-01-20 17:16:47 -06:00
Evan Almloff
8030ae5581
make text editing utilites agnostic over the text storage
2023-01-20 17:09:19 -06:00
Evan Almloff
278cac6551
pass clippy
2023-01-20 13:42:50 -06:00
Evan Almloff
dc768fee2f
fix replacing a dynamic text node in native core
2023-01-20 13:31:21 -06:00
Evan Almloff
04bf6c3f91
add fuzzing test to native core
2023-01-20 13:28:49 -06:00
Evan Almloff
ebb6300fc7
clean up the API
2023-01-20 13:23:26 -06:00
Evan Almloff
1587b41829
WIP make ECS work with reactive system
2023-01-19 14:40:56 -06:00
Evan Almloff
e36874d86e
use node id
2023-01-18 12:14:59 -06:00
Jon Kelley
f65b051102
Merge pull request #751 from Demonthos/expose-event-handle-desktop
...
Create with_event_handler to expose window event on desktop
2023-01-17 20:47:15 -08:00
Jonathan Kelley
e63226e15b
Merge branch 'master' of github.com:DioxusLabs/dioxus
2023-01-17 16:24:36 -08:00
Jonathan Kelley
4e4e101eee
fix: dont choke on emojji n exprs
2023-01-17 16:24:29 -08:00
Jonathan Kelley
07447fd756
Fix 782 - inline props should use cx token
2023-01-17 15:50:04 -08:00
Jon Kelley
ae1a618aa8
Merge pull request #780 from DioxusLabs/jk/dioxus-fmt
...
fix: short expr lists should not eat the final exprs
2023-01-17 13:01:51 -08:00
Jonathan Kelley
61b8a25ad8
make clippy happy
2023-01-17 10:51:23 -08:00
Jonathan Kelley
b81eca0433
fix: short expr lists should not eat the final exprs
2023-01-16 17:25:55 -08:00
Jon Kelley
ab967bb3d7
Merge pull request #779 from DioxusLabs/jk/dioxus-fmt
...
fix: immediate exprs in autofmt
2023-01-16 16:56:01 -08:00
Jonathan Kelley
b6e4db1f2f
fix: immediate exprs
2023-01-16 16:36:50 -08:00
Evan Almloff
91fc594708
ECS based tree data struture
2023-01-16 14:33:11 -06:00
Evan Almloff
5aa3587ea9
Merge branch 'upstream' into simplify-native-core
2023-01-16 13:05:34 -06:00
Evan Almloff
8548b324f1
fix dropping nested scopes
2023-01-15 21:23:49 -06:00
Evan Almloff
3f3db39c28
update doc links
2023-01-15 15:18:12 -06:00
Evan Almloff
d13d1fb1c9
Merge branch 'upstream' into fix-future-on-dropped-scope
2023-01-15 14:01:11 -06:00
Evan Almloff
d7f9a07f4e
fix
2023-01-15 13:52:06 -06:00
Jonathan Kelley
69a347a551
fix: scopes not dropping their hooks
2023-01-15 10:02:24 -08:00
Evan Almloff
60219d3f65
formatting
2023-01-15 12:01:12 -06:00
Evan Almloff
418d8b1c30
clippy
2023-01-15 11:51:17 -06:00
Evan Almloff
893d0be1a6
add option to specify a callback to make using hot-reloading in a CLI easier
2023-01-15 11:29:51 -06:00
Evan Almloff
70590c6af0
pass clippy
2023-01-14 16:07:13 -06:00
Jonathan Kelley
a45f16a773
chore: clean up comments
2023-01-14 11:57:36 -08:00
Jonathan Kelley
ecaa68605d
fix: trim start matches for events
2023-01-14 11:57:03 -08:00
Jonathan Kelley
441bd910f9
Merge branch 'master' into jk/fix-listener-indx
2023-01-14 00:43:10 -08:00
Jonathan Kelley
aa0f6812fa
fix ci around autofmt
2023-01-14 00:42:43 -08:00
Jonathan Kelley
40a36aa8e6
chore: use trim
2023-01-14 00:21:26 -08:00
Jonathan Kelley
8d59c626ea
fix: listeners should not use hard indexing
2023-01-14 00:19:37 -08:00
Jonathan Kelley
270de7a0d2
fmt
2023-01-13 18:03:16 -08:00
Jonathan Kelley
3945928c59
fix: adjust padding on autofmt
2023-01-13 17:16:06 -08:00
Jonathan Kelley
0b110075ef
chore: remvoe todos hiding in autofmt
2023-01-13 17:05:45 -08:00
Jonathan Kelley
9f9bcd747a
chore: fewer clones in autoformat infrastructure
2023-01-13 16:58:53 -08:00
Jonathan Kelley
ea032eeb8e
clean up macro crate a little bit
2023-01-13 16:52:37 -08:00
Jonathan Kelley
ac6035cb2a
feat: parse entire file instead of hunting for verbtain
2023-01-13 16:46:34 -08:00
Evan Almloff
63840bcca4
pass clippy
2023-01-13 17:55:11 -06:00
Evan Almloff
0c6750d177
fix dependancies
2023-01-13 17:50:32 -06:00
Evan Almloff
8a7cee529c
Merge branch 'upstream' into desktop-hot-reload
2023-01-13 17:43:32 -06:00
Evan Almloff
33c1b4e98f
Merge branch 'upstream' into desktop-hot-reload
2023-01-13 17:34:22 -06:00
Evan Almloff
80755e1d55
remove debug log
2023-01-13 17:32:31 -06:00
Evan Almloff
34c8ad8849
fix gitignore performance issues
2023-01-13 17:31:55 -06:00
Evan Almloff
31e21aaa79
change rebuild_handler to rebuild_command
2023-01-13 17:15:06 -06:00
Evan Almloff
22f86ed464
update docs
2023-01-13 16:57:27 -06:00
Evan Almloff
d642e53a2b
intigrate with .gitignore
2023-01-13 16:25:03 -06:00
Evan Almloff
cc983dc091
rebuild when the cargo.toml changes
2023-01-13 16:17:25 -06:00
Evan Almloff
b3d119b815
Provide option to do full rebuilds when nessisary
2023-01-13 16:13:07 -06:00
Jonathan Kelley
bf559a6d06
fix clippy
2023-01-13 10:59:03 -08:00
Jonathan Kelley
6cd87796f2
feat: allow ifchains and for loops
2023-01-13 10:51:12 -08:00
Jon Kelley
2dd2d7fe66
Merge pull request #763 from d4h0/liveview-remove-unnecessary-deps-and-features
...
Remove unnecessary dependencies and dependency features in `Cargo.toml` of `dioxus-liveview`
2023-01-13 10:13:48 -08:00
Jon Kelley
25fecf8de5
Merge pull request #761 from Demonthos/fix-web-boolean-attributes
2023-01-13 09:30:06 -08:00
d4h0
c4485071a7
init
2023-01-13 17:25:18 +01:00
Evan Almloff
c5bb4275e6
fix boolean attributes with the web renderer
2023-01-13 08:48:59 -06:00
Jonathan Kelley
8ec5cbcc20
fix ci
2023-01-12 22:54:50 -08:00
Jonathan Kelley
293ef9c690
fix: only flow exprs with indent in mind
2023-01-12 17:02:41 -08:00
Jonathan Kelley
983789e4c5
handle weird trailing whitespace in autofmt
2023-01-12 16:55:13 -08:00
Evan Almloff
3c229b38bc
make shutdown message more clear
2023-01-12 18:51:08 -06:00
Evan Almloff
cd17f515d4
change to hook api
2023-01-12 18:48:23 -06:00
Jonathan Kelley
92be7f990b
Merge branch 'master' of github.com:DioxusLabs/dioxus
2023-01-12 16:29:38 -08:00
Jonathan Kelley
cc8b910cf3
fix emoji support in autofmt
2023-01-12 16:29:31 -08:00
Evan Almloff
ebed5ac025
Merge branch 'upstream' into add-fuzzing-to-core
2023-01-12 16:38:29 -06:00
Evan Almloff
a01a65a0eb
seperate text and other dynamic nodes
2023-01-12 16:34:46 -06:00
Evan Almloff
260589cd7f
pass clippy
2023-01-12 15:53:33 -06:00
Evan Almloff
09da9c04a8
Use zero cost option instead of null pointers
2023-01-12 15:42:23 -06:00
Evan Almloff
8a04a6ab0e
clean up fuzzing test
2023-01-12 15:28:10 -06:00
Evan Almloff
75932a43e0
Merge branch 'upstream' into add-fuzzing-to-core
2023-01-12 15:17:20 -06:00
Evan Almloff
1899a10aec
fix removing aborted nodes
2023-01-12 15:13:47 -06:00
Evan Almloff
733ff40bd0
Merge branch 'upstream' into handle-aborting-renders
2023-01-12 13:30:15 -06:00
Jon Kelley
432125c630
Merge pull request #759 from Demonthos/fix-global-attribute-translation
2023-01-12 10:14:59 -08:00
Evan Almloff
fc28050da6
pass clippy
2023-01-12 12:09:43 -06:00
Evan Almloff
6c804cded7
Merge branch 'upstream' into desktop-hot-reload
2023-01-12 12:08:56 -06:00
Evan Almloff
f71ab650e8
don't include inteprocess in wasm builds
2023-01-12 11:41:46 -06:00
Evan Almloff
d8d483a8b4
apply the same fixes to element specific attributes
2023-01-12 11:31:21 -06:00
Evan Almloff
232b49a3be
change some upper camel case to snake case and fix some incorrect attributes
2023-01-12 11:21:34 -06:00
Evan Almloff
97b9f422e1
log path errors
2023-01-12 11:10:16 -06:00
Evan Almloff
4e180bd19e
remmove comment
2023-01-12 11:00:16 -06:00
Evan Almloff
dc8fcf254b
Merge branch 'upstream' into desktop-hot-reload
2023-01-12 10:59:01 -06:00
Evan Almloff
6b4a300880
doc formatting and cleanup
2023-01-12 10:58:12 -06:00
Evan Almloff
351b9fab6f
allow custom namespaces
2023-01-12 10:52:24 -06:00
Evan Almloff
c49c59b8b2
add readme
2023-01-12 10:32:50 -06:00
Evan Almloff
9be1df1451
allow disabling logging
2023-01-12 10:32:45 -06:00
Evan Almloff
82048737f4
fix the macro export and WIP hot reloading docs
2023-01-12 08:47:33 -06:00
Evan Almloff
19aaa0ee5b
allow watching arbitrary paths
2023-01-11 21:06:00 -06:00
Evan Almloff
ee57046b58
Merge branch 'desktop-hot-reload' of https://github.com/demonthos/dioxus into desktop-hot-reload
2023-01-11 20:05:55 -06:00
Jonathan Kelley
fd4eac3488
Merge branch 'master' of github.com:DioxusLabs/dioxus
2023-01-11 17:12:33 -08:00
Jonathan Kelley
cf79ca8113
chore: stop ignoring some doc tests
2023-01-11 17:12:09 -08:00
=
9e45cbe4a7
remove the hot-reload-macro crate
2023-01-11 18:51:09 -06:00
Jonathan Kelley
c4a18bc24d
chore: clean up some clippy warnings and add clippy lints to CI
2023-01-11 16:13:41 -08:00
=
042b67b61b
factor out a hot reloading connect function
2023-01-11 16:43:41 -06:00
Evan Almloff
1b53d4585e
handle liveview sockets disconnecting
2023-01-11 14:59:00 -06:00
Evan Almloff
e5e1abbdac
implement hot reloading for liveview
2023-01-11 14:41:29 -06:00
Evan Almloff
6eff4438cf
implement hot reloading for TUI
2023-01-11 14:20:38 -06:00
Evan Almloff
1073574896
implement hot reloading for desktop
2023-01-11 13:40:02 -06:00
Evan Almloff
2772b86629
create with event handler
2023-01-10 21:35:11 -06:00
Jon Kelley
e5b39bb61f
Merge pull request #744 from Demonthos/update-readmes
...
Update READMEs and tags for the 0.3 release
2023-01-10 18:21:55 -08:00
Jonathan Kelley
2a9eb90154
fix: generate brace in rosetta
2023-01-10 18:14:16 -08:00
Jonathan Kelley
6d24fc3a6f
ci: make CI pass for miri
2023-01-10 18:08:41 -08:00
Jonathan Kelley
74af8f0f52
chore: smallbox unused on miri ci
2023-01-10 18:05:48 -08:00
Jonathan Kelley
13e58daa20
Merge branch 'master' into jk/add-miri-to-ci
2023-01-10 17:53:25 -08:00
Jon Kelley
0546a2012f
Merge pull request #726 from DioxusLabs/jk/fix-comments-on-exprs
...
fix: comments being eaten in autofmt
2023-01-10 17:49:46 -08:00
Jonathan Kelley
1940855e39
feat: implement comments in zero children nodes
2023-01-10 17:47:58 -08:00
Jonathan Kelley
6500a6d490
Merge branch 'master' into jk/fix-comments-on-exprs
2023-01-10 16:57:33 -08:00
Jon Kelley
d306e64070
Merge pull request #729 from Demonthos/improve-passes
...
Unify DirtyNodes and DirtyNodeStates in native core
2023-01-10 16:56:03 -08:00
Jonathan Kelley
fd875cd9db
chore: dont log on pong
2023-01-10 16:54:40 -08:00
Jon Kelley
8a53b62126
Merge pull request #749 from Demonthos/keep-websocket-alive
...
Keep LiveView web socket alive
2023-01-10 16:53:36 -08:00
Jon Kelley
e023f155f9
Merge pull request #748 from Demonthos/fix-drag-events-web
...
Fix drag* events on the web renderer
2023-01-10 16:52:15 -08:00
Jonathan Kelley
20497f1510
Merge branch 'master' of github.com:DioxusLabs/dioxus
2023-01-10 16:40:07 -08:00
Jonathan Kelley
39c4f3f814
fix: ci not passing
2023-01-10 16:39:56 -08:00
Evan Almloff
6a8fefdfd8
keep liveview websocket alive
2023-01-10 14:41:26 -06:00
Evan Almloff
8a1f54f573
fix drag* events
2023-01-10 12:53:40 -06:00
Joe Perri
0e40619b52
Update Cargo.toml ( #740 )
2023-01-10 10:51:21 -06:00
Evan Almloff
52d5c8d4e7
update READMEs and tags for the 0.3 release
2023-01-10 10:16:11 -06:00
Jonathan Kelley
faf94c7b4e
fix: make miri pass on context api
2023-01-09 13:50:33 -08:00
Evan Almloff
d2b5af6615
remove logs from interpreter
2023-01-09 12:04:38 -06:00
Evan Almloff
85fdc77880
fix tui
2023-01-08 15:26:30 -06:00
Evan Almloff
8adee11fe7
fix custom type
2023-01-08 14:04:48 -06:00
Evan Almloff
ecf4ee275a
Merge branch 'upstream' into simplify-native-core
2023-01-08 14:03:44 -06:00
Evan Almloff
72b2a3ef37
fix tests
2023-01-08 12:02:44 -06:00
Evan Almloff
a934e60fdf
unify dirty nodes
2023-01-08 11:37:54 -06:00
Evan Almloff
927db9723a
handle abort diffing
2023-01-07 19:01:29 -06:00
Evan Almloff
112738c23d
improve fuzzing test
2023-01-07 18:52:37 -06:00
Jonathan Kelley
cb7e4f3f27
Merge branch 'master' of github.com:DioxusLabs/dioxus
2023-01-07 14:10:59 -08:00
Jonathan Kelley
4694e4d63e
release: bump fermi
2023-01-07 14:10:51 -08:00
Jonathan Kelley
74421d47fd
fix comments being eaten in autofmt
2023-01-07 14:09:32 -08:00
ealmloff
cd4474cc4f
Update docs to reflect changes in master ( #670 )
...
* work on updating docs to master version
* more updates
* more polishing
* finish interactivity chapter
* finish updating core guide
* fix grammer mistakes and typos
* more grammer fixes
* add liveview guide
* remove doc build
* WIP custom renderer docs
* add axum as dev-dependancy to guide
* fix examples
* fix overview example
* use md book fork to fix compilation
2023-01-06 15:00:12 -08:00
ealmloff
a616a8fa9d
fix templates being registered in mutations many times ( #722 )
2023-01-05 13:05:12 -06:00
ealmloff
64881fd951
improve error message when a user tried to use nested hooks ( #723 )
2023-01-05 13:05:04 -06:00
Evan Almloff
990b0503e1
remove outdated comment
2023-01-05 10:36:30 -06:00
Evan Almloff
42baadf65d
add fuzzing test to dioxus-core
2023-01-05 10:28:07 -06:00
Evan Almloff
3a6d06e205
remove nodes from listener list when the node is removed
2023-01-05 08:21:36 -06:00
Jonathan Kelley
a0961583d1
fix: versions and readme
2023-01-04 14:58:06 -05:00
Jonathan Kelley
7f01f61138
feat: publish 0.3 versions of many crates
2023-01-04 14:31:07 -05:00
Jon Kelley
3393d0487c
Merge pull request #718 from Demonthos/handle-removing-a-completed-future
...
Handle removing a future that does not exist
2023-01-04 12:49:08 -05:00
Jon Kelley
aa46bd2d0f
Merge pull request #717 from Demonthos/rename-tui-examples
...
Remove tui_ prefix from TUI Examples
2023-01-04 12:48:53 -05:00
Evan Almloff
e3dd55533f
handle removing a future that does not exist
2023-01-04 11:38:34 -06:00
Evan Almloff
5e77b297f2
rename tui examples
2023-01-04 11:21:29 -06:00
Evan Almloff
93a95b82a4
bump lightningcss version
2023-01-04 11:18:32 -06:00
Evan Almloff
52a74214da
don't remove realdom nodes when the element id changes
2023-01-04 09:14:58 -06:00
Jon Kelley
3733ce7332
Merge pull request #711 from Demonthos/realdom-generic-over-custom-types
...
make the real dom generic over custom types
2023-01-03 15:30:13 -05:00
Jon Kelley
35cccc3838
Merge pull request #708 from Demonthos/support-optional-attrtibutes
...
Support optional attributes
2023-01-03 15:27:07 -05:00
Jon Kelley
fba3fdf87a
Merge pull request #703 from DioxusLabs/jk/signal-crate
...
feat: simple signals implementation
2023-01-03 15:26:52 -05:00
Jon Kelley
7050550685
Merge pull request #707 from Demonthos/fix-namespace-on-dynamic-attributes
...
Fix the namespace and volatility of dynamic attributes
2023-01-03 15:25:37 -05:00
Evan Almloff
bf20b66b38
make the real dom generic over custom types
2023-01-03 12:35:48 -06:00
Maurice Kayser
dde4fb31b2
Fix typo ( #709 )
2023-01-03 10:09:03 -06:00