Commit graph

6499 commits

Author SHA1 Message Date
Jeffrey Finkelstein
cfe5a0d82c split: correct filename creation algorithm
Fix two issues with the filename creation algorithm. First, this
corrects the behavior of the `-a` option. This commit ensures a
failure occurs when the number of chunks exceeds the number of
filenames representable with the specified fixed width:

    $ printf "%0.sa" {1..11} | split -d -b 1 -a 1
    split: output file suffixes exhausted

Second, this corrects the behavior of the default behavior when `-a`
is not specified on the command line. Previously, it was always
settings the filenames to have length 2 suffixes. This commit corrects
the behavior to follow the algorithm implied by GNU split, where the
filename lengths grow dynamically by two characters once the number of
chunks grows sufficiently large:

    $ printf "%0.sa" {1..91} | ./target/debug/coreutils split -d -b 1 \
    >   && ls x* | tail
    x81
    x82
    x83
    x84
    x85
    x86
    x87
    x88
    x89
    x9000
2022-01-10 20:43:22 -05:00
Jeffrey Finkelstein
e5d6b7a1cf split: correct arg parameters for -b option 2022-01-10 20:43:22 -05:00
Terts Diepraam
f60c36f242
Merge pull request #2610 from miDeb/cp/abuse
cp: handle edge cases when dest is a symlink
2022-01-11 00:34:55 +01:00
Roy Ivy III
7a760cae99 refactor/polish ~ re-normalize whitespace
* minimize inconsistent/invisible whitespace

- consistent indentation (either spaces-only, tabs, *or* tabs with following spaces [for indentation])
- no internal/invisible tabs
- no trailing whitespace
- EOF EOLNs
2022-01-09 21:35:39 -06:00
Roy Ivy III
bb25129a48 maint/dev ~ update test-repo-whitespace.BAT dev utility 2022-01-09 21:34:22 -06:00
Roy Ivy III
d33efd8efc
Merge pull request #2857 from rivy/change.rm-vendor
change ~ remove (now unneeded) vendored 'nix'
2022-01-09 21:16:31 -06:00
Roy Ivy III
05a2f0ca70 update 'Cargo.lock' 2022-01-09 18:57:25 -06:00
Roy Ivy III
d6b93e42c9 update ~ pin 'retain_mut' to v0.1.2 (with MinSRV maint ToDO)
- v0.1.5 uses const generics which aren't stable until rust v1.51.0
2022-01-09 18:57:25 -06:00
Roy Ivy III
d22f3e239c change ~ remove (now unneeded) vendored nix-v0.23.1-patched 2022-01-09 18:57:25 -06:00
Roy Ivy III
774e72551b change ~ relax 'nix' version and remove 'nix' patch
- code coverage compilation on MacOS latest (MacOS-11+) now works with newer 'nix' versions
2022-01-09 18:57:25 -06:00
Sylvestre Ledru
dcfdeb334d
Merge pull request #2854 from kimono-koans/ls_fix_errno_1
ls: Fix Errno 1, print errors at the md call point
2022-01-09 20:56:06 +01:00
Sylvestre Ledru
c69380a193
Merge pull request #2858 from moko256/moko256_ls_metadata_in_is_hidden
ls: On Windows use metadata owned by DirEntry instead of retrieved one additionaly
2022-01-09 20:54:54 +01:00
moko256
5659bf8fae
ls: On Windows use DirEntry#metadata() instead of fs::metadata 2022-01-10 02:56:22 +09:00
Justin Tracey
4df2f3c148 join: add test for non-Unicode files 2022-01-08 21:28:29 -05:00
Justin Tracey
cdfe64369d join: add test for non-linefeed newline characters 2022-01-08 19:51:16 -05:00
Sylvestre Ledru
63ef039b4f
Merge pull request #2826 from jfinkels/stdbuf-uresult
stdbuf: return UResult from uumain() function
2022-01-08 22:34:06 +01:00
Sylvestre Ledru
6637fba988
Merge pull request #2833 from jfinkels/tr-uresult
tr: return UResult from uumain() function
2022-01-08 22:30:43 +01:00
Sylvestre Ledru
a007ef2c1a
Merge pull request #2834 from jfinkels/truncate-uresult
truncate: return UResult from uumain() function
2022-01-08 22:29:57 +01:00
electricboogie
4052d4ec6a Add test for double printing dangling link errors 2022-01-08 12:10:52 -06:00
kimono-koans
4ea61545c6
Merge branch 'uutils:master' into ls_fix_errno_1 2022-01-07 21:48:53 -06:00
Sylvestre Ledru
9922e48ba6
Merge pull request #2853 from kimono-koans/ls_fix_first_newline
ls: Fix newline when only dirs in base directory
2022-01-07 23:10:44 +01:00
Sylvestre Ledru
c9d982fb4d
Merge pull request #2848 from jfinkels/realpath-uresult
realpath: return UResult from uumain() function
2022-01-07 21:51:57 +01:00
Sylvestre Ledru
5f778ffa2e
Merge pull request #2847 from jfinkels/pr-uresult
pr: return UResult from uumain() function
2022-01-07 21:51:41 +01:00
Sylvestre Ledru
480bd3c36a
Merge pull request #2835 from jfinkels/tsort-uresult
tsort: return UResult from uumain() function
2022-01-07 21:51:25 +01:00
Sylvestre Ledru
0f4b0fd9cd
Merge pull request #2832 from jfinkels/timeout-uresult
timeout: return UResult from uumain() function
2022-01-07 21:51:01 +01:00
Sylvestre Ledru
3f27597fca
Merge pull request #2823 from jfinkels/split-uresult
split: return UResult from uumain() function
2022-01-07 21:49:11 +01:00
Sylvestre Ledru
c14ba865ce
Merge pull request #2821 from jfinkels/runcon-uresult
runcon: return UResult from uumain() function
2022-01-07 21:47:51 +01:00
Sylvestre Ledru
969f3cbf39
Merge pull request #2793 from tertsdiepraam/cksum-result-io-error
`cksum`: use `UIoError`
2022-01-07 21:47:01 +01:00
electricboogie
13d6d74fa3 Fix Windows test(?): inode request shouldn't error on Windows, b/c there are no inodes 2022-01-07 09:24:32 -06:00
electricboogie
01585a57f6 Fix Errno 1, print errors at the md call point 2022-01-07 00:38:24 -06:00
electricboogie
882b8ddd7b Fix test dir names for Windows 2022-01-06 15:41:53 -06:00
electricboogie
30b2425541 Fix newline when only dirs in base directory, and test 2022-01-06 14:58:56 -06:00
Justin Tracey
9ad8a03646 join: operate on bytes instead of Strings 2022-01-05 13:24:10 -05:00
kimono-koans
421330d07a
ls: Improve error handling and other improvements (#2809)
*  print error in the correct order by flushing the stdout buffer before printing an error
*  print correct GNU error codes
*  correct formatting for config.inode, and for dangling links
*  correct padding for Format::Long
*  remove colors after the -> link symbol as this doesn't match GNU
*  correct the major, minor #s for char devices, and correct padding
*  improve speed for all metadata intensive ops by not allocating metadata unless in a Sort mode
*  new tests, have struggled with how to deal with stderr, stdout ordering in a test though
*  tried to implement UIoError, but am still having issues matching the formatting of GNU


Co-authored-by: electricboogie <32370782+electricboogie@users.noreply.github.com>
2022-01-05 14:50:37 +01:00
Sylvestre Ledru
ae7190ec73
Merge pull request #2846 from jfinkels/wc-uresult
wc: return UResult from uumain() function
2022-01-05 14:39:39 +01:00
Sylvestre Ledru
64effa5e78
Merge branch 'master' into split-uresult 2022-01-05 13:51:48 +01:00
Sylvestre Ledru
8ef2ea1356
Merge pull request #2830 from jfinkels/tee-uresult
tee: return UResult from uumain() function
2022-01-05 13:51:05 +01:00
Sylvestre Ledru
b36759765d
Merge pull request #2849 from jfinkels/chcon-uresult
chcon: return UResult from uumain() function
2022-01-05 13:50:02 +01:00
Jeffrey Finkelstein
b30a20d895 chcon: return UResult from uumain() function 2022-01-02 20:08:11 -05:00
Jeffrey Finkelstein
49dca9adcb realpath: return UResult from uumain() function 2022-01-02 19:59:15 -05:00
Jeffrey Finkelstein
c80e44fb08 pr: return UResult from uumain() function 2022-01-02 19:48:52 -05:00
Jeffrey Finkelstein
cb92db322b timeout: return UResult from uumain() function 2022-01-02 19:41:21 -05:00
Jeffrey Finkelstein
9caf15c44f fixup! wc: return UResult from uumain() function 2022-01-02 19:40:22 -05:00
Sylvestre Ledru
cd1a0fbe36
Merge pull request #2841 from sbentmar/add-suffix-to-numfmt
numfmt: implement missing --suffix option
2022-01-02 23:07:29 +01:00
Sylvestre Ledru
3c68988ae7
Merge pull request #2843 from tertsdiepraam/stdbuf/fix-cargo-git-build
stdbuf: fix cargo --git build (#1276) (Attempt 2)
2022-01-02 23:06:59 +01:00
Sylvestre Ledru
e7dd56c1d5
Merge pull request #2845 from jfinkels/unexpand-uresult
unexpand: return UResult from uumain() function
2022-01-02 19:02:30 +01:00
Sylvestre Ledru
d5312e963f
Merge pull request #2844 from jfinkels/tty-uresult
tty: return UResult from uumain() function
2022-01-02 19:02:12 +01:00
Jeffrey Finkelstein
e060ac53f2 wc: return UResult from uumain() function 2022-01-02 11:15:30 -05:00
Jeffrey Finkelstein
f89dc6585d unexpand: return UResult from uumain() function 2022-01-02 10:33:41 -05:00
Jeffrey Finkelstein
b7e646e710 tty: return UResult from uumain() function 2022-01-02 10:28:53 -05:00