Commit graph

6195 commits

Author SHA1 Message Date
Jeffrey Finkelstein
294bde8e08 seq: correct width for certain negative decimals
Fix a bug in which a negative decimal input would not be displayed with
the correct width in the output. Before this commit, the output was
incorrectly

    $ seq -w -.1 .1 .11
    -0.1
    0.0
    0.1

After this commit, the output is correctly

    $ seq -w -.1 .1 .11
    -0.1
    00.0
    00.1

The code was failing to take into account that the input decimal "-.1"
needs to be displayed with a leading zero, like "-0.1".
2021-12-23 20:37:29 -05:00
Sylvestre Ledru
5c0adb26a5
Merge pull request #2778 from refi64/mountinfo-optional
uucore::fsext: Fix mountinfo parsing w/ multiple optional fields
2021-12-22 18:32:14 +01:00
kimono-koans
fd64e01d92
ls: Reduce binary size of ls by removing regex crate (#2781) 2021-12-22 18:31:45 +01:00
Ryan Gonzalez
23c0734a62 uucore::fsext: Fix mountinfo parsing w/ multiple optional fields
proc(5) mentions the following for the fields section and hyphen:

> (7)  optional fields: zero or more fields of the form "tag[:value]";
> see below.
> (8)  separator: the end of the optional fields is marked by a single
> hyphen.

IOW, there may actually be multiple optional fields, not just one, in
which case the previously hardcoded indexes for the filesystem type and
device name are now incorrect. Now, the filesystem type and device name
are parsed relative to the hypen's location, ensuring that they will be
correct regardless of the number of optional fields.

Signed-off-by: Ryan Gonzalez <ryan.gonzalez@collabora.com>
2021-12-20 08:46:22 -06:00
Sylvestre Ledru
f2f582aa14
Merge pull request #2782 from sylvestre/test_1665
cp: add a unit test for issue 1665
2021-12-19 22:49:42 +01:00
Sylvestre Ledru
59da0d8cd6 cp: add a unit test for issue 1665 2021-12-19 18:19:48 +01:00
Sylvestre Ledru
cf8ace8f09
Merge pull request #2779 from sylvestre/pla
bump the platform-info dep
2021-12-18 00:40:21 +01:00
Sylvestre Ledru
a3041843c9 bump the platform-info dep 2021-12-18 00:04:03 +01:00
Sylvestre Ledru
ca705e5ad2
Merge pull request #2772 from jfinkels/more-return-result
more: return Ok in main loop
2021-12-16 09:50:36 +01:00
Jeffrey Finkelstein
e88a8e8eb2 more: return Ok in main loop 2021-12-15 20:49:41 -05:00
Sylvestre Ledru
83201ecb35
Merge pull request #2765 from ybc37/fix/idempotent-build-gnu
Fix idempotence of `utils/build-gnu.sh`
2021-12-15 23:40:55 +01:00
Sylvestre Ledru
5e2dd9d0bc
Merge pull request #2767 from E3uka/more_uresult
more: use UResult
2021-12-15 23:40:38 +01:00
Sylvestre Ledru
5bcc53ecde
Merge pull request #2771 from E3uka/next_prev
more: add next-line and prev-line command.
2021-12-15 23:39:09 +01:00
electricboogie
a1960f5da0
Fix cp bug: pre-write permission change (#2769) 2021-12-15 22:18:02 +01:00
Ebuka Agbanyim
d2095edf6c more: add next-line and prev-line command. 2021-12-14 19:32:38 +00:00
Sylvestre Ledru
d5463ea5b9
Merge pull request #2770 from sylvestre/unbreak-windows-ci
Try to unbreak the code coverage CI.
2021-12-14 11:59:21 +01:00
Sylvestre Ledru
52d2fe1d28 Try to unbreak the code coverage CI.
For some reasons, on windows, test_compress_fail is failing with a different
error. So, don't check the output on windows
2021-12-14 09:46:28 +01:00
Ebuka Agbanyim
0bf2266ef0 more: use UResult 2021-12-13 00:37:34 +00:00
Daniel Schmid
0e4671215d Fix idempotence of utils/build-gnu.sh
* Fix regular expressions to only match when run the first time.
* Enhance the regular expression which removes duplicated "/usr/bin/" to
  allow a space between them (+ also consider `init.cfg`).
2021-12-12 19:20:55 +01:00
electricboogie
c7f7a222b9
Fix mv bug: Should be able to stat files, but not able to mv if source and target are the same (#2763)
Closes #2760
2021-12-12 17:49:38 +01:00
Sylvestre Ledru
3df989eacf
Merge pull request #2766 from ybc37/fix/typo-build-gnu
Fix typo in `utils/build-gnu.sh`
2021-12-12 17:48:47 +01:00
Daniel Schmid
e46ace85da Fix typo in utils/build-gnu.sh 2021-12-12 17:24:49 +01:00
Sylvestre Ledru
5e1685c8dc
Merge pull request #2653 from blyxxyz/entries-safety
uucore::entries: Fix safety issues
2021-11-26 16:51:21 +01:00
Jan Verbeek
ceff2690d2 getgroups: Reuse buffer, add comment about performance 2021-11-26 14:48:34 +01:00
Jan Verbeek
b125159535 getgroups: Handle race conditions properly 2021-11-26 14:48:34 +01:00
Jan Verbeek
412a81e7bf uucore::entries: Remove unnecessary unsafe Vec operations 2021-11-26 14:48:33 +01:00
Jan Verbeek
f2ddae93fa uucore::entries: Make Passwd::locate and Group::locate thread-safe 2021-11-26 14:48:33 +01:00
Sylvestre Ledru
fe286fa8c8
Merge pull request #2749 from thomasqueirozb/utils_uresult
basename+date+fold+nl+nproc+shuf+uname: use UResult
2021-11-25 13:43:46 +01:00
Sylvestre Ledru
1d794e1a94
Merge pull request #2752 from Smicry/master
tail use UResult
2021-11-21 10:14:03 +01:00
Smicry
81a1fde9f4 tail use UResult 2021-11-21 12:37:56 +08:00
Sylvestre Ledru
4d33a3af64
Merge pull request #2750 from rivy/fix.cicd
Fix/enhance CICD
2021-11-20 14:43:37 +01:00
Roy Ivy III
7e06ddaa92 fix/tee ~ repair 'unstable_name_collisions' compiler warning 2021-11-19 21:40:22 -06:00
Roy Ivy III
790884b177 maint/CICD ~ add dependencies between CI job steps (using 'needs')
- the build and test steps won't run until/unless Dependency and MSRV checks pass
- code coverage won't run until/unless the build steps all pass

## [why]

This helps make more efficient use of CI resources and can help more easily visualize
build issues from the resultant GHA dashboard flow diagram.
2021-11-19 18:04:55 -06:00
Roy Ivy III
ae05bffbab docs/spell ~ add 'vendor' directory exception for spell-checker 2021-11-19 18:04:55 -06:00
Roy Ivy III
7784a252f2 fix/yes ~ revise to match 'nix' changes 2021-11-19 18:04:53 -06:00
Roy Ivy III
7834d9ffaf update Cargo.lock 2021-11-19 17:55:03 -06:00
Roy Ivy III
03e0cbb020 update 'nix' within workspace to force patched version 2021-11-19 17:55:03 -06:00
Roy Ivy III
8b7f2b44f6 change ~ use patched/vendor'ed 'nix' crate until fixed at source
- a PR has been submitted to 'nix'; ref: <https://github.com/nix-rust/nix/pull/1590>
2021-11-19 17:55:02 -06:00
Roy Ivy III
39a6e6c75b maint/CICD ~ (GHA) normalize setup sub-step ordering 2021-11-19 17:55:02 -06:00
Roy Ivy III
f07a1749a1 fix spell-check errors 2021-11-19 17:55:02 -06:00
Roy Ivy III
7133efd0a5 tests ~ fix cargo clippy complaint (clippy::needless_return) 2021-11-19 17:55:02 -06:00
Roy Ivy III
047c17dd31 maint/CICD - (GHA) standardize job step ordering (install, vars, prereq, toolchain, ...) 2021-11-19 17:55:02 -06:00
Roy Ivy III
0b10e69f56 maint/CICD ~ (GHA) repair broken cspell by pinning it to version v4.2.8
## [why]

`cspell` in CI started mysteriously failing mid-2021. Tracking down the
error took some time as it was not obvious from `cspell` feedback where
the issue lay. Ultimately, it was discovered that `cspell` had deprecated
use on NodeJS versions < v12 for `cspell` v5+.

`cspell` is now pinned to v4.2.8, with a maintenance note to allow an
upgrade to the `cspell` version when a version of NodeJS >= v12 is being
used in the CI.

An issue requesting better tool feedback for similar situations was also
opened on the `cspell` repo.[*]

[*]: [🙏🏻 Add warning (or error) when used on deprecated/outdated JS platform versions](https://github.com/streetsidesoftware/cspell/issues/1984)
2021-11-19 17:55:02 -06:00
Roy Ivy III
aba1c8f596 maint/CICD ~ (GHA) disable tool cache use for 'action-rs/install'
# [why]

The tool cache is currently failing and seems to be getting further behind current
versions. The [actions-rs/install#12] issue addresses this but seems to be
languishing without any proposed solution.

[ref]: <actions-rs/install#12>
2021-11-19 17:55:02 -06:00
Roy Ivy III
f20aa49821 maint/CICD ~ (GHA) fix cargo-udeps false positives (add 'ignore' exceptions to sub-crates) 2021-11-19 17:55:02 -06:00
Roy Ivy III
12419b3ee2 maint/CICD ~ (GHA) reform 'unused dependency check' (cargo udeps ...) into a style warning 2021-11-19 17:55:02 -06:00
Roy Ivy III
a6635d62c7 maint/CICD ~ (GHA) use 'feat_os_unix' consistently for ubuntu jobs 2021-11-19 17:55:01 -06:00
Roy Ivy III
37a3c68f3a maint/CICD ~ (GHA) add style fault configurability (fail vs warn)
- add individual job-step control for 'style' step faults (build failure vs only a warning)
2021-11-19 17:55:01 -06:00
Roy Ivy III
c951806e70 maint/CICD ~ (GHA) fix cargo clippy lint
- fixes conversion of new `cargo clippy` output style to GHA annotations

## [why]

`cargo clippy` output formatting changed, using relative instead of absolute paths.
2021-11-19 17:55:01 -06:00
Roy Ivy III
36c6ccde0d maint/dev ~ prefer less visible tool configuration files 2021-11-19 17:55:01 -06:00