Commit graph

2302 commits

Author SHA1 Message Date
Justin Tracey
ce3df12eaa join: "support" field numbers larger than usize::MAX
They silently get folded to usize::MAX, which is the official GNU behavior.
2022-01-17 17:49:41 -05:00
Jeffrey Finkelstein
e575007629 tail: improve error handling when file not found 2022-01-17 10:57:24 -05:00
Jeffrey Finkelstein
0f1053ce68 head: refactor helper func find_nth_line_from_end
Factor out a loop for finding the index of the byte immediately
following the `n`th line from the end of a file. This does not change
the behavior of the code, just its organization.
2022-01-17 10:55:40 -05:00
Terts Diepraam
951f3bb689 fix up runcon and chcon for clap 3 2022-01-17 16:52:17 +01:00
Terts Diepraam
55893f0e3d od: use clap options instead of custom mock options for unit tests 2022-01-17 16:25:49 +01:00
sbentmar
b0cf6f9b34 numfmt: minor adjustments to test cases 2022-01-17 16:24:40 +01:00
sbentmar
635c2d0c31 numfmt: remove unused function 2022-01-17 16:24:40 +01:00
sbentmar
1287ce3780 numfmt: add tests for handle_buffer 2022-01-17 16:24:40 +01:00
sbentmar
4a7d313712 numfmt: add unit test for io error 2022-01-17 16:24:40 +01:00
sbentmar
5cab4e41b3 numfmt: add copyright notice 2022-01-17 16:24:40 +01:00
Sebastian Holgersson
9b04c98ddb numfmt: use UResult in more functions
This commit replaces generic Results with UResults in some key
functions in numfmt. As a result of this, we can provide different
exit codes for different errors, which resolves ~70 failing test
cases in the GNU numfmt.pl test suite.
2022-01-17 16:24:40 +01:00
Jeffrey Finkelstein
ab4036297b head: use uucore error handling instead of custom
Use `show!()` and `USimpleError` to handle I/O errors instead of using
custom code.
2022-01-17 08:58:44 -05:00
Jeffrey Finkelstein
58f2000406 split: method to convert ArgMatches to Settings
Create a `Settings::from` method that converts a `clap::ArgMatches`
instance into a `Settings` instance. This eliminates the unnecessary
use of a mutable variable when initializing the settings.
2022-01-17 08:58:10 -05:00
Jeffrey Finkelstein
d9afdf0527 uucore: move printf::memo module to uucore
Move the `printf::memo` module to `uucore` so that it can be used by
other programs, not just `printf`. For example, the `-f` option to `seq`
requires parsing and formatting numbers according to the same logic as
`printf`.
2022-01-17 08:46:45 -05:00
Jeffrey Finkelstein
2d66c84413 printf: remove cli module
Remove the cli module from the printf crate and move its functions into
the module tokenize::unescaped_text module, the only place they are
used.
2022-01-17 08:43:36 -05:00
Terts Diepraam
8872485922 Merge branch 'main' into clap-3 2022-01-17 13:25:51 +01:00
Terts Diepraam
08efa1fe5a
Merge branch 'main' into join-null-field-sep 2022-01-17 12:59:52 +01:00
Sylvestre Ledru
a87a71893f
Merge pull request #2879 from sylvestre/chrono-issue
Force minimal version of chrono to avoid a security issue
2022-01-17 12:53:31 +01:00
Justin Tracey
109277d405 join: add support for -t '\0' 2022-01-16 18:05:58 -05:00
Justin Tracey
346415e1d2 join: add support for -z option 2022-01-16 17:56:07 -05:00
Sylvestre Ledru
fcff6fec6d Force minimal version of chrono to avoid a security issue
See: https://rustsec.org/advisories/RUSTSEC-2020-0071.html
2022-01-16 23:33:12 +01:00
Sylvestre Ledru
4fc47aba61
Merge pull request #2878 from tertsdiepraam/stdbuf-trouble
`stdbuf`: fix `cargo publish` problem
2022-01-16 23:23:35 +01:00
Sylvestre Ledru
516bdfcfd5
Merge pull request #2872 from jfinkels/split-verbose
split: add --verbose option
2022-01-16 23:19:30 +01:00
Terts Diepraam
c5e2515833 fix stdbuf problem 2022-01-16 22:50:34 +01:00
electricboogie
16b7b38b92 Run cargo fmt 2022-01-16 11:17:43 -06:00
electricboogie
e6ce049d2c Fix Windows lints/build errors 2022-01-16 11:07:22 -06:00
electricboogie
e1bffea595 Merge branch 'master' into ls_bad_fd_2 2022-01-16 10:26:44 -06:00
electricboogie
15efba54c5 Use dir_entry metadata for dereferenced bad fds to match GNU, add comments, clippy lints 2022-01-16 10:20:50 -06:00
Sylvestre Ledru
1fbda8003c coreutils 0.0.8 => 0.0.9, uucore_procs 0.0.7 => 0.0.8, uucore 0.0.10 => 0.0.11 2022-01-16 17:05:48 +01:00
Sylvestre Ledru
00c11b184f
Merge pull request #2851 from jtracey/join-strless
join: operate on bytes instead of Strings
2022-01-16 16:24:38 +01:00
Terts Diepraam
448b84806f
fix Rust 1.58 clippy lints (#2874) 2022-01-16 15:57:33 +01:00
Jeffrey Finkelstein
7af3007204 split: add --verbose option 2022-01-16 09:34:28 -05:00
electricboogie
37ca6edfdc Fix display of bad fd errors 2022-01-15 22:39:07 -06:00
kimono-koans
fd5310411e
ls: Fix device display (#2855) 2022-01-15 00:39:56 +01:00
Sylvestre Ledru
3cc1fb593a
Merge pull request #2859 from jfinkels/split-dynamic-suffix-length
split: correct filename creation algorithm
2022-01-14 18:06:57 +01:00
Terts Diepraam
49e5412580 tsort: clap 3 2022-01-11 19:16:48 +01:00
Terts Diepraam
e62fdb9307 yes: clap 3 2022-01-11 19:16:48 +01:00
Terts Diepraam
fe69ad25f8 whoami: clap 3 2022-01-11 19:16:48 +01:00
Terts Diepraam
e3b8e6c993 who: clap 3 2022-01-11 19:16:48 +01:00
Terts Diepraam
e9e5768591 wc: clap 3 2022-01-11 19:16:48 +01:00
Terts Diepraam
e5a775be46 users: clap 3 2022-01-11 19:16:48 +01:00
Terts Diepraam
ac76eefb99 uptime: clap 3 2022-01-11 19:16:48 +01:00
Terts Diepraam
2cd32beb70 unlink 2022-01-11 19:16:48 +01:00
Terts Diepraam
5105a59fda uniq: clap 3 2022-01-11 19:16:48 +01:00
Terts Diepraam
dafa0737c8 unexpand: clap 3 2022-01-11 19:16:48 +01:00
Terts Diepraam
7de993fa4f uname: clap 3 2022-01-11 19:16:48 +01:00
Terts Diepraam
48c65934c7 tty: clap 3 2022-01-11 19:16:48 +01:00
Terts Diepraam
263357666f truncate: clap 3 2022-01-11 19:16:48 +01:00
Terts Diepraam
6c37cdebce true: clap 3 2022-01-11 19:16:48 +01:00
Terts Diepraam
fd777866a3 tr: clap 3 2022-01-11 19:16:48 +01:00
Terts Diepraam
9f58715d65 touch: clap 3 2022-01-11 19:16:48 +01:00
Terts Diepraam
7318d1d24b timeout: clap 3 2022-01-11 19:16:48 +01:00
Terts Diepraam
0ff1984471 test: clap 3 2022-01-11 19:16:48 +01:00
Terts Diepraam
3cac8a631f tee: clap 3 2022-01-11 19:16:48 +01:00
Terts Diepraam
9c9643807a tail: clap 3 2022-01-11 19:16:48 +01:00
Terts Diepraam
219498c2e8 tac: clap 3 2022-01-11 19:16:48 +01:00
Terts Diepraam
57361292aa sync: clap 3 2022-01-11 19:16:48 +01:00
Terts Diepraam
bad790840a sum: clap 3 2022-01-11 19:16:48 +01:00
Terts Diepraam
0fca4460de stdbuf: clap 3 2022-01-11 19:16:48 +01:00
Terts Diepraam
eaaa16291e stat: clap 3 2022-01-11 19:16:48 +01:00
Terts Diepraam
ecf6f18ab3 split: clap 3 2022-01-11 19:16:48 +01:00
Terts Diepraam
b43839a8a8 sort: clap 3 2022-01-11 19:16:48 +01:00
Terts Diepraam
d0a52c95e6 sleep: clap 3 2022-01-11 19:16:48 +01:00
Terts Diepraam
793e540323 shuf: clap 3 2022-01-11 19:16:48 +01:00
Terts Diepraam
92e94de2d7 shred: clap 3 2022-01-11 19:16:48 +01:00
Terts Diepraam
41513a8ba6 seq: clap 3 2022-01-11 19:16:48 +01:00
Terts Diepraam
ec42e824f0 runcon: clap 3 2022-01-11 19:16:48 +01:00
Terts Diepraam
4edab26dcc pr: clap 3 2022-01-11 19:16:48 +01:00
Terts Diepraam
f260f60093 rmdir: clap 3 2022-01-11 19:16:48 +01:00
Terts Diepraam
283973c5bf rm: clap 3 2022-01-11 19:16:48 +01:00
Terts Diepraam
a02e40fcad relpath: clap 3 2022-01-11 19:16:48 +01:00
Terts Diepraam
d52887e6c0 pwd: clap 3 2022-01-11 19:16:48 +01:00
Terts Diepraam
edafc468ed realpath: clap 3 2022-01-11 19:16:48 +01:00
Terts Diepraam
d8f2be2f3b readlink: clap 3 2022-01-11 19:16:48 +01:00
Terts Diepraam
24dc4d9037 ptx: clap 3 2022-01-11 19:16:48 +01:00
Terts Diepraam
b94809197f printf: clap 3 2022-01-11 19:16:48 +01:00
Terts Diepraam
8ba10936b0 printenv: clap 3 2022-01-11 19:16:48 +01:00
Terts Diepraam
c39a9b49d4 pinky: clap 3 2022-01-11 19:16:48 +01:00
Terts Diepraam
49b19972cc pathchk: clap 3 2022-01-11 19:16:48 +01:00
Terts Diepraam
8f7f3d18ee paste: clap 3 2022-01-11 19:16:48 +01:00
Terts Diepraam
9efd6654f8 od: clap 3 2022-01-11 19:16:48 +01:00
Terts Diepraam
7cebb2563b numfmt: clap 3 2022-01-11 19:16:48 +01:00
Terts Diepraam
5702313e9c nproc: clap 3 2022-01-11 19:16:48 +01:00
Terts Diepraam
5e9443567d nohup: clap 3 2022-01-11 19:16:48 +01:00
Terts Diepraam
5b13ec9c66 nl: clap 3 2022-01-11 19:16:48 +01:00
Terts Diepraam
64f57a9200 nice: clap 3 2022-01-11 19:16:48 +01:00
Terts Diepraam
ba93684a7e mv: clap 3 2022-01-11 19:16:47 +01:00
Terts Diepraam
41d567f44b more: clap 3 2022-01-11 19:16:47 +01:00
Terts Diepraam
f902ec7d6e mktemp: clap 3 2022-01-11 19:16:47 +01:00
Terts Diepraam
6e39eddbc1 mknod: clap 3 2022-01-11 19:16:47 +01:00
Terts Diepraam
c8eddad610 mkfifo: clap 3 2022-01-11 19:16:47 +01:00
Terts Diepraam
0e021e956a mkdir: clap 3 2022-01-11 19:16:47 +01:00
Terts Diepraam
c8270b202e ls: clap 3 2022-01-11 19:16:47 +01:00
Terts Diepraam
ebaf5caae8 logname: clap 3 2022-01-11 19:16:47 +01:00
Terts Diepraam
9951958b93 ln: clap 3 2022-01-11 19:16:47 +01:00
Terts Diepraam
0531f13cfd link: clap 3 2022-01-11 19:16:47 +01:00
Terts Diepraam
83f39619d5 kill: clap 3 2022-01-11 19:16:47 +01:00
Terts Diepraam
b61494337e join: clap 3 2022-01-11 19:16:47 +01:00
Terts Diepraam
89112fb1c2 install: clap 3 2022-01-11 19:16:47 +01:00
Terts Diepraam
8c58f8e2b1 id: clap 3 2022-01-11 19:16:47 +01:00
Terts Diepraam
82aadbf38f hostname: clap 3 2022-01-11 19:16:47 +01:00
Terts Diepraam
6876521b08 hostid: clap 3 2022-01-11 19:16:47 +01:00
Terts Diepraam
9fc9fdb1f3 head: clap 3 2022-01-11 19:16:47 +01:00
Terts Diepraam
6e34d8a53c hashsum: clap 3 2022-01-11 19:16:47 +01:00
Terts Diepraam
742fe8500c groups: clap 3 2022-01-11 19:16:47 +01:00
Terts Diepraam
ebe96f1454 fold: clap 3 2022-01-11 19:16:47 +01:00
Terts Diepraam
e3e35cb1a9 fmt: clap 3 2022-01-11 19:16:47 +01:00
Terts Diepraam
df5bf0c2a4 false: clap 3 2022-01-11 19:16:47 +01:00
Terts Diepraam
b5ba2fc5ca factor: clap 3 2022-01-11 19:16:47 +01:00
Terts Diepraam
55eb4a271b expr: clap 3 2022-01-11 19:16:47 +01:00
Terts Diepraam
449a536c59 expand: clap 3 2022-01-11 19:16:47 +01:00
Terts Diepraam
4d917e28b2 env: clap 3 2022-01-11 19:16:47 +01:00
Terts Diepraam
812f2db464 echo: clap 3 2022-01-11 19:16:47 +01:00
Terts Diepraam
1f2c3064b8 du: clap 3 2022-01-11 19:16:47 +01:00
Terts Diepraam
db1e630c6c dirname: clap 3 2022-01-11 19:16:47 +01:00
Terts Diepraam
9bd1c3e967 dircolors: clap 3 2022-01-11 19:16:47 +01:00
Terts Diepraam
739217968f df: clap 3 2022-01-11 19:16:47 +01:00
Terts Diepraam
11bfb5c73f dd: clap 3 2022-01-11 19:16:47 +01:00
Terts Diepraam
f5797275b7 date: clap 3 2022-01-11 19:16:47 +01:00
Terts Diepraam
7a0309a5aa cut: clap 3 2022-01-11 19:16:47 +01:00
Terts Diepraam
88447c2e50 csplit: clap 3 2022-01-11 19:16:47 +01:00
Terts Diepraam
37ab05bd7a cp: clap 3 2022-01-11 19:16:47 +01:00
Terts Diepraam
99a3dc324c comm: clap 3 2022-01-11 19:16:47 +01:00
Terts Diepraam
cf78121746 cksum: clap 3 2022-01-11 19:16:47 +01:00
Terts Diepraam
16afe58371 chroot: clap 3 2022-01-11 19:16:47 +01:00
Terts Diepraam
8261cf05f3 chown: clap 3 2022-01-11 19:16:47 +01:00
Terts Diepraam
2576615576 chmod: clap 3 2022-01-11 19:16:47 +01:00
Terts Diepraam
e4acb64880 chgrp: clap 3 2022-01-11 19:16:47 +01:00
Terts Diepraam
f35b132f67 chcon: clap 3 2022-01-11 19:16:47 +01:00
Terts Diepraam
048cfaf97f cat: clap 3 2022-01-11 19:16:47 +01:00
Terts Diepraam
fb1f9ecf80 basenc: clap 3 2022-01-11 19:16:47 +01:00
Terts Diepraam
7e9529b8b8 arch: clap 3 2022-01-11 19:16:47 +01:00
Terts Diepraam
031bde97bf base32: clap 3 2022-01-11 19:16:47 +01:00
Terts Diepraam
0fb7ceb1a0 base64: remove clap dependency (handled by base_common) 2022-01-11 19:06:36 +01:00
Terts Diepraam
67e5ede0a1 basename: clap 3 2022-01-11 19:06:36 +01:00
Sylvestre Ledru
6723a54610
Merge pull request #2862 from rivy/fix.whitespace
refactor/polish ~ whitespace fixup
2022-01-11 17:51:37 +01:00
kimono-koans
016d5e72ad
ls: Fix padding for dangling links in non-Long formats (#2856)
* Fix padding for dangling links in non-long formats

Co-authored-by: electricboogie <32370782+electricboogie@users.noreply.github.com>
2022-01-11 12:01:54 +01:00
Jeffrey Finkelstein
cfe5a0d82c split: correct filename creation algorithm
Fix two issues with the filename creation algorithm. First, this
corrects the behavior of the `-a` option. This commit ensures a
failure occurs when the number of chunks exceeds the number of
filenames representable with the specified fixed width:

    $ printf "%0.sa" {1..11} | split -d -b 1 -a 1
    split: output file suffixes exhausted

Second, this corrects the behavior of the default behavior when `-a`
is not specified on the command line. Previously, it was always
settings the filenames to have length 2 suffixes. This commit corrects
the behavior to follow the algorithm implied by GNU split, where the
filename lengths grow dynamically by two characters once the number of
chunks grows sufficiently large:

    $ printf "%0.sa" {1..91} | ./target/debug/coreutils split -d -b 1 \
    >   && ls x* | tail
    x81
    x82
    x83
    x84
    x85
    x86
    x87
    x88
    x89
    x9000
2022-01-10 20:43:22 -05:00
Jeffrey Finkelstein
e5d6b7a1cf split: correct arg parameters for -b option 2022-01-10 20:43:22 -05:00
Terts Diepraam
f60c36f242
Merge pull request #2610 from miDeb/cp/abuse
cp: handle edge cases when dest is a symlink
2022-01-11 00:34:55 +01:00
Roy Ivy III
7a760cae99 refactor/polish ~ re-normalize whitespace
* minimize inconsistent/invisible whitespace

- consistent indentation (either spaces-only, tabs, *or* tabs with following spaces [for indentation])
- no internal/invisible tabs
- no trailing whitespace
- EOF EOLNs
2022-01-09 21:35:39 -06:00
Roy Ivy III
d6b93e42c9 update ~ pin 'retain_mut' to v0.1.2 (with MinSRV maint ToDO)
- v0.1.5 uses const generics which aren't stable until rust v1.51.0
2022-01-09 18:57:25 -06:00
Roy Ivy III
774e72551b change ~ relax 'nix' version and remove 'nix' patch
- code coverage compilation on MacOS latest (MacOS-11+) now works with newer 'nix' versions
2022-01-09 18:57:25 -06:00
Sylvestre Ledru
dcfdeb334d
Merge pull request #2854 from kimono-koans/ls_fix_errno_1
ls: Fix Errno 1, print errors at the md call point
2022-01-09 20:56:06 +01:00
moko256
5659bf8fae
ls: On Windows use DirEntry#metadata() instead of fs::metadata 2022-01-10 02:56:22 +09:00
Sylvestre Ledru
63ef039b4f
Merge pull request #2826 from jfinkels/stdbuf-uresult
stdbuf: return UResult from uumain() function
2022-01-08 22:34:06 +01:00
Sylvestre Ledru
6637fba988
Merge pull request #2833 from jfinkels/tr-uresult
tr: return UResult from uumain() function
2022-01-08 22:30:43 +01:00
Sylvestre Ledru
a007ef2c1a
Merge pull request #2834 from jfinkels/truncate-uresult
truncate: return UResult from uumain() function
2022-01-08 22:29:57 +01:00
kimono-koans
4ea61545c6
Merge branch 'uutils:master' into ls_fix_errno_1 2022-01-07 21:48:53 -06:00
Sylvestre Ledru
9922e48ba6
Merge pull request #2853 from kimono-koans/ls_fix_first_newline
ls: Fix newline when only dirs in base directory
2022-01-07 23:10:44 +01:00