Ed Page
fa02111092
chore: Switch to workspace inheritance
2023-01-09 12:35:54 -06:00
Ed Page
f25fe5b3e0
chore: Bump MSRV to 1.64.0
2023-01-09 12:29:41 -06:00
Ed Page
fda2a961cb
Merge pull request #4614 from epage/fix
...
test(builder): Fix failing test
2023-01-09 12:14:39 -06:00
Ed Page
d745c32f4f
test(builder): Fix failing test
2023-01-09 11:59:20 -06:00
Ed Page
ac6b4cdf34
Merge pull request #4610 from tgross35/patch-1
...
Fix example that as runtime panic. Relates to #3864
2023-01-06 19:48:25 -06:00
Trevor Gross
c062182e1e
docs: fix example that as runtime panic. Relates to #3864
...
Relevant comment: https://github.com/clap-rs/clap/issues/3864#issuecomment-1374297155
2023-01-06 19:24:12 -05:00
Ed Page
7d57df5c89
Merge pull request #4609 from epage/error
...
fix(error): Try to polish/clarify messages
2023-01-06 17:26:25 -06:00
Ed Page
762b06fba4
fix(error): Try to polish/clarify messages
...
In text communication you need to balance
- Scannability, putting the most important information upfront
- Brevity so people don't get lost in the message
- Softness to help ease people through a frustrating experience
I feel we weren't doing great on the first two points, so tried to
iterate on the messages to improve them. I hope we aren't suffering too
much on the third point as a side effect.
2023-01-06 17:01:36 -06:00
Ed Page
3e7ca92173
chore: Upgrade trycmd
2023-01-06 16:43:40 -06:00
Ed Page
689c77a682
Merge pull request #4602 from epage/errors2
...
fix(error): More closely match rustc's error style
2023-01-03 13:41:58 -06:00
Ed Page
68a7740fdc
fix(error): Match rustc for giving more information
2023-01-03 13:22:35 -06:00
Ed Page
c2efb60a5f
fix(error): Lowercase the start of error messages
...
This matches the rustc error style
2023-01-03 13:17:46 -06:00
Ed Page
e7d58b3daf
Merge pull request #4385 from epage/errors
...
fix(error): Be consistent with rustc diagnostic guidelines
2023-01-03 12:54:16 -06:00
Ed Page
7229047d78
Merge pull request #4514 from noritada/notes-on-cargo-env-vars
...
docs: Present other environment variable alternatives to `crate_name!`
2023-01-03 12:44:42 -06:00
Ed Page
206d2e47a6
Merge pull request #4601 from epage/short
...
fix(help): Remove extraneous text from built-ins
2023-01-03 12:43:39 -06:00
Ed Page
36bc641648
fix(help): Remove extraneous text from built-ins
...
This is an intermediate solution for #4408 . As there were no agreeed
upon goals, I went with what I felt read well and that I saw commonly
used on non-clap commands.
- "information" isn't really a necessary word.
- I originally favored `Print this help` but realied that doesn't read
correctly in completions.
- Besides being shorter, the reason for the flipped short/long hint is
it gives people the context they need for scanning, emphasizing
"summary" and "more".
Fixes #4409
2023-01-03 11:02:26 -06:00
Ed Page
e7033f775f
Merge pull request #4515 from epage/wasm
...
chore(ci): Force setting of toolchain target
2023-01-03 09:42:52 -06:00
Ed Page
67864a4bb8
chore(ci): Disable color for wasm
2023-01-03 09:28:04 -06:00
Ed Page
09b51b58a2
chore: Update terminal_size
2023-01-03 09:28:01 -06:00
Ed Page
38872b604c
chore(ci): Don't check tests for wasm
...
Some of our testing infrastructure isn't wasm friendly.
2023-01-03 09:16:49 -06:00
Ed Page
2ef5ecd15a
chore(ci): Force setting of toolchain target
2023-01-03 09:04:11 -06:00
Ed Page
a87b55900d
doc(derive): Clarify default_value_t reqs
...
Fixes #4599
2023-01-02 22:37:24 -06:00
Ed Page
2ce5f46f5c
Merge pull request #4596 from orf/patch-2
...
Fix typo in clap-derive error message
2023-01-02 07:18:14 -06:00
Tom Forbes
1b32087418
Fix typo in clap-derive error message
...
I assume "litersl" should be "literals"?
2023-01-02 01:39:14 +00:00
Ed Page
ce1634e3b0
Merge pull request #4593 from clap-rs/renovate/compatible-(dev)
...
chore(deps): update compatible (dev)
2022-12-31 21:49:12 -06:00
renovate[bot]
acfc493a35
chore(deps): update compatible (dev)
2023-01-01 02:25:24 +00:00
Ed Page
ec4ccf005d
chore: Release
2022-12-22 13:21:07 -06:00
Ed Page
13fdb839b7
docs: Update changelog
2022-12-22 13:21:00 -06:00
Ed Page
b877345769
Merge pull request #4573 from epage/conflict
...
fix(parser): Override required when parent group has conflict
2022-12-22 13:19:46 -06:00
Ed Page
85ecb3e895
fix(parser): Override required when parent group has conflict
...
Fixes #4569
2022-12-22 13:09:14 -06:00
Ed Page
d145b8b166
test(parser): Demonstrate required-overload bug
2022-12-22 13:08:02 -06:00
Ed Page
0eccd556ac
chore: Release
2022-12-22 12:40:15 -06:00
Ed Page
1e37c25f5e
docs: Update changelog
2022-12-22 12:39:31 -06:00
Ed Page
dcd5fecab0
Merge pull request #4572 from epage/group
...
perf(parser): Reduce lookups for conflicts
2022-12-22 12:38:29 -06:00
Ed Page
dde22e74ca
style: Update for latest clippy
2022-12-22 12:25:33 -06:00
Ed Page
dd8435d8f3
perf(parser): Reduce duplicate lookups
...
Didn't actually see much of a gain because this isn't in a hot loop but
thought I'd keep it.
2022-12-22 12:17:24 -06:00
Ed Page
4a34b9dd43
perf(parser): Reduce lookups for conflicts
...
We already need to lookup every present-arg for conflicts, so we might
as well cache it ahead of time. This let's us move some operations to
be immutable so we can more easily cache other lookups.
For me, this gave a 70% speed improvement for #4516 with mixed results
on normal benchmarks
2022-12-22 12:16:37 -06:00
Ed Page
9242e1dd00
Merge pull request #4566 from hitenkoku/fix/4565
...
removed {bin} variable from help_template
2022-12-22 10:33:22 -06:00
DastInDark
b72ad5892c
fix: Added cfg in help_template
2022-12-22 01:38:49 +09:00
DastInDark
c6058dee6e
fix(help_template): Added cfg
2022-12-22 01:13:20 +09:00
DastInDark
a7a8241487
docs(command): Added deprecated suffix in help string
2022-12-22 01:13:20 +09:00
DastInDark
a42204243a
fix(help_template): Remove {bin} variable
2022-12-22 01:13:02 +09:00
Ed Page
957288c3f5
Merge pull request #4544 from tmccombs/group-action
...
Update grouped_values_of to use typed API and add support in derive
2022-12-21 08:01:29 -06:00
Thayne McCombs
6abc2cfc3b
feat: Add get/remove API for getting grouped values
...
Change it to be more consistent with get_one and get_many and related
functions.
Relates-To: #2924
2022-12-20 22:50:03 -07:00
Ed Page
d2d022248b
chore: Release
2022-12-20 20:40:55 -06:00
Ed Page
56a0bb624f
docs: Update changelog
2022-12-20 20:40:13 -06:00
Ed Page
b941a3eaef
Merge pull request #4567 from epage/error
...
fix(parser): Be less confusing with args/subcommand conflicts
2022-12-20 20:39:32 -06:00
Ed Page
453ac0bfb9
fix(parser): Be less confusing with args/subcommand conflicts
...
The new error message still isn't great but its better than the old one.
Reported at https://hachyderm.io/@eminence/109548978776785113
2022-12-20 20:27:58 -06:00
Ed Page
2a374db639
test(parser): Show bad behavior
2022-12-20 20:23:49 -06:00
Ed Page
f632424e65
test(parser): Consolidate args_conflicts_with tests
2022-12-20 20:23:44 -06:00