bevy/crates/bevy_ecs/src
Boxy df31b7d762 Remove insert_resource_with_id (#5608)
# Objective

remove `insert_resource_with_id` because `insert_resource_by_id` exists and does almost exactly the same thing

blocked on #5587 because otherwise we will leak a resource when it's inserted 

## Solution

remove the function and also add a safety invariant of to `insert_resource_by_id` that the id be valid for the world.

I didn't see any discussion in #4447 about this safety invariant being left off in favor of a panic so I'm curious if there was one or if it just seemed nicer to have less safety invariants for callers to uphold 😅 

---

## Changelog

- safety invariant added to `insert_resource_by_id` requiring the id to be valid for world

## Migration Guide

- audit any calls to `insert_resource_by_id` making sure that the id is valid for the world

Co-authored-by: Carter Anderson <mcanders1@gmail.com>
2022-08-30 20:32:15 +00:00
..
entity Make most Entity methods const (#5688) 2022-08-30 03:16:22 +00:00
query Add documentation to QueryCombinationIter (#5739) 2022-08-30 00:39:17 +00:00
schedule Remove an outdated workaround for impl Trait (#5659) 2022-08-16 23:40:24 +00:00
storage Remove insert_resource_with_id (#5608) 2022-08-30 20:32:15 +00:00
system Add a module for common system chain/pipe adapters (#5776) 2022-08-30 00:17:20 +00:00
world Remove insert_resource_with_id (#5608) 2022-08-30 20:32:15 +00:00
archetype.rs Fix various typos (#5417) 2022-07-21 20:46:54 +00:00
bundle.rs add more SAFETY comments and lint for missing ones in bevy_ecs (#4835) 2022-07-04 14:44:24 +00:00
change_detection.rs remove ReflectMut in favor of Mut<dyn Reflect> (#5630) 2022-08-09 16:19:34 +00:00
component.rs add more SAFETY comments and lint for missing ones in bevy_ecs (#4835) 2022-07-04 14:44:24 +00:00
event.rs Warning message for missing events (#5730) 2022-08-30 02:23:04 +00:00
lib.rs Add a module for common system chain/pipe adapters (#5776) 2022-08-30 00:17:20 +00:00
reflect.rs remove ReflectMut in favor of Mut<dyn Reflect> (#5630) 2022-08-09 16:19:34 +00:00