mirror of
https://github.com/bevyengine/bevy
synced 2024-11-22 20:53:53 +00:00
4847f7e3ad
Remove unnecessary calls to `iter()`/`iter_mut()`.
Mainly updates the use of queries in our code, docs, and examples.
```rust
// From
for _ in list.iter() {
for _ in list.iter_mut() {
// To
for _ in &list {
for _ in &mut list {
```
We already enable the pedantic lint [clippy::explicit_iter_loop](https://rust-lang.github.io/rust-clippy/stable/) inside of Bevy. However, this only warns for a few known types from the standard library.
## Note for reviewers
As you can see the additions and deletions are exactly equal.
Maybe give it a quick skim to check I didn't sneak in a crypto miner, but you don't have to torture yourself by reading every line.
I already experienced enough pain making this PR :)
Co-authored-by: devil-ira <justthecooldude@gmail.com>
57 lines
1.6 KiB
Rust
57 lines
1.6 KiB
Rust
//! Loads and renders a glTF file as a scene.
|
|
|
|
use bevy::prelude::*;
|
|
|
|
fn main() {
|
|
App::new()
|
|
.insert_resource(AmbientLight {
|
|
color: Color::WHITE,
|
|
brightness: 1.0 / 5.0f32,
|
|
})
|
|
.add_plugins(DefaultPlugins)
|
|
.add_startup_system(setup)
|
|
.add_system(animate_light_direction)
|
|
.run();
|
|
}
|
|
|
|
fn setup(mut commands: Commands, asset_server: Res<AssetServer>) {
|
|
commands.spawn_bundle(Camera3dBundle {
|
|
transform: Transform::from_xyz(0.7, 0.7, 1.0).looking_at(Vec3::new(0.0, 0.3, 0.0), Vec3::Y),
|
|
..default()
|
|
});
|
|
const HALF_SIZE: f32 = 1.0;
|
|
commands.spawn_bundle(DirectionalLightBundle {
|
|
directional_light: DirectionalLight {
|
|
shadow_projection: OrthographicProjection {
|
|
left: -HALF_SIZE,
|
|
right: HALF_SIZE,
|
|
bottom: -HALF_SIZE,
|
|
top: HALF_SIZE,
|
|
near: -10.0 * HALF_SIZE,
|
|
far: 10.0 * HALF_SIZE,
|
|
..default()
|
|
},
|
|
shadows_enabled: true,
|
|
..default()
|
|
},
|
|
..default()
|
|
});
|
|
commands.spawn_bundle(SceneBundle {
|
|
scene: asset_server.load("models/FlightHelmet/FlightHelmet.gltf#Scene0"),
|
|
..default()
|
|
});
|
|
}
|
|
|
|
fn animate_light_direction(
|
|
time: Res<Time>,
|
|
mut query: Query<&mut Transform, With<DirectionalLight>>,
|
|
) {
|
|
for mut transform in &mut query {
|
|
transform.rotation = Quat::from_euler(
|
|
EulerRot::ZYX,
|
|
0.0,
|
|
time.seconds_since_startup() as f32 * std::f32::consts::TAU / 10.0,
|
|
-std::f32::consts::FRAC_PI_4,
|
|
);
|
|
}
|
|
}
|