mirror of
https://github.com/bevyengine/bevy
synced 2024-12-23 11:33:06 +00:00
6a85eb3d7e
# Objective Add a convenient immediate mode drawing API for visual debugging. Fixes #5619 Alternative to #1625 Partial alternative to #5734 Based off https://github.com/Toqozz/bevy_debug_lines with some changes: * Simultaneous support for 2D and 3D. * Methods for basic shapes; circles, spheres, rectangles, boxes, etc. * 2D methods. * Removed durations. Seemed niche, and can be handled by users. <details> <summary>Performance</summary> Stress tested using Bevy's recommended optimization settings for the dev profile with the following command. ```bash cargo run --example many_debug_lines \ --config "profile.dev.package.\"*\".opt-level=3" \ --config "profile.dev.opt-level=1" ``` I dipped to 65-70 FPS at 300,000 lines CPU: 3700x RAM Speed: 3200 Mhz GPU: 2070 super - probably not very relevant, mostly cpu/memory bound </details> <details> <summary>Fancy bloom screenshot</summary> ![Screenshot_20230207_155033](https://user-images.githubusercontent.com/29694403/217291980-f1e0500e-7a14-4131-8c96-eaaaf52596ae.png) </details> ## Changelog * Added `GizmoPlugin` * Added `Gizmos` system parameter for drawing lines and wireshapes. ### TODO - [ ] Update changelog - [x] Update performance numbers - [x] Add credit to PR description ### Future work - Cache rendering primitives instead of constructing them out of line segments each frame. - Support for drawing solid meshes - Interactions. (See [bevy_mod_gizmos](https://github.com/LiamGallagher737/bevy_mod_gizmos)) - Fancier line drawing. (See [bevy_polyline](https://github.com/ForesightMiningSoftwareCorporation/bevy_polyline)) - Support for `RenderLayers` - Display gizmos for a certain duration. Currently everything displays for one frame (ie. immediate mode) - Changing settings per drawn item like drawing on top or drawing to different `RenderLayers` Co-Authored By: @lassade <felipe.jorge.pereira@gmail.com> Co-Authored By: @The5-1 <agaku@hotmail.de> Co-Authored By: @Toqozz <toqoz@hotmail.com> Co-Authored By: @nicopap <nico@nicopap.ch> --------- Co-authored-by: Robert Swain <robert.swain@gmail.com> Co-authored-by: IceSentry <c.giguere42@gmail.com> Co-authored-by: Carter Anderson <mcanders1@gmail.com>
164 lines
5.3 KiB
Rust
164 lines
5.3 KiB
Rust
use bevy_asset::Handle;
|
|
use bevy_core_pipeline::core_3d::Opaque3d;
|
|
use bevy_ecs::{
|
|
entity::Entity,
|
|
query::With,
|
|
system::{Query, Res, ResMut, Resource},
|
|
world::{FromWorld, World},
|
|
};
|
|
use bevy_pbr::*;
|
|
use bevy_render::{
|
|
mesh::Mesh,
|
|
render_resource::Shader,
|
|
view::{ExtractedView, ViewTarget},
|
|
};
|
|
use bevy_render::{
|
|
mesh::MeshVertexBufferLayout,
|
|
render_asset::RenderAssets,
|
|
render_phase::{DrawFunctions, RenderPhase, SetItemPipeline},
|
|
render_resource::*,
|
|
texture::BevyDefault,
|
|
view::Msaa,
|
|
};
|
|
|
|
use crate::{GizmoConfig, GizmoMesh, LINE_SHADER_HANDLE};
|
|
|
|
#[derive(Resource)]
|
|
pub(crate) struct GizmoPipeline {
|
|
mesh_pipeline: MeshPipeline,
|
|
shader: Handle<Shader>,
|
|
}
|
|
|
|
impl FromWorld for GizmoPipeline {
|
|
fn from_world(render_world: &mut World) -> Self {
|
|
GizmoPipeline {
|
|
mesh_pipeline: render_world.resource::<MeshPipeline>().clone(),
|
|
shader: LINE_SHADER_HANDLE.typed(),
|
|
}
|
|
}
|
|
}
|
|
|
|
impl SpecializedMeshPipeline for GizmoPipeline {
|
|
type Key = (bool, MeshPipelineKey);
|
|
|
|
fn specialize(
|
|
&self,
|
|
(depth_test, key): Self::Key,
|
|
layout: &MeshVertexBufferLayout,
|
|
) -> Result<RenderPipelineDescriptor, SpecializedMeshPipelineError> {
|
|
let mut shader_defs = Vec::new();
|
|
shader_defs.push("GIZMO_LINES_3D".into());
|
|
shader_defs.push(ShaderDefVal::Int(
|
|
"MAX_DIRECTIONAL_LIGHTS".to_string(),
|
|
MAX_DIRECTIONAL_LIGHTS as i32,
|
|
));
|
|
shader_defs.push(ShaderDefVal::Int(
|
|
"MAX_CASCADES_PER_LIGHT".to_string(),
|
|
MAX_CASCADES_PER_LIGHT as i32,
|
|
));
|
|
if depth_test {
|
|
shader_defs.push("DEPTH_TEST".into());
|
|
}
|
|
|
|
let vertex_buffer_layout = layout.get_layout(&[
|
|
Mesh::ATTRIBUTE_POSITION.at_shader_location(0),
|
|
Mesh::ATTRIBUTE_COLOR.at_shader_location(1),
|
|
])?;
|
|
let bind_group_layout = match key.msaa_samples() {
|
|
1 => vec![self.mesh_pipeline.view_layout.clone()],
|
|
_ => {
|
|
shader_defs.push("MULTISAMPLED".into());
|
|
vec![self.mesh_pipeline.view_layout_multisampled.clone()]
|
|
}
|
|
};
|
|
|
|
let format = if key.contains(MeshPipelineKey::HDR) {
|
|
ViewTarget::TEXTURE_FORMAT_HDR
|
|
} else {
|
|
TextureFormat::bevy_default()
|
|
};
|
|
|
|
Ok(RenderPipelineDescriptor {
|
|
vertex: VertexState {
|
|
shader: self.shader.clone_weak(),
|
|
entry_point: "vertex".into(),
|
|
shader_defs: shader_defs.clone(),
|
|
buffers: vec![vertex_buffer_layout],
|
|
},
|
|
fragment: Some(FragmentState {
|
|
shader: self.shader.clone_weak(),
|
|
shader_defs,
|
|
entry_point: "fragment".into(),
|
|
targets: vec![Some(ColorTargetState {
|
|
format,
|
|
blend: None,
|
|
write_mask: ColorWrites::ALL,
|
|
})],
|
|
}),
|
|
layout: bind_group_layout,
|
|
primitive: PrimitiveState {
|
|
topology: key.primitive_topology(),
|
|
..Default::default()
|
|
},
|
|
depth_stencil: Some(DepthStencilState {
|
|
format: TextureFormat::Depth32Float,
|
|
depth_write_enabled: true,
|
|
depth_compare: CompareFunction::Greater,
|
|
stencil: Default::default(),
|
|
bias: Default::default(),
|
|
}),
|
|
multisample: MultisampleState {
|
|
count: key.msaa_samples(),
|
|
mask: !0,
|
|
alpha_to_coverage_enabled: false,
|
|
},
|
|
push_constant_ranges: vec![],
|
|
label: Some("gizmo_3d_pipeline".into()),
|
|
})
|
|
}
|
|
}
|
|
|
|
pub(crate) type DrawGizmoLines = (
|
|
SetItemPipeline,
|
|
SetMeshViewBindGroup<0>,
|
|
SetMeshBindGroup<1>,
|
|
DrawMesh,
|
|
);
|
|
|
|
#[allow(clippy::too_many_arguments)]
|
|
pub(crate) fn queue_gizmos_3d(
|
|
draw_functions: Res<DrawFunctions<Opaque3d>>,
|
|
pipeline: Res<GizmoPipeline>,
|
|
mut pipelines: ResMut<SpecializedMeshPipelines<GizmoPipeline>>,
|
|
pipeline_cache: Res<PipelineCache>,
|
|
render_meshes: Res<RenderAssets<Mesh>>,
|
|
msaa: Res<Msaa>,
|
|
mesh_handles: Query<(Entity, &Handle<Mesh>), With<GizmoMesh>>,
|
|
config: Res<GizmoConfig>,
|
|
mut views: Query<(&ExtractedView, &mut RenderPhase<Opaque3d>)>,
|
|
) {
|
|
let draw_function = draw_functions.read().get_id::<DrawGizmoLines>().unwrap();
|
|
let key = MeshPipelineKey::from_msaa_samples(msaa.samples());
|
|
for (view, mut phase) in &mut views {
|
|
let key = key | MeshPipelineKey::from_hdr(view.hdr);
|
|
for (entity, mesh_handle) in &mesh_handles {
|
|
if let Some(mesh) = render_meshes.get(mesh_handle) {
|
|
let key = key | MeshPipelineKey::from_primitive_topology(mesh.primitive_topology);
|
|
let pipeline = pipelines
|
|
.specialize(
|
|
&pipeline_cache,
|
|
&pipeline,
|
|
(!config.on_top, key),
|
|
&mesh.layout,
|
|
)
|
|
.unwrap();
|
|
phase.add(Opaque3d {
|
|
entity,
|
|
pipeline,
|
|
draw_function,
|
|
distance: 0.,
|
|
});
|
|
}
|
|
}
|
|
}
|
|
}
|