mirror of
https://github.com/bevyengine/bevy
synced 2024-12-22 02:53:07 +00:00
3ead10a3e0
# Objective The clippy lint `type_complexity` is known not to play well with bevy. It frequently triggers when writing complex queries, and taking the lint's advice of using a type alias almost always just obfuscates the code with no benefit. Because of this, this lint is currently ignored in CI, but unfortunately it still shows up when viewing bevy code in an IDE. As someone who's made a fair amount of pull requests to this repo, I will say that this issue has been a consistent thorn in my side. Since bevy code is filled with spurious, ignorable warnings, it can be very difficult to spot the *real* warnings that must be fixed -- most of the time I just ignore all warnings, only to later find out that one of them was real after I'm done when CI runs. ## Solution Suppress this lint in all bevy crates. This was previously attempted in #7050, but the review process ended up making it more complicated than it needs to be and landed on a subpar solution. The discussion in https://github.com/rust-lang/rust-clippy/pull/10571 explores some better long-term solutions to this problem. Since there is no timeline on when these solutions may land, we should resolve this issue in the meantime by locally suppressing these lints. ### Unresolved issues Currently, these lints are not suppressed in our examples, since that would require suppressing the lint in every single source file. They are still ignored in CI.
133 lines
5 KiB
Rust
133 lines
5 KiB
Rust
#![allow(clippy::type_complexity)]
|
|
#![warn(missing_docs)]
|
|
#![warn(clippy::undocumented_unsafe_blocks)]
|
|
#![doc = include_str!("../README.md")]
|
|
|
|
pub mod commands;
|
|
/// The basic components of the transform crate
|
|
pub mod components;
|
|
/// Systems responsible for transform propagation
|
|
pub mod systems;
|
|
|
|
#[doc(hidden)]
|
|
pub mod prelude {
|
|
#[doc(hidden)]
|
|
pub use crate::{
|
|
commands::BuildChildrenTransformExt, components::*, TransformBundle, TransformPlugin,
|
|
};
|
|
}
|
|
|
|
use bevy_app::prelude::*;
|
|
use bevy_ecs::prelude::*;
|
|
use bevy_hierarchy::ValidParentCheckPlugin;
|
|
use prelude::{GlobalTransform, Transform};
|
|
use systems::{propagate_transforms, sync_simple_transforms};
|
|
|
|
/// A [`Bundle`] of the [`Transform`] and [`GlobalTransform`]
|
|
/// [`Component`](bevy_ecs::component::Component)s, which describe the position of an entity.
|
|
///
|
|
/// * To place or move an entity, you should set its [`Transform`].
|
|
/// * To get the global transform of an entity, you should get its [`GlobalTransform`].
|
|
/// * For transform hierarchies to work correctly, you must have both a [`Transform`] and a [`GlobalTransform`].
|
|
/// * You may use the [`TransformBundle`] to guarantee this.
|
|
///
|
|
/// ## [`Transform`] and [`GlobalTransform`]
|
|
///
|
|
/// [`Transform`] is the position of an entity relative to its parent position, or the reference
|
|
/// frame if it doesn't have a parent.
|
|
///
|
|
/// [`GlobalTransform`] is the position of an entity relative to the reference frame.
|
|
///
|
|
/// [`GlobalTransform`] is updated from [`Transform`] by systems in the system set
|
|
/// [`TransformPropagate`](crate::TransformSystem::TransformPropagate).
|
|
///
|
|
/// This system runs during [`PostUpdate`](bevy_app::PostUpdate). If you
|
|
/// update the [`Transform`] of an entity in this schedule or after, you will notice a 1 frame lag
|
|
/// before the [`GlobalTransform`] is updated.
|
|
#[derive(Bundle, Clone, Copy, Debug, Default)]
|
|
pub struct TransformBundle {
|
|
/// The transform of the entity.
|
|
pub local: Transform,
|
|
/// The global transform of the entity.
|
|
pub global: GlobalTransform,
|
|
}
|
|
|
|
impl TransformBundle {
|
|
/// An identity [`TransformBundle`] with no translation, rotation, and a scale of 1 on all axes.
|
|
pub const IDENTITY: Self = TransformBundle {
|
|
local: Transform::IDENTITY,
|
|
global: GlobalTransform::IDENTITY,
|
|
};
|
|
|
|
/// Creates a new [`TransformBundle`] from a [`Transform`].
|
|
///
|
|
/// This initializes [`GlobalTransform`] as identity, to be updated later by the
|
|
/// [`PostUpdate`](bevy_app::PostUpdate) schedule.
|
|
#[inline]
|
|
pub const fn from_transform(transform: Transform) -> Self {
|
|
TransformBundle {
|
|
local: transform,
|
|
..Self::IDENTITY
|
|
}
|
|
}
|
|
}
|
|
|
|
impl From<Transform> for TransformBundle {
|
|
#[inline]
|
|
fn from(transform: Transform) -> Self {
|
|
Self::from_transform(transform)
|
|
}
|
|
}
|
|
/// Set enum for the systems relating to transform propagation
|
|
#[derive(Debug, Hash, PartialEq, Eq, Clone, SystemSet)]
|
|
pub enum TransformSystem {
|
|
/// Propagates changes in transform to children's [`GlobalTransform`](crate::components::GlobalTransform)
|
|
TransformPropagate,
|
|
}
|
|
|
|
/// The base plugin for handling [`Transform`] components
|
|
#[derive(Default)]
|
|
pub struct TransformPlugin;
|
|
|
|
impl Plugin for TransformPlugin {
|
|
fn build(&self, app: &mut App) {
|
|
// A set for `propagate_transforms` to mark it as ambiguous with `sync_simple_transforms`.
|
|
// Used instead of the `SystemTypeSet` as that would not allow multiple instances of the system.
|
|
#[derive(Debug, Hash, PartialEq, Eq, Clone, SystemSet)]
|
|
struct PropagateTransformsSet;
|
|
|
|
app.register_type::<Transform>()
|
|
.register_type::<GlobalTransform>()
|
|
.add_plugin(ValidParentCheckPlugin::<GlobalTransform>::default())
|
|
.configure_set(
|
|
PostStartup,
|
|
PropagateTransformsSet.in_set(TransformSystem::TransformPropagate),
|
|
)
|
|
// add transform systems to startup so the first update is "correct"
|
|
.add_systems(
|
|
PostStartup,
|
|
(
|
|
sync_simple_transforms
|
|
.in_set(TransformSystem::TransformPropagate)
|
|
// FIXME: https://github.com/bevyengine/bevy/issues/4381
|
|
// These systems cannot access the same entities,
|
|
// due to subtle query filtering that is not yet correctly computed in the ambiguity detector
|
|
.ambiguous_with(PropagateTransformsSet),
|
|
propagate_transforms.in_set(PropagateTransformsSet),
|
|
),
|
|
)
|
|
.configure_set(
|
|
PostUpdate,
|
|
PropagateTransformsSet.in_set(TransformSystem::TransformPropagate),
|
|
)
|
|
.add_systems(
|
|
PostUpdate,
|
|
(
|
|
sync_simple_transforms
|
|
.in_set(TransformSystem::TransformPropagate)
|
|
.ambiguous_with(PropagateTransformsSet),
|
|
propagate_transforms.in_set(PropagateTransformsSet),
|
|
),
|
|
);
|
|
}
|
|
}
|