mirror of
https://github.com/bevyengine/bevy
synced 2024-11-10 15:14:50 +00:00
3d79dc4cdc
# Objective Current `FixedTime` and `Time` have several problems. This pull aims to fix many of them at once. - If there is a longer pause between app updates, time will jump forward a lot at once and fixed time will iterate on `FixedUpdate` for a large number of steps. If the pause is merely seconds, then this will just mean jerkiness and possible unexpected behaviour in gameplay. If the pause is hours/days as with OS suspend, the game will appear to freeze until it has caught up with real time. - If calculating a fixed step takes longer than specified fixed step period, the game will enter a death spiral where rendering each frame takes longer and longer due to more and more fixed step updates being run per frame and the game appears to freeze. - There is no way to see current fixed step elapsed time inside fixed steps. In order to track this, the game designer needs to add a custom system inside `FixedUpdate` that calculates elapsed or step count in a resource. - Access to delta time inside fixed step is `FixedStep::period` rather than `Time::delta`. This, coupled with the issue that `Time::elapsed` isn't available at all for fixed steps, makes it that time requiring systems are either implemented to be run in `FixedUpdate` or `Update`, but rarely work in both. - Fixes #8800 - Fixes #8543 - Fixes #7439 - Fixes #5692 ## Solution - Create a generic `Time<T>` clock that has no processing logic but which can be instantiated for multiple usages. This is also exposed for users to add custom clocks. - Create three standard clocks, `Time<Real>`, `Time<Virtual>` and `Time<Fixed>`, all of which contain their individual logic. - Create one "default" clock, which is just `Time` (or `Time<()>`), which will be overwritten from `Time<Virtual>` on each update, and `Time<Fixed>` inside `FixedUpdate` schedule. This way systems that do not care specifically which time they track can work both in `Update` and `FixedUpdate` without changes and the behaviour is intuitive. - Add `max_delta` to virtual time update, which limits how much can be added to virtual time by a single update. This fixes both the behaviour after a long freeze, and also the death spiral by limiting how many fixed timestep iterations there can be per update. Possible future work could be adding `max_accumulator` to add a sort of "leaky bucket" time processing to possibly smooth out jumps in time while keeping frame rate stable. - Many minor tweaks and clarifications to the time functions and their documentation. ## Changelog - `Time::raw_delta()`, `Time::raw_elapsed()` and related methods are moved to `Time<Real>::delta()` and `Time<Real>::elapsed()` and now match `Time` API - `FixedTime` is now `Time<Fixed>` and matches `Time` API. - `Time<Fixed>` default timestep is now 64 Hz, or 15625 microseconds. - `Time` inside `FixedUpdate` now reflects fixed timestep time, making systems portable between `Update ` and `FixedUpdate`. - `Time::pause()`, `Time::set_relative_speed()` and related methods must now be called as `Time<Virtual>::pause()` etc. - There is a new `max_delta` setting in `Time<Virtual>` that limits how much the clock can jump by a single update. The default value is 0.25 seconds. - Removed `on_fixed_timer()` condition as `on_timer()` does the right thing inside `FixedUpdate` now. ## Migration Guide - Change all `Res<Time>` instances that access `raw_delta()`, `raw_elapsed()` and related methods to `Res<Time<Real>>` and `delta()`, `elapsed()`, etc. - Change access to `period` from `Res<FixedTime>` to `Res<Time<Fixed>>` and use `delta()`. - The default timestep has been changed from 60 Hz to 64 Hz. If you wish to restore the old behaviour, use `app.insert_resource(Time::<Fixed>::from_hz(60.0))`. - Change `app.insert_resource(FixedTime::new(duration))` to `app.insert_resource(Time::<Fixed>::from_duration(duration))` - Change `app.insert_resource(FixedTime::new_from_secs(secs))` to `app.insert_resource(Time::<Fixed>::from_seconds(secs))` - Change `system.on_fixed_timer(duration)` to `system.on_timer(duration)`. Timers in systems placed in `FixedUpdate` schedule automatically use the fixed time clock. - Change `ResMut<Time>` calls to `pause()`, `is_paused()`, `set_relative_speed()` and related methods to `ResMut<Time<Virtual>>` calls. The API is the same, with the exception that `relative_speed()` will return the actual last ste relative speed, while `effective_relative_speed()` returns 0.0 if the time is paused and corresponds to the speed that was set when the update for the current frame started. ## Todo - [x] Update pull name and description - [x] Top level documentation on usage - [x] Fix examples - [x] Decide on default `max_delta` value - [x] Decide naming of the three clocks: is `Real`, `Virtual`, `Fixed` good? - [x] Decide if the three clock inner structures should be in prelude - [x] Decide on best way to configure values at startup: is manually inserting a new clock instance okay, or should there be config struct separately? - [x] Fix links in docs - [x] Decide what should be public and what not - [x] Decide how `wrap_period` should be handled when it is changed - [x] ~~Add toggles to disable setting the clock as default?~~ No, separate pull if needed. - [x] Add tests - [x] Reformat, ensure adheres to conventions etc. - [x] Build documentation and see that it looks correct ## Contributors Huge thanks to @alice-i-cecile and @maniwani while building this pull. It was a shared effort! --------- Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com> Co-authored-by: Cameron <51241057+maniwani@users.noreply.github.com> Co-authored-by: Jerome Humbert <djeedai@gmail.com>
415 lines
14 KiB
Rust
415 lines
14 KiB
Rust
//! A simplified implementation of the classic game "Breakout".
|
|
|
|
use bevy::{
|
|
prelude::*,
|
|
sprite::collide_aabb::{collide, Collision},
|
|
sprite::MaterialMesh2dBundle,
|
|
};
|
|
|
|
// These constants are defined in `Transform` units.
|
|
// Using the default 2D camera they correspond 1:1 with screen pixels.
|
|
const PADDLE_SIZE: Vec3 = Vec3::new(120.0, 20.0, 0.0);
|
|
const GAP_BETWEEN_PADDLE_AND_FLOOR: f32 = 60.0;
|
|
const PADDLE_SPEED: f32 = 500.0;
|
|
// How close can the paddle get to the wall
|
|
const PADDLE_PADDING: f32 = 10.0;
|
|
|
|
// We set the z-value of the ball to 1 so it renders on top in the case of overlapping sprites.
|
|
const BALL_STARTING_POSITION: Vec3 = Vec3::new(0.0, -50.0, 1.0);
|
|
const BALL_SIZE: Vec3 = Vec3::new(30.0, 30.0, 0.0);
|
|
const BALL_SPEED: f32 = 400.0;
|
|
const INITIAL_BALL_DIRECTION: Vec2 = Vec2::new(0.5, -0.5);
|
|
|
|
const WALL_THICKNESS: f32 = 10.0;
|
|
// x coordinates
|
|
const LEFT_WALL: f32 = -450.;
|
|
const RIGHT_WALL: f32 = 450.;
|
|
// y coordinates
|
|
const BOTTOM_WALL: f32 = -300.;
|
|
const TOP_WALL: f32 = 300.;
|
|
|
|
const BRICK_SIZE: Vec2 = Vec2::new(100., 30.);
|
|
// These values are exact
|
|
const GAP_BETWEEN_PADDLE_AND_BRICKS: f32 = 270.0;
|
|
const GAP_BETWEEN_BRICKS: f32 = 5.0;
|
|
// These values are lower bounds, as the number of bricks is computed
|
|
const GAP_BETWEEN_BRICKS_AND_CEILING: f32 = 20.0;
|
|
const GAP_BETWEEN_BRICKS_AND_SIDES: f32 = 20.0;
|
|
|
|
const SCOREBOARD_FONT_SIZE: f32 = 40.0;
|
|
const SCOREBOARD_TEXT_PADDING: Val = Val::Px(5.0);
|
|
|
|
const BACKGROUND_COLOR: Color = Color::rgb(0.9, 0.9, 0.9);
|
|
const PADDLE_COLOR: Color = Color::rgb(0.3, 0.3, 0.7);
|
|
const BALL_COLOR: Color = Color::rgb(1.0, 0.5, 0.5);
|
|
const BRICK_COLOR: Color = Color::rgb(0.5, 0.5, 1.0);
|
|
const WALL_COLOR: Color = Color::rgb(0.8, 0.8, 0.8);
|
|
const TEXT_COLOR: Color = Color::rgb(0.5, 0.5, 1.0);
|
|
const SCORE_COLOR: Color = Color::rgb(1.0, 0.5, 0.5);
|
|
|
|
fn main() {
|
|
App::new()
|
|
.add_plugins(DefaultPlugins)
|
|
.insert_resource(Scoreboard { score: 0 })
|
|
.insert_resource(ClearColor(BACKGROUND_COLOR))
|
|
.add_event::<CollisionEvent>()
|
|
.add_systems(Startup, setup)
|
|
// Add our gameplay simulation systems to the fixed timestep schedule
|
|
// which runs at 64 Hz by default
|
|
.add_systems(
|
|
FixedUpdate,
|
|
(
|
|
check_for_collisions,
|
|
apply_velocity.before(check_for_collisions),
|
|
move_paddle
|
|
.before(check_for_collisions)
|
|
.after(apply_velocity),
|
|
play_collision_sound.after(check_for_collisions),
|
|
),
|
|
)
|
|
.add_systems(Update, (update_scoreboard, bevy::window::close_on_esc))
|
|
.run();
|
|
}
|
|
|
|
#[derive(Component)]
|
|
struct Paddle;
|
|
|
|
#[derive(Component)]
|
|
struct Ball;
|
|
|
|
#[derive(Component, Deref, DerefMut)]
|
|
struct Velocity(Vec2);
|
|
|
|
#[derive(Component)]
|
|
struct Collider;
|
|
|
|
#[derive(Event, Default)]
|
|
struct CollisionEvent;
|
|
|
|
#[derive(Component)]
|
|
struct Brick;
|
|
|
|
#[derive(Resource)]
|
|
struct CollisionSound(Handle<AudioSource>);
|
|
|
|
// This bundle is a collection of the components that define a "wall" in our game
|
|
#[derive(Bundle)]
|
|
struct WallBundle {
|
|
// You can nest bundles inside of other bundles like this
|
|
// Allowing you to compose their functionality
|
|
sprite_bundle: SpriteBundle,
|
|
collider: Collider,
|
|
}
|
|
|
|
/// Which side of the arena is this wall located on?
|
|
enum WallLocation {
|
|
Left,
|
|
Right,
|
|
Bottom,
|
|
Top,
|
|
}
|
|
|
|
impl WallLocation {
|
|
fn position(&self) -> Vec2 {
|
|
match self {
|
|
WallLocation::Left => Vec2::new(LEFT_WALL, 0.),
|
|
WallLocation::Right => Vec2::new(RIGHT_WALL, 0.),
|
|
WallLocation::Bottom => Vec2::new(0., BOTTOM_WALL),
|
|
WallLocation::Top => Vec2::new(0., TOP_WALL),
|
|
}
|
|
}
|
|
|
|
fn size(&self) -> Vec2 {
|
|
let arena_height = TOP_WALL - BOTTOM_WALL;
|
|
let arena_width = RIGHT_WALL - LEFT_WALL;
|
|
// Make sure we haven't messed up our constants
|
|
assert!(arena_height > 0.0);
|
|
assert!(arena_width > 0.0);
|
|
|
|
match self {
|
|
WallLocation::Left | WallLocation::Right => {
|
|
Vec2::new(WALL_THICKNESS, arena_height + WALL_THICKNESS)
|
|
}
|
|
WallLocation::Bottom | WallLocation::Top => {
|
|
Vec2::new(arena_width + WALL_THICKNESS, WALL_THICKNESS)
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
impl WallBundle {
|
|
// This "builder method" allows us to reuse logic across our wall entities,
|
|
// making our code easier to read and less prone to bugs when we change the logic
|
|
fn new(location: WallLocation) -> WallBundle {
|
|
WallBundle {
|
|
sprite_bundle: SpriteBundle {
|
|
transform: Transform {
|
|
// We need to convert our Vec2 into a Vec3, by giving it a z-coordinate
|
|
// This is used to determine the order of our sprites
|
|
translation: location.position().extend(0.0),
|
|
// The z-scale of 2D objects must always be 1.0,
|
|
// or their ordering will be affected in surprising ways.
|
|
// See https://github.com/bevyengine/bevy/issues/4149
|
|
scale: location.size().extend(1.0),
|
|
..default()
|
|
},
|
|
sprite: Sprite {
|
|
color: WALL_COLOR,
|
|
..default()
|
|
},
|
|
..default()
|
|
},
|
|
collider: Collider,
|
|
}
|
|
}
|
|
}
|
|
|
|
// This resource tracks the game's score
|
|
#[derive(Resource)]
|
|
struct Scoreboard {
|
|
score: usize,
|
|
}
|
|
|
|
// Add the game's entities to our world
|
|
fn setup(
|
|
mut commands: Commands,
|
|
mut meshes: ResMut<Assets<Mesh>>,
|
|
mut materials: ResMut<Assets<ColorMaterial>>,
|
|
asset_server: Res<AssetServer>,
|
|
) {
|
|
// Camera
|
|
commands.spawn(Camera2dBundle::default());
|
|
|
|
// Sound
|
|
let ball_collision_sound = asset_server.load("sounds/breakout_collision.ogg");
|
|
commands.insert_resource(CollisionSound(ball_collision_sound));
|
|
|
|
// Paddle
|
|
let paddle_y = BOTTOM_WALL + GAP_BETWEEN_PADDLE_AND_FLOOR;
|
|
|
|
commands.spawn((
|
|
SpriteBundle {
|
|
transform: Transform {
|
|
translation: Vec3::new(0.0, paddle_y, 0.0),
|
|
scale: PADDLE_SIZE,
|
|
..default()
|
|
},
|
|
sprite: Sprite {
|
|
color: PADDLE_COLOR,
|
|
..default()
|
|
},
|
|
..default()
|
|
},
|
|
Paddle,
|
|
Collider,
|
|
));
|
|
|
|
// Ball
|
|
commands.spawn((
|
|
MaterialMesh2dBundle {
|
|
mesh: meshes.add(shape::Circle::default().into()).into(),
|
|
material: materials.add(ColorMaterial::from(BALL_COLOR)),
|
|
transform: Transform::from_translation(BALL_STARTING_POSITION).with_scale(BALL_SIZE),
|
|
..default()
|
|
},
|
|
Ball,
|
|
Velocity(INITIAL_BALL_DIRECTION.normalize() * BALL_SPEED),
|
|
));
|
|
|
|
// Scoreboard
|
|
commands.spawn(
|
|
TextBundle::from_sections([
|
|
TextSection::new(
|
|
"Score: ",
|
|
TextStyle {
|
|
font_size: SCOREBOARD_FONT_SIZE,
|
|
color: TEXT_COLOR,
|
|
..default()
|
|
},
|
|
),
|
|
TextSection::from_style(TextStyle {
|
|
font_size: SCOREBOARD_FONT_SIZE,
|
|
color: SCORE_COLOR,
|
|
..default()
|
|
}),
|
|
])
|
|
.with_style(Style {
|
|
position_type: PositionType::Absolute,
|
|
top: SCOREBOARD_TEXT_PADDING,
|
|
left: SCOREBOARD_TEXT_PADDING,
|
|
..default()
|
|
}),
|
|
);
|
|
|
|
// Walls
|
|
commands.spawn(WallBundle::new(WallLocation::Left));
|
|
commands.spawn(WallBundle::new(WallLocation::Right));
|
|
commands.spawn(WallBundle::new(WallLocation::Bottom));
|
|
commands.spawn(WallBundle::new(WallLocation::Top));
|
|
|
|
// Bricks
|
|
let total_width_of_bricks = (RIGHT_WALL - LEFT_WALL) - 2. * GAP_BETWEEN_BRICKS_AND_SIDES;
|
|
let bottom_edge_of_bricks = paddle_y + GAP_BETWEEN_PADDLE_AND_BRICKS;
|
|
let total_height_of_bricks = TOP_WALL - bottom_edge_of_bricks - GAP_BETWEEN_BRICKS_AND_CEILING;
|
|
|
|
assert!(total_width_of_bricks > 0.0);
|
|
assert!(total_height_of_bricks > 0.0);
|
|
|
|
// Given the space available, compute how many rows and columns of bricks we can fit
|
|
let n_columns = (total_width_of_bricks / (BRICK_SIZE.x + GAP_BETWEEN_BRICKS)).floor() as usize;
|
|
let n_rows = (total_height_of_bricks / (BRICK_SIZE.y + GAP_BETWEEN_BRICKS)).floor() as usize;
|
|
let n_vertical_gaps = n_columns - 1;
|
|
|
|
// Because we need to round the number of columns,
|
|
// the space on the top and sides of the bricks only captures a lower bound, not an exact value
|
|
let center_of_bricks = (LEFT_WALL + RIGHT_WALL) / 2.0;
|
|
let left_edge_of_bricks = center_of_bricks
|
|
// Space taken up by the bricks
|
|
- (n_columns as f32 / 2.0 * BRICK_SIZE.x)
|
|
// Space taken up by the gaps
|
|
- n_vertical_gaps as f32 / 2.0 * GAP_BETWEEN_BRICKS;
|
|
|
|
// In Bevy, the `translation` of an entity describes the center point,
|
|
// not its bottom-left corner
|
|
let offset_x = left_edge_of_bricks + BRICK_SIZE.x / 2.;
|
|
let offset_y = bottom_edge_of_bricks + BRICK_SIZE.y / 2.;
|
|
|
|
for row in 0..n_rows {
|
|
for column in 0..n_columns {
|
|
let brick_position = Vec2::new(
|
|
offset_x + column as f32 * (BRICK_SIZE.x + GAP_BETWEEN_BRICKS),
|
|
offset_y + row as f32 * (BRICK_SIZE.y + GAP_BETWEEN_BRICKS),
|
|
);
|
|
|
|
// brick
|
|
commands.spawn((
|
|
SpriteBundle {
|
|
sprite: Sprite {
|
|
color: BRICK_COLOR,
|
|
..default()
|
|
},
|
|
transform: Transform {
|
|
translation: brick_position.extend(0.0),
|
|
scale: Vec3::new(BRICK_SIZE.x, BRICK_SIZE.y, 1.0),
|
|
..default()
|
|
},
|
|
..default()
|
|
},
|
|
Brick,
|
|
Collider,
|
|
));
|
|
}
|
|
}
|
|
}
|
|
|
|
fn move_paddle(
|
|
keyboard_input: Res<Input<KeyCode>>,
|
|
mut query: Query<&mut Transform, With<Paddle>>,
|
|
time: Res<Time>,
|
|
) {
|
|
let mut paddle_transform = query.single_mut();
|
|
let mut direction = 0.0;
|
|
|
|
if keyboard_input.pressed(KeyCode::Left) {
|
|
direction -= 1.0;
|
|
}
|
|
|
|
if keyboard_input.pressed(KeyCode::Right) {
|
|
direction += 1.0;
|
|
}
|
|
|
|
// Calculate the new horizontal paddle position based on player input
|
|
let new_paddle_position =
|
|
paddle_transform.translation.x + direction * PADDLE_SPEED * time.delta_seconds();
|
|
|
|
// Update the paddle position,
|
|
// making sure it doesn't cause the paddle to leave the arena
|
|
let left_bound = LEFT_WALL + WALL_THICKNESS / 2.0 + PADDLE_SIZE.x / 2.0 + PADDLE_PADDING;
|
|
let right_bound = RIGHT_WALL - WALL_THICKNESS / 2.0 - PADDLE_SIZE.x / 2.0 - PADDLE_PADDING;
|
|
|
|
paddle_transform.translation.x = new_paddle_position.clamp(left_bound, right_bound);
|
|
}
|
|
|
|
fn apply_velocity(mut query: Query<(&mut Transform, &Velocity)>, time: Res<Time>) {
|
|
for (mut transform, velocity) in &mut query {
|
|
transform.translation.x += velocity.x * time.delta_seconds();
|
|
transform.translation.y += velocity.y * time.delta_seconds();
|
|
}
|
|
}
|
|
|
|
fn update_scoreboard(scoreboard: Res<Scoreboard>, mut query: Query<&mut Text>) {
|
|
let mut text = query.single_mut();
|
|
text.sections[1].value = scoreboard.score.to_string();
|
|
}
|
|
|
|
fn check_for_collisions(
|
|
mut commands: Commands,
|
|
mut scoreboard: ResMut<Scoreboard>,
|
|
mut ball_query: Query<(&mut Velocity, &Transform), With<Ball>>,
|
|
collider_query: Query<(Entity, &Transform, Option<&Brick>), With<Collider>>,
|
|
mut collision_events: EventWriter<CollisionEvent>,
|
|
) {
|
|
let (mut ball_velocity, ball_transform) = ball_query.single_mut();
|
|
let ball_size = ball_transform.scale.truncate();
|
|
|
|
// check collision with walls
|
|
for (collider_entity, transform, maybe_brick) in &collider_query {
|
|
let collision = collide(
|
|
ball_transform.translation,
|
|
ball_size,
|
|
transform.translation,
|
|
transform.scale.truncate(),
|
|
);
|
|
if let Some(collision) = collision {
|
|
// Sends a collision event so that other systems can react to the collision
|
|
collision_events.send_default();
|
|
|
|
// Bricks should be despawned and increment the scoreboard on collision
|
|
if maybe_brick.is_some() {
|
|
scoreboard.score += 1;
|
|
commands.entity(collider_entity).despawn();
|
|
}
|
|
|
|
// reflect the ball when it collides
|
|
let mut reflect_x = false;
|
|
let mut reflect_y = false;
|
|
|
|
// only reflect if the ball's velocity is going in the opposite direction of the
|
|
// collision
|
|
match collision {
|
|
Collision::Left => reflect_x = ball_velocity.x > 0.0,
|
|
Collision::Right => reflect_x = ball_velocity.x < 0.0,
|
|
Collision::Top => reflect_y = ball_velocity.y < 0.0,
|
|
Collision::Bottom => reflect_y = ball_velocity.y > 0.0,
|
|
Collision::Inside => { /* do nothing */ }
|
|
}
|
|
|
|
// reflect velocity on the x-axis if we hit something on the x-axis
|
|
if reflect_x {
|
|
ball_velocity.x = -ball_velocity.x;
|
|
}
|
|
|
|
// reflect velocity on the y-axis if we hit something on the y-axis
|
|
if reflect_y {
|
|
ball_velocity.y = -ball_velocity.y;
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
fn play_collision_sound(
|
|
mut commands: Commands,
|
|
mut collision_events: EventReader<CollisionEvent>,
|
|
sound: Res<CollisionSound>,
|
|
) {
|
|
// Play a sound once per frame if a collision occurred.
|
|
if !collision_events.is_empty() {
|
|
// This prevents events staying active on the next frame.
|
|
collision_events.clear();
|
|
commands.spawn(AudioBundle {
|
|
source: sound.0.clone(),
|
|
// auto-despawn the entity when playback finishes
|
|
settings: PlaybackSettings::DESPAWN,
|
|
});
|
|
}
|
|
}
|