mirror of
https://github.com/bevyengine/bevy
synced 2024-11-22 12:43:34 +00:00
f8191bebfb
# Objective - Fix a memory leak in the dynamic ECS example mentioned in #11459 ## Solution - Rather than allocate the memory manually instead store a collection of `Vec` that will be dropped after it is used. --- I must have misinterpreted `OwningPtr`s semantics when initially writing this example. I believe we should be able to provide better APIs here for inserting dynamic components that don't require the user to wrangle so much unsafety. We have no other examples using `insert_by_ids` and our only tests show it being used for 1 or 2 values with nested calls to `OwningPtr::make` despite the function taking an iterator. Rust's type system is quite restrictive here but we could at least let `OwningPtr::new` take non u8 `NonNull`. I also agree with #11459 that we should generally be trying to simplify and clarify this example. |
||
|---|---|---|
| .. | ||
| component_change_detection.rs | ||
| custom_query_param.rs | ||
| dynamic.rs | ||
| ecs_guide.rs | ||
| event.rs | ||
| fixed_timestep.rs | ||
| generic_system.rs | ||
| hierarchy.rs | ||
| iter_combinations.rs | ||
| nondeterministic_system_order.rs | ||
| one_shot_systems.rs | ||
| parallel_query.rs | ||
| removal_detection.rs | ||
| run_conditions.rs | ||
| startup_system.rs | ||
| state.rs | ||
| system_closure.rs | ||
| system_param.rs | ||
| system_piping.rs | ||