François Mockers
a8530ebbc8
screenshot comparison: fix upload for macOS... again ( #15914 )
...
# Objective
- Used the wrong variable to set metadata
- new fixes after https://github.com/bevyengine/bevy/pull/15911
## Solution
- Use the right one
- Also keep a reference to the original PR when there's one
2024-10-14 23:20:56 +00:00
François Mockers
8c0fcf02d0
screenshot comparison: prepare macos folder in the expected format by upload-artifact action ( #15911 )
...
# Objective
- After #15894 , creenshot upload now works on linux but still fails on
macOS
- Artifact with screenshot is not prepared correctly:
## Solution
- Try to prepare it like the `upload-artifact` action expects it
2024-10-14 21:16:25 +00:00
François Mockers
bd912c25f7
Fix screenshot comparison ( #15894 )
...
# Objective
- After merging #13248 the new upload job fails
## Solution
- Fix the file path
- Instead of a pull_request_target workflow, keep the examples in the
pull_request workflow and add another job that will run once its all
completed on a `workflow_run` event to upload screenshots
## Testing
- Tested in a ubuntu docker container, running the exact same script
- Manual result:
https://pixel-eagle.com/project/B04F67C0-C054-4A6F-92EC-F599FEC2FD1D/run/5/compare/2
- The CI on this job will still fail as its using the job from main
2024-10-14 19:16:12 +00:00
dependabot[bot]
78c255f9c9
Bump actions/github-script from 6 to 7 ( #10653 )
...
Bumps [actions/github-script](https://github.com/actions/github-script )
from 6 to 7.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/actions/github-script/releases ">actions/github-script's
releases</a>.</em></p>
<blockquote>
<h2>v7.0.0</h2>
<h2>What's Changed</h2>
<ul>
<li>Add base-url option by <a
href="https://github.com/robandpdx "><code>@robandpdx</code></a> in <a
href="https://redirect.github.com/actions/github-script/pull/429 ">actions/github-script#429</a></li>
<li>Expose async-function argument type by <a
href="https://github.com/viktorlott "><code>@viktorlott</code></a> in <a
href="https://redirect.github.com/actions/github-script/pull/402 ">actions/github-script#402</a>,
see for details <a
href="https://github.com/actions/github-script#use-scripts-with-jsdoc-support ">https://github.com/actions/github-script#use-scripts-with-jsdoc-support </a></li>
<li>Update dependencies and use Node 20 by <a
href="https://github.com/joshmgross "><code>@joshmgross</code></a> in <a
href="https://redirect.github.com/actions/github-script/pull/425 ">actions/github-script#425</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a
href="https://github.com/navarroaxel "><code>@navarroaxel</code></a>
made their first contribution in <a
href="https://redirect.github.com/actions/github-script/pull/285 ">actions/github-script#285</a></li>
<li><a href="https://github.com/robandpdx "><code>@robandpdx</code></a>
made their first contribution in <a
href="https://redirect.github.com/actions/github-script/pull/429 ">actions/github-script#429</a></li>
<li><a
href="https://github.com/viktorlott "><code>@viktorlott</code></a> made
their first contribution in <a
href="https://redirect.github.com/actions/github-script/pull/402 ">actions/github-script#402</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/actions/github-script/compare/v6.4.1...v7.0.0 ">https://github.com/actions/github-script/compare/v6.4.1...v7.0.0 </a></p>
<h2>v6.4.1</h2>
<h2>What's Changed</h2>
<ul>
<li>Add <code>@octokit/plugin-request-log</code>, to produce debug
output for requests by <a
href="https://github.com/mjpieters "><code>@mjpieters</code></a> in <a
href="https://redirect.github.com/actions/github-script/pull/358 ">actions/github-script#358</a></li>
<li>fix input handling by <a
href="https://github.com/mjpieters "><code>@mjpieters</code></a> in <a
href="https://redirect.github.com/actions/github-script/pull/357 ">actions/github-script#357</a></li>
<li>Remove unused dependencies by <a
href="https://github.com/mjpieters "><code>@mjpieters</code></a> in <a
href="https://redirect.github.com/actions/github-script/pull/356 ">actions/github-script#356</a></li>
<li>Default debug to current runner debug state by <a
href="https://github.com/mjpieters "><code>@mjpieters</code></a> in <a
href="https://redirect.github.com/actions/github-script/pull/363 ">actions/github-script#363</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/mjpieters "><code>@mjpieters</code></a>
made their first contribution in <a
href="https://redirect.github.com/actions/github-script/pull/358 ">actions/github-script#358</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/actions/github-script/compare/v6.4.0...v6.4.1 ">https://github.com/actions/github-script/compare/v6.4.0...v6.4.1 </a></p>
<h2>v6.4.0</h2>
<h2>What's Changed</h2>
<ul>
<li>Bump json5 from 2.1.3 to 2.2.3 by <a
href="https://github.com/dependabot "><code>@dependabot</code></a> in <a
href="https://redirect.github.com/actions/github-script/pull/319 ">actions/github-script#319</a></li>
<li>Bump minimatch from 3.0.4 to 3.1.2 by <a
href="https://github.com/dependabot "><code>@dependabot</code></a> in <a
href="https://redirect.github.com/actions/github-script/pull/320 ">actions/github-script#320</a></li>
<li>Add node-fetch by <a
href="https://github.com/danmichaelo "><code>@danmichaelo</code></a> in
<a
href="https://redirect.github.com/actions/github-script/pull/321 ">actions/github-script#321</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a href="https://github.com/jongwooo "><code>@jongwooo</code></a>
made their first contribution in <a
href="https://redirect.github.com/actions/github-script/pull/313 ">actions/github-script#313</a></li>
<li><a
href="https://github.com/austinvazquez "><code>@austinvazquez</code></a>
made their first contribution in <a
href="https://redirect.github.com/actions/github-script/pull/306 ">actions/github-script#306</a></li>
<li><a
href="https://github.com/danmichaelo "><code>@danmichaelo</code></a>
made their first contribution in <a
href="https://redirect.github.com/actions/github-script/pull/321 ">actions/github-script#321</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/actions/github-script/compare/v6.3.3...v6.4.0 ">https://github.com/actions/github-script/compare/v6.3.3...v6.4.0 </a></p>
<h2>v6.3.3</h2>
<h2>What's Changed</h2>
<ul>
<li>Update <code>@actions/glob</code> to 0.3.0 by <a
href="https://github.com/nineinchnick "><code>@nineinchnick</code></a>
in <a
href="https://redirect.github.com/actions/github-script/pull/279 ">actions/github-script#279</a></li>
</ul>
<h2>New Contributors</h2>
<ul>
<li><a
href="https://github.com/nineinchnick "><code>@nineinchnick</code></a>
made their first contribution in <a
href="https://redirect.github.com/actions/github-script/pull/279 ">actions/github-script#279</a></li>
</ul>
<p><strong>Full Changelog</strong>: <a
href="https://github.com/actions/github-script/compare/v6.3.2...v6.3.3 ">https://github.com/actions/github-script/compare/v6.3.2...v6.3.3 </a></p>
<h2>v6.3.2</h2>
<h2>What's Changed</h2>
<ul>
<li>Update <code>@actions/core</code> to 1.10.0 by <a
href="https://github.com/rentziass "><code>@rentziass</code></a> in <a
href="https://redirect.github.com/actions/github-script/pull/295 ">actions/github-script#295</a></li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="60a0d83039https://redirect.github.com/actions/github-script/issues/440 ">#440</a>
from actions/joshmgross/v7.0.1</li>
<li><a
href="b7fb2001b412e22ed06bhttps://redirect.github.com/actions/github-script/issues/439 ">#439</a>
from actions/joshmgross/avoid-setting-base-url</li>
<li><a
href="d319f8f5b5e69ef5462fhttps://redirect.github.com/actions/github-script/issues/425 ">#425</a>
from actions/joshmgross/node-20</li>
<li><a
href="ee0914b839d6fc56f33b384d6cf58184724927e384903f5182https://github.com/actions/github-script/compare/v6...v7 ">compare
view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores )
Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)
</details>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2023-11-20 09:01:27 +00:00
François
0087556028
switch CI jobs between windows and linux for example execution ( #9489 )
...
# Objective
- Example execution on linux/vulkan on CI is segfaulting for unclear
reasons
- This makes a lot of noise on PRs
## Solution
- Switch example execution on Linux to validation jobs (on PR merged).
It will still crash but not block merging, and we'll know when it's
fixed
- Switch example execution on Windows to CI jobs (on PR push). It's a
bit longer than on Linux but provides a useful status
- Disable job commenting on PR with job execution to reduce noise
---------
Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
2023-08-19 14:47:41 +00:00
Rob Parrett
9e8de2aa94
Slightly better message when contributor modifies examples template ( #9372 )
...
# Objective
Provide a slightly better message when a contributor needs to update the
generated example readme file for [any number of
reasons](https://github.com/bevyengine/bevy/pull/9372#discussion_r1285876202 )
but hasn't added any examples.
This recently happened here:
https://github.com/bevyengine/bevy/pull/9370#issuecomment-1666776092
The contributor modified the readme template and is being told that they
added an example.
## Solution
The advice given is still correct. Just change the message so that it's
not accusing the contributor of adding an example.
It may be possible to instead add more specific messages instead if
someone is motivated to do that.
edit: reworked this whole PR text
---------
Co-authored-by: Nicola Papale <nicopap@users.noreply.github.com>
2023-08-07 23:08:19 +00:00
François
261905f11d
Feature documentation ( #7814 )
...
# Objective
- Fixes #1800 , fixes #6984
- Alternative to #7196
- Ensure feature list is always up to date and that all are documented
- Help discovery of features
## Solution
- Use a template to update the cargo feature list
- Use the comment just above the feature declaration as the description
- Add the checks to CI
- Add the features to the base crate doc
2023-02-28 14:24:47 +00:00
François
1e591bf7a5
Fix ci error comments ( #7416 )
...
# Objective
- Fix a few errors on the workflow for leaving comments after ci failures
2023-01-29 23:05:33 +00:00
François
9d52aaede3
Make CI friendlier ( #7398 )
...
# Objective
- Make CI friendlier
## Solution
- CI now says hello to new contributor
- for some jobs with non obvious solutions to failures, give more context
- example run should say which example failed
- example doc should say the next action to do (add metadata or run the update script)
- MSRV will say when it needs updating
I'm not completely sure everything is working and will try to trigger failures in this PR
2023-01-29 17:16:29 +00:00
