mirror of
https://github.com/bevyengine/bevy
synced 2024-11-22 12:43:34 +00:00
0087556028
# Objective - Example execution on linux/vulkan on CI is segfaulting for unclear reasons - This makes a lot of noise on PRs ## Solution - Switch example execution on Linux to validation jobs (on PR merged). It will still crash but not block merging, and we'll know when it's fixed - Switch example execution on Windows to CI jobs (on PR push). It's a bit longer than on Linux but provides a useful status - Disable job commenting on PR with job execution to reduce noise --------- Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
180 lines
7.3 KiB
YAML
180 lines
7.3 KiB
YAML
name: CI - PR Comments
|
|
|
|
# This workflow has write permissions on the repo
|
|
# It must not checkout a PR and run untrusted code
|
|
|
|
# Also requesting write permissions on PR to be able to comment
|
|
permissions:
|
|
pull-requests: 'write'
|
|
|
|
on:
|
|
workflow_run:
|
|
workflows: ["CI"]
|
|
types:
|
|
- completed
|
|
|
|
jobs:
|
|
|
|
missing-examples:
|
|
runs-on: ubuntu-latest
|
|
if: >
|
|
github.event.workflow_run.event == 'pull_request' &&
|
|
github.event.workflow_run.conclusion == 'failure'
|
|
steps:
|
|
- name: 'Download artifact'
|
|
id: find-artifact
|
|
uses: actions/github-script@v6
|
|
with:
|
|
result-encoding: string
|
|
script: |
|
|
var artifacts = await github.rest.actions.listWorkflowRunArtifacts({
|
|
owner: context.repo.owner,
|
|
repo: context.repo.repo,
|
|
run_id: ${{github.event.workflow_run.id }},
|
|
});
|
|
var matchArtifacts = artifacts.data.artifacts.filter((artifact) => {
|
|
return artifact.name == "missing-examples"
|
|
});
|
|
if (matchArtifacts.length == 0) { return "false" }
|
|
var matchArtifact = matchArtifacts[0];
|
|
var download = await github.rest.actions.downloadArtifact({
|
|
owner: context.repo.owner,
|
|
repo: context.repo.repo,
|
|
artifact_id: matchArtifact.id,
|
|
archive_format: 'zip',
|
|
});
|
|
var fs = require('fs');
|
|
fs.writeFileSync('${{github.workspace}}/missing-examples.zip', Buffer.from(download.data));
|
|
return "true"
|
|
- run: unzip missing-examples.zip
|
|
if: ${{ steps.find-artifact.outputs.result == 'true' }}
|
|
- name: 'Comment on PR'
|
|
if: ${{ steps.find-artifact.outputs.result == 'true' }}
|
|
uses: actions/github-script@v6
|
|
with:
|
|
github-token: ${{ secrets.GITHUB_TOKEN }}
|
|
script: |
|
|
var fs = require('fs');
|
|
var issue_number = Number(fs.readFileSync('./NR'));
|
|
if (fs.existsSync('./missing-metadata')) {
|
|
await github.rest.issues.createComment({
|
|
owner: context.repo.owner,
|
|
repo: context.repo.repo,
|
|
issue_number: issue_number,
|
|
body: 'You added a new example but didn\'t add metadata for it. Please update the root Cargo.toml file.'
|
|
});
|
|
}
|
|
if (fs.existsSync('./missing-update')) {
|
|
await github.rest.issues.createComment({
|
|
owner: context.repo.owner,
|
|
repo: context.repo.repo,
|
|
issue_number: issue_number,
|
|
body: 'The generated `examples/README.md` is out of sync with the example metadata in `Cargo.toml` or the example readme template. Please run `cargo run -p build-templated-pages -- update examples` to update it, and commit the file change.'
|
|
});
|
|
}
|
|
|
|
missing-features:
|
|
runs-on: ubuntu-latest
|
|
if: >
|
|
github.event.workflow_run.event == 'pull_request' &&
|
|
github.event.workflow_run.conclusion == 'failure'
|
|
steps:
|
|
- name: 'Download artifact'
|
|
id: find-artifact
|
|
uses: actions/github-script@v6
|
|
with:
|
|
result-encoding: string
|
|
script: |
|
|
var artifacts = await github.rest.actions.listWorkflowRunArtifacts({
|
|
owner: context.repo.owner,
|
|
repo: context.repo.repo,
|
|
run_id: ${{github.event.workflow_run.id }},
|
|
});
|
|
var matchArtifacts = artifacts.data.artifacts.filter((artifact) => {
|
|
return artifact.name == "missing-features"
|
|
});
|
|
if (matchArtifacts.length == 0) { return "false" }
|
|
var matchArtifact = matchArtifacts[0];
|
|
var download = await github.rest.actions.downloadArtifact({
|
|
owner: context.repo.owner,
|
|
repo: context.repo.repo,
|
|
artifact_id: matchArtifact.id,
|
|
archive_format: 'zip',
|
|
});
|
|
var fs = require('fs');
|
|
fs.writeFileSync('${{github.workspace}}/missing-features.zip', Buffer.from(download.data));
|
|
return "true"
|
|
- run: unzip missing-features.zip
|
|
if: ${{ steps.find-artifact.outputs.result == 'true' }}
|
|
- name: 'Comment on PR'
|
|
if: ${{ steps.find-artifact.outputs.result == 'true' }}
|
|
uses: actions/github-script@v6
|
|
with:
|
|
github-token: ${{ secrets.GITHUB_TOKEN }}
|
|
script: |
|
|
var fs = require('fs');
|
|
var issue_number = Number(fs.readFileSync('./NR'));
|
|
if (fs.existsSync('./missing-features')) {
|
|
await github.rest.issues.createComment({
|
|
owner: context.repo.owner,
|
|
repo: context.repo.repo,
|
|
issue_number: issue_number,
|
|
body: 'You added a new feature but didn\'t add a description for it. Please update the root Cargo.toml file.'
|
|
});
|
|
}
|
|
if (fs.existsSync('./missing-update')) {
|
|
await github.rest.issues.createComment({
|
|
owner: context.repo.owner,
|
|
repo: context.repo.repo,
|
|
issue_number: issue_number,
|
|
body: 'You added a new feature but didn\'t update the readme. Please run `cargo run -p build-templated-pages -- update features` to update it, and commit the file change.'
|
|
});
|
|
}
|
|
|
|
msrv:
|
|
runs-on: ubuntu-latest
|
|
if: >
|
|
github.event.workflow_run.event == 'pull_request' &&
|
|
github.event.workflow_run.conclusion == 'failure'
|
|
steps:
|
|
- name: 'Download artifact'
|
|
id: find-artifact
|
|
uses: actions/github-script@v6
|
|
with:
|
|
result-encoding: string
|
|
script: |
|
|
var artifacts = await github.rest.actions.listWorkflowRunArtifacts({
|
|
owner: context.repo.owner,
|
|
repo: context.repo.repo,
|
|
run_id: ${{github.event.workflow_run.id }},
|
|
});
|
|
var matchArtifacts = artifacts.data.artifacts.filter((artifact) => {
|
|
return artifact.name == "msrv"
|
|
});
|
|
if (matchArtifacts.length == 0) { return "false" }
|
|
var matchArtifact = matchArtifacts[0];
|
|
var download = await github.rest.actions.downloadArtifact({
|
|
owner: context.repo.owner,
|
|
repo: context.repo.repo,
|
|
artifact_id: matchArtifact.id,
|
|
archive_format: 'zip',
|
|
});
|
|
var fs = require('fs');
|
|
fs.writeFileSync('${{github.workspace}}/msrv.zip', Buffer.from(download.data));
|
|
return "true"
|
|
- run: unzip msrv.zip
|
|
if: ${{ steps.find-artifact.outputs.result == 'true' }}
|
|
- name: 'Comment on PR'
|
|
if: ${{ steps.find-artifact.outputs.result == 'true' }}
|
|
uses: actions/github-script@v6
|
|
with:
|
|
github-token: ${{ secrets.GITHUB_TOKEN }}
|
|
script: |
|
|
var fs = require('fs');
|
|
var issue_number = Number(fs.readFileSync('./NR'));
|
|
await github.rest.issues.createComment({
|
|
owner: context.repo.owner,
|
|
repo: context.repo.repo,
|
|
issue_number: issue_number,
|
|
body: 'Your PR increases Bevy Minimum Supported Rust Version. Please update the `rust-version` field in the root Cargo.toml file.'
|
|
});
|