Mirrors/bevy
2
0
Fork 0
mirror of https://github.com/bevyengine/bevy synced 2024-11-14 00:47:32 +00:00
Code Issues Projects Releases Packages Wiki Activity

Fix with_child not inserting Parent component (#15009)

Browse source 
# Objective

The `Parent` component holds a reference to the parent entity of the
entity it is inserted onto. The `with_child` function erroneously
forgets to insert this component onto the child entity that it spawns,
causing buggy behaviour when the function is used instead of the other
child-spawning functions.

## Solution

Ensure `with_child` inserts the `Parent` component, the same as all the
other child-spawning functions.

## Testing

Checked before/after with a bevy_ui layout where this patch fixed buggy
behaviour I was seeing in parent/child UI nodes.
This commit is contained in:
BigWingBeat 2024-09-02 23:47:25 +01:00 committed by GitHub
parent 3fc02cb925
commit 61f9f8c5f6
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
crates/bevy_hierarchy/src/child_builder.rs
View file

@ -585,7 +585,8 @@ impl BuildChildren for EntityWorldMut<'_> {
} }
fn with_child<B: Bundle>(&mut self, bundle: B) -> &mut Self { fn with_child<B: Bundle>(&mut self, bundle: B) -> &mut Self {
let child = self.world_scope(|world| world.spawn(bundle).id()); let parent = self.id();
let child = self.world_scope(|world| world.spawn((bundle, Parent(parent))).id());
if let Some(mut children_component) = self.get_mut::<Children>() { if let Some(mut children_component) = self.get_mut::<Children>() {
children_component.0.retain(|value| child != *value); children_component.0.retain(|value| child != *value);
children_component.0.push(child); children_component.0.push(child);