mirror of
https://github.com/kwsch/PKHeX
synced 2024-11-25 05:20:20 +00:00
f2a6abbb6c
pkmnclassic has recently had some pokemon traded that cause game crashes when viewing the pokemon's information, or when trying to remove the pokemon for these boxes. most of these pokemon were reported legal by pkhex however. this fixes the biggest use of these we've seen actively traded (some of the other checks require more validation, as they seemed to be buggy, we intend to validate those & send more PRs if needed). this check effectively covers "NULL Bytes" within the trainers name, or the pokemon's nickname. We have attached an example pk4 that was traded through our service that exhibits this issue, a couple notes: - Generation 5+ seem to not be affected and replace character names with '?' - Not all screens crash inside of Generation 4, the big ones our users noticed were viewing the pokemons information, and removal from the boxes. - I also got a crash in pokemon ranch, but my testing setup was pretty hacky, and I'm not confident it wasn't something else, but we know it's potentially possible. - We check for the terminator character '\uffff' which the pkhex string converter inserts implicitly when encountering an invalid character, but the actual underlying character when performing a hex dump is `\0`. |
||
|---|---|---|
| .. | ||
| Editing | ||
| Game | ||
| Items | ||
| Legality | ||
| Moves | ||
| MysteryGifts | ||
| PersonalInfo | ||
| PKM | ||
| Resources | ||
| Ribbons | ||
| Saves | ||
| Util | ||
| PKHeX.Core.csproj | ||