f2a6abbb6c
pkmnclassic has recently had some pokemon traded that cause game crashes when viewing the pokemon's information, or when trying to remove the pokemon for these boxes. most of these pokemon were reported legal by pkhex however. this fixes the biggest use of these we've seen actively traded (some of the other checks require more validation, as they seemed to be buggy, we intend to validate those & send more PRs if needed). this check effectively covers "NULL Bytes" within the trainers name, or the pokemon's nickname. We have attached an example pk4 that was traded through our service that exhibits this issue, a couple notes: - Generation 5+ seem to not be affected and replace character names with '?' - Not all screens crash inside of Generation 4, the big ones our users noticed were viewing the pokemons information, and removal from the boxes. - I also got a crash in pokemon ranch, but my testing setup was pretty hacky, and I'm not confident it wasn't something else, but we know it's potentially possible. - We check for the terminator character '\uffff' which the pkhex string converter inserts implicitly when encountering an invalid character, but the actual underlying character when performing a hex dump is `\0`. |
||
|---|---|---|
| .github | ||
| PKHeX.Core | ||
| PKHeX.Drawing | ||
| PKHeX.Drawing.Misc | ||
| PKHeX.Drawing.PokeSprite | ||
| PKHeX.WinForms | ||
| Tests/PKHeX.Core.Tests | ||
| .editorconfig | ||
| .gitattributes | ||
| .gitignore | ||
| Directory.Build.props | ||
| icon.png | ||
| LICENSE | ||
| PKHeX.sln | ||
| README.md | ||
PKHeX
Pokémon core series save editor, programmed in C#.
Supports the following files:
- Save files ("main", *.sav, *.dsv, *.dat, *.gci, *.bin)
- GameCube Memory Card files (*.raw, *.bin) containing GC Pokémon savegames.
- Individual Pokémon entity files (.pk*, *.ck3, *.xk3, *.pb7, *.sk2, *.bk4, *.rk4)
- Mystery Gift files (*.pgt, *.pcd, *.pgf, .wc*) including conversion to .pk*
- Importing GO Park entities (*.gp1) including conversion to .pb7
- Importing teams from Decrypted 3DS Battle Videos
- Transferring from one generation to another, converting formats along the way.
Data is displayed in a view which can be edited and saved. The interface can be translated with resource/external text files so that different languages can be supported.
Pokémon Showdown sets and QR codes can be imported/exported to assist in sharing.
PKHeX expects save files that are not encrypted with console-specific keys. Use a savedata manager to import and export savedata from the console (Checkpoint, save_manager, JKSM, or SaveDataFiler).
We do not support or condone cheating at the expense of others. Do not use significantly hacked Pokémon in battle or in trades with those who are unaware hacked Pokémon are in use.
Screenshots
Building
PKHeX is a Windows Forms application which requires .NET 8.0.
The executable can be built with any compiler that supports C# 12.
Build Configurations
Use the Debug or Release build configurations when building. There isn't any platform specific code to worry about!
Dependencies
PKHeX's QR code generation code is taken from QRCoder, which is licensed under the MIT license.
PKHeX's shiny sprite collection is taken from pokesprite, which is licensed under the MIT license.
PKHeX's Pokémon Legends: Arceus sprite collection is taken from the National Pokédex - Icon Dex project and its abundance of collaborators and contributors.
IDE
PKHeX can be opened with IDEs such as Visual Studio by opening the .sln or .csproj file.