mirror of
https://github.com/kwsch/PKHeX
synced 2024-11-24 04:53:08 +00:00
6ee7a8724b
* Rework gen1 slot loading Slot templates are precomputed from ROM data and just loaded straight in, with tight coupling to the encounter area (grouped by slot types). * Revise fuzzy met check for underleveled wild evos Example: Level 23 poliwhirl in RBY as a level 50 poliwhirl, will assume the chain is 25-50 for poliwhirl (as poliwag evolves at 25). Instead of revising the origin chain, just ignore the evo min level in the comparison. Previous commit fixed it for gen1. * Rework gen2-4 slot loading Gen4 not finished, Type Encounter data and some edge encounters not recognizing yet... * Add feebas slots for old/good encounters * Begin moving properties Great news! Gen5-7 need to be de-dumbed like Gen1-4. Then I can remove the bang (!) on the Area accessor and ensure that it's never null! * Split off XD pokespot slot encounter table type * Set area in constructor * Deduplicate g3 roaming encounters * Deduplicate xd encounter locations (rebattle) Only difference is met location; no need to create 500 extra encounter objects. A simple contains check is ok (rarely in gen3 format). * Make all slots have a readonly reference to their parent area * Minor clean * Remove "Safari" slot type flag Can be determined via other means (generation-location), allows us to reduce the size of SlotType member to a byte Output of slot binaries didn't preserve the Safari flag anyway. * Update SlotType.cs * Handle type encounters correctly * Merge safari area into regular xy area * Merge dexnav accessor logic * fix some logic so that tests pass again rearrange g5 dw init to be done outside of static constructor (initializer instead) PIDGenerator: friend safari slots now generate with required flawless IV count * Add cianwood tentacool gift encounter * Remove unnecessary abstractions Fake area just returned a slot; since Slots have a non-null reference to the area, we can just return the slot and use the API to grab a list of possible slots for the chain. Increase restrictiveness of location/type get-set operations * Minor tweaks, pass parameters DexNav observed state isn't necessary to use, only need to see if it's possible to dexnav. Now that we have metadata for slots, we can. * Remove unused legality tables
80 lines
3.5 KiB
C#
80 lines
3.5 KiB
C#
using System.Linq;
|
|
using static PKHeX.Core.LegalityCheckStrings;
|
|
|
|
namespace PKHeX.Core
|
|
{
|
|
/// <summary>
|
|
/// Verifies the <see cref="PKM.EVs"/>.
|
|
/// </summary>
|
|
public sealed class EffortValueVerifier : Verifier
|
|
{
|
|
protected override CheckIdentifier Identifier => CheckIdentifier.EVs;
|
|
|
|
public override void Verify(LegalityAnalysis data)
|
|
{
|
|
var pkm = data.pkm;
|
|
if (pkm is IAwakened a)
|
|
{
|
|
VerifyAwakenedValues(data, a);
|
|
return;
|
|
}
|
|
var EncounterMatch = data.EncounterMatch;
|
|
int sum = pkm.EVTotal;
|
|
if (sum > 0 && pkm.IsEgg)
|
|
data.AddLine(GetInvalid(LEffortEgg));
|
|
|
|
// In Generations I and II, when a Pokémon is taken out of the Day Care, its experience will lower to the minimum value for its current level.
|
|
int format = pkm.Format;
|
|
if (format < 3) // can abuse daycare for EV training without EXP gain
|
|
return;
|
|
|
|
if (sum > 510) // format >= 3
|
|
data.AddLine(GetInvalid(LEffortAbove510));
|
|
var evs = pkm.EVs;
|
|
if (format >= 6 && evs.Any(ev => ev > 252))
|
|
data.AddLine(GetInvalid(LEffortAbove252));
|
|
|
|
const int vitaMax = 100; // Vitamin Max
|
|
if (format < 5) // 3/4
|
|
{
|
|
if (EncounterMatch.LevelMin == 100) // only true for Gen4 and Format=4
|
|
{
|
|
// Cannot EV train at level 100 -- Certain events are distributed at level 100.
|
|
if (evs.Any(ev => ev > vitaMax)) // EVs can only be increased by vitamins to a max of 100.
|
|
data.AddLine(GetInvalid(LEffortCap100));
|
|
}
|
|
else // check for gained EVs without gaining EXP -- don't check gen5+ which have wings to boost above 100.
|
|
{
|
|
var growth = PersonalTable.HGSS[EncounterMatch.Species].EXPGrowth;
|
|
var baseEXP = Experience.GetEXP(EncounterMatch.LevelMin, growth);
|
|
if (baseEXP == pkm.EXP && evs.Any(ev => ev > vitaMax))
|
|
data.AddLine(GetInvalid(string.Format(LEffortUntrainedCap, vitaMax)));
|
|
}
|
|
}
|
|
|
|
// Only one of the following can be true: 0, 508, and x%6!=0
|
|
if (sum == 0 && !EncounterMatch.IsWithinRange(pkm))
|
|
data.AddLine(Get(LEffortEXPIncreased, Severity.Fishy));
|
|
else if (sum == 508)
|
|
data.AddLine(Get(LEffort2Remaining, Severity.Fishy));
|
|
else if (evs[0] != 0 && evs.All(ev => evs[0] == ev))
|
|
data.AddLine(Get(LEffortAllEqual, Severity.Fishy));
|
|
}
|
|
|
|
private void VerifyAwakenedValues(LegalityAnalysis data, IAwakened awakened)
|
|
{
|
|
var pkm = data.pkm;
|
|
int sum = pkm.EVTotal;
|
|
if (sum != 0)
|
|
data.AddLine(GetInvalid(LEffortShouldBeZero));
|
|
|
|
var EncounterMatch = data.EncounterMatch;
|
|
if (!awakened.AwakeningAllValid())
|
|
data.AddLine(GetInvalid(LAwakenedCap));
|
|
if (EncounterMatch is EncounterSlot s && s.Area.Type == SlotType.GoPark && Enumerable.Range(0, 6).Select(awakened.GetAV).Any(z => z < 2))
|
|
data.AddLine(GetInvalid(string.Format(LAwakenedShouldBeValue, 2))); // go park transfers have 2 AVs for all stats.
|
|
else if (awakened.AwakeningSum() == 0 && !EncounterMatch.IsWithinRange(pkm))
|
|
data.AddLine(Get(LAwakenedEXPIncreased, Severity.Fishy));
|
|
}
|
|
}
|
|
}
|