PKHeX/PKHeX.Core/Legality/Verifiers
Kurt 6ee7a8724b
Offload EncounterSlot loading logic to reduce complexity (#2980)
* Rework gen1 slot loading

Slot templates are precomputed from ROM data and just loaded straight in, with tight coupling to the encounter area (grouped by slot types).

* Revise fuzzy met check for underleveled wild evos

Example: Level 23 poliwhirl in RBY as a level 50 poliwhirl, will assume the chain is 25-50 for poliwhirl (as poliwag evolves at 25). Instead of revising the origin chain, just ignore the evo min level in the comparison.

Previous commit fixed it for gen1.

* Rework gen2-4 slot loading

Gen4 not finished, Type Encounter data and some edge encounters not recognizing yet...

* Add feebas slots for old/good encounters

* Begin moving properties

Great news! Gen5-7 need to be de-dumbed like Gen1-4.

Then I can remove the bang (!) on the Area accessor and ensure that it's never null!

* Split off XD pokespot slot encounter table type

* Set area in constructor

* Deduplicate g3 roaming encounters

* Deduplicate xd encounter locations (rebattle)

Only difference is met location; no need to create 500 extra encounter objects. A simple contains check is ok (rarely in gen3 format).

* Make all slots have a readonly reference to their parent area

* Minor clean

* Remove "Safari" slot type flag

Can be determined via other means (generation-location), allows us to reduce the size of SlotType member to a byte

Output of slot binaries didn't preserve the Safari flag anyway.

* Update SlotType.cs

* Handle type encounters correctly

* Merge safari area into regular xy area

* Merge dexnav accessor logic

* fix some logic so that tests pass again

rearrange g5 dw init to be done outside of static constructor (initializer instead)
PIDGenerator: friend safari slots now generate with required flawless IV count

* Add cianwood tentacool gift encounter

* Remove unnecessary abstractions

Fake area just returned a slot; since Slots have a non-null reference to the area, we can just return the slot and use the API to grab a list of possible slots for the chain.

Increase restrictiveness of location/type get-set operations

* Minor tweaks, pass parameters

DexNav observed state isn't necessary to use, only need to see if it's possible to dexnav. Now that we have metadata for slots, we can.

* Remove unused legality tables
2020-08-30 10:23:22 -07:00
..
Ribbons Refactoring some IEncounterable-type'd object initialization and original-generation evo chain (#2974) 2020-08-21 16:35:49 -07:00
AbilityVerifier.cs Offload EncounterSlot loading logic to reduce complexity (#2980) 2020-08-30 10:23:22 -07:00
BallVerifier.cs Offload EncounterSlot loading logic to reduce complexity (#2980) 2020-08-30 10:23:22 -07:00
ConsoleRegionVerifier.cs Split Country/Region/ConsoleRegion to interface 2020-07-31 11:17:31 -07:00
ContestStatVerifier.cs Update ContestStatVerifier.cs 2020-05-11 16:51:10 -07:00
CXDVerifier.cs Allow antishiny CXD spreads for some checks 2020-04-11 23:14:16 -07:00
EffortValueVerifier.cs Offload EncounterSlot loading logic to reduce complexity (#2980) 2020-08-30 10:23:22 -07:00
EncounterTypeVerifier.cs Refactoring some IEncounterable-type'd object initialization and original-generation evo chain (#2974) 2020-08-21 16:35:49 -07:00
FormVerifier.cs Offload EncounterSlot loading logic to reduce complexity (#2980) 2020-08-30 10:23:22 -07:00
GenderVerifier.cs Use enum for species comparisons 2019-12-08 17:39:19 -08:00
HistoryVerifier.cs Split gen6/7 affection stats to interface 2020-08-02 11:06:30 -07:00
HyperTrainingVerifier.cs Add gold bottle cap bypass for LGPE 2019-01-06 16:21:34 -08:00
IndividualValueVerifier.cs Offload EncounterSlot loading logic to reduce complexity (#2980) 2020-08-30 10:23:22 -07:00
ItemVerifier.cs Relocate gen3 ereader berry logic 2020-07-18 22:51:55 -05:00
LanguageVerifier.cs Use enum for species comparisons 2019-12-08 17:39:19 -08:00
LevelVerifier.cs Handle unhatched manaphy egg 2020-08-09 20:02:28 -07:00
MarkVerifier.cs Add initial marking checks 2020-04-06 16:32:23 -07:00
MedalVerifier.cs Clean up super training medal checks 2019-09-20 20:55:36 -07:00
MemoryVerifier.cs Minor tweaks 2020-08-04 22:56:55 -07:00
MiscVerifier.cs Make CanToggleGigantamax have a form argument 2020-08-16 23:06:49 -07:00
NHarmoniaVerifier.cs Simplify N's pkm encounter handling 2020-01-25 12:31:56 -08:00
NicknameVerifier.cs Finish splitting gen1/2 encounter types from parent class 2020-07-19 13:32:40 -05:00
ParseSettings.cs Add tracker unique text & setting 2020-02-12 18:10:24 -08:00
PIDVerifier.cs Offload EncounterSlot loading logic to reduce complexity (#2980) 2020-08-30 10:23:22 -07:00
TrainerNameVerifier.cs Minor clean 2020-06-27 23:36:53 -05:00
TransferVerifier.cs Initial Isle of Armor support 2020-06-19 18:51:15 -05:00
Verifier.cs Rework secondary check flow 2018-06-23 22:00:01 -07:00