mirror of
https://github.com/kwsch/PKHeX
synced 2024-12-24 19:33:10 +00:00
47071b41f3
Existing `get`/`set` logic is flawed in that it doesn't work on Big Endian operating systems, and it allocates heap objects when it doesn't need to. `System.Buffers.Binary.BinaryPrimitives` in the `System.Memory` NuGet package provides both Little Endian and Big Endian methods to read and write data; all the `get`/`set` operations have been reworked to use this new API. This removes the need for PKHeX's manual `BigEndian` class, as all functions are already covered by the BinaryPrimitives API. The `StringConverter` has now been rewritten to accept a Span to read from & write to, no longer requiring a temporary StringBuilder. Other Fixes included: - The Super Training UI for Gen6 has been reworked according to the latest block structure additions. - Cloning a Stadium2 Save File now works correctly (opening from the Folder browser list). - Checksum & Sanity properties removed from parent PKM class, and is now implemented via interface.
96 lines
No EOL
2.8 KiB
C#
96 lines
No EOL
2.8 KiB
C#
using System;
|
|
using static System.Buffers.Binary.BinaryPrimitives;
|
|
|
|
namespace PKHeX.Core
|
|
{
|
|
/// <summary>
|
|
/// Combined save block; 0x100 for first, 0x100 for second.
|
|
/// </summary>
|
|
public sealed class PlayerData5 : SaveBlock
|
|
{
|
|
public PlayerData5(SAV5BW sav, int offset) : base(sav) => Offset = offset;
|
|
public PlayerData5(SAV5B2W2 sav, int offset) : base(sav) => Offset = offset;
|
|
|
|
private Span<byte> OT_Trash => Data.AsSpan(Offset + 4, 0x10);
|
|
|
|
public string OT
|
|
{
|
|
get => SAV.GetString(OT_Trash);
|
|
set => SAV.SetString(OT_Trash, value.AsSpan(), SAV.OTLength, StringConverterOption.ClearZero);
|
|
}
|
|
|
|
public int TID
|
|
{
|
|
get => ReadUInt16LittleEndian(Data.AsSpan(Offset + 0x14 + 0));
|
|
set => WriteUInt16LittleEndian(Data.AsSpan(Offset + 0x14 + 0), (ushort)value);
|
|
}
|
|
|
|
public int SID
|
|
{
|
|
get => ReadUInt16LittleEndian(Data.AsSpan(Offset + 0x14 + 2));
|
|
set => WriteUInt16LittleEndian(Data.AsSpan(Offset + 0x14 + 2), (ushort)value);
|
|
}
|
|
|
|
public int Language
|
|
{
|
|
get => Data[Offset + 0x1E];
|
|
set => Data[Offset + 0x1E] = (byte)value;
|
|
}
|
|
|
|
public int Game
|
|
{
|
|
get => Data[Offset + 0x1F];
|
|
set => Data[Offset + 0x1F] = (byte)value;
|
|
}
|
|
|
|
public int Gender
|
|
{
|
|
get => Data[Offset + 0x21];
|
|
set => Data[Offset + 0x21] = (byte)value;
|
|
}
|
|
|
|
// 22,23 ??
|
|
|
|
public int PlayedHours
|
|
{
|
|
get => ReadUInt16LittleEndian(Data.AsSpan(Offset + 0x24));
|
|
set => WriteUInt16LittleEndian(Data.AsSpan(Offset + 0x24), (ushort)value);
|
|
}
|
|
|
|
public int PlayedMinutes
|
|
{
|
|
get => Data[Offset + 0x24 + 2];
|
|
set => Data[Offset + 0x24 + 2] = (byte)value;
|
|
}
|
|
|
|
public int PlayedSeconds
|
|
{
|
|
get => Data[Offset + 0x24 + 3];
|
|
set => Data[Offset + 0x24 + 3] = (byte)value;
|
|
}
|
|
|
|
public int M
|
|
{
|
|
get => ReadInt32LittleEndian(Data.AsSpan(Offset + 0x180));
|
|
set => WriteUInt16LittleEndian(Data.AsSpan(Offset + 0x180), (ushort)value);
|
|
}
|
|
|
|
public int X
|
|
{
|
|
get => ReadUInt16LittleEndian(Data.AsSpan(Offset + 0x186));
|
|
set => WriteUInt16LittleEndian(Data.AsSpan(Offset + 0x186), (ushort)value);
|
|
}
|
|
|
|
public int Z
|
|
{
|
|
get => ReadUInt16LittleEndian(Data.AsSpan(Offset + 0x18A));
|
|
set => WriteUInt16LittleEndian(Data.AsSpan(Offset + 0x18A), (ushort)value);
|
|
}
|
|
|
|
public int Y
|
|
{
|
|
get => ReadUInt16LittleEndian(Data.AsSpan(Offset + 0x18E));
|
|
set => WriteUInt16LittleEndian(Data.AsSpan(Offset + 0x18E), (ushort)value);
|
|
}
|
|
}
|
|
} |