mirror of
https://github.com/kwsch/PKHeX
synced 2024-12-24 19:33:10 +00:00
47071b41f3
Existing `get`/`set` logic is flawed in that it doesn't work on Big Endian operating systems, and it allocates heap objects when it doesn't need to. `System.Buffers.Binary.BinaryPrimitives` in the `System.Memory` NuGet package provides both Little Endian and Big Endian methods to read and write data; all the `get`/`set` operations have been reworked to use this new API. This removes the need for PKHeX's manual `BigEndian` class, as all functions are already covered by the BinaryPrimitives API. The `StringConverter` has now been rewritten to accept a Span to read from & write to, no longer requiring a temporary StringBuilder. Other Fixes included: - The Super Training UI for Gen6 has been reworked according to the latest block structure additions. - Cloning a Stadium2 Save File now works correctly (opening from the Folder browser list). - Checksum & Sanity properties removed from parent PKM class, and is now implemented via interface.
30 lines
No EOL
1 KiB
C#
30 lines
No EOL
1 KiB
C#
using System;
|
|
using static System.Buffers.Binary.BinaryPrimitives;
|
|
|
|
namespace PKHeX.Core
|
|
{
|
|
public sealed class PWTBlock5 : SaveBlock
|
|
{
|
|
public PWTBlock5(SAV5B2W2 sav, int offset) : base(sav) => Offset = offset;
|
|
|
|
public ushort GetPWTRecord(int id) => GetPWTRecord((PWTRecordID)id);
|
|
|
|
public ushort GetPWTRecord(PWTRecordID id)
|
|
{
|
|
if (id is < PWTRecordID.Normal or > PWTRecordID.MixMaster)
|
|
throw new ArgumentOutOfRangeException(nameof(id));
|
|
int ofs = Offset + 0x5C + ((int)id * 2);
|
|
return ReadUInt16LittleEndian(Data.AsSpan(ofs));
|
|
}
|
|
|
|
public void SetPWTRecord(int id, ushort value) => SetPWTRecord((PWTRecordID)id, value);
|
|
|
|
public void SetPWTRecord(PWTRecordID id, ushort value)
|
|
{
|
|
if (id is < PWTRecordID.Normal or > PWTRecordID.MixMaster)
|
|
throw new ArgumentOutOfRangeException(nameof(id));
|
|
int ofs = Offset + 0x5C + ((int)id * 2);
|
|
WriteUInt16LittleEndian(Data.AsSpan(ofs), value);
|
|
}
|
|
}
|
|
} |