mirror of
https://github.com/kwsch/PKHeX
synced 2024-12-24 19:33:10 +00:00
47071b41f3
Existing `get`/`set` logic is flawed in that it doesn't work on Big Endian operating systems, and it allocates heap objects when it doesn't need to. `System.Buffers.Binary.BinaryPrimitives` in the `System.Memory` NuGet package provides both Little Endian and Big Endian methods to read and write data; all the `get`/`set` operations have been reworked to use this new API. This removes the need for PKHeX's manual `BigEndian` class, as all functions are already covered by the BinaryPrimitives API. The `StringConverter` has now been rewritten to accept a Span to read from & write to, no longer requiring a temporary StringBuilder. Other Fixes included: - The Super Training UI for Gen6 has been reworked according to the latest block structure additions. - Cloning a Stadium2 Save File now works correctly (opening from the Folder browser list). - Checksum & Sanity properties removed from parent PKM class, and is now implemented via interface.
125 lines
No EOL
4.1 KiB
C#
125 lines
No EOL
4.1 KiB
C#
using System;
|
|
using static System.Buffers.Binary.BinaryPrimitives;
|
|
|
|
namespace PKHeX.Core
|
|
{
|
|
public sealed class BattleSubway5 : SaveBlock
|
|
{
|
|
public BattleSubway5(SAV5BW sav, int offset) : base(sav) => Offset = offset;
|
|
public BattleSubway5(SAV5B2W2 sav, int offset) : base(sav) => Offset = offset;
|
|
|
|
public int BP
|
|
{
|
|
get => ReadUInt16LittleEndian(Data.AsSpan(Offset));
|
|
set => WriteUInt16LittleEndian(Data.AsSpan(Offset), (ushort)value);
|
|
}
|
|
|
|
// Normal
|
|
public int SinglePast
|
|
{
|
|
get => ReadUInt16LittleEndian(Data.AsSpan(Offset + 0x08));
|
|
set => WriteUInt16LittleEndian(Data.AsSpan(Offset + 0x08), (ushort)value);
|
|
}
|
|
|
|
public int SingleRecord
|
|
{
|
|
get => ReadUInt16LittleEndian(Data.AsSpan(Offset + 0x1A));
|
|
set => WriteUInt16LittleEndian(Data.AsSpan(Offset + 0x1A), (ushort)value);
|
|
}
|
|
|
|
public int DoublePast
|
|
{
|
|
get => ReadUInt16LittleEndian(Data.AsSpan(Offset + 0x0A));
|
|
set => WriteUInt16LittleEndian(Data.AsSpan(Offset + 0x0A), (ushort)value);
|
|
}
|
|
|
|
public int DoubleRecord
|
|
{
|
|
get => ReadUInt16LittleEndian(Data.AsSpan(Offset + 0x1C));
|
|
set => WriteUInt16LittleEndian(Data.AsSpan(Offset + 0x1C), (ushort)value);
|
|
}
|
|
|
|
public int MultiNPCPast
|
|
{
|
|
get => ReadUInt16LittleEndian(Data.AsSpan(Offset + 0x0C));
|
|
set => WriteUInt16LittleEndian(Data.AsSpan(Offset + 0x0C), (ushort)value);
|
|
}
|
|
|
|
public int MultiNPCRecord
|
|
{
|
|
get => ReadUInt16LittleEndian(Data.AsSpan(Offset + 0x1E));
|
|
set => WriteUInt16LittleEndian(Data.AsSpan(Offset + 0x1E), (ushort)value);
|
|
}
|
|
|
|
public int MultiFriendsPast
|
|
{
|
|
get => ReadUInt16LittleEndian(Data.AsSpan(Offset + 0x0E));
|
|
set => WriteUInt16LittleEndian(Data.AsSpan(Offset + 0x0E), (ushort)value);
|
|
}
|
|
|
|
public int MultiFriendsRecord
|
|
{
|
|
get => ReadUInt16LittleEndian(Data.AsSpan(Offset + 0x20));
|
|
set => WriteUInt16LittleEndian(Data.AsSpan(Offset + 0x20), (ushort)value);
|
|
}
|
|
|
|
// Super Check
|
|
public int SuperCheck
|
|
{
|
|
get => Data[Offset + 0x04];
|
|
set => Data[Offset + 0x04] = (byte)value;
|
|
}
|
|
|
|
// Super
|
|
public int SuperSinglePast
|
|
{
|
|
get => ReadUInt16LittleEndian(Data.AsSpan(Offset + 0x12));
|
|
set => WriteUInt16LittleEndian(Data.AsSpan(Offset + 0x12), (ushort)value);
|
|
}
|
|
|
|
public int SuperSingleRecord
|
|
{
|
|
get => ReadUInt16LittleEndian(Data.AsSpan(Offset + 0x24));
|
|
set => WriteUInt16LittleEndian(Data.AsSpan(Offset + 0x24), (ushort)value);
|
|
}
|
|
|
|
public int SuperDoublePast
|
|
{
|
|
get => ReadUInt16LittleEndian(Data.AsSpan(Offset + 0x14));
|
|
set => WriteUInt16LittleEndian(Data.AsSpan(Offset + 0x14), (ushort)value);
|
|
}
|
|
|
|
public int SuperDoubleRecord
|
|
{
|
|
get => ReadUInt16LittleEndian(Data.AsSpan(Offset + 0x26));
|
|
set => WriteUInt16LittleEndian(Data.AsSpan(Offset + 0x26), (ushort)value);
|
|
}
|
|
|
|
public int SuperMultiNPCPast
|
|
{
|
|
get => ReadUInt16LittleEndian(Data.AsSpan(Offset + 0x16));
|
|
set => WriteUInt16LittleEndian(Data.AsSpan(Offset + 0x16), (ushort)value);
|
|
}
|
|
|
|
public int SuperMultiNPCRecord
|
|
{
|
|
get => ReadUInt16LittleEndian(Data.AsSpan(Offset + 0x28));
|
|
set => WriteUInt16LittleEndian(Data.AsSpan(Offset + 0x28), (ushort)value);
|
|
}
|
|
|
|
public int SuperMultiFriendsPast
|
|
{
|
|
get => ReadUInt16LittleEndian(Data.AsSpan(Offset + 0x18));
|
|
set => WriteUInt16LittleEndian(Data.AsSpan(Offset + 0x18), (ushort)value);
|
|
}
|
|
|
|
public int SuperMultiFriendsRecord
|
|
{
|
|
get => ReadUInt16LittleEndian(Data.AsSpan(Offset + 0x2A));
|
|
set => WriteUInt16LittleEndian(Data.AsSpan(Offset + 0x2A), (ushort)value);
|
|
}
|
|
|
|
// TODO: Wifi??
|
|
|
|
}
|
|
} |