PKHeX/PKHeX.Core/Editing
Kurt 0626b0c29b
Add Breeding move ordering logic, and use in legality analysis (#3183)
* Initial bred moveset validation logic

Unpeel the inheritance via recursion and permitted moves

* Volt tackle considerations

* Optimize out empty slot skips

* Add tests, fix off-by-one's

* Require all base moves if empty slot in moveset

* Add test to prove failure per Anubis' provided test

* Tweak enum labels for easier debugging

When two enums share the same underlying value, the ToString/name of the value may be either of the two (or the last defined one, in my debugging). Just give it a separate magic value.

* Fix recursion oopsie

Also check for scenario where no-base-moves but not enough moves to push base moves out

* Add Crystal tutor checks

* Add specialized gen2 verification method

Game loops through father's moves and pushes in one iteration, rather than checking by type.

* Add another case with returning base move

* Add push-out requirement for re-added base moves

* Minor tweaks

Condense tests, fix another off-by-one noticed when creating tests

* Disallow inherited parent levelup moves

Disallow volt tackle on Gen2/R/S

* Split MoveBreed into generation specific classes

Gen2 behaves slightly different from Gen3/4, which behaves slightly different from Gen5... and Gen6 behaves differently too.

Add some xmldoc as the api is starting to solidify

* Add method overload that returns the parse

Verify that the parse order is as expected

* Add reordering suggestion logic

Try sorting first, then go nuclear with rebuilding.

* Return base moves if complete fail

* Set base moves when generating eggs, only.

* Use breed logic to check for egg ordering legality

Don't bother helping for split-breed species
2021-04-04 18:30:01 -07:00
..
Applicators Add Breeding move ordering logic, and use in legality analysis (#3183) 2021-04-04 18:30:01 -07:00
Bulk Add some code analysis for try-return with nullable out 2021-01-17 00:05:07 -08:00
PKM Template fields with species for save file 2021-01-27 08:40:37 -08:00
Saves Make some properties into consts 2021-03-20 12:47:21 -07:00
Showdown Replace dashes with spaces for cosplay pikachu (rock star) 2021-02-02 09:19:29 -08:00
CommonEdits.cs Revert implicit casting 2021-03-29 00:14:44 -07:00
HiddenPower.cs Minor clean 2021-01-16 12:01:40 -08:00
IBattleTemplate.cs Unify concepts with different names 2020-12-10 20:42:30 -08:00
IPKMView.cs Refactoring 2019-09-02 19:30:58 -07:00
IPlugin.cs Clean up some method signatures 2020-06-16 21:46:22 -05:00
ISaveFileProvider.cs Add basic plugin sys 2018-05-13 12:49:29 -07:00
ISpriteBuilder.cs Add shiny sprites, alcremie sprites & big sprites for all 2020-03-03 20:22:57 -08:00
LocalizeUtil.cs Split up DataUtil to separate files 2020-12-21 19:13:18 -08:00
WurmpleUtil.cs Clean up some method signatures 2020-06-16 21:46:22 -05:00