Mirrors/PKHeX
2
0
Fork 0
mirror of https://github.com/kwsch/PKHeX synced 2024-12-20 01:13:17 +00:00
Code Issues Projects Releases Packages Wiki Activity
6992 commits 3 branches 76 tags 119 MiB
Commit graph

572 commits

Author SHA1 Message Date
Kurt
12b8060ec1 Use byte instead of int 2020-07-21 23:43:34 -05:00
Kurt
4cb283981b Remove linq from list init, manually allocate 
Add some docs cuz gen1 structures are always spooky

gen1 not being exactly same as gen2, and jp != int => 4 different sizes of spookiness
 2020-07-21 20:56:41 -05:00
Kurt
d3863f9c63 Minor tweaks 
verify relearn: move split check before method call
movelist: don't capture pkm in local method; meowstic ID
pkm: flip argument for easier understanding
 2020-07-19 18:30:46 -05:00
Kurt
9f20aa2f4f Remove unnecessary comparison 
in Array.Resize, an array is only created if the size is not equivalent
we're just repeating the same logic; let the jit optimize out the null check
 2020-07-19 16:35:31 -05:00
Kurt
eb7ed44b29 Finish splitting gen1/2 encounter types from parent class 
Results in a little more code, but each path is less tangled
simplify some expressions
remove RBDragonair content in favor of a strict filter for catch rate

Move gen1 trade trainer names to stringconverter, since pk1/pk2 shouldn't refer to legality classes
 2020-07-19 13:32:40 -05:00
Kurt
ea609d43a5 Move soup to gmax class (extension methods), fix home gmax starters 
Directly accessing CanEatMaxSoup is now forbidden :)

Fixes home galar starters being flagged when gmax-final evos
 2020-07-16 21:04:27 -05:00
Kurt
e04b96a9b3 Fix dizzy punch egg recognition & gen2 hatch conter verification 
Closes #2939
Fixes #2938

Inline some logic where appropriate for egg levels
 2020-07-12 20:58:07 -05:00
Kurt
993673f0de Minor clean 
no functional change
 2020-06-27 23:36:53 -05:00
Kurt
a7ba178005 Remove unreachable/const logic 
Earlier compares result in some logic being unnecessary

The Gen7 level up move compare was actually an oversight, so it's a worthwhile fix :)
 2020-06-27 22:44:14 -05:00
Kurt
c565c7ca2c Extract move suggest logic, add battleversion clamp 
Closes #2911
 2020-06-27 13:06:28 -05:00
Kurt
1ae9cb7602 Handle pika/meow soup evolutions 
Can lose gmax flag if its current species is able to eat soup, or its origin species could eat soup

this handles stuff like charmander->charizard, as charmeleon would not pass

hopefully there's never a mid-stage evo that has a gmax form, and its final evo doesn't... (don't get any ideas, gamefreak)
 2020-06-24 18:59:26 -05:00
Kurt
6fb2ebe039 Minor clean 
add some xmldoc
 2020-06-21 19:46:06 -05:00
Kurt
fc4ba1df35 Bounds check ability requested 
no longer exception's on RefreshAbility(negative number)
 2020-06-21 18:16:18 -05:00
Kurt
645db23706 Extract EvoBase and MoveList from Core 
These are really old bloated parts of the original legality checking logic; separating for now to rewrite.
 2020-06-20 19:44:05 -05:00
Kurt
4f7845547e Minor clean 
Remove met location dynamic sizing for C/XD (already resized for SWSH)
add some xmldoc comments
rename some parameters
 2020-06-20 18:23:03 -05:00
ReignOfComputer
41aff36d50
Unblock IoA Mons Auto Dynamax (#2879) 
Probably easier to blacklist this way?
 2020-06-20 07:52:54 -05:00
Kurt
36dd5ece21 Initial Isle of Armor support 
Co-Authored-By: sciresm <sciresm@users.noreply.github.com>
Co-Authored-By: Matt <sora10pls@users.noreply.github.com>
Co-Authored-By: Archit Date <architdate@gmail.com>
 2020-06-19 18:51:15 -05:00
Kurt
2cdb5d26db Clean up some method signatures 
rename things to be a little more consistent in naming conventions
 2020-06-16 21:46:22 -05:00
Kurt
efb628c002 PID Rand: Handle ability bits for gen34 differently from gen5 
quite an old method we have here; used to just maintain both low bits from u16. Need to handle things differently for g34/g5.

Rearrange some variable init for slightly better perf, and clean up parameter names

https://projectpokemon.org/home/forums/topic/55750-pkhex-square-shiny/
 2020-06-11 09:32:43 -07:00
Kurt
afa368823e Minor clean 
handle some compiler messages
 2020-05-26 16:59:47 -07:00
Kurt
4f40330af9 Add Dynamax Level = 10 to showdownset if legal 
Closes #2835 ; zacian/zamazenta/eternatus can't have a DynamaxLevel other than 0.

Co-Authored-By: Mikewando <mikewando@users.noreply.github.com>
 2020-05-16 15:15:41 -07:00
Kirk Scheibelhut
0aa84f3456
Fix minor typos in FormConverter comments (#2831) 2020-05-10 14:27:12 -07:00
Kurt
3100471299 Strip out some unnecessary logic 
notnull => no need to check for null manually
 2020-04-16 12:58:48 -07:00
Kurt
b8814d2448 Split GG into LGPE (GP/GE), GG (LGPE||GO) 
Update usages
 2020-04-16 12:48:18 -07:00
Kurt
0ada4cbd77 Remove some unnecessary null checks 2020-04-12 13:20:40 -07:00
Kurt
0b48034f4d && -> || 
we want to decrypt if either are set
(they should be zero as they're the always-null terminators of strings)

ty @Lusamine !
 2020-04-06 15:12:51 -07:00
Kurt
270d984130 Minor clean 
Remove unnecessary null checks
Mark some methods with nullable type
 2020-04-04 19:30:50 -07:00
Kurt
cce28df6e3 Update PKMConverter.cs 2020-03-20 09:28:16 -07:00
Kurt
287a2ac5c5 Rework handling of bk4 constructor 
Can't really detect if it's shuffled or not; just assume it's always unshuffled unless it originates from a save file read. Probably not a perfect solution, but achieves better results.

https://projectpokemon.org/home/forums/topic/56217-error-in-archive-bk4/
 2020-03-18 23:34:53 -07:00
Kurt
ed02f39224 Use another overload 
Co-Authored-By: Archit Date <architdate@gmail.com>
 2020-03-04 22:31:07 -08:00
Kurt
a83556d612 Heal x->pk8 converts 2020-03-02 16:32:23 -08:00
Kurt
d58426ebf5 Hide affection fields, remove setters for unused 
#2738
 2020-02-27 20:53:33 -08:00
Kurt
9efaae0df6 Remove unneded property copy 
eggs didnt exist in lgpe, would be all zero anyways
memories copy in pk7, remove todo
 2020-02-14 14:48:48 -08:00
Kurt
ae0777018c Update PB7.cs 
Co-Authored-By: Chris Feger <piepie62@users.noreply.github.com>
 2020-02-14 11:48:13 -08:00
Kurt
d560fbcf7f Fix typo 
Co-Authored-By: Chris Feger <piepie62@users.noreply.github.com>
 2020-02-13 21:00:07 -08:00
Kurt
6346444db7 Extract home tracker to interface 2020-02-12 18:52:48 -08:00
Kurt
ebf20d927b More transfer implications 
Totems are downsized to regular
araquanid, togedemaru, and ribombee totems can't transfer (at the moment)
 2020-02-11 20:11:33 -08:00
Kurt
435953f4e1 Don't transfer locale 2020-02-11 19:04:00 -08:00
Kurt
217156d2b9 Continued comparisons & implications 
pk7->pk8 doesnt assign height/weight (zero), require zero for legal
p*7->pk8 assigns a tracker value, enforce something is present for legal
copy OT friendship (oops)
 2020-02-11 18:35:54 -08:00
Kurt
332f92f5e9 Update p*7 transfer logic 
Add scalars & stat natures

Do note: there is more data that is set and can potentially be used to flag you for cheats. Beware.
 2020-02-11 18:05:07 -08:00
Kurt
c301ce88ab Update Random to be a bit more thread safe 
Random isn't thread safe; users of PKHeX.Core.dll might run multithreaded operations (see PKSM + ALM), so we need to have a thread-specific RNG available.

Thread Local get; to improve performance, save the random object locally whenever it is used more than once in the method.

https://docs.microsoft.com/en-us/dotnet/api/system.threading.threadlocal-1?redirectedfrom=MSDN&view=netframework-4.8
https://stackoverflow.com/questions/18333885/threadstatic-v-s-threadlocalt-is-generic-better-than-attribute/18337158#18337158
 2020-01-25 21:49:52 -08:00
Kurt
467045e95c Swap rand call order, rename as overload 2020-01-22 19:04:20 -08:00
Kurt
63ea57436f Make the template IV/contest stat array readonly 
See prior commits
no longer need to clone subarrays, they're shared immutable
 2020-01-18 19:11:29 -08:00
Kurt
843330a375 Remove unnecessary null checks 
this is a null free project /s
dont provide null, else u deserve to get an exception
 2020-01-18 16:57:25 -08:00
Kurt
8312c52cc1 Make Move[] readonly list 
contract: don't modify the template movesets
mystery gift now exposes IRelearn, remove unnecessary type checks
 2020-01-18 16:46:38 -08:00
Kurt
857124acf0 Swap zen galar -> galar zen 
ty showdown for changing your convention over a month ago
a01e2a26bc (diff-58e367765263b7e21df251b3e7619b70L9307)
 2020-01-16 18:54:09 -08:00
Kurt
2e16fb058c Show form arguments in gen6/7 
Clamp form argument load to current list bounds (used to throw arg range exception if invalid)
 2020-01-13 17:09:03 -08:00
Kurt
95f24a9d36 Revise suggested AV set logic 
Closes #2630
 2020-01-11 11:43:53 -08:00
Kurt
51d2fc9d93 Update with slowpoke-1/new raid data 
TransferVerifier: Revise transfer check to allow slowpoke-1 (slowpoke-0 is flagged via next check)
 2020-01-09 18:44:45 -08:00
Kurt
0dd4d1fe7a Remove unnecessary casts 2020-01-06 17:50:18 -08:00