Mirrors/PKHeX
2
0
Fork 0
mirror of https://github.com/kwsch/PKHeX synced 2024-12-18 16:33:24 +00:00
Code Issues Projects Releases Packages Wiki Activity
5910 commits 3 branches 76 tags 119 MiB
Commit graph

506 commits

Author SHA1 Message Date
Kurt
face8d64a9 Fix gen5 dexflag set 
Add unit tests to check
Closes #2356
 2019-07-11 00:13:52 -07:00
Kurt
c64ff5dd76 Fix sav5 behavior 
Closes #2356 ty @Ammako
 2019-07-10 00:19:59 -07:00
Kurt
cf0908a21e Remove check for impossible conditions 
#2354
SUBE is never < 0 with the latest change (blank saves behave same as
retail saves).
 2019-07-08 10:03:53 -07:00
NotTsunami
e29da1a8e8 Remove check for impossible condition in XY Save (#2354) 
XY can't be ORASDEMO
 2019-07-07 22:58:33 -07:00
Kurt
15c44139c3 Fix record read offset 
Closes #2353
first 100 are u32, second 100 are u16; shift accordingly
 2019-07-07 14:54:38 -07:00
Kurt
8f88e630c2 Fix ORAS inventory class type 
now no longer removes items from pouch

https://projectpokemon.org/home/forums/topic/53761-oras-item-problems-with-new-version/
 2019-07-07 08:43:58 -07:00
Kurt
772a2715c0 Fix SecondsTo* read offset 
copypasted from gen6's, oops
Thanks CreamatedReptile2018!
 2019-07-07 08:43:04 -07:00
Kurt
f2ac29ff4e Relocate some logic 
slightly reduces savefile.cs footprint
 2019-07-05 22:02:29 -07:00
Kurt
9a61f0de0f Minor relocation of logic 
and the gradual shift to full-oop continues
 2019-07-05 21:39:47 -07:00
Kurt
c0eda5eb61 Add more dex bulk manip options 
unused, not sure how an abstraction can work for all games (needs some
virtual methods to actually work, since 1-3 don't have langflags)
 2019-07-05 18:49:43 -07:00
Kurt
aa94c70df2 Hide gen6 dex logic behind zukan class 
Same as prior commit for gen5 & gen7
 2019-07-05 18:04:36 -07:00
Kurt
adbb3e842a Hide gen7 dex logic behind zukan class 
Same as prior commit for gen5
 2019-07-05 17:05:42 -07:00
Kurt
79a9269fbe Hide gen5 dex logic in Zukan class 
Didn't change any of the bulk modifications, but the data get/set is now
done via the Zukan object rather than raw data manipulation
 2019-07-05 16:21:53 -07:00
Kurt
7f186048fb Really fix dex lang flag offset style 
c345688f6d

base(x) -> base(x - y) resulted in incorrect offsets for LGPE. Great.
Just make PokeDexLanguageFlags a shift offset instead of absolute;
update all usages.

Closes #2348
 2019-07-05 12:16:09 -07:00
Kurt
599ec4ed45 Fix checksum offset fetch 
#2348
 2019-07-05 11:57:40 -07:00
Kurt
810f7271c6 Clear boxes after initialize 
Closes #2349
 2019-07-05 11:53:13 -07:00
pokecal
6b3d6999d1 update MailBoxEditor (#2344) 
fixed FRLG offset, etc.
 2019-07-04 21:48:18 -07:00
Kurt
5a8b421672 Add jp crystal eventflag offset 
was pointing to an FF'd region, was added back via
e86b8c670f

Closes #2347
 2019-07-04 15:07:37 -07:00
Kurt
c345688f6d Fix dex lang bitflag offset write 
LangFlags is expected to be less than 0x500 or whatever, zero indexed to
the start of the dex block; NOT an absolute position.
I don't feel like making every usage consistent (gen5, gui editors)
which use the absolute position, so just adjust in the zukan
constructors
 2019-06-22 16:53:25 -07:00
Kurt
e81e5f31da Remove shadow info index shift 
Thanks @PP-theSLAYER !

https://projectpokemon.org/home/forums/topic/53405-bug-oddity-with-shadow-recognition/?do=findComment&comment=246125
 2019-06-20 20:39:34 -07:00
Kurt
dc813da2f7 Add DisplayTID/SID getset 2019-06-19 17:49:56 -07:00
Matt
08835d5d97 Fix ORAS held items/personal reference (#2329) 2019-06-19 12:18:09 -07:00
Kurt
de77f949da Prevent assert on non-exportable saves 2019-06-17 20:55:01 -07:00
Kurt
7225b2b87b Add more sav1/2 option properties 
Closes #2321
Closes #2322
no gui as SimpleTrainer is kinda getting overloaded; use linqpad or wait
for someone to make a GUI for the specific games
 2019-06-09 14:15:42 -07:00
Kurt
455ab32722 Retain override version on clone 
Also hide the pika friend label when YW features hidden #2283
 2019-06-09 13:48:51 -07:00
Kurt
a30a00317f Add missing trainer location overrides 
Was missing from #2319
 2019-06-08 20:19:39 -07:00
Kurt
1b028198ad
Split gen5-7 saves with inheritance (#2319) 
refer to pull request comments for summary
 2019-06-08 19:56:11 -07:00
Kurt
de774ed131 readonly ComboItem 
create once, never modified after
 2019-06-01 19:12:41 -07:00
Kurt
2b8ef9236a use some explicit dex numbers as enum 2019-06-01 10:22:49 -07:00
Kurt
144a78d688 Relocate method 2019-05-29 16:42:48 -07:00
Kurt
8d781fd167 Simplify sorting to remove linq usage 
create custom comparer to do the work
reorder some parameters
simplify gb hm set (All and FindIndex is duplicate work)

only usages of linq remaining are for the bulk action Where filtering
(ok)
 2019-05-28 22:55:41 -07:00
Kurt
a45cddd3ed Add missing hax item clamp early return 
Closes #2281
remove unnecessary "else", and break for visual separation
 2019-05-27 21:38:04 -07:00
Kurt
827eb94f3c Add GameSync r/w for lgpe 
https://projectpokemon.org/home/forums/topic/52797-request-lgpe-game-sync-like-value-to-be-added/

ty @PP-theSLAYER !
 2019-05-16 22:26:51 -07:00
ReignOfComputer
7625ab66b4 Fix Import Count on Load Boxes (#2308) 
Calculation was wrong if non-overwrite is selected. Also fixed OCD-triggering extra space in output message.
 2019-05-15 09:11:48 -07:00
Kurt
be8e8851e2 Update 19.05.15 2019-05-14 22:47:48 -07:00
Kurt
091b9e2281 Add g4 poffin editor (misc edits) 
Thanks @sora10pls for docs!
https://pastebin.com/jNeVJQi0
 2019-05-13 22:56:45 -07:00
Kurt
76e3174d8c Add gen4 poffin logic 
800 bytes starting at Offset = SAV.DP ? 0x5050 : 0x52E0;
8 bytes per poffin, 100 poffins.
 2019-05-13 18:42:30 -07:00
Kurt
15f93216bd Fix record flag clearing 
yay missing ~, Closes #2301 ty @CanoeHope !
rewrite flag loading to not use linq
 2019-05-12 15:08:04 -07:00
Kurt
bad16adcee Fix sav7b clone method 
underlying data should be a different reference when cloned
 2019-05-12 15:06:50 -07:00
Kurt
21e7f4317e Minor updates 
increase readability, simplifly some expressions
relocate hot path for legality report string creation
 2019-05-11 10:12:14 -07:00
Kurt
300ef4d60a Minor simplifications 
Use "SetData" method to automatically apply the Edited flag
Use appropriate method for CopyTo
simplify expressions a tad
 2019-04-29 17:21:19 -07:00
Kurt
7c380a29c3 Make sort skip delegate more general 2019-04-29 17:20:16 -07:00
Kurt
0dc45c00ec Check block index before calculating 
Missing/Duplicate blocks (???) result in -1, so skip them.

https://projectpokemon.org/home/forums/topic/52437-cant-export-unmodified-sav-file/

replace linq with manual allocation
 2019-04-27 17:19:54 -07:00
Kurt
0bd6caf927 Fix male-only dex bit wiping 
only wipe the index specific bits, don't wipe everything but the index
specific bits
 2019-04-22 22:25:14 -07:00
Kurt
934595126f Simplify qr gender 
use personalinfo object to do majority of work,
end result has the 4 sequential bytes set neatly
 2019-04-15 15:43:48 -07:00
Kurt
27dfffd5b2 Add model-gender/starter-gender get/set 
https://projectpokemon.org/home/forums/topic/52127-lgpe-save-research/?tab=comments#comment-243751
Thanks theSlayer!

(starter gender not modifiable via gui)
 2019-04-10 17:03:05 -07:00
Kurt
82fb95b436 Add ConfigSave language get/set 
This value is what determines what language the game runs with
 2019-04-09 21:19:08 -07:00
Kurt
2f2512b09c Reduce allocations for checking file write time 
FileInfo inherits from FileSystemInfo, which initializes a bunch of
strings that we don't need
this isn't a great optimization, just a fun exercise finding a quicker
approach to get these values
 2019-04-05 18:45:59 -07:00
Kurt
bbe56a3318 Simplify trade trainer parameters 
Bank was always false, don't try to minimalize gets by fetching before
call (be simple)

remove unreachable branches now that dust has settled
 2019-03-30 22:05:28 -07:00
Kurt
e614aa9ac8 Relocate xd/batrev encryption 
update some xmldoc too
 2019-03-30 21:28:32 -07:00