Kurt
efb3d9aeac
Add inaccessible den-rank checks
...
Rotom Bike water upgrade isn't available until you have sufficient progress, so you can't get these dens with the lowest rank.
Co-Authored-By: Lusamine <30205550+Lusamine@users.noreply.github.com>
2021-04-22 21:47:25 -07:00
Kurt
f66662b8db
More deferral tweaks for non-HA having HA
2021-04-22 13:47:33 -07:00
Kurt
b049c82284
Update SAV_MysteryGiftDB.cs
2021-04-21 19:36:10 -07:00
Kurt
8e1be1f911
Pre-filter gifts that aren't available for current save
2021-04-21 19:28:01 -07:00
Kurt
5607d833be
Remove affixed on none-ribbon
...
don't care about remove all legal retaining if not removed
2021-04-21 19:19:58 -07:00
Kurt
8483dc241d
Update MarkVerifier.cs
2021-04-21 19:12:50 -07:00
Kurt
802275ced0
Fix recently loaded tracking
...
Not present would return instantly; just chain it with the remove tail
2021-04-21 19:02:30 -07:00
Kurt
7256ff0a7f
Check if the Shedinja's encounter can have marks
...
Not all gen8 encounters can have marks (nest, go), so use the regular method.
2021-04-21 18:52:24 -07:00
Kurt
b89c4fb17f
Database load on invalid party counts
2021-04-21 18:33:57 -07:00
Kurt
2aed4c3118
Add shedinja dropped ribbons/marking considerations
...
Nice bug ya got there, gamefreak.
Coulda cleared the AffixedRibbon value instead of copying it on Shedinja creation, and it would have made this unnecessary.
Please ditch the Affixed Ribbon gimmick for future games, thanks!
2021-04-21 15:20:16 -07:00
Kurt
25565e6f07
More pattern matching expressions
...
Shapes are fancy; nested pattern checks
2021-04-20 02:17:28 -07:00
Kurt
9dfa1077ee
Rename internal PKMInfo class to match batch names
2021-04-20 01:50:47 -07:00
Kurt
d9c22b1d74
Move pk1/2 EV maxing to class
2021-04-20 01:50:27 -07:00
Kurt
b64edb751d
More xmldoc
2021-04-20 01:50:04 -07:00
Kurt
2f078e6565
Minor tweaks
...
Make HP IV set use single array fetch, less memory required
add some xmldoc
2021-04-20 01:02:32 -07:00
Kurt
778aacb9cf
Show larger sprite box
2021-04-19 23:30:46 -07:00
Kurt
45f12bd924
Update FormVerifier.cs
2021-04-18 21:22:58 -07:00
Kurt
f61108ac4e
Check gen1/2 female OTs a little more thoroughly
...
https://github.com/kwsch/PKHeX/issues/2687#issuecomment-822072999
celebi is a es2e, so just filter on specified TID
Co-Authored-By: FeralFalcon <33670476+FeralFalcon@users.noreply.github.com>
2021-04-18 19:31:22 -07:00
Kurt
c67e01849a
Extract 3ds chinese glyph remapping, only do on 3DS games
...
Optimize some functions within gen7zh for perf (no linq, no allocation)
2021-04-18 18:29:02 -07:00
Kurt
0e4848ad82
minor clean
2021-04-18 18:18:09 -07:00
Kurt
c6d6a52e0b
'->’ stragglers
2021-04-18 14:04:26 -07:00
Lusamine
f2c2a77cfe
Check nest distribution encounters by patch epoch ( #3195 )
...
Distribution raid encounters from before each of the DLC patches can only be captured in existing Wild Area locations.
Store the BCAT index in the encounter details and use it to compare when the BCAT was available.
2021-04-18 11:01:42 -07:00
Kurt
fd8da81b4a
Remove unnecessary setter
2021-04-18 11:00:40 -07:00
Kurt
0719320e33
Eggs: explicitly pass generation instead of calculating
2021-04-17 20:09:02 -07:00
Kurt
9171d7f87e
move property to class that uses it
2021-04-17 20:08:20 -07:00
Kurt
f35a3ce03c
Add overload for Totem check, simplify some flow
2021-04-17 13:24:57 -07:00
Kurt
5635e8f345
Unroll some loops, reduce allocations a little for hacked eggs
2021-04-17 13:13:03 -07:00
Kurt
893f22a664
Extract generation traversal list fetch to static class
2021-04-17 13:09:09 -07:00
Kurt
8e52d2fddb
Xmldoc updates
2021-04-17 13:07:28 -07:00
Kurt
8b180c3122
Fix egg move source indications (were defaulting to gen2)
...
Switch expression had an issue with interpreting the object's type (unboxing, yay)
should probably just return a typed object from the parse, but nah, this is a quick fix.
2021-04-16 17:57:48 -07:00
Kurt
16406d7bba
Allow Strongest Trainer memory on gen6-visitors banned from Maison
...
https://projectpokemon.org/home/forums/topic/57375-pkhex-new-update-legality-errors-contribution-page/?do=findComment&comment=265898
End result is only gen7-origin-in-gen7 are disallowed.
Co-Authored-By: Matt <17801814+sora10pls@users.noreply.github.com>
2021-04-16 08:53:50 -07:00
Kurt
4bb5433489
Change default setting so that "Legal!" pops up unless opted out
2021-04-14 14:09:54 -07:00
Kurt
aaae94b739
Fix Gen2 roamer location check
...
https://projectpokemon.org/home/forums/topic/57375-pkhex-new-update-legality-errors-contribution-page/?do=findComment&comment=265885
Location=>pkm.Met_Location
Change the array search for a bitwise and check, for muh efficiency
2021-04-14 13:29:23 -07:00
Kurt
c56ba76601
Expand jp table too
...
6754645a5f
2021-04-12 19:14:23 -07:00
Kurt
6754645a5f
Minor optimization
...
Similar to the index hack done for array shuffling modulo 24 & 1f.
2021-04-12 17:08:57 -07:00
Kurt
758b6e6770
Remove '<->’ aliasing
...
Farfetch’d uses the non-vertical apostrophe, still.
Showdown is consistent with their usage (in/outputting ’), but we'll keep the '->’ for that sanitization just in case other services/users enter the wrong char.
Closes #3185
2021-04-12 17:04:02 -07:00
Kurt
b289c12918
Update Locations.cs
2021-04-12 15:43:21 -07:00
Kurt
7bc733c900
Update SK2 language coercion
...
Closes #3194
Exports are fine, imports with an ambiguous language (can be either JPN or INT) while illegal don't result in the above branches passing it.
Inputs with <=6 chars for OT&Nick will be ambiguous; PKM editor.
2021-04-11 20:50:34 -07:00
Kurt
0d45075d4b
Rewrite settings handling; enhance some user experiences ( #3193 )
...
- Settings now stored as json next to exe
- Settings now exposes all legality checking setttings that can be changed
- Slot hovering now can play cries in MGDB/PKMDB/etc, not just the main boxes.
- Enhanced hover text for mystery gifts and encounters that have movesets
- Show recently loaded save files in ctrl-f browser
- Toggle auto-load savefile setting to be none/detect-latest/last-loaded
- Custom extensions & extra backup paths can now be configured directly in the json settings
- Settings editor now uses propertygrid & tabs.
2021-04-11 18:09:54 -07:00
Kurt
aaa69eac15
Rename Gen3 Champ ribbon to be more accurate
...
been like this since mid 2016
this ribbon can be obtained in either Hoenn or Kanto within Gen3
https://bulbapedia.bulbagarden.net/wiki/List_of_Ribbons_in_the_games#League_Ribbons
2021-04-10 12:09:43 -07:00
Kurt
cfcefca14f
Add splitbreed relearn suggest recursion
2021-04-10 11:03:21 -07:00
Kurt
4dea69e068
Fix met location list misbehavior
...
PKM Editor is so spaghetti anyway
2021-04-10 10:30:10 -07:00
Kurt
329a2cbd44
Remove indirect data fetching
2021-04-09 19:44:14 -07:00
Kurt
0576b9dfba
68x56
2021-04-09 17:23:09 -07:00
Kurt
bfd581e89d
Rearrange daycare for 68x56 layout
2021-04-09 17:20:42 -07:00
Kurt
9bc07b6e01
Remove unused setting
2021-04-09 17:20:30 -07:00
Kurt
5ed73e0bff
Revise Party tab labels
2021-04-09 17:20:00 -07:00
Kurt
d73baebad2
Use wider sprite boxes for Mystery Gift album display
2021-04-09 16:37:32 -07:00
Kurt
b3b60894b6
Remove 40x30 sprite assets
...
Farewell; let's assume things are 68x56 from now on.
2021-04-09 16:24:19 -07:00
Kurt
c7b997865c
Minor clean
2021-04-09 14:52:49 -07:00