3771 commits

This branch

This branch

All branches

Author	SHA1	Message	Date
Kurt	e9cebf933c	Fix headbutt encountertype fetch ... future improvement can be detecting when "none" is appropriate, but for now, whatever. Closes #1502	2017-10-29 20:19:49 -07:00
Kurt	da9e316cd8	Add rock smash encounter type flagging ... I don't believe rock smash (EncounterType 1) exists, tests at Route 19 and Vermillion yielded None & City. Closes #1379 Opens #1502	2017-10-29 19:17:53 -07:00
Kurt	3f533399f2	Simplify slot type loading ... instead of 2 similar methods, use params to achieve a flexible method for both situations isolate rock smash / headbutt type loading	2017-10-29 18:09:30 -07:00
Kurt	afde4514e2	Add realgam tower / deep colosseum locs ... sudowoodo & gsc dogs closes #1549 fix loading issue for abilities in gen3 format, copy the gen4 sanitization	2017-10-29 10:41:12 -07:00
Kurt	9ada593af9	add gen7 nick ot (trades) ... #1249 todo usum table when appropriate	2017-10-28 23:04:02 -07:00
Kurt	d2ebb6340e	Add gen5 nick/OT info (trades) ... #1249 appears b2w2 is the first game with fixed nature & nonfixed PID (based on RoC's specimens), so can't filter by PID on those.	2017-10-28 21:43:47 -07:00
Kurt	e4319fd929	Add gen3 nick/OT info ... #1249	2017-10-28 19:51:55 -07:00
Kurt	2c73e130af	Add gen4 nick/OT info ... #1249	2017-10-28 19:02:18 -07:00
Kurt	021ecbfe47	move pkm load compat check to pkmconverter ... closes #1550 , mgdb/pkmdb throw unconverted files which need conversion; move main file load conversion to a reusable method and have pkmeditor call it on every load. add skip argument to ignore the conversion check (ie if the file is loaded from an undoubtedly same type source).	2017-10-28 14:26:27 -07:00
Kurt	9d0b153eab	Add egg hatch suggestion for b2w2	2017-10-28 14:00:44 -07:00
Kurt	a401db608e	Split trade encounter nick/OT verification methods ... #1249	2017-10-28 13:15:51 -07:00
Kurt	0e9960909b	Refactor encountertype check to bitflags ... #1379 need to double check none permissive later	2017-10-27 23:57:21 -07:00
Kurt	52b2fd2778	Add fullwidth 0-9 for kor tables ... since _0 and _B are the same, just share a reference instead of separate tables with same values. Closes #1548 , thanks @host1126 !	2017-10-27 16:30:02 -07:00
Kurt	f6927e4fe5	Add gen2 KOR localization exceptions ... Closes #1547 Thanks @host1126 !	2017-10-26 20:37:11 -07:00
Kurt	c2cf824afd	Fix {0xE8, "췄"} - {"츄", 0xF2} KOR swap ... that's silly lol #1547	2017-10-26 20:18:32 -07:00
Kurt	02cfeef4cd	Uncap low end of purification meter ... apparently values can be -100 (colo) and -1 on xd...?	2017-10-26 17:55:34 -07:00
Kurt	00a4c1adf5	Add multilang c/xd ingame gifts ... save space by just using a loop closes #1529 , pokespot proc discussion relocated to associated issue (as previously noted in comments)	2017-10-25 21:53:55 -07:00
Kurt	32abc6daf4	speed up pkm loading slightly ... PreparePKM had the opportunity to be recursive (preparation -> validating*N -> preparation*N), lock out preview sprite updating (which calls PreparePKM via Main.cs) while validating all controls remove uncallable paths (format is checked prior, and checksum check is never called as fieldsInitialized is forced false) move gui toggling to loading methods when appropriate	2017-10-25 19:37:31 -07:00
Kurt	a6ef105544	Update gen3/4 encounter generators ... revisit for simplification now that EncounterTrade matching is more precise (PID required to match). #1249	2017-10-24 22:25:52 -07:00
Kurt	59319a614a	Add PID values for Gen3/4 ingame trades ... #1249	2017-10-24 22:24:29 -07:00
Kurt	3458924446	Restrict data sources per savefile not pkm ... pkm is not restricted from ORAS (etc) values when on an XY (etc) save file; use the save file maxes and indication values. no reference to the pkm anymore! Closes #1546	2017-10-24 21:06:21 -07:00
Kurt	8c2dcb2dd3	Use generation specific species name ... nickname resetting should use the generation specific value	2017-10-24 20:59:58 -07:00
Kurt	8a84f63fcb	Add usum special tutor bitflags ... ( ͡° ͜ʖ ͡°)	2017-10-24 19:59:46 -07:00
Kurt	c60fee85b2	fix pk2 korean nickname set ... closes #1544 , thanks @host1126 !	2017-10-24 18:57:28 -07:00
Kurt	9bbd7c6551	Save all 5 korean OT characters ... Closes #1545, thanks @Bl4ckSh4rk !	2017-10-24 18:49:51 -07:00
Kurt	933bfba8e1	Misc cleanup ... check gen2 stadium names, use pkm.Japanese when favorable	2017-10-24 18:27:40 -07:00
Kurt	69cf1eaa9c	add more pkhex.core xml documentation ... adds a bunch of documentation useful for those unfamiliar with the core library	2017-10-23 23:12:58 -07:00
Kurt	2ad5b19f6c	Add mgqr -> tabs ... Closes #1542 and prevents incorrect loading cases (qrpk2jp -> g2en sav etc) simplifies things a bit ;)	2017-10-23 15:49:52 -07:00
Kurt	a46e56c917	Add xmldoc for mystery gift class names ... refactor pattern checking to simpler representation, add null abort when extension is not provided.	2017-10-23 15:45:58 -07:00
Kurt	60562fb44e	Use empty enumerable when appropriate ... no allocation == no pressure for garbage collector	2017-10-23 15:44:01 -07:00
Kurt	a03ac10fc5	Misc refactoring ... no functional change	2017-10-22 23:26:37 -07:00
Kurt	515a694afa	Add LanguageID enum ... no functional change, just less-magic-numbers for easier to understand src	2017-10-22 21:01:08 -07:00
Kurt	cd16a7721b	Set roamer data back on save ... existing code cloned the savedata reference to a new array, and didn't copy back the Roamer3 reader/writer does all the r/w, and writing only happens with the setter when the form is called to Save. Thanks TheRealAlphA!	2017-10-22 17:17:17 -07:00
Kurt	44c80bd722	Exclude light ball pikachu from gen1 species setter ... Thanks Dunsparce! https://projectpokemon.org/home/forums/topic/41880-yellow-version-pikachu-editing-bug/ non-functional change but fix misuse of gameversion checks (used X/Y instead of YelloW)	2017-10-22 17:11:48 -07:00
Kurt	42d1c252ee	Enhance gen1/2 language detection ... Closes #1540 , check for german only characters (gen1/2 can trade between resulting in only OT being checkable). May be worth changing the german check to return an int instead and check for other language specific values.	2017-10-22 16:52:46 -07:00
Kurt	096f6bbd18	Add RANDY Gen2 ingame trade ... closes #1538 rename pid deferral to pidiv deferral for clarity	2017-10-22 10:41:27 -07:00
Kurt	c5b0ed6c35	Move encountertype deferral to main generator ... gen4->gen5/6 electrode will match static & wild slots, but deferral only defers within the same IEncounterable group.	2017-10-22 09:42:15 -07:00
Kurt	3970b177af	Fix kor table 0x5 0x30-3A swaps ... pls no more	2017-10-22 09:27:00 -07:00
Kurt	cc2e379880	Fix kor table 0x5 0x10-0x20 swaps ... there's still more in the 0x5_30 region y u rong bulbapedia	2017-10-21 19:05:38 -07:00
Kurt	528593b59e	Disallow crystal tutors if VC	2017-10-21 19:01:23 -07:00
Kurt	791a41b1a7	Fix KOR encoding table off by 1 ... Closes #1534 Thanks @host1126 !	2017-10-21 10:32:08 -07:00
Kurt	14ba3fad0b	Merge pull request #1536 from wwwwwwzx/master ... Fix Gen3-5 MaxEV per stat	2017-10-21 08:05:22 -07:00
wwwwwwzx	0820059adf	Fix Gen3-5 MaxEV per stat	2017-10-21 01:06:25 -07:00
Kurt	39279a7ad4	Add VC transfer checks ... checks were previously only performed when finding the encounter, once found, the GB encounter was validated. the transfer encounter is derived after all encounter checks, thus remaining unchecked (really, only for Locations). Move generating logic to the generator, and double check the locations are valid. #1535 Thanks @DJPanda065 !	2017-10-20 21:07:15 -07:00
Kurt	00adfda6e4	Flag Hidden Ability -> other change (hacked) ... Closes #1535	2017-10-20 20:10:56 -07:00
Kurt	0e24b5237e	cleanup ... remove redundant/repetitive match update (updateTypeInfo with Format>=7 already updates the encountermatch just prior to this method call)	2017-10-20 20:10:13 -07:00
Kurt	f85910abe2	Show Time of Day for gen2 ... apparently both controls were hidden also hide encountertype control panel when not applicable (shifts time of day up beneath other controls)	2017-10-20 19:53:38 -07:00
Kurt	7c36190661	Expand IdentifierContains feature ... now behaves the same as a property filtering	2017-10-20 08:47:31 -07:00
Kurt	ae0bf5c75c	remove (None) egg gen4 hatch location	2017-10-19 22:00:31 -07:00
Kurt	a75614ed77	Modify eggmove fetch ... fetch is exclusively done with version already known; there are cases where version can change for eggs so it's safer this way. version change reference (gen6+): 212a489335	2017-10-19 21:20:47 -07:00